62867 Commits

This Branch

This Branch

All Branches

• Add failing test coverage of player not pausing track correctly
  Dean Herbert · 2023-10-10 17:55:35 +09:00
  4319b22db8
• Merge pull request #25077 from bdach/fix-guest-score-lookup

  Fix score importer looking up guest user by username online

  Dean Herbert · 2023-10-10 17:35:15 +09:00
  1388f7240e
• Merge pull request #25070 from frenzibyte/fix-legacy-catcher-layout

  Adjust legacy catcher display to match 1:1 with osu!(stable)

  Dean Herbert · 2023-10-10 17:31:10 +09:00
  a0bd91f3bb
• Merge pull request #25067 from bdach/approach-circle-cutoff

  Adjust approach circle maximum size limits for backwards compatibility

  Dean Herbert · 2023-10-10 17:05:16 +09:00
  0ca05d986d
• Fix cross-test interference

  `TestLastPlayedUpdated` was implicitly relying on running first.
  `TestGuestScoreIsStoredAsGuest` showing up changed test ordering,
  causing the former test to fail if it didn't get to run first.

  Bartłomiej Dach · 2023-10-10 09:30:51 +02:00
  ea400a9db7
• Fix score importer looking up guest user by username online
  Bartłomiej Dach · 2023-10-10 09:28:01 +02:00
  24956588e9
• Add failing test case for guest user being looked up in API
  Bartłomiej Dach · 2023-10-10 09:18:57 +02:00
  08b1a3cbe2
• Merge pull request #25073 from peppy/mania-beat-snap-grid-fix

  Fix osu!mania beat snap grid sometimes not displaying correctly

  Bartłomiej Dach · 2023-10-10 08:21:43 +02:00
  6b38600010
• Use a DrawablePool for mania's beat snap grid

  I'm not sure what the cause of the issue is, but I'm also not sure why
  it wasn't using `DrawablePool` (was it not around back then?).
  
  Either way, switching to a proper pool fixes things just fine.
  
  Resolves https://github.com/ppy/osu/issues/25009.

  Dean Herbert · 2023-10-10 13:36:31 +09:00
  1a60d6ade5
• Refactor catch playfield size adjustment logic w.r.t. catcher position
  Salman Ahmed · 2023-10-10 02:42:37 +03:00
  6073f3e756
• Adjust the catch playfield's position to match 1:1 with stable
  Salman Ahmed · 2023-10-10 02:17:43 +03:00
  b2987caf7c
• Fix test catcher sprites in "special skin" incorrectly suffixed as being @2x
  Salman Ahmed · 2023-10-10 01:26:59 +03:00
  693b8d72db
• Add brief explaination of BASE_SIZE
  Salman Ahmed · 2023-10-10 01:26:59 +03:00
  fed0deac02
• Fix legacy catcher sprites getting shrunk
  Salman Ahmed · 2023-10-10 01:26:59 +03:00
  fc63ee43be
• Adjust catcher origin position to match 1:1 with stable

  Change catcher origin position logic to 1:1 match stable on legacy skin

  Salman Ahmed · 2023-10-10 01:26:59 +03:00
  0fb7895a52
• Merge pull request #24988 from smoogipoo/fix-legacy-score-multipliers-2

  Fix legacy score calculators using incorrect mod multipliers

  Bartłomiej Dach · 2023-10-09 12:56:39 +02:00
  b3d3ae87be
• Merge branch 'master' into fix-legacy-score-multipliers-2
  Bartłomiej Dach · 2023-10-09 10:53:14 +02:00
  71c4b138fb
• Hotfix approach circle cutoff
  Dean Herbert · 2023-10-09 10:16:57 +02:00
  ad6f04cfb0
• Merge pull request #25063 from peppy/move-download-button

  Move playlist item download button to left

  Bartłomiej Dach · 2023-10-09 10:01:15 +02:00
  ca217094d6
• Move playlist item download button to left
  Dean Herbert · 2023-10-09 12:21:56 +09:00
  142c61ab9b
• Rename FailAnimation to FailAnimationContainer
  Dean Herbert · 2023-10-08 00:39:30 +09:00
  2023.1008.0 e5207167c8
• Merge pull request #24986 from peppy/health-animates-in-intro

  Add initial animation for health bars

  Dean Herbert · 2023-10-07 10:31:34 +09:00
  7c7771afca
• Merge pull request #25028 from peppy/bindable-fixes

  Fix some incorrect bindable-related code

  Bartłomiej Dach · 2023-10-06 22:31:30 +02:00
  cfcdbe1c30
• Merge pull request #25029 from peppy/socket-exception-handling

  Fix OAuth refresh attempt when no network available causing full logout (part 2)

  Bartłomiej Dach · 2023-10-06 21:59:27 +02:00
  250b9112c4
• Merge pull request #25030 from peppy/adjustable-health-bar

  Adjust argon health bar to fit with existing layout

  Bartłomiej Dach · 2023-10-06 21:51:18 +02:00
  a099cc0f36
• Only flush the Current transform specifically
  Bartłomiej Dach · 2023-10-06 21:39:29 +02:00
  b7d0bf3756
• Fix health display potentially desyncing from actual if health was changed during initial animation
  Bartłomiej Dach · 2023-10-06 21:35:08 +02:00
  ce0d4bd0df
• Merge pull request #24885 from peppy/clock-fix-attempt-2

  Adjust clock usage in line with framework changes

  Bartłomiej Dach · 2023-10-06 20:43:24 +02:00
  037632940d
• Rename local variable
  Bartłomiej Dach · 2023-10-06 19:43:00 +02:00
  5ea45e3e96
• Fix health animation affecting failing tint
  Dean Herbert · 2023-10-07 01:06:31 +09:00
  58448d3dd9
• Merge branch 'master' into health-animates-in-intro
  Dean Herbert · 2023-10-07 00:32:19 +09:00
  1a60e6d76e
• Update framework
  Bartłomiej Dach · 2023-10-06 14:11:41 +02:00
  10ce5705ce
• Fix variable clash
  Dean Herbert · 2023-10-06 21:01:23 +09:00
  8e5b2e78e5
• Adjust transition time based on miss/hit
  Dean Herbert · 2023-10-06 19:34:38 +09:00
  d87ab9c82d
• Add argon health display to default skin layout
  Dean Herbert · 2023-10-06 19:34:27 +09:00
  3f2a00d90d
• Add ability to adjust health bar settings in test scene
  Dean Herbert · 2023-10-06 19:34:27 +09:00
  71be3c8f8b
• Remove left line from health display
  Dean Herbert · 2023-10-06 19:34:27 +09:00
  f40e910c51
• Change ArgonHealthDisplay to be relative sized for now
  Dean Herbert · 2023-10-06 18:56:39 +09:00
  db5178e453
• Fix OAuth refresh attempt when no network available causing full logout (part 2)

  This time for `SocketException`s. I seem to recall looking at this and
  deciding there was a reason to not catch socket exceptions, but on
  revisiting it seems sane to do so.
  
  This covers a fail case like reported:
  
  ```
  2023-10-06 03:24:17 [verbose]: Request to https://lazer.ppy.sh/oauth/token failed with System.Net.Http.HttpRequestException: No such host is known. (lazer.ppy.sh:443)
  2023-10-06 03:24:17 [verbose]: ---> System.Net.Sockets.SocketException (11001): No such host is known.
  2023-10-06 03:24:17 [verbose]: at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.ThrowException(SocketError error, CancellationToken cancellationToken)
  ```
  
  Closes https://github.com/ppy/osu/issues/24890 (again).

  Dean Herbert · 2023-10-06 18:24:22 +09:00
  c78b5112c6
• Fix a couple of compilation errors
  Dean Herbert · 2023-10-06 18:13:02 +09:00
  7227f5c881
• Fix redundant bindable initialisation in SongSelect
  Dean Herbert · 2023-10-06 16:51:56 +09:00
  936a21a661
• Fix incorrect implementation of IHasCurrentValue in FooterButtonFreeMods
  Dean Herbert · 2023-10-06 16:51:40 +09:00
  1d7b8ea21a
• Fix publicly-settable bindables
  Dean Herbert · 2023-10-06 16:51:24 +09:00
  f2e56bbb65
• Remove pointless test class in TestSceneStoryboardSamples
  Dean Herbert · 2023-10-06 16:43:28 +09:00
  f9021bf551
• Fix incorrect test assumption in TestSceneEditorClock

  I don't know what this test was trying to do, but it was wrong. Any
  offset which is applied should be invisible to the clock's final
  `CurrentTime` (and to the user).

  Dean Herbert · 2023-10-06 16:43:28 +09:00
  1005b7ac85
• Merge branch 'master' into clock-fix-attempt-2
  Dean Herbert · 2023-10-06 16:43:27 +09:00
  354193c53a
• Merge pull request #25023 from bdach/skinning-max-size-update

  Adjust gameplay element maximum size limits for backwards compatibility

  Dean Herbert · 2023-10-06 14:37:15 +09:00
  cc6210035f
• Apply feedback regarding maximum osu! element sizings

  - `default-N` number sprites maximum size increased by 1.25x to a total
    of 320x320 to counteract the 0.8x factor applied onto them when
    displayed on a hitcircle.
  
  - `sliderb` and parts' maximum size increased to 384x384, to match
    `sliderfollowcircle`, as the two are apparently sometimes used
    interchangeably by skinners to achieve different visual effects.

  Bartłomiej Dach · 2023-10-05 22:33:49 +02:00
  96bb8ed150
• Adjust gameplay element maximum size limits for backwards compatibility

  The new limits were chosen by sampling across over 4000 skins. The
  methodology for doing so is described in the following gist:
  
  	https://gist.github.com/bdach/6228ba41d128b23d1f89142f404108a3

  Bartłomiej Dach · 2023-10-05 20:37:10 +02:00
  0ae4a0f11f
• Merge pull request #25016 from peppy/fix-waveform-comparison-crash

  Fix `WaveformComparisonDisplay` potentially crashing on invalid track length

  Bartłomiej Dach · 2023-10-05 20:02:44 +02:00
  4d315cb718