Dean Herbert
548fd9cbf9
Show breaks behind objects in timeline
...
Closes https://github.com/ppy/osu/issues/29227 .
2024-08-01 19:47:44 +09:00
Caiyi Shyu
188ddbcad6
pass ModCustomisationPanel through ctor
2024-08-01 18:38:01 +08:00
Dean Herbert
dab967e6be
Fix insane transform allocations in new leaderboard display
2024-08-01 18:36:33 +09:00
Bartłomiej Dach
cd28fa7325
Merge pull request #29211 from peppy/always-show-control-points-timing
...
Always show timing points in timeline when at the timing screen
2024-07-31 16:46:55 +02:00
Dean Herbert
5098d637b5
Flash customise button on mod overlay when it becomes available
2024-07-31 19:55:20 +09:00
Dean Herbert
2d52bab77b
Always show timing points in timeline when at the timing screen
...
Supersedes https://github.com/ppy/osu/pull/29196 .
2024-07-31 19:43:08 +09:00
Dean Herbert
e329427d6e
Apply nullability to Timeline
2024-07-31 19:28:32 +09:00
jkh675
54e73acece
Cleanup code
2024-07-31 17:49:03 +08:00
jkh675
04ecefe226
Remove unused using
2024-07-31 17:23:25 +08:00
Caiyi Shyu
5fb364cad6
remove redundant code added accidentally
2024-07-31 16:56:25 +08:00
Caiyi Shyu
5b46597d56
fix click to expand on touch devices
2024-07-31 16:54:32 +08:00
jkh675
9e03dc3b5e
Implement maximum width on CommentTooltip
2024-07-31 16:52:53 +08:00
Dean Herbert
cbfb569ad4
Update resources
2024-07-31 14:37:56 +09:00
Dean Herbert
e9ed9ff58b
Merge pull request #29188 from bdach/daily-challenge/better-messaging
...
Add notification on daily challenge conclusion & start of new one
2024-07-31 13:35:25 +09:00
Dean Herbert
e77489f2a9
Allow notification of new strings
2024-07-31 03:10:36 +09:00
Dean Herbert
bdc465e1c6
Reword notification text slightly
2024-07-31 03:06:35 +09:00
Dean Herbert
5ebb5ad670
Fix test failure due to TestMetadataClient providing null statistics array
2024-07-31 02:53:10 +09:00
Dean Herbert
7f22ade90d
Fix oversight in timekeeping
2024-07-30 21:59:59 +09:00
Dean Herbert
d75c170ba1
Merge branch 'master' into daily-challenge/better-messaging
2024-07-30 19:04:48 +09:00
Dean Herbert
d5f9173288
Remove unused local variable
2024-07-30 19:04:43 +09:00
Dean Herbert
25747fdeb3
Fix edge case where minutes are same but hour is different
2024-07-30 18:06:56 +09:00
Dean Herbert
7229ae83ea
Adjust sizing and distribution of timestamp and username
2024-07-30 18:03:56 +09:00
Dean Herbert
6670f79258
Reduce overall size of chat text
2024-07-30 18:03:56 +09:00
Dean Herbert
4557ad43d5
Reduce padding on chat lines to give more breathing room
2024-07-30 17:52:56 +09:00
Dean Herbert
a2a73232f3
Avoid showing timestamp in chat line when repeated
2024-07-30 17:52:55 +09:00
Dean Herbert
e63080eb2e
Don't show seconds in chat timestamps
2024-07-30 17:52:54 +09:00
Dean Herbert
71acb7e9fc
Merge pull request #29137 from normalid-awa/feature/visual/chatline-background-altering
...
Alternate background colour of chat lines to better visually distinguish wrapped lines
2024-07-30 17:51:41 +09:00
Dean Herbert
c80f338893
Merge pull request #29198 from bdach/fix-difficulty-bindable
...
Fix incorrect `DifficultyBindable` logic
2024-07-30 17:50:58 +09:00
Bartłomiej Dach
1b57a2a136
Show new daily challenge notification globally
2024-07-30 10:36:26 +02:00
Dean Herbert
d48849040b
Merge pull request #29182 from bdach/revert-present-score
...
Force exit to main menu when presenting scores from within playlists / multiplayer
2024-07-30 17:24:27 +09:00
Dean Herbert
fc78dc9f38
Adjust paddings to avoid scrollbar overlap
2024-07-30 16:45:36 +09:00
Dean Herbert
bf10a91082
Adjust colouring to work better across multiple usages
2024-07-30 16:45:35 +09:00
Bartłomiej Dach
6813f5ee0a
Fix incorrect DifficultyBindable logic
2024-07-30 08:39:20 +02:00
Salman Ahmed
91dfe4515b
Fix daily challenge display showing incorrect statistic
2024-07-30 08:12:03 +03:00
Salman Ahmed
dca61eb76c
Remove no longer used dependency
2024-07-30 07:07:11 +03:00
Salman Ahmed
33fc6dfaff
Hide daily challenge display when not selecting osu!
...
Also hide when no user is displayed.
2024-07-30 07:06:59 +03:00
Salman Ahmed
8b910e59f6
Reduce tooltip shadow outline
2024-07-30 06:37:29 +03:00
Salman Ahmed
9868fb4aaa
Remove tier-based colour from the condensed piece to match web
2024-07-30 06:36:02 +03:00
Salman Ahmed
78417db06d
Remove stray line
2024-07-30 06:35:09 +03:00
Salman Ahmed
621f4dfece
Enforce new line between X/Y coordinate in editor position inspector
2024-07-30 02:45:21 +03:00
Dean Herbert
aa2515763c
Merge pull request #29184 from bdach/daily-challenge/wrong-mods-after-replay
...
Fix mods persisting after watching replay from daily challenge screen
2024-07-29 23:23:45 +09:00
Bartłomiej Dach
48e38bd467
Merge pull request #29186 from peppy/fix-status-config
...
Fix online status not persisting correctly
2024-07-29 16:11:05 +02:00
Bartłomiej Dach
5032a149e7
Merge pull request #29187 from peppy/daily-challenge-pieces-not-always-present
...
Favour updating daily challenge statistics when they come on screen
2024-07-29 15:48:26 +02:00
Bartłomiej Dach
3a30ff7817
Merge pull request #29172 from kadambishreyas/handle-timestamp-mod-content
...
Handle timestamp mod content
2024-07-29 15:34:50 +02:00
Bartłomiej Dach
12e553a290
Merge pull request #29166 from normalid-awa/bugfix/visual/mod-preset-tooltips-text-being-cutoff
...
Fix mod preset tooltip's description text being cut off
2024-07-29 15:19:06 +02:00
Bartłomiej Dach
b46f3c97da
Add notification on daily challenge conclusion & start of new one
...
Because I wish to stop seeing "DAILY CHALLENGE WHERE" every day
on #general.
The notifications are constrained to the daily challenge screen only to
not spam users who may not care.
2024-07-29 14:30:10 +02:00
Dean Herbert
7afcd72872
Fix potentially too many scores displaying in breakdown while in gameplay
2024-07-29 20:58:42 +09:00
Dean Herbert
05056f0e8a
Remove no longer required AlwaysPresent definition
...
This also reverts commit 7fedfd368c
2024-07-29 20:43:56 +09:00
Dean Herbert
5a1002c1a0
Ensure score breakdown doesn't spam scores when not visible
2024-07-29 20:43:50 +09:00
Dean Herbert
5bc02cc1c6
Fix background alternating not updating on message removal
2024-07-29 20:25:55 +09:00
Dean Herbert
997b3eb498
Fix typos and visuals
2024-07-29 20:24:51 +09:00
Bartłomiej Dach
8b96b0b9e4
Add logging when starting and stopping watch operations in online metadata client
...
For future use with debugging issues like
https://github.com/ppy/osu/issues/29138 , hopefully.
2024-07-29 13:19:01 +02:00
jkh675
d51a53b051
Preventing the mod icon being squashed up
2024-07-29 19:08:14 +08:00
Dean Herbert
11265538c4
Reset online status on logout
2024-07-29 20:06:30 +09:00
Dean Herbert
c142adf926
Fix online status not persisting correctly
...
Regressed at some point.
I don't see much reason not to link the bindable directly with config.
It seems to work as you'd expect. Tested with logout (resets to
"Online") and connection failure (persists).
Closes https://github.com/ppy/osu/issues/29173 .
2024-07-29 20:06:27 +09:00
Bartłomiej Dach
f1a84a5111
Fix mods persisting after watching replay from daily challenge screen
...
Closes https://github.com/ppy/osu/issues/29133 .
Hope I can be forgiven for no tests. I had a brief try but writing them
is going to take hours.
2024-07-29 12:52:30 +02:00
jkh675
8f86681110
Replace OsuSpriteText with TextFlowContainer
2024-07-29 18:29:44 +08:00
jkh675
90fdf5599f
Revert changes
2024-07-29 18:14:07 +08:00
Bartłomiej Dach
cebd38c6eb
Merge pull request #29163 from Joehuu/copy-lb-mods-daily
...
Add ability to copy leaderboard mods in daily challenge
2024-07-29 12:09:27 +02:00
Bartłomiej Dach
9b96bd1d73
Force exit to main menu when presenting scores from within playlists / multiplayer
...
- Closes https://github.com/ppy/osu/issues/29152
- Partially reverts https://github.com/ppy/osu/pull/29097
- Reopens https://github.com/ppy/osu/issues/26666
When testing I failed to predict that in multiplayer there can be a
different beatmap in the playlist queue. If this is the case,
`PresentScore()` will exit out to `Multiplayer`, whose `RoomSubScreen`
will update the selected item - and thus, the global beatmap - to the
next item in queue, at which point trying to play games with "not
touching the global beatmap bindable if we don't need to" fail to work,
because the bindable *must* be touched for correct operation, yet it
cannot (because `OnlinePlayScreen`s disable it).
I'm not sure what the fix is here:
- making replay player somehow independent of the global beatmap?
- not exiting out to multiplayer, but instead doing the present from the
results screen itself? if so, then how to ensure the screen stack
can't overflow to infinity?
so I'm just reverting the broken part. The daily challenge part is left
in because as is it should not cause issues.
2024-07-29 12:07:45 +02:00
jkh675
5ec46a79b4
Only create a new drawable object when the background is needed
2024-07-29 17:50:23 +08:00
Bartłomiej Dach
2ff0a89b4f
Convert into auto-property even more
2024-07-29 10:59:21 +02:00
Bartłomiej Dach
861b546562
Add vague test coverage
2024-07-29 10:58:05 +02:00
Bartłomiej Dach
54c904d439
Convert into auto-property
2024-07-29 10:40:29 +02:00
Bartłomiej Dach
aa7f6f81ef
Merge pull request #29127 from Joehuu/add-negative-horizontal-padding-daily
...
Fix daily challenge background clipping when settings/notifications is opened
2024-07-29 10:28:48 +02:00
jkh675
63757a77a5
Extract update background method
2024-07-29 13:39:08 +08:00
Shreyas Kadambi
dec6b190f2
Add optional 'suffix' to timestamp
2024-07-28 11:31:36 -04:00
normalid
4e65944609
Make the tooltips width be dyanmic with the content, so the long text wont occurs wierd line break
2024-07-28 16:26:18 +08:00
normalid
5db0e36404
Use the TruncatingSpriteText in ModPresetTooltip
2024-07-28 16:18:43 +08:00
Joseph Madamba
f6eb9037df
Add ability to copy leaderboard mods in daily challenge
2024-07-27 23:55:56 -07:00
Salman Ahmed
7fedfd368c
Fix score breakdown tooltips appearing in other feeds
2024-07-28 07:22:58 +03:00
Salman Ahmed
6bdb1107c1
Add shadow over tooltip
2024-07-28 06:35:00 +03:00
Salman Ahmed
31787757ef
Provide colour scheme as part of tooltip data to handle reusing tooltip with different profile hues
2024-07-28 06:21:23 +03:00
Salman Ahmed
e82c54a31c
Integrate daily challenge streak display with user profile overlay
2024-07-28 05:58:30 +03:00
Salman Ahmed
17f5d58be2
Add daily challenge streak display and tooltip
2024-07-28 05:58:27 +03:00
Salman Ahmed
0c89210bd7
Add API models for daily challenge statistics
2024-07-28 05:24:05 +03:00
normalid
4e44a6e7f8
Clean up code
2024-07-27 18:55:17 +08:00
normalid
73a98b45e9
FIx code quality
2024-07-27 18:48:45 +08:00
Caiyi Shyu
77d64e0c3d
replace with ReceivePositionalInputAt
2024-07-27 17:59:38 +08:00
normalid
c2711d0c4e
Implement chatline background altering
2024-07-27 17:25:44 +08:00
Caiyi Shyu
fc842868a9
fix code quality
2024-07-27 16:24:20 +08:00
Caiyi Shyu
b97d96fcb0
Fix panel collapse when hovering dropdown menu
2024-07-27 15:15:14 +08:00
Joseph Madamba
d55e861b90
Fix daily challenge background clipping when settings/notifications is opened
2024-07-26 16:55:15 -07:00
Dean Herbert
565107205c
Merge pull request #29097 from bdach/dont-exit-to-menu-when-presenting-score-in-online
...
Don't force exit to main menu when presenting scores from within online screens
2024-07-27 02:46:58 +09:00
Dean Herbert
9323f89357
Fix "Beatmap not downloaded" tooltip hint not showing in daily challenge
2024-07-27 02:06:56 +09:00
Caiyi Shyu
aed81d9758
make code inspector happy
2024-07-26 22:56:07 +08:00
Caiyi Shyu
0cc6818b21
allow hover to expand ModCustomisationPanel
2024-07-26 22:44:50 +08:00
Dean Herbert
0421e1e9d0
Reduce number spacing a bit more
2024-07-26 23:21:44 +09:00
Dean Herbert
96049807c4
Adjust weight and text in event feed output
...
Just some minor adjustments.
2024-07-26 23:20:32 +09:00
Dean Herbert
4fa6a19409
Merge pull request #29108 from bdach/daily-challenge/better-breakdown
...
Improve score breakdown on daily challenge
2024-07-26 23:12:04 +09:00
Dean Herbert
47eca0eb37
Merge pull request #29101 from bdach/daily-challenge/fix-preview-track
...
Fix preview tracks not stopping playback when suspending/exiting daily challenge screen
2024-07-26 21:52:26 +09:00
Dean Herbert
6f7d05d5a0
Merge pull request #29104 from bdach/daily-challenge/fix-no-audio-adjustments
...
Fix daily challenge screen not applying track adjustments from mods
2024-07-26 21:51:58 +09:00
Bartłomiej Dach
0996f9b0b5
Fix code quality
2024-07-26 14:45:39 +02:00
Dean Herbert
1607075e0c
Merge pull request #29099 from bdach/daily-challenge/totals-display
...
Implement component for displaying running totals in daily challenge
2024-07-26 21:44:58 +09:00
Dean Herbert
a870722ea6
Adjust easings and reduce character spacing slightly
2024-07-26 21:43:23 +09:00
Bartłomiej Dach
fc0ade2c61
Highlight where local user's best is on the breakdown
2024-07-26 14:32:01 +02:00
Bartłomiej Dach
2caaebb670
Add tooltip with counts to daily challenge score breakdown chart
2024-07-26 13:47:41 +02:00
Dean Herbert
19affa7062
Rename new property to match true usage (per item)
...
Also document a bit more.
2024-07-26 20:45:13 +09:00
Bartłomiej Dach
2e37f3b5de
Hook up score totals display to daily challenge screen
2024-07-26 12:34:23 +02:00
Dean Herbert
1ad0b31217
Add required pieces to MultiplayerPlaylistItemStats for total score tracking
2024-07-26 19:04:04 +09:00
Bartłomiej Dach
1abcf16231
Fix daily challenge screen not applying track adjustments from mods
...
Closes https://github.com/ppy/osu/issues/29093 .
2024-07-26 11:50:43 +02:00
Bartłomiej Dach
f9cfc7d96c
Fix preview tracks not stopping playback when suspending/exiting daily challenge screen
...
Closes https://github.com/ppy/osu/issues/29083 .
2024-07-26 10:53:12 +02:00
Cameron Brown
17f00ec0a6
Bind the mod select overlay's Beatmap to OsuScreen.Beatmap in constructor
...
Suggested by @bdach!
2024-07-26 18:29:50 +10:00
Cameron Brown
a8851950bc
Update the beatmap of Daily Challenge's mods overlay when beatmap is set - #29094
2024-07-26 18:10:11 +10:00
Bartłomiej Dach
174dc91f4b
Implement component for displaying running totals in daily challenge
...
Total pass count and cumulative total score, to be more precise.
2024-07-26 09:51:39 +02:00
Bartłomiej Dach
e489ae8f72
Merge pull request #29055 from peppy/event-feed-improvements
...
Improve daily challenge event feed
2024-07-26 08:37:47 +02:00
Bartłomiej Dach
662e9eab8c
Don't force exit to main menu when presenting scores from within online screens
...
Struck me as weird when reviewing https://github.com/ppy/osu/pull/29057 .
Like sure, that PR adds the replay button, but it's a bit terrible that
clicking the button quits the daily challenge screen and you're back at
main menu when done watching...?
Also extended to cover playlists and multiplayer, which have the same
issue.
2024-07-26 08:17:39 +02:00
Bartłomiej Dach
09a1fd2cd1
Merge pull request #29057 from frenzibyte/daily-challenge-replay-download-button
...
Fix daily challenge not showing a replay button in results screen
2024-07-26 08:03:17 +02:00
Bartłomiej Dach
c17cabd981
Adjust alpha for rows for better visibility
2024-07-26 07:44:02 +02:00
Salman Ahmed
c558dfdf13
Reset download state when score is changed
2024-07-26 05:11:54 +03:00
Dean Herbert
c90e04092a
Merge pull request #29068 from bdach/results-statistics-toggle-crash
...
Fix crash when toggling extended statistics visibility during results load
2024-07-25 22:49:41 +09:00
Dean Herbert
6cc3e8aab8
Merge pull request #29067 from bdach/report-daily-challenge
...
Fix not being able to send chat reports on daily challenge screen
2024-07-25 22:33:41 +09:00
Bartłomiej Dach
3bb30d7ff9
Fix several missing properties on MultiplayerScore
...
You wouldn't think this would be an actual thing that can happen to us,
but it is. The most important one by far is `MaximumStatistics`; that
is the root cause behind why stuff like spinner ticks or slider tails
wasn't showing.
On a better day we should probably do cleanup to unify these models
better, but today is not that day.
2024-07-25 13:15:45 +02:00
Bartłomiej Dach
8dbd4d70ff
Fix crash when toggling extended statistics visibility during results load
...
Closes https://github.com/ppy/osu/issues/29066 .
Initially I fixed this at where the assert is right now:
9790c5a574/osu.Game/Screens/Ranking/ResultsScreen.cs (L333)
2024-07-25 11:45:17 +02:00
Bartłomiej Dach
8d89557ab8
Fix not being able to send chat reports on daily challenge screen
...
Something something some people cannot be trusted with a textbox.
2024-07-25 11:11:54 +02:00
Salman Ahmed
615f07d54c
Fix results screen fetching more scores twice
2024-07-25 09:16:09 +03:00
Salman Ahmed
9d5fbb8b4f
Fix target score selection abruptly discarded after opening results screen
2024-07-25 09:01:43 +03:00
Dean Herbert
f1dda4ab1e
Fix too many event rows displaying after spending a long time in gameplay/results
2024-07-25 14:31:22 +09:00
Dean Herbert
c90d345ff9
Scroll content forever rather than aggressively fading
2024-07-25 14:31:21 +09:00
Salman Ahmed
dad8e28446
Fix replay download button not added when no score is selected initially
2024-07-25 07:40:17 +03:00
Dean Herbert
aac98ab6b2
Debounce leaderboard refetches to stop excessive operations after returning from gameplay
2024-07-25 12:58:35 +09:00
Dean Herbert
9ec687caab
Avoid reloading the daily challenge leaderboard when already requested
2024-07-25 12:55:45 +09:00
Salman Ahmed
6645dac71d
Fix dragging number boxes overwritten by select-all-on-focus feature
2024-07-24 23:19:04 +03:00
Dean Herbert
4983e5f33e
Merge pull request #29039 from bdach/multiple-selection-sample-popover
...
Make sample popover change properties of all samples in multiple selection
2024-07-24 22:49:20 +09:00
Bartłomiej Dach
c3dae81935
Only add legacy key overlay to osu! and catch HUD layers
2024-07-24 15:41:20 +02:00
Bartłomiej Dach
26395bd443
Adjust animations further to match stable
2024-07-24 15:26:27 +02:00
Bartłomiej Dach
3c28c116ca
Simplify input overlay text colour decode (and fix incorrect default)
2024-07-24 14:53:01 +02:00
Bartłomiej Dach
087dd759be
Adjust layout to ballpark-match stable
...
I dunno what the wiki is claiming with the "24px" figure or why
but I'm not playing conversion games either. Dimensions ballparked
via screenshots captured at x768 resolution.
Also removes a weird homebrew method to keep the text upright.
There is one canonical way to do this, namely
`UprightAspectMaintainingContainer`. And the other key counters
were already using it.
2024-07-24 14:52:56 +02:00
Bartłomiej Dach
1ed7e4b075
Make sample popover change properties of all samples in multiple selection
...
Closes https://github.com/ppy/osu/issues/28916 .
The previous behaviour *may* have been intended, but it was honestly
quite baffling. This seems like a saner variant.
2024-07-24 12:15:12 +02:00
Dean Herbert
6e4625609d
Merge pull request #29036 from bdach/hardcode-positions-for-leaderboard
...
Fill daily challenge top 50 position numbers client-side
2024-07-24 17:49:51 +09:00
Bartłomiej Dach
788b70469d
Exit daily challenge screen when going offline
...
This sort of thing is bound to happen when rewriting screens from
scratch without invoking abstract eldritch entities sometimes. Damned if
you do, damned if you don't...
2024-07-24 09:15:32 +02:00
Bartłomiej Dach
bf4bf4d39e
Fill daily challenge top 50 position numbers client-side
...
Only doing this client-side, because doing this server-side is
expensive:
https://github.com/ppy/osu-web/pull/11354#discussion_r1689224285
2024-07-24 08:57:11 +02:00
Dean Herbert
aded31bd07
Merge pull request #29021 from bdach/editor-breaks-respect-time-preempt
...
Respect pre-empt time when auto-generating breaks
2024-07-24 15:21:12 +09:00
normalid
fede6b3657
Fix indent problems
2024-07-24 13:09:21 +08:00
normalid
b24be96d04
Fix code quality
2024-07-24 12:57:30 +08:00
normalid
56143de2c6
Update offset factor
2024-07-24 12:39:36 +08:00
normalid
e2beacb3dd
Remove logging
2024-07-24 12:31:01 +08:00
normalid
395f8424b5
Match the stable animation
2024-07-24 12:30:08 +08:00
normalid
c52a993607
Support custom input overlay color
2024-07-23 23:35:25 +08:00
normalid
c7b110a471
* Fix the default position
...
* Make the font match stable style
2024-07-23 22:11:28 +08:00
normalid
989ac56cbb
Fix the return button being squshed
2024-07-23 21:12:55 +08:00
normalid
9fe369b7f4
Replace SkinnableSprite with Sprite
2024-07-23 21:08:08 +08:00
normalid
a015fde014
Change the default height to match the stable
2024-07-23 20:53:06 +08:00
normalid
dce894108a
Remove unused blending mode
2024-07-23 20:50:08 +08:00
normalid
f7dc0b65da
Clean up the code
2024-07-23 20:47:49 +08:00
normalid
5dcc8b7a8f
Make the text are always horizontal
2024-07-23 19:56:43 +08:00
Dean Herbert
aed7ba9508
Change order of application to avoid bias to side with more room to drag
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2024-07-23 20:56:21 +09:00
normalid
777a0deb0f
Update the offset formula
2024-07-23 19:45:53 +08:00
Bartłomiej Dach
c3062f96ee
Fix autogenerated breaks not invalidating on change to pre-empt time
2024-07-23 13:38:50 +02:00
Bartłomiej Dach
088e8ad0a2
Respect pre-empt time when auto-generating breaks
...
Closes https://github.com/ppy/osu/issues/28703 .
2024-07-23 13:30:13 +02:00
