1238 Commits

Author	SHA1	Message	Date
Bartłomiej Dach	68c20a2a37	Allow autoplay score generation to access mod list	2021-02-07 18:35:34 +01:00
Joehu	9ef130cdcc	Fix codefactor style issues	2021-02-04 13:28:35 -08:00
Corentin PALLARD	d168de0ae3	Formatting	2021-01-29 03:03:23 +01:00
Corentin PALLARD	da4c207a73	Fix the ctb auto mod speedup in some occasions	2021-01-29 02:53:26 +01:00
smoogipoo	1b166d809e	Adjust package titles	2021-01-18 11:08:03 +09:00
smoogipoo	ec00aaef90	Add nuget deploys for all rulesets	2021-01-18 10:53:31 +09:00
Bartłomiej Dach	303cc62ee7	Transfer flags indicating if settings were changed	2021-01-06 22:46:46 +01:00
Dean Herbert	1793385e96	Pass a score to the replay recorder to allow reading more general scoring data	2020-12-14 16:52:14 +09:00
Dean Herbert	b81dbfc192	Move shared implementation to a named function	2020-12-14 13:56:46 +09:00
ekrctb	5b5e883904	Remove EffectiveXBindable (setting Value was not handled) ... And use orthogonal `OriginalXBindable` and `XOffsetBindable`.	2020-12-14 13:39:07 +09:00
ekrctb	0ad256a762	Fix comment	2020-12-14 13:18:32 +09:00
ekrctb	d96399ea42	Revert "Remove X setter from CatchHitObject" ... This reverts commit 7cbbd74d	2020-12-14 13:18:14 +09:00
ekrctb	7cbbd74df2	Remove X setter from CatchHitObject	2020-12-14 11:38:07 +09:00
ekrctb	f621d977fc	Add some more doc comment	2020-12-14 11:32:34 +09:00
ekrctb	36529bdd1b	Use OriginalX for CatchHitObject.X instead of EffectiveX ... And explicitly implement IHasXPosition interface to prevent use of the X property. It should be preferred for beatmap conversion purpose.	2020-12-14 11:26:05 +09:00
ekrctb	089f3bebf5	Add doc comments to catch hit object X properties	2020-12-14 11:15:49 +09:00
ekrctb	cd2db59900	XBindable -> EffectiveXBindable in catch DHO	2020-12-14 11:05:26 +09:00
ekrctb	96f3e0dad8	Replace CatchHitObject.X usage to EffectiveX and OriginalX	2020-12-14 11:03:14 +09:00
ekrctb	c1f3f1c231	Obsolete X getter	2020-12-14 11:03:10 +09:00
ekrctb	8da502da44	Separate asymmetric CatchHitObject.X to EffectiveX and OriginalX	2020-12-14 11:03:03 +09:00
Dean Herbert	c0d20d8ce4	Add some spacing to interface class	2020-12-11 16:43:00 +09:00
ekrctb	2634c6b8d9	Combine DisplayRadius and Scale to DisplaySize	2020-12-10 20:43:01 +09:00
ekrctb	e097b6e61c	Add ScalingContainer back ... Don't want to set DHO.Scale or DHO.Rotation because because DHO may be transformed by mods. DHO.Size is also assigned for drawable visualizer	2020-12-10 19:42:01 +09:00
smoogipoo	ac91f0e270	Add extended limits to difficulty adjustment mod	2020-12-10 00:37:19 +09:00
ekrctb	a8e2f35b62	Remove unneeded check of caught object removal ... The logic was public but now it is private so the condition is ensured by the caller	2020-12-09 10:50:35 +09:00
ekrctb	775c4bad97	Remove unneeded lifetime assignment	2020-12-09 10:47:04 +09:00
ekrctb	da2f3d4473	Move classes to separate files	2020-12-09 10:40:42 +09:00
ekrctb	b52e279702	Reword exception message	2020-12-09 10:38:11 +09:00
ekrctb	86445e7c23	Remove unnecessary copy	2020-12-09 10:36:54 +09:00
ekrctb	c8b0934573	Rename caughtFruitContainer -> caughtObjectContainer	2020-12-09 10:35:36 +09:00
ekrctb	ccca7e0b25	more specific type droppedObjectContainer	2020-12-09 10:35:01 +09:00
ekrctb	df9de7a8dd	Remove null check that is not required anymore	2020-12-09 10:28:42 +09:00
ekrctb	b80204642e	Revert rename error	2020-12-09 10:25:35 +09:00
ekrctb	1212ffd24f	Rename to CopyStateFrom, and add comment	2020-12-08 23:35:24 +09:00
ekrctb	5ca98b0033	Add doc comments a bit	2020-12-08 23:11:22 +09:00
ekrctb	1f36bbecd1	Fix dropped objects not removed on revert result	2020-12-08 23:07:30 +09:00
ekrctb	749d5380ca	Pool caught objects and dropped objects	2020-12-08 22:38:10 +09:00
ekrctb	a32dac00dd	Introduce IHasCatchObjectState implemented by DHO and CaughtObject	2020-12-08 21:29:26 +09:00
ekrctb	c301223d8c	Make object on the catcher plate separate CaughtObject class	2020-12-08 21:11:40 +09:00
ekrctb	94a59ac3b2	Make catch hit lighting logic not dependent on caught object	2020-12-08 20:41:26 +09:00
ekrctb	004c705aa9	Remove ScaleContainer and flatten the Drawable tree of catch DHO	2020-12-08 20:37:08 +09:00
ekrctb	56721a6fa9	Compute object position in stack via a pure function	2020-12-08 20:36:59 +09:00
Dan Balasescu	0739f09930	Merge pull request #11110 from ekrctb/fruit-piece-in-place ... Implement in-place update of catch DrawableHitObject	2020-12-08 18:36:20 +09:00
Dan Balasescu	c3241f163d	Merge pull request #11126 from ekrctb/fix-catcher-trail-sprite-pooled ... Clear all transforms of catcher trail sprite before returned to pool	2020-12-08 17:59:23 +09:00
Dan Balasescu	1757b9c3e7	Merge branch 'master' into fruit-piece-in-place	2020-12-08 17:42:34 +09:00
ekrctb	22a5df6309	Clear all transforms of catcher trail sprite before returned to pool	2020-12-08 17:31:00 +09:00
ekrctb	4d5c242d35	Use virtual property instead of a field for optional pieces	2020-12-08 17:15:40 +09:00
ekrctb	603cecb2eb	Make CatchHitObjectPiece abstract class	2020-12-08 17:02:57 +09:00
ekrctb	17d48c82f6	Use switch statement instead of an array	2020-12-08 16:59:06 +09:00
ekrctb	02571ec7ae	Remove hit explosion on revert result	2020-12-08 15:43:17 +09:00
ekrctb	1a66d8f2bc	Remove caught objects on revert result	2020-12-08 15:24:39 +09:00
ekrctb	100b365c98	Restore hyper dash state on revert judgement result	2020-12-08 15:21:47 +09:00
ekrctb	cb76a2d7b5	Restore catcher state on revert judgement result	2020-12-08 15:03:03 +09:00
ekrctb	0213f77b4b	Move catcher state changing logic to OnNewResult method	2020-12-08 14:28:30 +09:00
ekrctb	4da6717d0e	Rename things in PulpFormation	2020-12-08 10:33:18 +09:00
ekrctb	3cbdaf5960	Make resolved properties protected	2020-12-08 10:30:23 +09:00
ekrctb	b2e5658d23	Merge branch 'master' into fruit-piece-in-place	2020-12-07 18:57:42 +09:00
Dan Balasescu	fb599e0746	Merge pull request #11114 from ekrctb/pool-catcher-trail ... Pool catcher trail sprite	2020-12-07 18:48:08 +09:00
ekrctb	12c6b3c1fb	Pool catcher trail sprite	2020-12-07 18:12:55 +09:00
ekrctb	c1d39b6401	Don't inherit Fruit from Banana	2020-12-07 14:10:17 +09:00
ekrctb	7f1ad1040d	Don't inherit DrawableFruit from DrawableBanana ... - A banana cannot be hyper	2020-12-07 14:08:50 +09:00
ekrctb	c0f39514b9	Fix legacy droplet scale	2020-12-07 14:00:22 +09:00
ekrctb	b8f1c499a4	Allow PulpFormation to update formation dynamically ... Pulps are lazily allocated but never deallocated for a DrawableFruit	2020-12-07 13:56:22 +09:00
ekrctb	0d73bf8488	Refactor catch default piece to allow reuse ... But Fruit in-place update is still incomplete, as child drawables are recreated when reused.	2020-12-07 13:14:00 +09:00
ekrctb	d51d2c5331	Don't recreate pieces when catch DHO is reused	2020-12-07 12:59:03 +09:00
ekrctb	87189452d1	Refactor legacy skin piece to allow texture update	2020-12-07 12:57:24 +09:00
ekrctb	d18397acad	Adjust namespace	2020-12-07 12:35:24 +09:00
ekrctb	b4b9312e0f	Move piece files of Catch ruleset	2020-12-07 12:34:38 +09:00
Dean Herbert	d3a17b65d5	Move public methods upwards	2020-12-04 14:36:40 +09:00
Dean Herbert	8988023407	Tidy up code formatting and remove unnecessarily publicly exposed methods	2020-12-04 14:35:56 +09:00
Dean Herbert	aa24890aff	Merge branch 'master' into caught-object-refactor	2020-12-04 14:12:33 +09:00
Dean Herbert	0134ac94a7	Merge pull request #11055 from ekrctb/catch-stateless-rng	2020-12-04 13:08:30 +09:00
ekrctb	23af70dd32	Invert if	2020-12-04 10:24:25 +09:00
ekrctb	e82ca66d3e	Fix depth of dropped objects	2020-12-04 10:21:54 +09:00
ekrctb	7e66714c2f	Use ApplyCustomUpdateState for dropping transformation ... We cannot just apply the transforms because DHO clears transforms when state is updated	2020-12-03 18:46:58 +09:00
ekrctb	be456f9c6b	Make DroppedObjectAnimation private	2020-12-03 18:46:58 +09:00
ekrctb	5a5c956ced	Move more logic to Catcher from CatcherArea	2020-12-03 16:44:36 +09:00
ekrctb	2eb2c934cc	Refactor fruit dropping code ... - The repeated `Remove` call was quadratic complexity. Now it is linear time.	2020-12-03 16:44:36 +09:00
ekrctb	873f2363c1	Simplify the fruit stacking code ... It is now more clear that the expression of distance checking is probably unintended (a bug)	2020-12-03 16:44:36 +09:00
ekrctb	8d32cca5d6	Use more specific type for caught object	2020-12-03 16:44:36 +09:00
ekrctb	a231a4aa6d	Remove unused method	2020-12-03 16:44:36 +09:00
ekrctb	af45e8d97b	Don't delay caught fruit loading ... It is not needed anymore because some code in DCHO is moved from `load` to constructor.	2020-12-03 16:44:36 +09:00
ekrctb	e5c8e06c4b	Create children in the constructor	2020-12-03 16:44:36 +09:00
ekrctb	2e8195e059	Use transformation to set fruit rotation	2020-12-03 12:13:14 +09:00
ekrctb	fdcfa81e46	Make RandomSeed a property, not a bindable	2020-12-02 20:53:47 +09:00
ekrctb	08848e49de	Set banana combo colour using random seed	2020-12-02 17:12:30 +09:00
ekrctb	8b6161a51c	Use deterministic randomness in catch hit object	2020-12-02 16:54:18 +09:00
ekrctb	e7c0e9834f	Introduce RandomSeed in catch DHO	2020-12-02 16:53:01 +09:00
smoogipoo	946613e803	Fix bananas not playing sounds	2020-12-02 15:22:54 +09:00
Dean Herbert	71a121389b	Merge pull request #11033 from smoogipoo/immutable-hit-samples ... Make HitSampleInfo immutable	2020-12-02 14:44:26 +09:00
Dan Balasescu	2e0fdf9bca	Merge pull request #11011 from ekrctb/catch-pooling-initial ... Initial implementation of hit object pooling in osu!catch ruleset	2020-12-02 13:02:22 +09:00
smoogipoo	6b4a6c12c8	Fix bad equality comparer implementations	2020-12-01 18:13:53 +09:00
smoogipoo	199710b941	Implement equality comparers for HitSampleInfo	2020-12-01 16:04:08 +09:00
smoogipoo	5760e1c1fc	Make HitSampleInfo immutable	2020-12-01 15:37:51 +09:00
ekrctb	e8842eed81	Use bigger initial capacity for catch hit object pool	2020-12-01 14:50:42 +09:00
ekrctb	a16b265090	Apply suggested styling changes	2020-12-01 14:46:04 +09:00
smoogipoo	5945c088cb	A few code standard cleanups	2020-12-01 12:57:37 +09:00
ekrctb	08cb84b325	Pool osu!catch hit explosion	2020-12-01 11:32:20 +09:00
ekrctb	d1076778fd	Convert switch expression to switch statement	2020-12-01 09:50:52 +09:00
ekrctb	4cd234ea05	Fix null reference of LegacyFruitPiece	2020-11-30 19:56:12 +09:00