Dean Herbert
|
2db42f8e67
|
Remove default allowRetry parameter value from ResultsScreen
|
2020-11-20 14:35:44 +09:00 |
|
Dean Herbert
|
5113d4af8f
|
Rename BeatmapDifficultyManager to BeatmapDifficultyCache
|
2020-11-06 13:14:29 +09:00 |
|
Dan Balasescu
|
98c992004b
|
Merge pull request #10660 from peppy/fix-song-select-first-track-looping
Fix looping mode not being set on first track after entering song select
|
2020-11-04 14:37:27 +09:00 |
|
Dean Herbert
|
cfe3218239
|
Move scheduler call to inside method itself for added safety
|
2020-11-04 10:23:06 +09:00 |
|
Dean Herbert
|
d788931661
|
Fix LoadComponentAsync calls potentially occuring after beatmap wedge disposal
As seen in https://ci.appveyor.com/project/peppy/osu/builds/36109658/tests.
Also adds cancellation logic for good measure.
|
2020-11-03 19:53:45 +09:00 |
|
Dean Herbert
|
df9ff76f23
|
Reduce assert to guard in the outwards direction
|
2020-11-03 16:49:13 +09:00 |
|
Dean Herbert
|
d5c95a8b46
|
Centralise into methods and add assertions for safety
|
2020-11-03 00:45:55 +09:00 |
|
Dean Herbert
|
c3d3856a64
|
Fix looping mode not being set on first track after entering song select
Closes #10656.
|
2020-11-02 23:51:02 +09:00 |
|
smoogipoo
|
6f623d8cca
|
Rename IsUserPaused -> UserPauseRequested
|
2020-11-02 16:08:59 +09:00 |
|
Dean Herbert
|
8f2cd0e8c5
|
Add matching requestedByUser parameter to Play method
|
2020-11-02 15:01:30 +09:00 |
|
Dean Herbert
|
6e2d722b8a
|
Merge pull request #10649 from ppy/dependabot/nuget/Microsoft.CodeAnalysis.FxCopAnalyzers-3.3.1
|
2020-11-02 11:52:38 +09:00 |
|
Dean Herbert
|
61c9bb3245
|
Merge branch 'master' into dependabot/nuget/Microsoft.CodeAnalysis.FxCopAnalyzers-3.3.1
|
2020-11-02 10:56:09 +09:00 |
|
Dan Balasescu
|
b1b52f9073
|
Merge branch 'master' into fix-resume-beatmap-options-edit
|
2020-11-02 10:46:31 +09:00 |
|
Joehu
|
71d55f16f3
|
Fix edit beatmap options button not resuming back to song select
|
2020-11-01 13:50:38 -08:00 |
|
Bartłomiej Dach
|
3090b6ccb5
|
Resolve CA2249 inspections
"Use `string.Contains` instead of `string.IndexOf` to improve
readability"
|
2020-11-01 18:54:44 +01:00 |
|
cadon0
|
a1fa6588f6
|
Fix "bounce" when metadata container text is empty
|
2020-10-31 01:06:19 +13:00 |
|
Dean Herbert
|
8b04cd2cb0
|
Fix a potential null reference when loading carousel difficulties
|
2020-10-25 20:28:24 +09:00 |
|
Dean Herbert
|
8232bf1957
|
Merge pull request #10576 from Game4all/song-select-wedge-dynamic-star-rating
|
2020-10-23 15:39:02 +09:00 |
|
Dean Herbert
|
9753dab93b
|
Remove IOnlineComponent and change existing components to use bindable flow
|
2020-10-22 14:19:12 +09:00 |
|
Lucas A
|
cf69eacae9
|
Make StarRatingDisplay dynamic.
|
2020-10-21 19:05:14 +02:00 |
|
Lucas A
|
670775cecb
|
Make beatmap wedge difficulty indicator color update dynamically.
|
2020-10-21 18:57:48 +02:00 |
|
Dan Balasescu
|
1fe987d4b3
|
Merge pull request #10497 from peppy/beatmap-carousel-less-diffcalc-stutter
Disable difficulty calculation for set-level difficulty icons
|
2020-10-20 14:57:34 +09:00 |
|
Dan Balasescu
|
976f96b51d
|
Merge branch 'master' into beatmap-carousel-refactor-less-alloc-overhead
|
2020-10-20 14:26:23 +09:00 |
|
Dan Balasescu
|
13060b8575
|
Merge branch 'master' into beatmap-carousel-less-diffcalc-stutter
|
2020-10-20 14:26:16 +09:00 |
|
Dean Herbert
|
d5940193a2
|
Ensure visible items is greater than zero before trying to display a range
|
2020-10-19 19:55:20 +09:00 |
|
Dean Herbert
|
9106e97c37
|
Ensure max value in clamp is at least zero
|
2020-10-19 19:10:01 +09:00 |
|
Dean Herbert
|
1c2185e969
|
Replace comment with link to issue
|
2020-10-19 18:41:28 +09:00 |
|
Dean Herbert
|
044622a7a6
|
Fix out of bounds issues
|
2020-10-19 18:41:17 +09:00 |
|
Dean Herbert
|
467bb9b96f
|
Merge branch 'master' into beatmap-carousel-refactor
|
2020-10-19 13:17:11 +09:00 |
|
Dean Herbert
|
bff3856c83
|
Account for panel height when removing as off-screen
|
2020-10-19 13:13:32 +09:00 |
|
Dean Herbert
|
ee0efa0b4c
|
Fix off-by-one in display range retrieval logic
|
2020-10-19 13:05:42 +09:00 |
|
Dean Herbert
|
4590d9b93b
|
Remove outdated comment logic
|
2020-10-19 13:04:12 +09:00 |
|
Berkan Diler
|
cc11283143
|
Use string.Starts-/EndsWith char overloads
|
2020-10-16 11:27:02 +02:00 |
|
Dean Herbert
|
88ffcb9234
|
Update EndsWith usages
|
2020-10-16 12:58:34 +09:00 |
|
Dean Herbert
|
30e1fce7a4
|
Reduce alloc overhead of DrawableCarouselBeatmapSet using new function-based ctor
|
2020-10-14 15:10:50 +09:00 |
|
Dean Herbert
|
07e6609e6d
|
Disable difficulty calculation for set-level difficulty icons
|
2020-10-14 14:16:22 +09:00 |
|
Dean Herbert
|
e662dc5342
|
Add missing licence headers
|
2020-10-13 20:57:26 +09:00 |
|
Dean Herbert
|
8057ea1097
|
Fix formatting issues
|
2020-10-13 20:50:36 +09:00 |
|
Dean Herbert
|
3d416f4d64
|
Clean up beatmapSet resolution in DrawableCarouselBeatmapSet
|
2020-10-13 19:31:29 +09:00 |
|
Dean Herbert
|
75b6a5e17e
|
Remove unnecessary hack (fixed via framework update)
|
2020-10-13 19:31:29 +09:00 |
|
Dean Herbert
|
5d11db7753
|
Locallise ChildItems to DrawableCarouselBeatmapSet for clarity
|
2020-10-13 19:31:29 +09:00 |
|
Dean Herbert
|
37daefc2b5
|
Remove outdated comment
|
2020-10-13 19:12:33 +09:00 |
|
Dean Herbert
|
8eca28e8bc
|
Add comment about off-screen loading
|
2020-10-13 19:10:35 +09:00 |
|
Dean Herbert
|
834b0186f4
|
Adjust fade duration to be slightly shorter
|
2020-10-13 18:50:10 +09:00 |
|
Dean Herbert
|
2346644c04
|
Switch DelayedLoadUnloadWrappers to DelayedLoadWrappers
Due to pooling usage, there is no time we need to unload. Switching to
DelayedLoadWrapper cleans up the code and reduces overhead
substantially.
|
2020-10-13 18:47:40 +09:00 |
|
Dean Herbert
|
a1801f8ae4
|
Unmark todo for now
|
2020-10-13 18:47:36 +09:00 |
|
Dean Herbert
|
40a0ab7aaa
|
Avoid allocating CarouselItems for bounds checks
|
2020-10-13 18:33:31 +09:00 |
|
Dean Herbert
|
4f4f222514
|
Remove unnecessary fade (already applied by base DrawableCarouselItem)
|
2020-10-13 18:28:28 +09:00 |
|
Dean Herbert
|
83358d487f
|
Remove logging
|
2020-10-13 18:18:22 +09:00 |
|
Dean Herbert
|
3d9ea852ec
|
Remove masking override (no longer needed as our size is now correct)
|
2020-10-13 18:14:23 +09:00 |
|