595 Commits

• Tooling updates (#37031)

  Most of this is as everywhere else, but there's also interesting code
  inspection fixes from the InspectCode bump, so I'll talk about that a
  little.
  
  ## [Fix suspicious equality in
  `Hotkey`](https://github.com/ppy/osu/commit/948136e49e88a721827d54e51c5759fe9aca811d)
  
  Inspection:
  https://www.jetbrains.com/help/resharper/TypeWithSuspiciousEqualityIsUsedInRecord.Global.html
  
  Pretty annoying to fix, nullable array types are a pain. Does look legit
  though.
  
  ## [Fix `StarDifficulty` using inefficient struct
  equality](https://github.com/ppy/osu/commit/2db775ebb0bb9f18de67677ef84b993465d26545)
  
  Inspection:
  https://www.jetbrains.com/help/resharper/DefaultStructEqualityIsUsed.Global.html
  
  This is a dodgy one because there's no real sane way to define equality
  on `StarDifficulty` now that it has difficulty and performance
  attributes jammed into it. So I just basically shut the inspection up
  with a `record` modifier and move on.
  
  Unclear where the equality is used precisely. It's from a global
  inspection. F12 is very unhelpful when trying to track down usages of
  `Equals()`. We definitely have `Bindable<StarDifficulty>` instances and
  those do use equality. Maybe more than that.
  
  ## [Use `nameof` expressions to reference enum member
  names](https://github.com/ppy/osu/commit/aa08175c803bc725f3b15a92174dfe6d1b812d91)
  
  Inspection:
  https://www.jetbrains.com/help/resharper/CanSimplifyDictionaryRemovingWithSingleCall.html
  
  Pretty quaint.
  
  ## [Prefer using concrete values over `default` or
  `new()`](https://github.com/ppy/osu/commit/b21ee08d7748be10d42268d5c2eb77369026545d)
  
  Inspection:
  https://www.jetbrains.com/help/resharper/PreferConcreteValueOverDefault.html
  
  I could see this one going both ways, but I'm kinda sold on this
  inspection. Explicit is always better. Saves some allocations in the
  `CancellationToken` cases as well.
  
  ## [Explicitly call `.AsEnumerable()` in some realm
  usages](https://github.com/ppy/osu/commit/c8ce1ecd42b9d8abb8b9e2ab93d471f463e80401)
  
  Inspection:
  https://www.jetbrains.com/help/resharper/PossibleUnintendedQueryableAsEnumerable.html
  
  Not fully sold on this one but it's quick and simple so might as well.
  
  ## [Simplify dictionary removal with single `.Remove()`
  call](https://github.com/ppy/osu/commit/5964ceccea900302df726b7a8ecbf6b74eb2e427)
  
  Inspection:
  https://www.jetbrains.com/help/resharper/CanSimplifyDictionaryRemovingWithSingleCall.html
  
  Not much to say.

  Bartłomiej Dach · 2026-03-19 00:05:52 +09:00
  18d4ba5874
• Preserve bookmarks when creating a new difficulty from scratch (#36675)

  Closes #33395
  
  Copies the bookmarks from `referenceWorkingBeatmap` while creating a new
  difficulty from scratch. I adapted the tests in
  `TestSceneEditorBeatmapCreation` to include the bookmark checks.
  
  ---------
  
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Arthur Araujo · 2026-02-16 12:50:04 +09:00
  2f459dd94e
• Merge branch 'master' into add-custom-samples-via-setup
  Dean Herbert · 2026-01-16 20:11:28 +09:00
  e1bde264bc
• Adjust beatmap query to fix potential crash
  Dan Balasescu · 2026-01-05 17:16:27 +09:00
  78a5654e1f
• Add way to add/remove custom beatmap samples to setup screen

  Among others, this features a scary-looking change wherein
  `WorkingBeatmap` now exposes a `RealmAccess` via
  `IStorageResourceProvider`. This is necessary to make
  `RealmBackedResourceStore` actually start firing callbacks when the
  edited beatmap's skin is modified by adding new samples to it.

  Bartłomiej Dach · 2025-12-31 12:14:28 +01:00
  334a54e6f7
• Reduce code duplication

  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Dan Balasescu · 2025-12-24 19:30:04 +09:00
  81f03957d8
• Add explicit menu item for exporting guest difficulties from editor

  A few facts of life:
  
  - Guest difficulties are at this point a staple of mapping.
  
  - People are very much used to flinging `.osu`s around (because there's
    no better alternative).
  
  - Currently there are two ways to get an `.osu` out of lazer. You can:
  
    - Export the beatmap as "compatibility" to an `.osz`, then
      transmogrify the `.osz` to a `.zip`, then extract the `.zip`, then
      pluck out the `.osu`. This is the "correct" way to make sure stable
      works, but is also stupidly arcane.
  
    - Use "edit externally" to mount the beatmap files to disk, then
      copy-paste out the `.osu`. This is the *wrong* way to make sure
      stable works, because the mounting process exposes the raw "for
      editing" format with features stable doesn't support, but it the
      actual easy one.
  
  - Reports about guest difficulties exported from lazer "working wrong on
    stable" are prevalent. Probably mostly because of the preceding point.
  
  What this PR does is introduce a *third* method to export an `.osu`,
  which is designed to be both the easiest one yet *and* correct. I am
  hoping this will curb the complaints until support for direct submission
  of guest difficulties is added - which I still hope to see, but it will
  be a significant effort *client-side* (the server side has been ready
  for years now).
  
  And yes, you will notice that much of the code added in
  `LegacyBeatmapExporter` related to manipulation of the path is
  copy-pasted from `LegacyExporter`. I don't care enough to invent
  protected / abstract / whatever else OOP faff for something that may not
  survive review and is mostly a weird semi-temporary wart.

  Bartłomiej Dach · 2025-12-22 11:36:23 +01:00
  3712093158
• Use interface instead
  Dan Balasescu · 2025-10-22 16:02:46 +09:00
  4cac1781c5
• Fix quick play not redownloading modified beatmaps
  Dan Balasescu · 2025-10-22 15:34:29 +09:00
  c6fcba7e1c
• SSV2 : Replace "Mark as Played" with "Remove from Played" if map is already played (#35287)

  * SSV2 : Replace Mark as Played with Remove from Played if already played
  
  * Remove checks of BeatmapInfo.LastPlayed for DateTimeOffset.MinValue
  
  * Make FooterButtonOptions use a RealmLive<BeatmapInfo> and act on review comments
  
  * FIXUP: Detach BeatmapInfo before passing it to FooterButtonOptions.Popover
  
  ---------
  
  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Alban Cabannes-Michel · 2025-10-16 14:59:16 +02:00
  8f6f859c15
• Add some logging when FindWithRefresh triggers a slow realm refresh
  Dean Herbert · 2025-10-10 13:36:28 +09:00
  94c7489c1c
• Disallow hiding beatmap difficulties if only one difficulty remains
  Dean Herbert · 2025-07-10 17:57:45 +09:00
  789ddcf395
• Use alternative method of fixing issue of improper beatmap query in daily challenge (and expand to other online play modes)
  Bartłomiej Dach · 2025-03-27 09:33:35 +01:00
  f73601535d
• Do not reset online info on beatmap save
  Bartłomiej Dach · 2025-01-31 12:21:42 +01:00
  c3981f1097
• Implement ability to mark beatmap as played

  Reported at https://osu.ppy.sh/community/forums/topics/2015478?n=1.
  
  Would you believe it that this button that has been there for literal
  years never did anything?
  
  Implemented at a per-beatmap level. Also additionally added to context
  menu (at @peppy's suggestion), and also copy reworded from "Delete from
  unplayed" to "Mark as played" because double negation hurt my tiny
  brain.

  Bartłomiej Dach · 2024-12-16 10:49:19 +09:00
  a6e00d6eac
• Fix reference effect point getting mutated
  Salman Alshamrani · 2024-12-06 05:47:41 -05:00
  5cb6b86b1c
• Copy effect points across on blank difficulty creation
  Salman Alshamrani · 2024-12-04 02:32:00 -05:00
  e3abbf1177
• Centralise supported file extensions to one helper class

  As proposed in
  https://github.com/ppy/osu-server-beatmap-submission/pull/5#discussion_r1861680837.

  Bartłomiej Dach · 2024-11-29 08:42:45 +01:00
  110e4fbb30
• Use RealmLive in SaveFailedScoreButton

  This also optimises the manager classes to better support `Live` usage
  where the managed object is already in a good state (ie. doesn't require
  re-fetching).

  Dean Herbert · 2024-11-27 15:25:42 +09:00
  5260a401d4
• Only update beatmaps which actually had offsets

  Without this every beatmap gets a write and it reloads the whole of song
  select, basically.

  Dean Herbert · 2024-10-14 00:35:18 +09:00
  53671ad11e
• Add functionality to mass reset offsets
  Artemis Rosman · 2024-10-13 00:50:45 +11:00
  e4f9c861ba
• Add support for automatically downloading daily challenge during the intro display
  Dean Herbert · 2024-08-08 15:10:18 +09:00
  5d66eda982
• Add basic flow for mounting beatmaps for external editing
  Dean Herbert · 2024-07-10 18:29:51 +09:00
  d3c66e2404
• Switch to const string
  Brandon · 2024-02-18 22:12:03 -08:00
  413b7aab60
• Add feedback to delete button even when no-op
  Brandon · 2024-02-18 21:52:23 -08:00
  c6ca812ea0
• use realm query
  cdwcgt · 2023-09-04 17:13:46 +09:00
  3decadaf51
• Merge remote-tracking branch 'upstream/master' into legacy-export
  OliBomby · 2023-07-18 12:18:49 +02:00
  5d82190b70
• Optimize realm transactions for editor Save action
  OliBomby · 2023-07-13 14:33:21 +02:00
  cde8d8e7f1
• Move all conversion code to LegacyBeatmapExporter
  OliBomby · 2023-07-13 00:20:01 +02:00
  1d837a8725
• dispose the streams
  OliBomby · 2023-07-12 15:18:16 +02:00
  8ca801a224
• Export legacy converted beatmaps as .osz and non-converted beatmaps as .osz2
  OliBomby · 2023-07-11 21:04:09 +02:00
  b577b6b6ae
• It works now
  OliBomby · 2023-07-11 20:18:54 +02:00
  2db25722cb
• legacy export broken
  OliBomby · 2023-07-11 02:30:16 +02:00
  06e5ef88c0
• Merge pull request #24114 from peppy/editor-save-local-score-management

  Ensure scores always have the correct linked `BeatmapInfo`

  Dean Herbert · 2023-07-07 15:40:54 +09:00
  d72765b6f8
• Bring realm library up-to-date
  Dean Herbert · 2023-07-06 13:37:43 +09:00
  a98a36872e
• Move score attach logic to a helper method and call during editor save
  Dean Herbert · 2023-07-04 15:07:40 +09:00
  64fc5e40e8
• Fix difficulty deletion not deleting records from realm
  Bartłomiej Dach · 2023-06-27 23:43:00 +02:00
  6876566530
• Remove usages of [ExcludeFromDynamicCompile]
  Dan Balasescu · 2023-05-08 18:12:56 +09:00
  d2380bd840
• Remove non-Live pathway
  Dean Herbert · 2023-05-06 23:10:18 +09:00
  0d095c4bb7
• Merge branch 'master' into export
  cdwcgt · 2023-05-04 00:18:01 +09:00
  4549a865d9
• Fix beatmap leaderboard test failure

  Because the online info reset (which includes online ID reset) was
  happening after encoding,
  `TestSceneBeatmapLeaderboard.TestLocalScoresDisplayOnBeatmapEdit()`
  started failing, as the hash no longer matched expectations after the
  first save of the map.

  Bartłomiej Dach · 2023-05-01 19:44:15 +02:00
  436ebdcfcb
• Always reset online info when saving local beatmap
  Bartłomiej Dach · 2023-05-01 18:17:45 +02:00
  f470b2c9cc
• Fixed video importing bug #23259
  Haspamelodica · 2023-04-21 02:10:24 +02:00
  b62de5514c
• Do not look up metadata for locally-modified beatmaps on save
  Bartłomiej Dach · 2023-04-11 23:14:35 +02:00
  e72f103c17
• use Live<TModel>

  Use RealmAccess only when needed

  cdwcgt · 2023-04-09 22:21:15 +09:00
  de21b4a2f7
• Merge branch 'master' into export
  cdwcgt · 2023-02-17 22:15:19 +09:00
  e84e011d5d
• Reword comment regarding hash transfer to make more sense
  Dean Herbert · 2023-01-25 14:11:02 +09:00
  392ff2ffea
• Make transferCollections argument to private method explicitly required
  Dean Herbert · 2023-01-25 14:09:13 +09:00
  741ca96853
• Add argument hint for nondescript bool

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2023-01-25 14:04:30 +09:00
  739ec8d81d
• Revert split and make collections boolean internal to BeatmapManager
  naoey · 2023-01-24 07:27:26 +09:00
  e6de167adb