1156 Commits

• Use CreateRuleset() for editor test scenes as well
  Salman Ahmed · 2020-06-04 00:47:10 +03:00
  741fa20149
• Remove bindable-disabling logic and don't tie immediately to CreateRuleset()
  Salman Ahmed · 2020-06-04 00:44:28 +03:00
  c72592c52c
• Fix mod perfect test scenes failing due to null ruleset provided

  Just a workaround for now, a better fix may be to put the test data creation in an action that is guaranteed to be invoked after the test scene has fully loaded (all dependencies would've been resolved by then).

  Salman Ahmed · 2020-06-04 00:43:11 +03:00
  bbad70c3f0
• Set the ruleset bindable value at the BDL for its subclasses usages

  There are test scenes using current value of ruleset bindable on their BDL (example in TestSceneSliderSnaking's BDL)

  Salman Ahmed · 2020-06-04 00:37:06 +03:00
  136e10086a
• Reorder declaration position of ruleset-creation methods

  Should be recognized as a normal protected method in its declaring class.

  Salman Ahmed · 2020-06-03 23:43:18 +03:00
  11da045d8c
• Merge remote-tracking branch 'upstream/master' into test-scene-create-ruleset

  # Conflicts:
  #	osu.Game.Rulesets.Catch.Tests/TestSceneBananaShower.cs
  #	osu.Game.Rulesets.Catch.Tests/TestSceneHyperDash.cs
  #	osu.Game/Tests/Visual/ModTestScene.cs
  #	osu.Game/Tests/Visual/OsuTestScene.cs

  Salman Ahmed · 2020-06-03 22:00:02 +03:00
  84b40ea2c6
• Remove unnecessary use of and remove StartupStorage
  Salman Ahmed · 2020-05-31 19:49:03 +03:00
  2c6887e610
• Replace any potential usage of Environment.CurrentDirectory with a new RuntimeInfo.StartupDirectory

  Using `Environment.CurrentDirectory` for storing / reading files is dangerous as the current directory is mutable and can be changed when performing a certain operation (like opening solutions in roslyn type reference builder for example).

  Salman Ahmed · 2020-05-31 02:24:49 +03:00
  82fe99cf4a
• Fix remaining test failures
  Dean Herbert · 2020-05-22 18:23:24 +09:00
  866db629d6
• Cache and resolve editor clock as EditorClock in all cases
  Dean Herbert · 2020-05-22 16:44:06 +09:00
  dd09d7830d
• Move more logic to column to both clean things up and fix tests
  Dean Herbert · 2020-05-21 14:25:37 +09:00
  bac78707de
• Pass down snap result and remove local TimeAt usage
  Dean Herbert · 2020-05-20 21:01:29 +09:00
  82d6549161
• Merge branch 'master' into remove-requiredtypes
  Dean Herbert · 2020-05-16 18:28:14 +09:00
  be3a0a3c1d
• Remove all RequiredTypes usages
  smoogipoo · 2020-05-16 18:17:12 +09:00
  648999a2de
• Commit missed change
  Dean Herbert · 2020-05-12 20:26:34 +09:00
  44319c1b71
• Fix mod failure checks executing actual game logic
  Dean Herbert · 2020-05-12 20:08:35 +09:00
  de50b725d5
• Improve test scene
  smoogipoo · 2020-04-28 18:36:10 +09:00
  7d54d4b800
• Merge branch 'master' into fix-mania-placement
  Dean Herbert · 2020-04-24 17:00:12 +09:00
  fe0038ed14
• Merge remote-tracking branch 'upstream/master' into test-scene-create-ruleset
  Salman Ahmed · 2020-04-23 16:25:33 +03:00
  227503c0af
• Seal the ruleset creation methods and let abstract method take their place

  Also makes `CreatePlayerRuleset()` and `CreateRulesetForSkinProvider()` not-null to avoid unwanted behaviour with their derivers

  Salman Ahmed · 2020-04-23 13:27:12 +03:00
  2fa47992dc
• Mark the top ruleset creation method as can-be-null
  Salman Ahmed · 2020-04-23 13:24:30 +03:00
  0a0ea39431
• Expose direction from scrolling test container
  smoogipoo · 2020-04-23 11:17:16 +09:00
  6df45164fa
• Resolve broken test scene
  smoogipoo · 2020-04-23 10:37:05 +09:00
  40f11ed15c
• Ensure editor tests wait for load to complete
  smoogipoo · 2020-04-22 19:49:21 +09:00
  08982e0e00
• Merge pull request #8800 from iiSaLMaN/allow-cancelling-completion

  Fix results screen pushed after rewinding in-between push delay

  Dean Herbert · 2020-04-21 12:49:49 +09:00
  af32f51116
• Replace all judged event logic with HasCompleted bindable
  Salman Ahmed · 2020-04-19 05:36:04 +03:00
  fc6c245de5
• Merge branch 'master' into taiko-drumroll-skinning
  Dean Herbert · 2020-04-17 19:30:18 +09:00
  d4788e39bb
• Re-enable ruleset bindable before setting defined ruleset in case it's disabled

  Happens on cases like restarting the test scene by clicking directly on it on the browser (*where it for some reason reloads the entire test scene*)

  Salman Ahmed · 2020-04-17 11:18:05 +03:00
  7f791dcdf0
• Remove ModTestScene ruleset parameter on constructor and use CreateRuleset instead
  Salman Ahmed · 2020-04-17 11:17:59 +03:00
  155bc8b49a
• Remove PlayerTestScene constructor and use CreateRuleset method instead
  Salman Ahmed · 2020-04-17 11:17:51 +03:00
  92df4e3a9e
• Move SkinnableTestScene into using the global CreateRuleset method
  Salman Ahmed · 2020-04-17 11:17:44 +03:00
  5fa6bcb5a3
• Add CreateRuleset in OsuTestScene for scenes that depend on it
  Salman Ahmed · 2020-04-17 11:12:25 +03:00
  67bd7bfa39
• Merge branch 'master' into fix-0-customsampleset
  Dean Herbert · 2020-04-16 11:20:31 +09:00
  4eefe47ce3
• Setup drumroll testing
  Dean Herbert · 2020-04-15 16:29:39 +09:00
  18c28390ef
• Fix no audiomanager in test scene working beatmap
  smoogipoo · 2020-04-14 21:05:42 +09:00
  b29957798f
• Improve slider placement test scene
  smoogipoo · 2020-04-13 15:31:54 +09:00
  bde0b259c1
• Cache ruleset dependencies if the scene tests ruleset-specific components
  Salman Ahmed · 2020-04-11 04:23:31 +03:00
  2b4208bebf
• Merge branch 'master' into per-ruleset-skinnable-tests
  Dan Balasescu · 2020-04-07 22:59:42 +09:00
  7951a52a15
• Retrieve dll resources using a more reliable method
  Dean Herbert · 2020-04-07 18:55:03 +09:00
  c9872f1d93
• Ensure the correct (up-to-date) ruleset is retrieved
  Dean Herbert · 2020-04-07 16:20:13 +09:00
  0a340bac5a
• Fix SkinnableTestScene losing test resources on dynamic recompilation
  Dean Herbert · 2020-04-07 13:46:37 +09:00
  8506029237
• Rework lookups to not require total playfield columns
  smoogipoo · 2020-04-03 12:31:05 +09:00
  1f797207f7
• Fix tooltips not showing inside ManualInputManagerTestScenes
  Dean Herbert · 2020-03-30 19:15:44 +09:00
  0d4830550e
• Rename base test class to help avoid incorrect reference
  Dean Herbert · 2020-03-23 10:01:33 +09:00
  0b728f483f
• Rename data class
  Dean Herbert · 2020-03-11 00:36:56 +09:00
  0be423183d
• Fix player instantiation

  Since ModTestScene.CreatePlayer would apply mods in addition to
  instantiating the player, overriding it could lead to mistakenly also
  overriding the code that was supposed to set up the test via
  currentTestData.
  
  Make ModTestScene.CreatePlayer sealed, which ensures that mod &
  autoplay changes are applied, and expose ModTestScene.CreateModPlayer
  instead which has the expected semantics.

  Bartłomiej Dach · 2020-03-08 14:18:45 +01:00
  c803de2b49
• Do not transition to result screen
  Bartłomiej Dach · 2020-03-08 14:08:49 +01:00
  cc5cae4db9
• Merge branch 'master' into fix-perfect-judgements
  Bartłomiej Dach · 2020-03-08 14:06:18 +01:00
  d5dda05d98
• Restore clamp behaviour
  Dean Herbert · 2020-03-06 22:44:11 +09:00
  3295f8657a
• Remove wild writeline
  Dean Herbert · 2020-03-06 02:18:35 +09:00
  c3ad08f230