43313 Commits

Author	SHA1	Message	Date
Salman Ahmed	337f05f9a4	Fix loading (but not showing) a sheared overlay hiding displayed footer content ... Identified by tests. See https://github.com/ppy/osu/actions/runs/9869382635/job/27253010485 & https://github.com/ppy/osu/actions/runs/9869382635/job/27253009622. This change also prevents the initial `PopOut` call in overlays from calling `clearActiveOverlayContainer`, since it's not in the update thread and it's never meant to be called at that point anyway (it's supposed to be accompanied by a previous `PopIn` call adding the footer content).	2024-07-10 11:56:35 +03:00
Salman Ahmed	002679ebb0	Ask for VisibilityContainer explicitly	2024-07-10 11:14:22 +03:00
Bartłomiej Dach	95783bd6c2	Merge pull request #28789 from peppy/fix-deletes-reappearing ... Fix deleted beatmap sets potentially reappearing due to pending update requests	2024-07-10 09:14:10 +02:00
Dean Herbert	9a88281ab0	Merge branch 'master' into footer-v2-integration	2024-07-10 15:33:05 +09:00
Dean Herbert	4fe3f39d22	Merge pull request #28682 from frenzibyte/footer-v2-overlay-content ... Add implementation for `ScreenFooter` to house footer content of sheared overlays	2024-07-10 15:08:00 +09:00
Dean Herbert	cd9973b6f9	Merge pull request #28740 from bdach/daily-challenge/better-results ... Improve results displays in daily challenge screen	2024-07-10 14:17:21 +09:00
Dean Herbert	f281019358	Rename method to match provided argument	2024-07-10 14:00:15 +09:00
Dean Herbert	4e1240c349	Migrate ShearedOverlayContainer to NRT	2024-07-10 13:54:27 +09:00
Joseph Madamba	8c81ba3357	Fix preview track persisting to play after leaving multi/playlists room	2024-07-09 14:36:24 -07:00
Dean Herbert	123d3d2ff8	Add similar special case for insert after removal	2024-07-09 20:44:55 +09:00
Dean Herbert	0e2e44a2f5	Add failing test case showing editor save then delete failure	2024-07-09 20:41:22 +09:00
Salman Ahmed	ed1f3a1eb4	Merge branch 'master' into footer-v2-integration	2024-07-09 13:48:40 +03:00
Salman Ahmed	b17af86491	Merge branch 'master' into footer-v2-overlay-content	2024-07-09 13:41:44 +03:00
Bartłomiej Dach	ca4c0aa7e2	Remove unused using	2024-07-09 10:57:21 +02:00
Bartłomiej Dach	13c8370823	Merge pull request #28786 from Joehuu/sort-direction-caret-transition ... Add caret transition to beatmap listing sort tab items	2024-07-09 10:52:11 +02:00
Dean Herbert	920c0e4d25	Fix deleted beatmap sets potentially reappearing due to pending update requests	2024-07-09 17:08:26 +09:00
Dean Herbert	63b4327978	Ensure beatmap set is always detached when updating ... Slight performance improvement by doing the detach as early as possible.	2024-07-09 17:08:25 +09:00
Bartłomiej Dach	877ade3053	Merge pull request #28787 from peppy/adjust-editor-fades ... Adjust editor transparent tweens to be less "flashy"	2024-07-09 10:08:14 +02:00
Bartłomiej Dach	5d5dd0de00	Redesign bottom timeline pieces to match stable better	2024-07-09 09:25:22 +02:00
Bartłomiej Dach	29b8948609	Slim down bottom timeline ... This removes the BPM display, which is commonly cited to have no functional purpose by users, and reduces the height of the bottom bar in exchange for more space for the playfield.	2024-07-09 09:25:22 +02:00
Bartłomiej Dach	50818da166	Ensure timeline ticks aren't hidden by other pieces ... Addresses https://github.com/ppy/osu/issues/28667.	2024-07-09 09:25:22 +02:00
Dean Herbert	aadcc5384d	Adjust editor transparent tweens to be less "flashy" ... Touched on in https://github.com/ppy/osu/discussions/28581. After a bit more usage of the editor I do agree with this and think that making the fades a bit more gentle helps a lot.	2024-07-09 16:16:19 +09:00
Dean Herbert	ee9e329db3	Inhibit original callback from firing when sending initial changeset	2024-07-09 16:05:58 +09:00
Dean Herbert	2423bbb776	Ensure realm subscriptions always fire initial callback with null ChangeSet ... We expect this to be the case, but it turns out that it [may be coalesced](https://www.mongodb.com/docs/realm-sdks/dotnet/latest/reference/Realms.IRealmCollection-1.html#Realms_IRealmCollection_1_SubscribeForNotifications_Realms_NotificationCallbackDelegate__0__Realms_KeyPathsCollection_): > Notifications are delivered via the standard event loop, and so can't > be delivered while the event loop is blocked by other activity. When > notifications can't be delivered instantly, multiple notifications may > be coalesced into a single notification. This can include the > notification with the initial collection. Rather than struggle with handling this locally every time, let's fix the callback at our end to ensure we receive the initial null case. I've raised concern for the API being a bit silly with realm (https://github.com/realm/realm-dotnet/issues/3641).	2024-07-09 15:47:43 +09:00
Joseph Madamba	cd968d4185	Add caret transition to beatmap sort tab items	2024-07-08 16:46:35 -07:00
Dean Herbert	c100d1ab65	Merge pull request #28769 from peppy/carousel-realm-simplification ... Simplify realm model tracking in `BeatmapCarousel` (and fix hard delete handling)	2024-07-09 01:40:10 +09:00
Dan Balasescu	9c2a0576fb	Merge pull request #28776 from bdach/fix-composer-disappearing ... Fix composer disappearing when undoing change to control points	2024-07-09 00:54:38 +09:00
Dean Herbert	9a61adc4bc	Ensure other lists are cleared when realm is reset	2024-07-08 23:59:20 +09:00
Bartłomiej Dach	275b959c02	Fix composer disappearing when undoing change to control points ... As mentioned in https://github.com/ppy/osu/issues/28752. Regressed in https://github.com/ppy/osu/pull/28444.	2024-07-08 16:28:54 +02:00
Bartłomiej Dach	877b5768fc	Merge branch 'master' into sorted-breaks	2024-07-08 15:59:32 +02:00
Bartłomiej Dach	0d22c9a9c6	Pass comparer in all usages for consistency	2024-07-08 15:58:21 +02:00
Salman Ahmed	b33e54d064	Enforce IBeatmap.Breaks to be sorted chronologically	2024-07-08 16:06:38 +03:00
Bartłomiej Dach	2cad8d3684	Merge branch 'master' into time-accurate	2024-07-08 14:19:57 +02:00
Bartłomiej Dach	d5158d1035	Fix incorrect changes around success callback refactor	2024-07-08 13:36:30 +02:00
OliBomby	2822ba2377	Fix CurrentTimeAccurate being inaccurate if seeking smoothly in the same frame and a transform is already active	2024-07-08 13:30:11 +02:00
Bartłomiej Dach	0fe2c45e1d	Fix editor playback control not removing correct adjustment ... Closes https://github.com/ppy/osu/issues/28768. great job past me 🤦🤦🤦🤦🤦🤦🤦🤦🤦🤦🤦	2024-07-08 13:21:42 +02:00
Dean Herbert	c0a1696538	Merge pull request #28762 from frenzibyte/change-chevron-display ... Change display of "expanded" chevrons in many UI components to use scale instead of rotation	2024-07-08 20:05:59 +09:00
Dean Herbert	8f271170e9	Coalesce beatmap updates	2024-07-08 20:05:18 +09:00
Dean Herbert	1095137a5b	Simplify tracking of hidden beatmaps ... Handling a few extra events is preferrable to keeping a second realm subscription live.	2024-07-08 20:05:18 +09:00
Dean Herbert	151c448535	Simplify tracking of beatmap sets in BeatmapCarousel	2024-07-08 20:05:18 +09:00
Dean Herbert	910153c2e0	Fix sizing / padding of collection dropdown header	2024-07-08 19:32:28 +09:00
Dan Balasescu	b2bdb67a3e	Merge pull request #28765 from bdach/editor-menu-max-height ... Fix editor menus overflowing off screen	2024-07-08 19:13:30 +09:00
Dan Balasescu	44ebec07bb	Merge pull request #28767 from bdach/editor-test-play-ur-counter-crash ... Fix editor player crashing with UR counter present in skin	2024-07-08 19:13:19 +09:00
Salman Ahmed	2fcc61edfa	Merge branch 'master' into audio-ducking-fx	2024-07-08 12:50:46 +03:00
Bartłomiej Dach	14a93bfc1a	Merge pull request #28553 from frenzibyte/mod-select-customisation-panel ... Detach mod customisation area from the footer and replace with an overlay panel display	2024-07-08 11:26:21 +02:00
Salman Ahmed	784a9ae743	Merge branch 'master' into audio-ducking-fx	2024-07-08 12:26:10 +03:00
Bartłomiej Dach	db7774485a	Fix editor player crashing with UR counter present in skin ... Closes https://github.com/ppy/osu/issues/28764.	2024-07-08 11:14:32 +02:00
Bartłomiej Dach	2ceedb0f93	Fix editor menus overflowing off screen ... Closes https://github.com/ppy/osu/issues/28750. Yes this is not the perfect change to fix this (which would probably be some framework change to take bounds of the parenting input manager into account). I really do not want to go there and would like to just fix this locally and move on. Due to the game-wide scaling container this sorta works for any resolution anyhow.	2024-07-08 11:05:39 +02:00
Joseph Madamba	73d164e0d0	Add chevron transition to CommentRepliesButton	2024-07-08 00:32:54 -07:00
Dean Herbert	03bd6069d8	Add slight animation when revert to default button is displayed ... This also fixes the transforms running too often (could make the initial transform take longer than expected if adjusting a slider bar, for instance).	2024-07-08 15:50:27 +09:00
Joseph Madamba	9532146978	Fix content overflowing to border ... The +2 for the top isn't really needed for the original purpose as content fades out now, but visually, having the header and content spacing looks more correct.	2024-07-07 23:12:20 -07:00
Salman Ahmed	7dc901df11	Do not be lenient on nullability of dropdown	2024-07-08 08:54:05 +03:00
Salman Ahmed	58e236a247	Add transition to dropdown chevrons	2024-07-08 08:48:52 +03:00
Salman Ahmed	4c2ae07eba	Use scale instead of rotation in ChevronButton (used in top-right of comments section)	2024-07-08 08:48:07 +03:00
Salman Ahmed	dc630ddc9d	Use scale instead of rotation in news month sidebar	2024-07-08 08:45:44 +03:00
Salman Ahmed	be039b85ad	Use scale instead of rotation in profile cover toggle button	2024-07-08 08:32:29 +03:00
Salman Ahmed	5223e0aeae	Use scale instead of rotation for overlay scroll button	2024-07-08 08:31:33 +03:00
Salman Ahmed	22f2f83695	Rescale chevron up and down instead	2024-07-08 08:07:57 +03:00
Salman Ahmed	a0ffe9bcbc	Remove unnecessary HandlePositionalInput override	2024-07-08 07:58:40 +03:00
Salman Ahmed	0c5a1410d3	Add fade transition to content during open/close	2024-07-08 07:54:37 +03:00
Dean Herbert	3650f3c479	Allow multiple ducks with same parameters	2024-07-08 13:52:40 +09:00
Dean Herbert	0067450b22	Change volume parameter to double	2024-07-08 13:47:57 +09:00
Dean Herbert	5907e0d1eb	Make DuckDuration non-zero by default	2024-07-05 18:39:13 +09:00
Dean Herbert	7efb4ce30a	Fix multiple disposals resulting in assert being hit	2024-07-05 18:39:12 +09:00
Dean Herbert	717f7ba9f0	Better support multiple concurrent ducking operations	2024-07-05 18:12:40 +09:00
Bartłomiej Dach	4c59ec1d94	Fix incorrect ternary state computation for bank toggles ... Closes https://github.com/ppy/osu/issues/28741. Regressed in a7b066f3ee. The intent of the original change there was to ensure that addition banks being set will put the ternary state toggles in indeterminate state (to at least provide a visual indication that the selection does not use a single bank). This would previously not be the case due to the use of `.All()` in the original condition (a single object/node was considered to have a bank enabled if and only if *all* samples within it used it). However the attempt to fix that via switching to `Any()` was not correct. The logic used in the offending commit operates on extracted `Samples` and `NodeSamples` from the selection, and would consider the ternary toggle: - fully off if none of the samples/node samples contained a sample with the given bank, - indeterminate if the some of the samples/node samples contained a sample with the given bank, - fully on if at least one sample from every samples/node samples contained a sample with the given bank. This is a *two-tiered* process, as in first a *binary* on/off state is extracted from each object's samples/node samples, and *then* a ternary state is extracted from all objects/nodes. This is insufficient to express the *desired* behaviour, which is that the toggle should be: - fully off if *none of the individual samples in the selection* use the given bank, - indeterminate if *at least one individual sample in the selection* uses the given bank, - fully on if *all individual samples in the selection* use the given bank. The second wording is flattened, and no longer tries to consider "nodes" or "objects", it just looks at all of the samples in the selection without concern as to whether they're from separate objects/nodes or not. To explain why this discrepancy caused the bug, consider a single object with a `soft` normal bank and `drum` addition bank. Selecting the object would cause a ternary button state update; as per the incorrect logic, there were two samples on the object and each had its own separate banks, so two ternary toggles would have their state set to `True` (rather than the correct `Indeterminate`), thus triggering a bindable feedback loop that would cause one of these banks to win and actually overwrite the other. Note that the addition indeterminate state computation *still* needs to do the two-tiered process, because there it actually makes sense (for a selection to have an addition fully on rather than indeterminate, *every* object/node *must* contain that addition).	2024-07-05 09:27:21 +02:00
Bartłomiej Dach	6907d3d3b5	Merge branch 'master' into nodesample-inherit	2024-07-05 08:12:47 +02:00
Bartłomiej Dach	ab8623ec48	Merge pull request #28727 from OliBomby/inherit-addition ... Allow inheriting addition bank from previous hitobject when using auto bank assignment	2024-07-05 08:12:30 +02:00
Dean Herbert	20ba6ca867	Add mention of return type for Duck method	2024-07-05 15:11:11 +09:00
Dean Herbert	554740af10	Adjust ducking API to use a parameters record	2024-07-05 15:04:40 +09:00
Dean Herbert	0d858ce8f8	Change default easings to In/Out for all ducking operations	2024-07-05 13:51:41 +09:00
Dean Herbert	ec4623d49f	Reduce duck length slightly on toolbar ruleset selector	2024-07-05 13:51:29 +09:00
Dean Herbert	4528daf7fa	Update resources	2024-07-05 13:15:15 +09:00
Dean Herbert	0696e2df32	Apply nullability to ducking methods	2024-07-05 12:58:34 +09:00
Dean Herbert	7f84e377ab	Merge branch 'music-controller-nullability' into audio-ducking-fx	2024-07-05 12:57:39 +09:00
Dean Herbert	d21eec9542	Apply nullability to MusicController	2024-07-05 12:50:15 +09:00
Dan Balasescu	aaef5c189d	Merge pull request #28739 from peppy/fix-skin-fallbacks ... Fix incorrect skin fallback order when beatmap skin is present	2024-07-05 12:05:57 +09:00
Dean Herbert	f201cc3fea	Expand explanation in inline comment	2024-07-05 10:09:06 +09:00
Dean Herbert	f0ad7a97cb	Merge branch 'master' into daily-challenge/better-results	2024-07-04 23:56:09 +09:00
Dean Herbert	aa72c09c3a	Merge pull request #28659 from bdach/daily-challenge/integration ... Use room watching functionality to receive realtime daily challenge updates	2024-07-04 23:55:46 +09:00
Bartłomiej Dach	c524c23db6	Merge branch 'master' into inherit-addition	2024-07-04 15:24:59 +02:00
Bartłomiej Dach	ea9dd841c0	Merge pull request #28728 from OliBomby/inherit-volume ... Always inherit the volume from the previous hit object on placement	2024-07-04 15:24:34 +02:00
Bartłomiej Dach	652d2e9633	Adjust code style	2024-07-04 15:19:36 +02:00
Bartłomiej Dach	8b4155fc0a	Merge branch 'inherit-addition' into nodesample-inherit	2024-07-04 15:13:20 +02:00
Bartłomiej Dach	faedf268ec	Merge branch 'inherit-volume' into inherit-addition	2024-07-04 14:52:05 +02:00
Bartłomiej Dach	72492a79cd	Reduce duplication in new logic	2024-07-04 14:45:46 +02:00
Bartłomiej Dach	5fa586848d	Replace old bad daily challenge leaderboard with new implementation ... - Actually shows scores rather than playlist aggregates (which are useful... in playlists, where there is more than one item) - Actually allows scores to be shown by clicking on them - Doesn't completely break down visually on smaller window sizes The general appearance is not as polished as the old one in details but I wanted something quick that we can get out by next weekend. Also includes the naive method of refetching scores once a new top 50 score is detected. I can add a stagger if required.	2024-07-04 13:52:08 +02:00
Bartłomiej Dach	8e8909c999	Adjust daily challenge screen background colour	2024-07-04 13:49:33 +02:00
Bartłomiej Dach	b29e535ca5	Add results screen for displaying arbitrary daily challenge scores ... At this point its primary usage is the daily challenge event feed, but the leaderboard will be using this too shortly. Because the playlists results screen that exists in `master` is hard-coupled to showing the *local user's* best result on a given playlist by way of hard-coupling itself to the relevant API request, allowing show of *arbitrary* score by ID requires a whole bunch of subclassery as things stand. Oh well. Class naming is... best effort, due to the above.	2024-07-04 13:45:24 +02:00
Dean Herbert	e3c8bee7d0	Fix nullability failure	2024-07-04 20:17:40 +09:00
Dean Herbert	b2af49c102	Fix classic fallback not having a transformer (and only add if required)	2024-07-04 20:17:39 +09:00
Salman Ahmed	207ee8a2ee	Fix editor not updating ruleset when switching difficulty	2024-07-04 14:06:36 +03:00
Jamie Taylor	a5077fcb3f	Rename TimedDuck -> DuckMomentarily	2024-07-04 17:22:33 +09:00
Dean Herbert	a4c575f77a	Merge pull request #28521 from bdach/tempo-adjust-editor ... Change editor speed adjustment back to adjusting tempo	2024-07-04 16:42:55 +09:00
Dean Herbert	3f138489a1	Merge pull request #28509 from bdach/slider-anchor-type-switching ... Add ability to cycle slider control point types via keyboard	2024-07-04 16:11:37 +09:00
Jamie Taylor	82e4e884d7	Change overlapping Duck() usages to be a noop instead of a throw	2024-07-04 15:51:50 +09:00
Jamie Taylor	753463fadb	Fix code style	2024-07-04 15:01:37 +09:00
Jamie Taylor	681398059e	Merge branch 'master' into audio-ducking-fx	2024-07-04 14:28:37 +09:00
Jamie Taylor	d948193757	Change Duck() to be IDisposable and prevent overlapping usages	2024-07-04 14:23:35 +09:00
Dean Herbert	73d71d3d77	Merge pull request #28705 from bdach/editor-test-play ... Reimplement missing gameplay test hotkeys from stable	2024-07-04 13:44:25 +09:00
Salman Ahmed	585e09981f	Allow scrollbar to overlap content ... The content is already padded enough to have the scrollbar sit on top. Having the content change padding when the scrollbar appears gives an unpleasent experience (especially when the scrollbar is hidden at first but the user increases the content's height by clicking on a dropdown or something)	2024-07-04 07:36:31 +03:00
Salman Ahmed	33711ba616	Remove scroll-dropdown-into-view logic	2024-07-04 07:34:19 +03:00
Salman Ahmed	8658389854	Clarify how the panel blocks input	2024-07-04 07:34:19 +03:00
Salman Ahmed	899c8d39fe	Merge branch 'master' into verify-title-markers	2024-07-04 07:07:59 +03:00
OliBomby	e754668daa	Always inherit the volume from the previous hit object	2024-07-04 01:09:06 +02:00
OliBomby	8f3a30b0b9	inherit addition bank from last hitobject	2024-07-04 00:56:53 +02:00
OliBomby	8dd04b6e9a	update nodesamples on placement	2024-07-04 00:39:12 +02:00
Bartłomiej Dach	00a0058fc7	Fix typo	2024-07-03 16:13:47 +02:00
Bartłomiej Dach	bcb479d4f7	Use one less regex	2024-07-03 16:13:30 +02:00
Bartłomiej Dach	5696e85b68	Adjust conditionals ... The fact that checking the unicode title was gated behind a `hasRomanisedTitle` guard was breaking my brain.	2024-07-03 15:52:05 +02:00
Bartłomiej Dach	32b3d3d7df	Compile regexes for speed	2024-07-03 15:49:21 +02:00
Bartłomiej Dach	901fec65ef	Address code quality issues	2024-07-03 15:49:17 +02:00
Dean Herbert	88375694a3	Merge branch 'master' into slider-anchor-type-switching	2024-07-03 22:36:57 +09:00
Bartłomiej Dach	0ab13e4486	Use alternative method of releasing user-pressed keys when activating autoplay	2024-07-03 14:37:07 +02:00
Bartłomiej Dach	e73faaefd2	Merge branch 'master' into editor-test-play	2024-07-03 13:54:47 +02:00
Dean Herbert	56cdd83451	Adjust padding and round corners of hover layer	2024-07-03 20:42:34 +09:00
Dean Herbert	5f56ed6872	Merge branch 'master' into navigate-to-timestamp	2024-07-03 20:42:32 +09:00
Bartłomiej Dach	17ce9cd162	Merge branch 'master' into grids-2	2024-07-03 10:57:05 +02:00
Bartłomiej Dach	84c7d34b77	Fix user-pressed keys remaining pressed whtn autoplay is turned on	2024-07-03 10:32:08 +02:00
Bartłomiej Dach	294aa09c41	Clear pressed keys and last replay frame when detaching replay from ruleset input manager	2024-07-03 10:19:59 +02:00
Bartłomiej Dach	29c3ff0677	Enable NRT in RulesetInputManager	2024-07-03 09:33:48 +02:00
Dean Herbert	824a00b018	Merge pull request #28707 from bdach/remove-breaks ... Add option to remove breaks via timeline context menu	2024-07-03 16:29:25 +09:00
Dan Balasescu	537e3a1642	Merge pull request #28619 from bdach/fix-tail-volume-not-saving ... Fix slider tail volume not saving	2024-07-03 16:13:18 +09:00
Dean Herbert	abfcac7466	Fix nullability	2024-07-03 15:31:46 +09:00
Dean Herbert	b6dc483fc1	Add missing change handler to ensure undo/redo works for break removal	2024-07-03 14:23:31 +09:00
Jamie Taylor	d29d114133	Match prior ducking behaviour	2024-07-03 13:52:20 +09:00
Jamie Taylor	b972632e4f	Change default easing to match prior behaviour	2024-07-03 13:50:35 +09:00
Jamie Taylor	153138cdac	Use null to disable audio filter instead	2024-07-03 13:47:59 +09:00
Salman Ahmed	f1012070c4	Merge branch 'master' into mod-select-customisation-panel	2024-07-03 07:36:52 +03:00
Salman Ahmed	cb350470e5	Merge branch 'master' into update-framework-has-flag	2024-07-03 07:06:13 +03:00
Arthur Araujo	7143ff523f	Make MarkerChecks and MarkerCheck class private	2024-07-02 21:09:49 -03:00
Arthur Araujo	7cdad20119	Fix explicit array type specification in MarkerChecks	2024-07-02 20:55:52 -03:00
Arthur Araujo	7cb3d7445c	Add verify checks for title markers	2024-07-02 17:20:00 -03:00
Dean Herbert	5350945340	Update HasFlag usages	2024-07-03 00:19:04 +09:00
Dean Herbert	9034f6186b	Update framework	2024-07-03 00:15:34 +09:00
Bartłomiej Dach	a7b066f3ee	Include node samples when changing additions and banks	2024-07-02 16:22:15 +02:00
Bartłomiej Dach	9414aec8bf	Add capability to remove breaks via context menu	2024-07-02 14:55:04 +02:00
Bartłomiej Dach	d85c467856	Implement quick exit hotkeys for editor test play	2024-07-02 14:34:36 +02:00
Bartłomiej Dach	e28befb98d	Implement quick pause toggle for editor test play	2024-07-02 14:34:35 +02:00
Bartłomiej Dach	1e4db77925	Implement autoplay toggle for editor test play ... Contains some hacks to fix weird behaviours like rewinding to the start on enabling autoplay, or gameplay cursor hiding.	2024-07-02 14:34:31 +02:00
Salman Ahmed	1d94c96a8e	Display customisation header in disabled state when no customisable mod selected	2024-07-02 14:40:16 +03:00
Bartłomiej Dach	d4a8f6c8b0	Do not add extra sample control point after end of IHasRepeats objects	2024-07-02 09:13:07 +02:00
Dan Balasescu	31edca866c	Remove unused code	2024-07-02 12:21:24 +09:00
Dan Balasescu	04da1209f7	Revert "Change breaks list to IReadOnlyList" ... This reverts commit 2c3b411bb5.	2024-07-02 12:16:11 +09:00
Dan Balasescu	db84711214	Revert "Move break cloning back to non-virtual method" ... This reverts commit f69bc40a4b.	2024-07-02 12:16:10 +09:00
Dean Herbert	f69bc40a4b	Move break cloning back to non-virtual method	2024-07-02 12:07:13 +09:00
Dean Herbert	2c3b411bb5	Change breaks list to IReadOnlyList	2024-07-02 11:59:24 +09:00
Dean Herbert	f694ae416e	Fix typo in xmldoc	2024-07-02 11:47:40 +09:00
Dean Herbert	005af280f2	Isolate bindable breaks list to EditorBeatmap	2024-07-02 11:31:55 +09:00
Dan Balasescu	f942595829	Fix ManiaModInvert permanently messing up the beatmap	2024-07-01 15:02:00 +09:00