recapitalverb
0a186fe722
Avoid calculating constants in load()
2020-02-02 22:37:58 +07:00
recapitalverb
bd3d7a285b
Merge branch 'adjust-profile-scores' of https://github.com/recapitalverb/osu into adjust-profile-scores
2020-02-02 21:39:04 +07:00
recapitalverb
aa13b605a4
Fix inconsistent local variable naming
2020-02-02 21:34:35 +07:00
recapitalverb
2a463e2893
Merge branch 'master' into adjust-profile-scores
2020-02-02 21:14:20 +07:00
recapitalverb
79efcbd6f3
Fix performance background width
2020-02-02 21:08:16 +07:00
recapitalverb
a641069ec2
Change profile score background colour
2020-02-02 21:07:23 +07:00
recapitalverb
122fd63ac4
Inline single-use constants
2020-02-02 21:05:20 +07:00
Dean Herbert
aa1daa0ad5
Merge pull request #7703 from bdach/beatmap-stats-precision
...
Apply precision when determining bar colour in difficulty statistics
2020-02-02 22:31:52 +09:00
recapitalverb
52aae68411
Adjust profile scores to closer match osu-web
2020-02-02 17:52:34 +07:00
Dean Herbert
ed48e3014c
Merge pull request #7709 from bdach/bindable-float-double
...
Remove all usages of Bindable<float> and Bindable<double>
2020-02-02 11:25:36 +09:00
Bartłomiej Dach
434c0d92e4
Use Bindable{Float,Double}s everywhere
...
To avoid further floating-point comparison bugs, remove all usages of
Bindable<{float,double}>, replacing them with their
Bindable<Float,Double> counterparts.
2020-02-01 22:50:29 +01:00
Bartłomiej Dach
e894acf53c
Make star filter range bindables BindableDoubles
...
Due to using Bindable<double>s previously, song select's filter control
would not apply tolerance when checking IsDefault, therefore wrongly
hiding maps with star ratings above 10.1.
2020-02-01 22:48:46 +01:00
Bartłomiej Dach
0bfadfbbf1
Apply precision when comparing adjusted values
...
In some cases, applying the Difficulty Adjust mod without actually
changing any of the settings previously caused the bar in song select
beatmap details to appear red/blue instead of staying white.
This was caused by not accounting for floating-point imprecisions when
determining bar colour in AdvancedStats. To resolve, first check
equality with tolerance, and only then apply blue/red colours if that
equality check does not hold.
2020-02-01 16:16:15 +01:00
Bartłomiej Dach
e90ae667b7
Add failing tests
2020-02-01 16:08:24 +01:00
Bartłomiej Dach
a74d22d9e5
Extract beatmap stats test to separate scene
2020-02-01 15:50:33 +01:00
Dean Herbert
c904ae485a
Make use of ElementAtOrDefault() when possible ( #7695 )
...
Make use of ElementAtOrDefault() when possible
2020-02-01 11:05:00 +09:00
Dean Herbert
5e834b64cd
Merge branch 'master' into use_ElementAtOrDefault
2020-02-01 10:42:40 +09:00
Berkan Diler
6d30e425a1
Revert change to avoid conflict with another PR
2020-01-31 18:51:29 +01:00
Dean Herbert
b7f4dd8dd4
Fix Alt+number shortcuts for tabs in chat overlay ( #7687 )
...
Fix Alt+number shortcuts for tabs in chat overlay
2020-02-01 02:51:18 +09:00
Berkan Diler
9596030e1d
Make use of ElementAtOrDefault() when possible
2020-01-31 18:32:47 +01:00
Dean Herbert
b3e63d8869
Merge branch 'master' into fix-chat-tab-shortcuts
2020-02-01 02:03:43 +09:00
Dan Balasescu
9a1df491cd
Merge pull request #7690 from peppy/exit-all-screens-centrally
...
Centralise screen exit logic to ScreenTestScene
2020-02-01 02:03:07 +09:00
Dean Herbert
e728d2be17
Use ElementAtOrDefault
2020-02-01 01:19:04 +09:00
Dean Herbert
0c305b96d1
Merge branch 'master' into fix-chat-tab-shortcuts
2020-01-31 22:22:04 +09:00
Dean Herbert
c4331f34d5
Consume TearDownSteps
2020-01-31 22:09:39 +09:00
Dean Herbert
f8aee122b6
Merge remote-tracking branch 'upstream/master' into exit-all-screens-centrally
2020-01-31 22:09:12 +09:00
Dean Herbert
3e15265a53
Update framework
2020-01-31 22:09:02 +09:00
Dean Herbert
a547d2ed5c
Don't least at Player just yet
2020-01-31 18:37:16 +09:00
Dean Herbert
2f61d3f5ad
Fix song select remaining issue locally
2020-01-31 17:35:53 +09:00
Dean Herbert
f736bbfccb
Merge pull request #7691 from peppy/fix-incorrect-nunit
...
Fix incorrect nUnit adapter version causing rider failures
2020-01-31 17:05:53 +09:00
Dean Herbert
ab7bbf38a8
Set default beatmap later in test initialisation
2020-01-31 16:14:55 +09:00
Dean Herbert
97c3ce132b
Fix incorrect nUnit adapter version causing rider failures
2020-01-31 15:01:37 +09:00
Dean Herbert
e6783b622d
Fix incorrectly build tests
2020-01-31 14:56:42 +09:00
Dean Herbert
5f48affcba
Centralise screen exit logic to ScreenTestScene
2020-01-31 14:19:29 +09:00
Dan Balasescu
d5b9df049b
Merge pull request #7683 from peppy/fix-chat-test-failure
...
Fix chat test intermittently failing
2020-01-31 10:56:04 +09:00
Bartłomiej Dach
1553444001
Fix channel tab keyboard shortcut
...
Filter out the selector tab item at the point of enumerating tabs to fix
the regression of the Alt+number key shortcut.
2020-01-30 21:44:53 +01:00
Bartłomiej Dach
fcd05b5a3c
Add failing test
2020-01-30 21:31:25 +01:00
Dean Herbert
40a4435792
Fix chat test intermittently failing
...
Was throwing exception instead of returning false due to LINQ Single() call.
2020-01-31 00:33:24 +09:00
Dean Herbert
8193991445
Merge pull request #7675 from smoogipoo/fix-possible-chat-crash
...
Fix possible crash when searching with no channel topic
2020-01-30 18:22:23 +09:00
Dean Herbert
947ee7a055
Merge pull request #7676 from peppy/fix-replay-initial-frames
...
Fix negative replay frames being played back incorrectly
2020-01-30 17:18:36 +09:00
Dan Balasescu
3fe84e0ddf
Merge branch 'master' into fix-replay-initial-frames
2020-01-30 16:56:37 +09:00
Dean Herbert
d03723303d
Fix typo in comment
2020-01-30 16:29:15 +09:00
Dan Balasescu
dfd0b1b88c
Merge pull request #7663 from peppy/fix-import-different-ruleset
...
Fix presenting a beatmap from a different ruleset not working
2020-01-30 15:36:25 +09:00
Dan Balasescu
7b403fd57a
Merge pull request #7673 from peppy/catch-relax-input-allowance
...
Fix osu!catch not handling all vertical space
2020-01-30 15:35:49 +09:00
Dan Balasescu
3604730027
Merge branch 'master' into fix-replay-initial-frames
2020-01-30 15:16:24 +09:00
Dan Balasescu
b57421247f
Merge branch 'master' into catch-relax-input-allowance
2020-01-30 15:16:16 +09:00
Dan Balasescu
09f6c57b0f
Merge branch 'master' into fix-import-different-ruleset
2020-01-30 15:08:25 +09:00
smoogipoo
2fb640f57f
Change to until step + fix CI error
2020-01-30 15:00:39 +09:00
Dean Herbert
7b4a658264
Fix negative replay frames being played back incorrectly
2020-01-30 14:54:57 +09:00
Dan Balasescu
fb51ffc169
Merge pull request #7667 from peppy/editor-match-accessibility
...
Fix editor being accessible for multiplayer song select
2020-01-30 14:38:30 +09:00
