Joseph Madamba
277f71d36a
Expire reply editor instead of clearing container
2023-02-07 15:15:51 -08:00
Dean Herbert
0320ba770f
Handle component changes via ISkinnableTarget.Components
rather than inside SkinEditor
directly
...
Seems saner? Maybe?
2023-02-07 16:23:25 +09:00
Dean Herbert
e162fd56da
Change the way initial state saving works in EditorChangeHandler
to be closer to first change
2023-02-07 16:22:51 +09:00
Dean Herbert
dad348111d
Fix holding a selection while changing screens causing a crash
2023-02-07 16:07:33 +09:00
Dean Herbert
71eef238c4
Make OnStateChange
non-implemented rather than wrong
2023-02-07 16:04:31 +09:00
tsrk
da10166628
quality: convert getter property to method so that sensible information can be hidden via an argument
2023-02-06 21:30:55 +00:00
tsrk
1baaae35a9
quality: Simplify string
2023-02-06 20:07:16 +00:00
Bartłomiej Dach
12f6d461b9
Merge pull request #22532 from peppy/fix-long-storyboard-outro
...
Fix storyboard outro time potentially running too long
2023-02-06 20:30:36 +01:00
Bartłomiej Dach
179db09075
Merge pull request #22531 from peppy/apply-future-rider-inspection
...
Apply single inspection from newer inspectcode versions
2023-02-06 20:05:49 +01:00
tsrk
bc89f8dc5b
feat: add name and rulset verb display support
2023-02-06 12:44:00 +00:00
Dean Herbert
aaf3ad805c
Fix potential nullref in tests
2023-02-06 19:31:45 +09:00
Dean Herbert
b83c8443ea
Ensure pause sample loop is stopped on exiting player
2023-02-06 18:24:31 +09:00
Dean Herbert
c691a0d3af
Merge branch 'master' into sheared_slider_implementation_clean_ii
2023-02-06 17:49:33 +09:00
Dean Herbert
c078d3a344
Merge pull request #22357 from EXtremeExploit/groups-probationary-badges
...
Make probationary groups a bit transparent
2023-02-06 17:43:57 +09:00
Dean Herbert
ddcc02fdfe
Merge pull request #22505 from Joehuu/fix-hover-click-sounds
...
Fix some clickable elements having no hover and click sounds
2023-02-06 16:52:19 +09:00
Dean Herbert
eabd1a0cc1
Remove unused Duration
property to avoid any misunderstandings
2023-02-06 16:42:39 +09:00
Dean Herbert
679ec986d5
Fix storyboard outro time potentially running too long
2023-02-06 16:39:44 +09:00
Dean Herbert
4c868372a2
Correctly handle anchor/origin changes as undo states
2023-02-06 15:05:05 +09:00
Dean Herbert
778b8a9bf7
Fix default settings not being serialised / state tracked correctly
2023-02-06 15:00:42 +09:00
Dean Herbert
7445814fc6
Handle changes to SettingSource
skin element settings
2023-02-06 14:42:59 +09:00
Dean Herbert
e5f62b0d2e
Remove public
access modifier from interface methods
2023-02-06 14:19:25 +09:00
Dean Herbert
e4b17588f5
Add missing xmldoc to new methods in EditorChangeHandler
2023-02-06 14:11:40 +09:00
Dean Herbert
701d21c26f
Apply single inspection from newer inspectcode verisons
...
As found in rider EAPs. Appears as a warning and is annoying me
occasionally.
2023-02-06 13:52:27 +09:00
Dean Herbert
10ab4d572a
Merge branch 'master' into skin-editor-undo-support
2023-02-06 13:46:50 +09:00
tsrk
b3f38b0f4c
quality: remove redundant Status
override
2023-02-06 00:56:11 +00:00
tsrk
bf273597ea
feat: actually support status also for Replays
2023-02-06 00:41:10 +00:00
tsrk
d5b2d9ce97
feat: add support for spectating status
2023-02-05 23:58:08 +00:00
Joseph Madamba
cb8458cceb
Use linq and alpha instead
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2023-02-04 20:11:29 -08:00
Joseph Madamba
191259c050
Use equals instead and update other usage
2023-02-04 19:58:48 -08:00
Bartłomiej Dach
ef900bccdf
Merge branch 'master' into BPM_counter_fix
2023-02-04 23:44:58 +01:00
Bartłomiej Dach
cb7540564a
Merge pull request #22504 from peppy/fix-editor-positional-nudge-undo
...
Fix beatmap editor positional nudging not being undoable
2023-02-04 15:52:34 +01:00
Joseph Madamba
4192388b20
Fix expanded beatmap cards getting cut off at the end of profile sections
2023-02-03 21:29:01 -08:00
mk56-spn
88872cf1cf
Use ``GetTrueGameplayRate()
`` to remove need for jank
2023-02-04 00:53:54 +01:00
mk56-spn
d9bee958dd
Stop ``BPMCounter.cs
``'s value from going to 0 after failing.
2023-02-03 23:56:34 +01:00
Bartłomiej Dach
97afb83394
Merge branch 'master' into carousel
2023-02-03 22:15:44 +01:00
Bartłomiej Dach
63f7d326c2
Merge branch 'master' into fix-editor-positional-nudge-undo
2023-02-03 21:31:05 +01:00
Bartłomiej Dach
4bd43171e8
Merge branch 'master' into fix-skin-editor-padding-weirdness
2023-02-03 20:28:47 +01:00
Bartłomiej Dach
b2a5cf9f2d
Merge branch 'master' into triangles-old-texel
2023-02-03 19:43:34 +01:00
Bartłomiej Dach
59656a7286
Merge branch 'master' into skin-editor-dont-show-save-on-no-change
2023-02-03 19:08:33 +01:00
EXtremeExploit
f9809c9481
the comment
2023-02-03 11:48:11 -03:00
mk56-spn
e1af5e110a
Remove ``RoundedNub.cs
` and make
`Nub.cs
`` non abstract again
2023-02-03 12:19:09 +01:00
mk56-spn
8c11e8e6f4
Extract ShearedNub.cs implementation into its own entirely independent implementation
2023-02-03 11:58:10 +01:00
Joseph Madamba
461b5c5375
Fix comment cancel button not behaving the same as reply text toggle
...
- Removed the fading animation as it is awkward right now (needs resizing)
2023-02-03 02:04:19 -08:00
Dean Herbert
2cda277c09
Add a basic change handler to the skin editor
2023-02-03 18:57:50 +09:00
Dean Herbert
2f30306ea2
Expose a method to reload a SkinnableTargetContainer
from provided info
2023-02-03 18:53:09 +09:00
Dean Herbert
3345e34544
Move beatmap specific logic out of EditorChangeHandler
2023-02-03 17:53:54 +09:00
Joseph Madamba
94d2799b90
Fix comments having too much padding at the bottom
2023-02-03 00:47:10 -08:00
Joseph Madamba
5a76c1ab9c
Refactor HoverSampleDebounceComponent
to inherit Component
2023-02-03 00:29:25 -08:00
Dean Herbert
b437501b0f
Fix beatmap editor positional nudging not being undoable
2023-02-03 17:28:58 +09:00
Dean Herbert
554f14151c
Apply NRT to EditorChangeHandler
2023-02-03 17:13:24 +09:00
Dean Herbert
b19047b90b
Fix skin editor component list having uneven padding
2023-02-03 16:55:51 +09:00
Joseph Madamba
f27bf3ca20
Fix click sounds potentially not working
2023-02-02 23:54:57 -08:00
Joseph Madamba
77569058cb
Alternatively fix hover sounds playing out of clicking bounds
2023-02-02 23:45:54 -08:00
Dean Herbert
60ccf35125
Update resources
2023-02-03 16:44:53 +09:00
Joseph Madamba
6135db6bd7
Revert moving hover sounds to content container
2023-02-02 23:43:08 -08:00
Dean Herbert
7b9239088b
Comment space addition
2023-02-03 16:40:16 +09:00
Andrei Zavatski
14524237ac
Add comment explaining texelSize value
2023-02-03 10:32:41 +03:00
Dean Herbert
92306b9123
Combine localisations for abstract skinnable components into a single file
...
Generally we don't want localisation files with only one to two
translations. It makes it harder for translators to handle in crowdin (a
lot of file changes for small results).
So for cases like this I believe we should be grouping translations
where it makes sense.
I've left individual components in their own files as I can see
potential for more settings to be added in the future. Plus it gives a
bit of extra context.
2023-02-03 16:02:18 +09:00
Dean Herbert
cf8cfe0d2c
Move skin component localisations to namespaces
2023-02-03 15:34:57 +09:00
Dean Herbert
50559643bb
Fix incorrectly applied enum localisation
2023-02-03 15:27:11 +09:00
Dean Herbert
32207dc9dd
Merge branch 'master' into locale/skin-editor-components
2023-02-03 15:24:00 +09:00
Dean Herbert
5ca5f04794
Add parameter hint for optional bool
value
2023-02-03 15:18:40 +09:00
Dean Herbert
9c954a93e3
Update Save
method xmldoc to make more sense
2023-02-03 15:18:01 +09:00
Dean Herbert
f7094567d7
Rename and document method to limit scope
2023-02-03 15:04:47 +09:00
Bartłomiej Dach
1af898160c
Merge branch 'master' into delete-on-import-android
2023-02-02 21:40:52 +01:00
Bartłomiej Dach
e937022b09
Merge branch 'master' into middle-click-replay-pause
2023-02-02 20:52:03 +01:00
Bartłomiej Dach
4d46a8f32d
Merge branch 'master' into skin-editor-dont-show-save-on-no-change
2023-02-02 19:36:23 +01:00
Bartłomiej Dach
f7fa9e3927
Remove outdated comment
2023-02-02 18:41:35 +01:00
Bartłomiej Dach
779c58f9c1
Merge branch 'master' into skin-editor-ux-impovements
2023-02-02 18:16:18 +01:00
Bartłomiej Dach
6c0aada86a
Merge pull request #22490 from peppy/skin-overlay-namespace
...
Move skin editor to overlays namespace
2023-02-02 18:14:16 +01:00
mk56-spn
3f0ce75bf5
Rename NormalSliderBar.cs to RoundedSliderBar.cs
2023-02-02 17:24:45 +01:00
mk56-spn
7c5a65bdb7
Rename NormalNub.cs to RoundedNub.cs
2023-02-02 17:23:09 +01:00
Dean Herbert
015f4f2b38
Avoid showing skin save message when changing scenes after making no changes
2023-02-02 18:42:37 +09:00
Dean Herbert
9b6d95b3d6
Adjust skin editor pop in/out to be more snappy
2023-02-02 18:33:45 +09:00
Dean Herbert
26efb8e842
Replace white box legacy placeholder with something that visually fits
2023-02-02 18:33:31 +09:00
tsrk
843d9914c4
quality: remove new line
2023-02-02 08:18:56 +00:00
Dean Herbert
659b78058f
Move replay specific key bindings to their own section
2023-02-02 15:25:52 +09:00
Dean Herbert
edecd2ee25
Merge branch 'master' into middle-click-replay-pause
2023-02-02 15:25:51 +09:00
Dean Herbert
b792dc3af0
Merge pull request #22281 from cdwcgt/editor-check-previewtime
...
Add preview time setting check
2023-02-02 15:10:06 +09:00
Dean Herbert
48ef25cbe5
Merge pull request #22421 from EXtremeExploit/misses-animation
...
Add movement to legacy misses in osu ruleset
2023-02-02 15:00:57 +09:00
Dean Herbert
91fbf388da
Use localisation strings from ButtonSystem
for better consistency
2023-02-02 15:00:24 +09:00
Dean Herbert
500e9c7944
Refactor into a method rather than property
2023-02-02 14:53:58 +09:00
Dean Herbert
942e7729f3
Merge branch 'master' into carousel
2023-02-02 14:41:55 +09:00
Dean Herbert
5b3d7a8f26
Fix typo in missing-preview-point message
2023-02-02 14:34:59 +09:00
Andrei Zavatski
175b9fc5c9
Specify texelSize value in the Triangles background
2023-02-02 08:34:38 +03:00
Dean Herbert
c2cde8361a
Fix message not reading well
2023-02-02 14:33:41 +09:00
Dean Herbert
3a861fd943
Remove multiple cases of excess braces
2023-02-02 14:28:21 +09:00
Dean Herbert
50659f3d52
Merge pull request #22428 from EVAST9919/triangles-new-masking
...
Implement Masking property for `TrianglesV2` background
2023-02-02 14:22:16 +09:00
Dean Herbert
229fb518dc
Apply NRT to LegacyJudgementPieceOld
2023-02-02 14:19:00 +09:00
Dean Herbert
183d1c5bd6
Change version comparison to match other existing code as proposed in review
2023-02-02 14:18:49 +09:00
Dean Herbert
263a7e2766
Merge branch 'master' into misses-animation
2023-02-02 14:08:15 +09:00
Dean Herbert
8dc2e6872e
Move skin editor to overlays namespace
2023-02-02 14:00:31 +09:00
Dean Herbert
10df64467a
Merge pull request #22430 from peppy/skin-editor-nrt
...
Apply NRT to all skin editor classes
2023-02-02 13:57:57 +09:00
tsrk
0fb6a63709
refactor: change namespacing to allow osu-localisation-analyzer to process all strings
2023-02-02 00:46:14 +00:00
Ruki
89a30d87c7
Merge branch 'ppy:master' into locale/skin-editor-components
2023-02-02 00:02:14 +00:00
tsrk
ddfa95e6ef
refactor: fix typos
2023-02-02 00:01:48 +00:00
tsrk
8645e705fd
feat: add localisation for Skin editor components
2023-02-01 23:48:05 +00:00
Bartłomiej Dach
292016d31e
Merge pull request #22483 from peppy/test-output-gameplay-time
...
Output gameplay clock progress in `PlayerTestScene`s
2023-02-01 22:55:10 +01:00
Dean Herbert
a77baf8717
Output gameplay clock progress in PlayerTestScene
s
2023-02-01 23:42:44 +09:00
Dean Herbert
d54db8de64
Merge branch 'master' into fix-clicking-metadata-relevance-sort
2023-02-01 19:39:13 +09:00