Dean Herbert 1016bca280 Keep any stateful dropdown menu open on click (#37021) ...

Right click is a very obfuscated UX which most users won't find. This
makes more sense to the average user (probably).

Caveat: clicking away actually sends clicks to underlying UI. This is
not the case in macOS or windows (locally, same app; globally it still
sends clicks to other windows).

Coming from https://github.com/ppy/osu/discussions/36926.

---------

Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

1016bca280 · 2026-03-21 22:18:02 +09:00

History

..

OsuPlayerTestScene.cs

Automated pass

2023-06-24 01:00:03 +09:00

SkinnableHUDComponentTestScene.cs

Refactor performance points test scene to support skinning

2024-03-05 03:34:25 +03:00

TestSceneAllRulesetPlayers.cs

Fix crash when loading player instance without exiting previous instance

2023-09-19 05:09:01 +03:00

TestSceneArgonHealthDisplay.cs

Fix intermitent test failure in TestSceneArgonHealthDisplay

2024-07-18 01:20:50 +03:00

TestSceneArgonJudgementCounter.cs

Demonstrate failure in test

2025-09-13 10:50:33 +09:00

TestSceneAutoplay.cs

Fix more nullable inspections

2024-01-29 08:44:27 +01:00

TestSceneBeatmapMetadataDisplay.cs

Remove all song select v1 files

2026-03-03 16:45:14 +09:00

TestSceneBeatmapOffsetControl.cs

Add failing test case

2025-08-14 13:47:58 +03:00

TestSceneBeatmapSkinFallbacks.cs

Component -> Lookup

2024-08-23 14:48:50 +09:00

TestSceneBezierConverter.cs

Fix code style/quality issues

2023-11-13 08:25:27 +01:00

TestSceneBreakTracker.cs

Fix LetterboxOverlay not handling its own visibility

2025-03-12 17:46:18 +09:00

TestSceneClicksPerSecondCalculator.cs

Fix rider EAP new naming inspections

2025-05-25 20:39:55 +09:00

TestSceneColourHitErrorMeter.cs

Partial everything

2022-11-27 00:00:27 +09:00

TestSceneCompletionCancellation.cs

Add flag to allow backwards seeks in tests

2024-02-29 23:05:28 +08:00

TestSceneDefaultSongProgressGraph.cs

Prefix subclasses of DefaultSongProgress with Default

2023-01-18 15:45:16 +09:00

TestSceneDelayedResumeOverlay.cs

Add countdown display

2024-03-04 16:50:24 +09:00

TestSceneDrawableGameplayLeaderboardScore.cs

Move leaderboards classes to gameplay namespace for now

2026-03-03 16:45:13 +09:00

TestSceneDrawableScrollingRuleset.cs

Fix test value getting clobbered due to stupid stuff

2023-12-06 15:59:29 +09:00

TestSceneDrawableStoryboardSprite.cs

Fix a few flaky tests

2026-03-07 23:19:13 +09:00

TestSceneFailAnimation.cs

Automated pass

2023-06-24 01:00:03 +09:00

TestSceneFailingLayer.cs

Fix failing test by setting health on source of truth

2024-01-10 23:09:43 +09:00

TestSceneFailJudgement.cs

Automated pass

2023-06-24 01:00:03 +09:00

TestSceneFrameStabilityContainer.cs

Ignore more potentially incorrect data from BASS

2025-08-14 19:20:30 +09:00

TestSceneGameplayLeaderboard.cs

Move leaderboards classes to gameplay namespace for now

2026-03-03 16:45:13 +09:00

TestSceneGameplayMenuOverlay.cs

Apply NRT to touched files

2024-02-27 23:58:28 -08:00

TestSceneGameplayRewinding.cs

Rename {KeyCounter -> InputCount}Controller

2023-06-26 19:27:42 +02:00

TestSceneGameplaySamplePlayback.cs

Fix flaky TestSceneGameplaySamplePlayback test

2025-06-29 00:24:12 +09:00

TestSceneGameplaySampleTriggerSource.cs

Refactor hit windows class structure to reduce rigidity

2025-06-25 08:40:12 +02:00

TestSceneHitErrorMeter.cs

Ignore more potentially incorrect data from BASS

2025-08-14 19:20:30 +09:00

TestSceneHoldForMenuButton.cs

Update test coverage

2024-08-20 01:13:00 +09:00

TestSceneHUDOverlay.cs

Remove HoldForMenuButton player dependency

2026-01-06 17:20:28 +09:00

TestSceneHUDOverlayRulesetLayouts.cs

Move leaderboards classes to gameplay namespace for now

2026-03-03 16:45:13 +09:00

TestSceneJudgementContainer.cs

Fix code inspection

2024-07-16 11:31:16 +02:00

TestSceneJudgementCounter.cs

De-dupe displayed hits in judgement counter

2024-01-15 16:02:59 +09:00

TestSceneKeyBindings.cs

Partial everything

2022-11-27 00:00:27 +09:00

TestSceneKeyCounter.cs

Add visual test seane

2024-07-24 12:24:58 +08:00

TestSceneLeadIn.cs

Merge branch 'master' into beatmap-info-purge

2024-09-15 04:53:35 +09:00

TestSceneMedalOverlay.cs

Fix yet another failure

2024-02-20 18:42:01 +01:00

TestSceneModValidity.cs

Partial everything

2022-11-27 00:00:27 +09:00

TestSceneNightcoreBeatContainer.cs

Automated pass

2023-06-24 01:00:03 +09:00

TestSceneOverlayActivation.cs

Adjust ILocalUserPlayInfo to expose whether gameplay is in a paused/break state

2024-10-01 17:53:46 +09:00

TestSceneParticleExplosion.cs

Partial everything

2022-11-27 00:00:27 +09:00

TestSceneParticleSpewer.cs

Fix regression in time jumping behaviour

2023-07-19 13:38:04 +09:00

TestScenePause.cs

Remove failing test

2025-08-15 10:01:10 +02:00

TestScenePauseInputHandling.cs

Merge pull request #29500 from frenzibyte/fix-pausing-for-the-millionth-time

2024-08-27 10:04:47 +02:00

TestScenePauseWhenInactive.cs

Partial everything

2022-11-27 00:00:27 +09:00

TestScenePerformancePointsCounter.cs

Implement "legacy" pp counter

2025-08-27 11:07:53 +08:00

TestScenePlayerLoader.cs

Add failing test

2025-08-14 14:18:25 +02:00

TestScenePlayerLocalScoreImport.cs

Fix test scene leaks through RealmRulesetStore/RealmAccess

2025-10-09 15:28:15 +09:00

TestScenePlayerMaxDimensions.cs

Update ImageSharp usages

2024-03-06 12:13:12 +08:00

TestScenePlayerReferenceLeaking.cs

Partial everything

2022-11-27 00:00:27 +09:00

TestScenePlayerScoreSubmission.cs

Add failing test coverage for no score submission attempt on known locally modified beatmap

2025-10-02 09:16:17 +02:00

TestScenePoolingRuleset.cs

Ignore more potentially incorrect data from BASS

2025-08-14 19:20:30 +09:00

TestSceneReplay.cs

Rename {KeyCounter -> InputCount}Controller

2023-06-26 19:27:42 +02:00

TestSceneReplayDownloadButton.cs

Add test case against resetting score in download button

2024-07-26 05:08:13 +03:00

TestSceneReplayPlayer.cs

Add test coverage and fix one more fail case

2025-08-26 18:41:14 +09:00

TestSceneReplayRecorder.cs

Fix replays being misrecorded if an action is pressed and released in one update frame

2025-06-06 09:10:51 +02:00

TestSceneScrollingHitObjects.cs

Partial everything

2022-11-27 00:00:27 +09:00

TestSceneSkinEditor.cs

Keep any stateful dropdown menu open on click (#37021)

2026-03-21 22:18:02 +09:00

TestSceneSkinEditorComponentsList.cs

Move GlobalSkinnableContainers to global scope

2024-08-22 18:46:07 +09:00

TestSceneSkinEditorMultipleSkins.cs

Move leaderboards classes to gameplay namespace for now

2026-03-03 16:45:13 +09:00

TestSceneSkinnableAccuracyCounter.cs

Refactor performance points test scene to support skinning

2024-03-05 03:34:25 +03:00

TestSceneSkinnableComboCounter.cs

Abstractify LegacyComboCounter to re-use for mania

2023-12-30 05:29:22 +03:00

TestSceneSkinnableDrawable.cs

Revert "Update GetTexture signature rather than creating new overload"

2023-09-19 03:21:19 +03:00

TestSceneSkinnableHealthDisplay.cs

Refactor performance points test scene to support skinning

2024-03-05 03:34:25 +03:00

TestSceneSkinnableHUDOverlay.cs

Move leaderboards classes to gameplay namespace for now

2026-03-03 16:45:13 +09:00

TestSceneSkinnableKeyCounter.cs

Add a keycounter that has been actually used in Triangles skin (#35491)

2025-10-29 12:18:00 +09:00

TestSceneSkinnableRankDisplay.cs

Fix test not compiling

2024-06-07 09:54:00 +02:00

TestSceneSkinnableScoreCounter.cs

Add "Argon" total score counter

2023-10-26 08:58:25 +03:00

TestSceneSkinnableSound.cs

Fix TestSceneSkinnableSound failing

2024-03-09 21:55:00 +03:00

TestSceneSkipOverlay.cs

Add simple multiplayer skip overlay

2025-10-31 21:39:41 +09:00

TestSceneSliderPath.cs

Fix code style/quality issues

2023-11-13 08:25:27 +01:00

TestSceneSoloGameplayLeaderboardProvider.cs

Move leaderboards classes to gameplay namespace for now

2026-03-03 16:45:13 +09:00

TestSceneSongProgress.cs

Add a fake load to visual test to restore previous testing behaviour

2024-01-18 14:01:37 +09:00

TestSceneSpectator.cs

Update lots of packages (#36996)

2026-03-17 03:58:02 +09:00

TestSceneSpectatorHost.cs

Automated pass

2023-06-24 01:00:03 +09:00

TestSceneSpectatorList.cs

Disable user customisation of spectator list font / colour

2025-03-10 15:19:34 +09:00

TestSceneSpectatorPlayback.cs

Fix replays being misrecorded if an action is pressed and released in one update frame

2025-06-06 09:10:51 +02:00

TestSceneStarCounter.cs

Add twenty star counter in visual test

2024-02-16 22:47:38 -08:00

TestSceneStoryboard.cs

Add failing test coverage

2025-04-18 14:21:50 +02:00

TestSceneStoryboardCommands.cs

Add enough test coverage

2024-03-10 09:01:40 +03:00

TestSceneStoryboardSamplePlayback.cs

Add an extra storyboard sample to avoid intermittent failures in TestStoryboardSamplesStopOnSkip

2023-10-31 14:28:40 +09:00

TestSceneStoryboardWithIntro.cs

Resolve post-merge-conflict issues

2024-05-01 23:57:58 +03:00

TestSceneStoryboardWithOutro.cs

Refactor to avoid dual-boolean mess

2024-11-14 22:10:45 +09:00

TestSceneUnknownMod.cs

Fix TestSceneUnknownMod failing due to null reference

2023-07-25 19:06:13 +09:00

TestSceneUnorderedBreaks.cs

Add failing test case

2024-07-08 16:06:34 +03:00

TestSceneUnstableRateCounter.cs

Fix test scene doing very weird things for (seemingly) no reason

2025-08-12 13:21:16 +02:00

TestSceneUserTopScoreContainer.cs

Remove all song select v1 files

2026-03-03 16:45:14 +09:00