Dean Herbert
7fda38d0b0
Use ordinal comparison when searching at song select
...
Bypasses various overheads. In theory should be fine? (until it's not on some language)
2023-12-05 14:14:13 +09:00
Dan Balasescu
b90de83f33
Replicate integer calculations for tiny tick conversion
2023-12-05 11:58:00 +09:00
Andrei Zavatski
68907fe1ba
Cleanup pass
2023-12-05 02:48:11 +03:00
Guido
8756dd25c6
Changed file chooser in resource selection to show file name when file is selected
2023-12-04 22:51:56 +01:00
Salman Ahmed
629e64d50a
Fix ArgonHealthDisplay not displaying miss correctly during initial transition
2023-12-04 23:55:31 +03:00
Salman Ahmed
4d82a55594
Remove method for being unused
2023-12-04 23:24:28 +03:00
Salman Ahmed
5723715ea0
Fix ArgonHealthDisplay sometimes behaving weirdly on miss judgements
2023-12-04 23:24:28 +03:00
Bartłomiej Dach
1292c322c0
Merge pull request #25671 from Susko3/uncomment-net6.0-code
...
Uncomment net6.0 code and remove old code in `BeatmapListingOverlay`
2023-12-04 21:06:54 +01:00
Salman Ahmed
17577a6606
Add visual test case for late miss in argon health display
2023-12-04 23:01:11 +03:00
Susko3
0e47492858
Uncomment net6.0 code and remove old code
2023-12-04 20:17:22 +01:00
Bartłomiej Dach
f0364f01ea
Merge pull request #25665 from bdach/skin-editor-breakage
...
Fix several edge cases in skin editor gameplay scene opening flow
2023-12-04 16:48:41 +01:00
Dean Herbert
c5a08a0711
Remove unused using statement
2023-12-04 23:06:08 +09:00
Bartłomiej Dach
5512298d60
Trim unused resolved bindable
2023-12-04 15:01:23 +01:00
Bartłomiej Dach
8754fa40f4
Source autoplay mod from beatmap about to be presented rather than ambient global
2023-12-04 14:42:51 +01:00
Bartłomiej Dach
063694f544
Do not attempt to load gameplay scene if current beatmap is dummy
2023-12-04 14:42:51 +01:00
Bartłomiej Dach
9d39b70e38
Fix endless player not handling load failure
2023-12-04 14:42:51 +01:00
Bartłomiej Dach
055fb5bd8f
Do not set initial activity in skin editor endless player
...
Seems like an overreach to say that the user is "watching a replay"
there.
2023-12-04 14:42:51 +01:00
Bartłomiej Dach
43312619e3
Add test coverage for crashing on wrong ruleset
2023-12-04 14:42:51 +01:00
Bartłomiej Dach
7c041df0f1
Add test coverage for crashing on dummy beatmap
2023-12-04 14:42:42 +01:00
Bartłomiej Dach
d3e94cd5bf
Add test coverage for crashing on empty beatmap
2023-12-04 14:42:40 +01:00
Bartłomiej Dach
7deff70b4a
Extract beatmap import steps from gameplay scene switch helper
2023-12-04 13:34:36 +01:00
Bartłomiej Dach
fcb6f40666
Prioritise hyperfruit over non-hyperfruit if simultaneous
...
In case of simultaneous hyperfruit and non-hyperfruit - which happen to
occur on some aspire maps - the desired behaviour is to hyperdash. This
did not previously occur, due to annoying details in how
`HitObjectContainer` is structured.
`HitObjectContainer`'s drawable comparer determines the order of
updating the objects. One could say that forcing the hyperfruit to be
updated last, after normal fruit, could help; unfortunately this is
complicated by the existence of juice streams and the fact that while a
juice stream can be terminated by a normal fruit that is coincidental
with a hyperfruit, the two are not comparable directly using the
comparer in any feasible way.
Therefore, apply a `Catcher`-level workaround that intends to handle
this locally; in short, if a hyperdash was toggled in a given frame, it
cannot be toggled off again in the same frame. This yields the desired
behaviour.
2023-12-04 09:30:18 +01:00
Bartłomiej Dach
bb198e0c5a
Add test coverage for missing hyperdashes on simultaneous notes
2023-12-04 09:26:23 +01:00
Bartłomiej Dach
0652ea316d
Merge branch 'master' into catch-hyperdash-stable-sort
2023-12-04 09:05:42 +01:00
Andrei Zavatski
ec5c7d7830
Add deceleration and rework depth handling
2023-12-04 10:26:43 +03:00
Dan Balasescu
6f73d78bc9
Replicate integer calculations for catch hyperdash generation
2023-12-04 14:32:14 +09:00
Dan Balasescu
c755bcbec4
Add failing test
2023-12-04 14:30:08 +09:00
Dean Herbert
36b1369a4e
Merge pull request #25636 from Susko3/fix-older-android-storage
...
Request `READ_EXTERNAL_STORAGE` on older android versions
2023-12-04 12:11:08 +09:00
Dean Herbert
c2a4a6d8cb
Add inline comment matching framework
2023-12-04 12:10:31 +09:00
Dean Herbert
e06d5f5875
Merge pull request #25649 from smoogipoo/remove-mania-drain-again
...
Once again remove Mania passive HP drain
2023-12-04 12:03:32 +09:00
Dan Balasescu
8587652869
Fix countdown button being enabled
2023-12-04 11:00:11 +09:00
Dan Balasescu
9ccd33a1ec
Add comments to test
2023-12-04 10:20:53 +09:00
Dan Balasescu
c2644a5d5e
Correctly implement button enabled state
2023-12-04 10:18:37 +09:00
Dan Balasescu
b56a78c6ec
Adjust with framework changes
2023-12-04 08:51:21 +09:00
OliBomby
13b7f2fa42
Fix test cases
2023-12-03 22:42:48 +01:00
Dan Balasescu
d0acb7f4f9
Improve commenting
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2023-12-04 06:08:31 +09:00
OliBomby
060141866c
Update SliderPlacementBlueprint.cs
2023-12-03 22:06:07 +01:00
OliBomby
b3d1a9ee2e
Dont snap expected distance while drawing
...
This makes it 10 billion times smoother to draw, very nice
2023-12-03 22:03:51 +01:00
OliBomby
ca55a7b2bf
call builder finish before ending curve
2023-12-03 21:43:37 +01:00
OliBomby
bcf2effae9
Remove the Linear segment simplification because it just makes things harder to edit afterwards if it made some segment linear type when you actually intended there to be some curve
2023-12-03 21:22:04 +01:00
OliBomby
34b5264616
fix the linear segment
2023-12-03 21:13:27 +01:00
OliBomby
ba2cc0243c
update comment
2023-12-03 21:10:01 +01:00
OliBomby
8873824107
fix control points being cleared
2023-12-03 20:53:25 +01:00
OliBomby
4cd6efc8f7
update default parameters
2023-12-03 20:53:05 +01:00
OliBomby
595bc9398a
update to new builder control point signature
2023-12-03 20:14:00 +01:00
Andrei Zavatski
b90000f7b7
Simplify objects depth calculation
2023-12-03 17:15:52 +03:00
Andrei Zavatski
ebcde63caa
Don't override hitobjects anchor
2023-12-03 17:13:47 +03:00
Andrei Zavatski
937689ee6b
Add OsuModDepth as incompatable to other mods
2023-12-03 05:39:44 +03:00
Andrei Zavatski
cf6e50f73c
Add header and fix typo
2023-12-03 05:07:40 +03:00
Andrei Zavatski
dc588e6d56
Implement OsuModDepth
2023-12-03 04:58:17 +03:00
