63079 Commits

This Branch

This Branch

All Branches

• Merge branch 'master' into pitch_change
  Dean Herbert · 2023-10-18 16:33:03 +09:00
  eabfcfbf2a
• Merge pull request #25163 from Joehuu/double-click-slider-nub-default

  Add ability to revert slider settings to default when double-clicking nub

  Dean Herbert · 2023-10-18 16:23:05 +09:00
  bf4aa3c118
• Add ability to revert slider settings to default when double-clicking nub
  Joseph Madamba · 2023-10-17 21:41:03 -07:00
  18e8ca6245
• Add slider nub double click revert to default test
  Joseph Madamba · 2023-10-17 21:41:03 -07:00
  1a3a81c33b
• Merge pull request #25155 from peppy/fix-new-inspections

  Fix various new rider EAP inspections

  Bartłomiej Dach · 2023-10-17 17:04:39 +02:00
  e927267c4d
• Merge pull request #25152 from bdach/key-binding-deduplication

  Clear pre-existing bindings of same key combination to single action

  Dean Herbert · 2023-10-17 17:49:51 +09:00
  d9fc532a9f
• Fix various other inspections
  Dean Herbert · 2023-10-17 17:48:51 +09:00
  e081fa48a2
• Bypass Parent nullability checks for now
  Dean Herbert · 2023-10-17 17:48:45 +09:00
  5341a335a6
• Merge pull request #25153 from peppy/store-speed-change-config

  Persist the state of "show speed changes" between editor sessions

  Bartłomiej Dach · 2023-10-17 10:23:00 +02:00
  5833c20be5
• Merge branch 'master' into key-binding-deduplication
  Dean Herbert · 2023-10-17 17:17:44 +09:00
  4885c55ef0
• Add backwards migration of catch dash binding
  Bartłomiej Dach · 2023-10-17 09:43:40 +02:00
  4cfc95c673
• Use left mouse as alternative default binding for catch dash

  This mirrors stable. Although the way stable does this is pretty dodgy,
  see:
  	https://github.com/peppy/osu-stable-reference/blob/master/osu!/GameModes/Play/Rulesets/Fruits/RulesetFruits.cs#L274-L275

  Bartłomiej Dach · 2023-10-17 09:31:29 +02:00
  79a4b985fe
• Persist the state of "show speed changes" between editor sessions

  Addresses https://github.com/ppy/osu/discussions/25149.

  Dean Herbert · 2023-10-17 16:01:02 +09:00
  165cd07428
• Merge pull request #25111 from peppy/mania-bonus-refactor

  Change osu!mania "perfect" judgements to only award bonus score

  Dan Balasescu · 2023-10-17 14:27:54 +09:00
  6f4a2b9889
• Merge branch 'master' into mania-bonus-refactor
  Dan Balasescu · 2023-10-17 13:28:04 +09:00
  d2a3f14d5b
• Merge pull request #25143 from peppy/split-spinner-fix

  Apply various fixes and cleanup to spinner logic

  Bartłomiej Dach · 2023-10-16 22:30:24 +02:00
  240d317928
• Fix bindings being cleared if multiple bindings for same action have the same combination

  This actually seems to be the case in catch (dash is bound to shift
  twice). This is annoying but harmless, so let's work around it for now
  to avoid ruining users' configs.

  Bartłomiej Dach · 2023-10-16 22:20:26 +02:00
  828cedea33
• Add failing case for two bindings of single action bound to same key
  Bartłomiej Dach · 2023-10-16 22:20:26 +02:00
  3aae07d1ca
• Add migration to remove duplicate bindings
  Bartłomiej Dach · 2023-10-16 22:20:26 +02:00
  9c6166ec3d
• Prevent ruleset input managers from reading duplicate bindings
  Bartłomiej Dach · 2023-10-16 21:02:24 +02:00
  639c96e60c
• Implement method to deduplicate keybindings
  Bartłomiej Dach · 2023-10-16 20:51:57 +02:00
  90c44cee54
• Add stub of method to deduplicate bindings (and failing test)
  Bartłomiej Dach · 2023-10-16 20:48:52 +02:00
  79273b88f6
• Merge branch 'master' into split-spinner-fix
  Bartłomiej Dach · 2023-10-16 18:59:08 +02:00
  f14928cdfb
• Fix potential frame misordering in generator
  Dan Balasescu · 2023-10-16 22:49:41 +09:00
  3065c9f23d
• Merge pull request #25142 from bdach/clean-up-scoring-difficulty-attributes

  Remove no longer used scoring difficulty attributes

  Dean Herbert · 2023-10-16 20:16:20 +09:00
  75011db3a7
• Remove no longer used scoring difficulty attributes
  Bartłomiej Dach · 2023-10-16 12:36:58 +02:00
  f2436a5ecb
• Fix incorrect initial rotation transfer value

  Should have been removed as part of https://github.com/ppy/osu/pull/24360.

  Dean Herbert · 2023-10-16 19:34:55 +09:00
  0bb95cfa88
• Tidy up lastAngle usage and add assertion of maximum delta
  Dean Herbert · 2023-10-16 19:34:22 +09:00
  10bab61441
• Change SpinFramesGenerator to take degrees as input
  Dean Herbert · 2023-10-16 18:34:56 +09:00
  04af46b8c7
• Add prospective test coverage of spinner input handling
  Dean Herbert · 2023-10-16 18:31:01 +09:00
  28ee99f132
• Add SpinFramesGenerator class to simplify creating spinner tests
  Dean Herbert · 2023-10-16 18:25:40 +09:00
  cfa4adb24d
• Rename RateAdjustedRotation to TotalRotation
  Dean Herbert · 2023-10-16 18:25:03 +09:00
  159b24acf7
• Fix large instantaneous delta on first frame

  Happens when the first update frame comes in before any mouse input.

  Dan Balasescu · 2023-10-16 18:17:11 +09:00
  84be714d6b
• Merge pull request #25139 from peppy/collection-ordering-fix

  Fix collections not being sorted alphabetically in context menus

  Bartłomiej Dach · 2023-10-16 10:53:43 +02:00
  9cd33d9bb2
• Merge pull request #25140 from peppy/manage-collections-drag-handles-bye-bye

  Remove drag handles from manage collections dialog for now

  Bartłomiej Dach · 2023-10-16 10:47:38 +02:00
  ee3ddacf46
• Merge pull request #25136 from peppy/fix-taiko-hp-bar-animation

  Fix health bar animating when it shouldn't be

  Bartłomiej Dach · 2023-10-16 10:30:17 +02:00
  38d92187af
• Reformat long lines
  Bartłomiej Dach · 2023-10-16 09:06:34 +02:00
  c48142816c
• Rename test step
  Bartłomiej Dach · 2023-10-16 09:04:53 +02:00
  624c05e0ff
• Fix collections not being sorted correctly in context menus
  Dean Herbert · 2023-10-16 16:03:12 +09:00
  7139592e43
• Remove mention of "any tick"

  They're very dead now.

  Bartłomiej Dach · 2023-10-16 08:57:35 +02:00
  b9a84127ac
• Fix test failure due to missing zero (and FP shenanigans)
  Bartłomiej Dach · 2023-10-16 08:53:56 +02:00
  db00b794a2
• Remove drag handles from manage collections dialog for now

  The realm implementation doesn't support this.

  Dean Herbert · 2023-10-16 15:51:18 +09:00
  36112302d6
• Fix code quality inspection (weird one)
  Dean Herbert · 2023-10-16 15:16:10 +09:00
  d9d0629157
• Rename PerfectBonusNote to NotePerfectBonus
  Dean Herbert · 2023-10-16 15:14:28 +09:00
  4f1546c474
• Fix legacy skin body piece dimming when it shouldn't
  Dean Herbert · 2023-10-16 15:11:33 +09:00
  3f09ed396f
• Add empty hit windows on PefectBonusNote
  Dean Herbert · 2023-10-16 14:58:49 +09:00
  1a957364ae
• Add DisplayResult flag and remove unnecessary AlwaysPresent
  Dean Herbert · 2023-10-16 14:57:58 +09:00
  43f619f92a
• Fix MissForcefully not considering the bonus object
  Dean Herbert · 2023-10-16 14:53:36 +09:00
  14fedffcc1
• Fix various tests
  Dean Herbert · 2023-10-16 14:21:33 +09:00
  7c49843411
• Adjust method flow to hopefully be more legible
  Dean Herbert · 2023-10-16 13:31:14 +09:00
  e85c039722