Jorolf
a2dfef301a
remove unused parameters
2017-10-24 20:56:05 +02:00
Jorolf
f65d4b626e
don't use c# 7 feature
2017-10-24 20:46:15 +02:00
Jorolf
9109b1b3f1
Merge branch 'master' of git://github.com/ppy/osu into recent-scores
2017-10-24 20:34:26 +02:00
Jorolf
aadc699e73
show recent scores
2017-10-24 20:31:38 +02:00
Dean Herbert
15b9307b6c
Fix WaveOverlayContainer appearing incorrectly on first PopIn
2017-10-24 20:26:27 +09:00
Dean Herbert
808c97fcb4
Fix multiple requests potentially being triggered during connect sequence
...
As the Success callbacks happen in a scheduled context, if the Update thread is in a stalled state, this loop can generate many unnecessary API requests.
2017-10-24 17:13:59 +09:00
Dean Herbert
4eef9c0067
Merge branch 'master' into bugfix-nofail-scoreprocessor
2017-10-24 15:48:42 +09:00
Jacob Odgård Tørring
493fe1d621
Makes HasFailed private set and removes alreadyFailed
2017-10-24 08:34:10 +02:00
Jacob Odgård Tørring
86419e0ded
Merge remote-tracking branch 'upstream/master' into bugfix-nofail-scoreprocessor
2017-10-24 08:05:31 +02:00
Dean Herbert
542c6501a7
Fix VolumeControl and OnScreenDisplay being added to the wrong container
2017-10-24 13:10:17 +09:00
Dean Herbert
635f26badc
Remove unnecessary using
2017-10-24 11:59:57 +09:00
Dan Balasescu
ecd641c44a
Merge branch 'master' into startup-load-improvements
2017-10-24 11:54:31 +09:00
Dean Herbert
9ec870a821
Add comment pertaining to why Schedule() is required
2017-10-24 11:50:18 +09:00
Dean Herbert
e98bfec644
Remove Thread.Sleep and tidy up new method
2017-10-24 11:40:38 +09:00
Dean Herbert
00bb82215b
Merge branch 'master' into revert-to-default-glow
2017-10-24 10:48:08 +09:00
Dan Balasescu
9eab2deee7
Merge branch 'master' into config-slider-keyboardstep
2017-10-24 10:10:39 +09:00
Dean Herbert
0e04260b3c
Move ToolbarUserArea initialisation to BDL
2017-10-24 10:08:42 +09:00
Dean Herbert
777cdcbdc1
Load even more components async
2017-10-24 10:08:42 +09:00
Dean Herbert
9b7d569a65
Add a single-file loading sequence for main components
...
This stops aync loading from getting overloaded with tasks, which was happening previously.
2017-10-24 10:08:42 +09:00
Dan Balasescu
cf6079fd07
Merge branch 'master' into import-test-fixes
2017-10-24 09:36:48 +09:00
Dean Herbert
4e4f6c1a47
Merge branch 'master' into update-framework
2017-10-24 08:14:58 +09:00
Dean Herbert
26d8b67f25
Merge branch 'master' into config-slider-keyboardstep
2017-10-24 08:14:56 +09:00
Dean Herbert
b877177b83
Merge branch 'master' into bugfix-nofail-scoreprocessor
2017-10-24 08:14:54 +09:00
Dean Herbert
ffe94ea880
Merge branch 'master' into revert-to-default-glow
2017-10-24 08:14:53 +09:00
Dean Herbert
22b3f5dd19
Merge remote-tracking branch 'upstream/master' into import-test-fixes
2017-10-23 22:03:37 +09:00
Dean Herbert
dc9c474033
Move all TestCases to Testing project
...
This allows tests to successfully retrieve rulesets, as they are referenced.
2017-10-23 19:32:02 +09:00
Dean Herbert
1a3debc91d
Ensure thread safety on shared contexts
...
Let's call this one temporary.
2017-10-23 17:56:04 +09:00
Dean Herbert
e7931ef4c7
Add a default icon when a ruleset isn't present
2017-10-23 17:32:28 +09:00
Dean Herbert
df20845fbb
Share one context per file store for performance reasons
...
There is now a CreateContext method for retrieving a stand-alone context for threaded use.
We may want to add safety against this context being disposed (or just return a fresh one if it is).
2017-10-23 16:35:35 +09:00
Dean Herbert
4a68dd88cb
Centralise BeginTransaction and disable transaction use for now
2017-10-23 14:53:13 +09:00
Dean Herbert
8fab6abf90
Update WebRequest usage in line with framework changes
2017-10-23 14:46:17 +09:00
Shane Woolcock
ea2934d92c
Add KeyboardStep values for configuration options
2017-10-23 16:06:08 +10:30
Dean Herbert
1b455019a8
Merge remote-tracking branch 'upstream/master' into revert-to-default-glow
2017-10-23 11:56:17 +09:00
Nabile Rahmani
5af6fb41f5
Fixed .NET Standard build on Linux.
2017-10-23 02:03:46 +02:00
Jacob Odgård Tørring
9b54e834d9
Implements virtual Failcondition in scoreprocessor and enforces nofail in UpdateFailed
2017-10-22 20:32:59 +02:00
Dean Herbert
c089842adf
Merge branch 'master' into import-test-fixes
2017-10-23 02:21:42 +09:00
DerpyCrabs
cf468d6708
Fix linux build
...
Build is failing on linux because of case sensitive file system. This change fixes it.
2017-10-22 20:14:38 +07:00
Dean Herbert
61c1dd3636
Don't output database logs unless DEBUG_DATABASE is specified compile-time
2017-10-22 19:46:08 +09:00
Dean Herbert
7ba22f0028
Merge remote-tracking branch 'upstream/master' into import-test-fixes
2017-10-22 17:50:03 +09:00
Dan Balasescu
9a005fb63a
Merge branch 'master' into key-binding-store-improvements
2017-10-22 17:33:43 +09:00
Dean Herbert
5b2219a692
Add back test cleanup before run
2017-10-22 16:20:04 +09:00
Dean Herbert
1514d8451e
Use a more elegant method of setting the connection timeout
2017-10-22 16:20:04 +09:00
Dean Herbert
9aa46bfb0d
Add transaction usage for key binding defaults
2017-10-22 16:17:55 +09:00
Dean Herbert
29fcd210aa
Centralise transaction committing
2017-10-22 16:17:40 +09:00
Dean Herbert
39b356880e
Fix typo
2017-10-22 15:32:47 +09:00
Dean Herbert
6818ebdaff
Change the way migrations are checked for
...
This method allows switching between sqlite-net and EF builds without completely breaking. Note that DB migration still only happens in a forward direction, but this will allow switching back and forth without eventually being unable to start the game.
2017-10-22 15:27:16 +09:00
Shane Woolcock
2e6a68d358
Rename indicator class, add colour/fade easing, and add tooltip
2017-10-22 16:12:30 +10:30
Dean Herbert
f45eb96a5b
Merge remote-tracking branch 'upstream/master' into revert-to-default-glow
2017-10-22 13:27:53 +09:00
Shane Woolcock
5785af9f6a
Reenable revert indicator on audio device since the potential crash was addressed in #1101
2017-10-22 14:22:57 +10:30
Dean Herbert
1a7e23b5c1
Don't query database on keypress
2017-10-21 23:39:31 +09:00
Dean Herbert
4f392a867a
Use a transaction for key binding population
2017-10-21 23:39:24 +09:00
Shane Woolcock
59b10981dc
CI fixes
2017-10-21 17:06:28 +10:30
Shane Woolcock
f5946c0e07
Fix wrong license header
2017-10-21 16:28:03 +10:30
Shane Woolcock
840ba9f48e
Allow the default indicator colour to be specified, and fix bug where disabled bindables could be reset
2017-10-21 16:05:37 +10:30
Shane Woolcock
b4d575fbcd
Fix namespace and unnecessary using
2017-10-21 13:22:21 +10:30
Shane Woolcock
290fac8990
Temporarily disable revert functionality for audio device, since it crashes
2017-10-21 13:17:03 +10:30
Shane Woolcock
98044a17d3
Fix misaligned settings buttons
2017-10-21 13:16:06 +10:30
Shane Woolcock
2c7343e965
Add revert-to-default glow for settings items
2017-10-21 12:44:47 +10:30
Dean Herbert
270f984ae7
Merge remote-tracking branch 'upstream/master' into db-migration-fixes
2017-10-21 00:15:21 +09:00
Dean Herbert
47213d2498
Rely on storage.DeleteDatabase for guaranteed database deletion
...
Relies on https://github.com/ppy/osu-framework/pull/1100 being merged for most effectiveness.
2017-10-21 00:15:02 +09:00
Dan Balasescu
a9b9d82b74
Merge branch 'master' into fix-ef-hiding
2017-10-20 17:22:50 +09:00
Dean Herbert
b805174143
Output the inner exception to the log when possible
2017-10-20 14:33:35 +09:00
Dean Herbert
980a6c93b4
Merge branch 'master' into fix-ef-hiding
2017-10-20 14:24:46 +09:00
Dean Herbert
f18a3117a2
Merge branch 'master' into notification-thread-safety
2017-10-20 14:24:33 +09:00
Dean Herbert
f9d5eadd05
Fix TestCase failing in an infinite loop
2017-10-20 12:21:18 +09:00
Dean Herbert
35ce6fd2bd
Merge branch 'master' into notification-thread-safety
2017-10-20 11:48:14 +09:00
Dean Herbert
93b2fc6dc5
Fix issues with deletion
...
Main fix is avoiding nullrefs being thrown when metadata isn't present on a beatmap (quite a common scenario).
2017-10-20 11:18:08 +09:00
Dean Herbert
f69fa0cf1f
Fix selection after hiding all difficulties in a set
2017-10-20 11:16:56 +09:00
Dean Herbert
7f83cf6780
Fix hiding not always working
...
Because we are not sharing a single context, we need to use Update to attach the entity to the local context.
2017-10-20 11:16:45 +09:00
Dean Herbert
d32059a7ba
Ignore include-ignore warnings for now
2017-10-20 09:25:54 +09:00
Dean Herbert
ca78078436
Add more logging output
2017-10-20 08:06:07 +09:00
Dean Herbert
0e1328a30e
Add maximum try count before bailing
2017-10-20 08:01:38 +09:00
Dean Herbert
efaf98c5cf
Allow recovery from a very broken database
2017-10-20 00:48:27 +09:00
Dean Herbert
9b1ed5b3aa
Keep trying until delete succeeds
...
Turns out it can fail if file handles are still open.
2017-10-19 23:33:27 +09:00
Dean Herbert
d9fd05a5af
Hidden cannot be null
2017-10-19 23:19:30 +09:00
Dean Herbert
8aea6068ba
Add fallback logic for the case where previous database can't be migrated
2017-10-19 21:37:09 +09:00
Dan Balasescu
afaf3b4116
Merge branch 'master' into notification-thread-safety
2017-10-19 21:12:53 +09:00
Dean Herbert
1672e0d6b6
Add fallback logic in case migration fails
...
Nuke it all.
2017-10-19 21:11:43 +09:00
Dean Herbert
1fbbee14e4
Allow migration from sqlite-net to EF
...
Bonus stage
2017-10-19 20:04:59 +09:00
Dean Herbert
f7d0df1743
Fix beatmap difficulty and metadata deletion
2017-10-19 17:50:46 +09:00
Dean Herbert
b02dd196f6
Don't make one factory each context
...
A factory is supposed to be re-used.
2017-10-19 17:29:39 +09:00
Dean Herbert
36c00577af
Reduce database log output
...
Also hard-disables it for uninteresting log levels, providing a further performance boost.
2017-10-19 16:35:06 +09:00
Dean Herbert
12900a8b15
Remove unnecessary second call to AutoTransactionsEnabled
2017-10-19 15:53:11 +09:00
Dean Herbert
908c6d827f
ValueTuple please
2017-10-19 14:49:23 +09:00
Dean Herbert
5d5ea5fb2e
Fix all remaining db structure issues
2017-10-19 14:05:11 +09:00
Dean Herbert
71d614b813
FIx missing columns yet again
2017-10-18 21:57:54 +09:00
Dean Herbert
ac4b2797dc
valuetuple nightmare
2017-10-18 20:07:25 +09:00
Dean Herbert
0dac770e38
Remove TestCase cleanup temporarily until context disposal is sorted
2017-10-18 19:52:08 +09:00
Dean Herbert
b73b4755eb
Ignore r# locked context inspection here
2017-10-18 18:41:04 +09:00
Dean Herbert
a85de09c0f
Fix beatmap carousel interactions with deletion when not yet displayed
2017-10-18 18:36:35 +09:00
Dean Herbert
668f68dd63
Remove some unnecessary update calls
2017-10-18 18:27:57 +09:00
Dean Herbert
4841d4a937
Fix deletion and use single context for imports and deletions for now
2017-10-18 18:27:17 +09:00
Dean Herbert
cf5290fead
Remove unnecessary locking; operations are now thread-safe
2017-10-18 13:48:15 +09:00
Dean Herbert
2f3319552d
Merge remote-tracking branch 'upstream/master' into EfCore
2017-10-18 11:43:37 +09:00
EVAST9919
bae91d7de7
Simplify gradient usage in Letterbox Overlay
2017-10-18 05:06:17 +03:00
Dean Herbert
518e5a2245
Make ProgressNotification's status and progress thread-safe
...
Quite regularly a task will hold a reference to a progress notification and udpate it as progress is made. Therefore these operations should be thread-safe.
2017-10-18 10:07:20 +09:00
Dean Herbert
4193004fbf
Improve performance of imports by keeping a context hot
2017-10-17 20:29:47 +09:00
Dean Herbert
4e8019b313
Add some more missing indices
2017-10-17 19:59:22 +09:00
Dean Herbert
e4a066dc5f
Run cleanup tasks only on startup via manual calls
2017-10-17 19:58:33 +09:00
Dean Herbert
b9d0fb96ed
Fix cascade deletions
2017-10-17 18:26:28 +09:00
Dean Herbert
12639c6819
Use a different database name for now to avoid conflicts when switching versions
2017-10-17 17:52:20 +09:00
Dean Herbert
3e415e3269
Fix tooling failures
2017-10-17 17:52:02 +09:00
Dean Herbert
0177fcbe5f
Fix xmldoc
2017-10-17 17:08:47 +09:00
Dean Herbert
7a18d373ec
Improve performance of beatmap imports (still needs revision)
2017-10-17 17:08:42 +09:00
Dean Herbert
64dfce258f
Fix file prefix not being read when calling storage.Exists
2017-10-17 17:08:19 +09:00
Dean Herbert
e02640637a
Fix KeyBindingStore regression
2017-10-17 17:08:01 +09:00
Dean Herbert
ad54ca9268
Fix TestCasePlaySongSelect
2017-10-17 16:04:54 +09:00
Dean Herbert
cf3881b18c
Fix not being able to restore hidden beatmaps via context menu
2017-10-17 15:50:52 +09:00
Dean Herbert
e487b6f82a
Standardise context retrieval
2017-10-17 15:50:42 +09:00
Dean Herbert
cd41862e3b
Add back transaction support for beatmap importing
2017-10-17 15:00:27 +09:00
Dean Herbert
fe44a28d48
Add back startup tasks runner
2017-10-17 12:46:38 +09:00
Dean Herbert
66894d11ea
Connection -> context
2017-10-17 12:46:29 +09:00
Dean Herbert
c92e0e2dc1
Fix username display on beatmap panels
2017-10-17 11:24:59 +09:00
Dean Herbert
0df474accb
Simplify file storing
2017-10-17 11:22:50 +09:00
Dean Herbert
31dc5c97f2
Fix intro and duplicate inserts
2017-10-17 11:22:42 +09:00
Dean Herbert
ef10bb73db
osu.Game csproj fixes
2017-10-17 10:31:54 +09:00
Dean Herbert
799f510217
FileStore logic fixes
2017-10-17 10:25:18 +09:00
Dean Herbert
81476ebe75
Correct and simplify BeatmapStore and BeatmapManager
2017-10-17 10:17:21 +09:00
Dean Herbert
eff1c20e38
CI fixing
2017-10-16 22:00:54 +09:00
Dean Herbert
e378d0685d
Remove weird additions
2017-10-16 20:37:10 +09:00
Dean Herbert
9ee6d1e3f9
Correct and simplify KeyBindingStore
2017-10-16 18:42:49 +09:00
Dean Herbert
acc299c7b9
Correct and simplify RulesetStore
2017-10-16 17:02:31 +09:00
Dean Herbert
ec51314e37
Remove duplicate command
2017-10-16 16:11:34 +09:00
Dean Herbert
1f4a943f74
Fix test case runs not being correctly isolated on mono
2017-10-16 15:23:28 +09:00
Dean Herbert
7049a73490
Remove ValidTypes from databased stored; explicitly expose query methods instead
2017-10-16 14:47:33 +09:00
Dean Herbert
1a16784db9
Add BindingRedirects rule to fix dependency when running via nunit
...
See https://github.com/ErikEJ/EntityFramework.SqlServerCompact/issues/463
2017-10-16 14:18:01 +09:00
Dean Herbert
5b6c331434
Fix all keybindings being reset every startup
2017-10-16 14:12:08 +09:00
Dean Herbert
a5ccf12e4a
Fix ValueTuple mess
2017-10-16 14:04:04 +09:00
Dean Herbert
29b46a5c5e
Add missing reference to System.ValueTuple
2017-10-16 13:23:41 +09:00
Dean Herbert
4981630131
Fix formatting regressions
2017-10-16 13:12:51 +09:00
Dean Herbert
0a6dcdd405
Fix remaining warnings
2017-10-16 13:09:10 +09:00
Dean Herbert
8a0b184dd6
Revert "Return back DatabaseBackedStore's query and populate functions"
...
This reverts commit 7cf5d63cd3
2017-10-16 12:59:59 +09:00
Dean Herbert
04e5f764a3
Revert "Fix removal of FileInfo, BeatmapMetadata, BeatmapDifficulty objects"
2017-10-16 12:59:59 +09:00
TocoToucan
56e8c7303c
Revert "Fix inconsistent lock usage in BeatmapManager"
...
This reverts commit 4a064da30f
2017-10-16 12:59:59 +09:00
Dean Herbert
e3d31bdd10
Not implemented instead of incorrect
2017-10-16 12:59:59 +09:00
Dean Herbert
129cca0704
Tidy up context creation
2017-10-16 12:59:59 +09:00
Huo Yaoyuan
5a684f926f
CI fixes.
2017-10-16 12:59:59 +09:00
Huo Yaoyuan
c2836a8393
Use format string for double instead of Math.Round.
2017-10-16 12:59:59 +09:00
Huo Yaoyuan
f837117495
Use localisation engine instead of asking current culture directly.
2017-10-16 12:59:59 +09:00
Huo Yaoyuan
90592b0757
Construct DwarableScore using null weight.
2017-10-16 12:59:59 +09:00
TocoToucan
4a064da30f
Fix inconsistent lock usage in BeatmapManager
2017-10-15 21:56:33 +03:00
Dean Herbert
0a8b3ad619
Add one more licence header
2017-10-16 00:58:56 +09:00
Dean Herbert
a232033469
Fix some file headers and unused files
2017-10-16 00:54:09 +09:00
TocoToucan
db2750592d
Fix removal of FileInfo, BeatmapMetadata, BeatmapDifficulty objects
2017-10-15 14:01:35 +03:00
Huo Yaoyuan
06fe874594
CI fixes.
2017-10-15 16:53:30 +08:00
Huo Yaoyuan
9b3676c562
Use format string for double instead of Math.Round.
2017-10-15 16:44:15 +08:00
Huo Yaoyuan
192ebe776f
Use localisation engine instead of asking current culture directly.
2017-10-15 16:30:52 +08:00
Huo Yaoyuan
bed5a64ee2
Construct DwarableScore using null weight.
2017-10-15 16:15:35 +08:00
TocoToucan
7cf5d63cd3
Return back DatabaseBackedStore's query and populate functions
2017-10-15 00:40:41 +03:00
EVAST9919
e3ce641ea0
Merge remote-tracking branch 'refs/remotes/ppy/master' into intro
2017-10-15 00:15:25 +03:00
