62942 Commits

This Branch

This Branch

All Branches

• Remove nullability of bonusNote
  Dean Herbert · 2023-10-16 13:14:58 +09:00
  ddbda69751
• Add note about why SmallBonus is not listed in GetValidHitResults
  Dean Herbert · 2023-10-13 17:36:30 +09:00
  850950ba61
• Fix hodl tail notes not correctly handling nested bonus judgement
  Dean Herbert · 2023-10-13 17:36:19 +09:00
  125f28219d
• Add nested bonus judgement to DrawableNote for perfect bonus score
  Dean Herbert · 2023-10-13 17:01:48 +09:00
  94b64044e0
• Change Perfect judgement to not give extra score
  Dean Herbert · 2023-10-13 16:29:02 +09:00
  3787348448
• Merge pull request #25104 from bdach/make-realm-key-binding-action-suck-less

  Refactor key binding panel for easier usage

  Dean Herbert · 2023-10-13 14:27:07 +09:00
  7c36848eb1
• Merge branch 'master' into make-realm-key-binding-action-suck-less
  Dean Herbert · 2023-10-13 13:53:24 +09:00
  549a6581b0
• Tidy up GlobalActionContainer a bit
  Dean Herbert · 2023-10-13 13:47:51 +09:00
  9289c47cd4
• Merge pull request #25093 from Joehuu/mod-switch-tiny-extended-info

  Add extended info support to tiny mod switches

  Dean Herbert · 2023-10-13 13:40:24 +09:00
  aabed8b6e5
• Merge pull request #25096 from peppy/show-total-bonus

  Show maximum bonus statistics on results screen

  Bartłomiej Dach · 2023-10-12 20:29:28 +02:00
  edec10204e
• Refactor key binding panel leveraging new helper methods
  Bartłomiej Dach · 2023-10-12 15:03:29 +02:00
  c2e92cbb70
• Add API for retrieving global key bindings per section
  Bartłomiej Dach · 2023-10-12 14:24:21 +02:00
  1c784c9abe
• Add method to unmap RealmKeyBinding.Action to actual enum-typed value
  Bartłomiej Dach · 2023-10-12 14:17:26 +02:00
  2a0e4c364d
• Merge pull request #25100 from bdach/large-tick-mania-begone

  Remove remaining usages of `LargeTick{Hit,Miss}` in mania

  Dean Herbert · 2023-10-12 19:13:10 +09:00
  45db4ab412
• Fix judgement counter test failure due to exploiting mania ruleset

  Large ticks are not a thing in mania anymore, so the judgement counter
  tests began to fail as `LargeTickHit` is no longer a valid hit result
  in that ruleset.

  Bartłomiej Dach · 2023-10-12 11:34:59 +02:00
  34bab38e80
• Remove remaining usages of LargeTickHit in mania
  Bartłomiej Dach · 2023-10-12 11:16:51 +02:00
  a42e75452e
• Merge pull request #25082 from peppy/test-scene-background

  Remove test scene background stack and use new `ChangeBackgroundColour`

  Dean Herbert · 2023-10-12 14:57:34 +09:00
  2023.1012.0 d2044fc2cc
• Show maximum bonus statistics on results screen

  Addresses https://github.com/ppy/osu/discussions/25088.

  Dean Herbert · 2023-10-12 14:55:16 +09:00
  5bb73632c4
• Remove test scene background stack and use new ChangeBackgroundColour method
  Dean Herbert · 2023-10-12 14:08:31 +09:00
  194ad9650d
• Update framework
  Dean Herbert · 2023-10-12 14:08:31 +09:00
  29eba3c58a
• Merge pull request #25062 from smoogipoo/remove-hold-note-ticks

  Remove osu!mania hold note ticks

  Dean Herbert · 2023-10-12 13:55:50 +09:00
  f26e3afd29
• Merge pull request #25092 from bdach/key-binding-row-cleanups

  Clean up `KeyBindingRow` and related classes

  Dean Herbert · 2023-10-12 13:38:52 +09:00
  52255b15f0
• Add extended info support to tiny mod switches
  Joseph Madamba · 2023-10-11 12:47:12 -07:00
  764f641bc9
• Enable NRT in KeyBindingsSubsection
  Bartłomiej Dach · 2023-10-11 20:03:31 +02:00
  712564ea4f
• Merge branch 'master' into remove-hold-note-ticks
  Bartłomiej Dach · 2023-10-11 19:47:51 +02:00
  063623b4e6
• Assign red colour to ComboBreak hit result

  For a judgement result to show up on the colour hit error meter, it has
  to be two things: be scorable, and not be bonus.
  
  `ComboBreak` happens to meet both of those criteria - it impacts score
  indirectly via decreasing the combo portion, and isn't bonus. Therefore
  it would show up on the colour hit error meter, but because
  `OsuColour.ForHitResult()` wasn't handling it explicitly, it was
  painting the result in light blue, which isn't ideal for a miss type
  judgement. Therefore, use red instead.
  
  There is possibly an argument to be made that this judgement should not
  show up on the colour hit error meter at all, but I think it's actually
  okay for it to be this way. In any case it doesn't appear to be anything
  so major as to warrant blocking the hold note tick removal at this time.

  Bartłomiej Dach · 2023-10-11 19:44:46 +02:00
  041318e3e8
• Assign empty hit windows to HoldNoteBody

  It's not a timed object, so following precedent, it should have empty
  hitwindows.
  
  This is not actually just aesthetics; several components check whether a
  hitobject has empty hitwindows to determine whether to include it on
  various HUD displays and results screen components where timed objects
  are explicitly involved.

  Bartłomiej Dach · 2023-10-11 19:40:55 +02:00
  3f29f27cd4
• Enable NRT in KeyBindingRow
  Bartłomiej Dach · 2023-10-11 08:50:00 +02:00
  797109c05c
• Add xmldoc
  Bartłomiej Dach · 2023-10-11 08:50:00 +02:00
  0b2b065383
• Use init-only properties where applicable
  Bartłomiej Dach · 2023-10-11 08:49:58 +02:00
  7ac874d17a
• Reorder KeyBindingRow members
  Bartłomiej Dach · 2023-10-11 08:18:59 +02:00
  1acc02405e
• Merge pull request #25081 from peppy/song-bar-less-black

  Reduce black fill of song bar in tournament UI back to reasonable levels

  Bartłomiej Dach · 2023-10-10 22:28:50 +02:00
  eeb5409733
• Merge pull request #25074 from peppy/fix-argon-health-bar-flash

  Fix argon health bar not completing flash animation correctly

  Bartłomiej Dach · 2023-10-10 22:28:30 +02:00
  969c1b0812
• Merge branch 'master' into fix-argon-health-bar-flash
  Bartłomiej Dach · 2023-10-10 20:03:20 +02:00
  6f5f3a1ef4
• Merge pull request #25083 from peppy/fix-preview-point-incorrect

  Fix default preview point being incorrect on old beatmaps

  Bartłomiej Dach · 2023-10-10 19:54:14 +02:00
  66c12e5269
• Merge branch 'master' into fix-argon-health-bar-flash
  Dean Herbert · 2023-10-11 00:20:08 +09:00
  b9dbc8139b
• Merge pull request #25076 from peppy/fix-argon-health-bar-perf

  Ensure health displays don't pile up transforms when off-screen

  Bartłomiej Dach · 2023-10-10 16:33:32 +02:00
  d701e88a08
• Merge pull request #25079 from peppy/fix-player-startup-stop

  Fix multiplayer not correctly pausing the track on initialisation

  Bartłomiej Dach · 2023-10-10 16:30:35 +02:00
  0c64fe7eaa
• Adjust comment to match current behaviour

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2023-10-10 22:54:19 +09:00
  b9dadc52b7
• Remove comment regarding inlined delegate
  Dean Herbert · 2023-10-10 22:12:20 +09:00
  e2e28ef0ca
• Remove JudgementResult from Miss/Flash as it is not used
  Dean Herbert · 2023-10-10 22:10:44 +09:00
  682aa06acf
• Move validation to DHO.ApplyResult()
  Dan Balasescu · 2023-10-10 21:42:37 +09:00
  a1a46e58fc
• Fix beatmaps with no preview point set getting incorrect default

  Note that this will require a re-import to fix existing beatmaps
  becuse.. it's stored to realm. Probably not worth worrying about for
  now.

  Dean Herbert · 2023-10-10 19:13:16 +09:00
  2781846147
• Add failing test coverage of incorrect default preview time
  Dean Herbert · 2023-10-10 19:13:16 +09:00
  7220ca34f7
• Reduce black fill of song bar

  Closes https://github.com/ppy/osu/issues/24993.

  Dean Herbert · 2023-10-10 18:47:20 +09:00
  97e521acad
• Change GameplayClockContainer.Reset to directly call GameplayClock.Stop

  The reasoning is explained in the inline comment, but basically this was
  getting blocked by `isPaused` being in an initial `true` state (as it is
  on construction), while the source clock was still `IsRunning`.
  
  There's no real guarantee of sync between the source and the `isPaused`
  bindable right now. Maybe there should be in the future, but to restore
  sanity, let's ensure that a call to `Reset` can at least stop the track
  as we expect.

  Dean Herbert · 2023-10-10 18:16:14 +09:00
  f0bd975393
• Fix MultiplayerPlayer never calling Reset on GameplayClockContainer

  This call is responsible for ensuring the clock is in a stopped state.

  Dean Herbert · 2023-10-10 17:58:37 +09:00
  100c0cf533
• Reduce severity of clock running check to avoid production crashes
  Dean Herbert · 2023-10-10 17:58:11 +09:00
  eee7dc02da
• Add failing test coverage of player not pausing track correctly
  Dean Herbert · 2023-10-10 17:55:35 +09:00
  4319b22db8
• Merge pull request #25077 from bdach/fix-guest-score-lookup

  Fix score importer looking up guest user by username online

  Dean Herbert · 2023-10-10 17:35:15 +09:00
  1388f7240e