1095 Commits

• Shorten show/hide code
  Bartłomiej Dach · 2020-10-31 13:54:02 +01:00
  d74c19e2d7
• Run OnSelectionChanged() on each change
  Bartłomiej Dach · 2020-10-31 13:54:02 +01:00
  3322b8a7ea
• Bind UpdateVisibility() directly to source of truth
  Bartłomiej Dach · 2020-10-31 13:54:02 +01:00
  003994ab75
• Merge pull request #10596 from charlie-gray/right-click-circle-delete

  Add support for deleting objects when Shift is held down

  Dan Balasescu · 2020-10-29 11:37:22 +09:00
  8ccc3c2ec8
• Merge branch 'master' into right-click-circle-delete
  Bartłomiej Dach · 2020-10-28 22:12:14 +01:00
  a1696942f0
• Group selection actions back up in SelectionHandler
  Bartłomiej Dach · 2020-10-28 22:06:48 +01:00
  202fe09306
• Merge branch 'master' into fix-editor-bindable-crash
  Dean Herbert · 2020-10-28 13:34:54 +09:00
  351acce698
• Fix editor crash on exit when forcing exit twice in a row
  Dean Herbert · 2020-10-28 13:32:39 +09:00
  01b576c861
• Merge branch 'master' into fix-editor-samples-not-pausing-screen-swap
  Dan Balasescu · 2020-10-27 21:29:16 +09:00
  26a7545534
• Move editor sample disabling logic to editor class (and support screen switching)
  Dean Herbert · 2020-10-27 14:33:44 +09:00
  e0ad005cc1
• Remove unused using statement
  Dean Herbert · 2020-10-27 13:17:44 +09:00
  3c2e2f29bc
• Move right-click deletion logic to be handled at a SelectionBlueprint level
  Dean Herbert · 2020-10-27 12:53:54 +09:00
  27c1a4c4d3
• Change editor timing screen seek behaviour to only occur on clicking table rows

  Previously it would react to any selection changed event, which could in
  lude time changes (which is done by removing then adding the
  ControlPointGroup).
  
  Closes #10590.

  Dean Herbert · 2020-10-27 12:28:12 +09:00
  e1f578c590
• Fix code style issues & restructure
  Bartłomiej Dach · 2020-10-26 22:16:28 +01:00
  3f8c4c57d0
• fixed issue with returns
  Charlie · 2020-10-26 14:52:59 -05:00
  255bb9d100
• formatting
  Charlie · 2020-10-26 14:30:37 -05:00
  ccaf6560ec
• moved right click shift delete functionality to HandleSelectionRequested + reduced func size
  Charlie · 2020-10-26 14:28:53 -05:00
  1239670566
• added function so circle is deleted when shift+right click
  Charlie · 2020-10-26 13:40:42 -05:00
  ead3c19567
• Merge pull request #9484 from FlashyReese/visible-playfield-boundary
  Dean Herbert · 2020-10-20 19:43:41 +09:00
  8273715bde
• Merge branch 'master' into visible-playfield-boundary
  Dean Herbert · 2020-10-19 18:05:28 +09:00
  22bde43106
• Reapply waveform colour fix
  Dean Herbert · 2020-10-19 16:57:08 +09:00
  79a17b2371
• Merge pull request #10521 from peppy/fix-editor-seek-interval-when-playing

  Fix editor not seeking by full beat when track is playing

  Dan Balasescu · 2020-10-16 13:55:03 +09:00
  829241a9f0
• Fix editor not seeking by full beat when track is playing

  This is expected behaviour as my osu-stable, and I still stand behind
  the reasoning behind it.
  
  Closes #10519.

  Dean Herbert · 2020-10-16 13:07:00 +09:00
  aea31d1582
• Update with new r# inspections
  Dean Herbert · 2020-10-16 12:49:39 +09:00
  88f74921fb
• Make SelectionHandler require EditorBeatmap presence
  Dean Herbert · 2020-10-09 21:44:10 +09:00
  b0f8a7794a
• Merge branch 'master' into editor-fix-button-states-after-paste
  Dean Herbert · 2020-10-09 20:51:09 +09:00
  681e88af40
• Merge branch 'master' into fix-editor-batch-handling
  Dan Balasescu · 2020-10-09 20:06:06 +09:00
  ecfb7e94c5
• Merge pull request #10428 from peppy/editor-reset-newcombo-on-placement

  Reset new combo button state after successful placement

  Dan Balasescu · 2020-10-09 19:48:47 +09:00
  07f19342d1
• Merge pull request #10446 from peppy/fix-timeline-tick-bar-lines

  Fix bar lines ("down beat" as people call it) showing up too often in timeline

  Dan Balasescu · 2020-10-09 19:24:29 +09:00
  bcc096ee49
• Merge pull request #10432 from peppy/editor-reverse-pattern

  Add "reverse pattern" support to editor selection handler

  Dan Balasescu · 2020-10-09 19:19:24 +09:00
  62690e4873
• Fix missed usages
  Dean Herbert · 2020-10-09 18:50:05 +09:00
  3838f405dd
• Reference EditorBeatmap directly for selected objects
  Dean Herbert · 2020-10-09 18:44:23 +09:00
  edaf6db5c6
• Fix bar lines ("down beat" as people call it) showing up too often in timeline
  Dean Herbert · 2020-10-09 18:35:44 +09:00
  21c6242f90
• Merge pull request #10440 from peppy/fix-editor-song-after-exit

  Fix editor playing deleted beatmap's track on exit-without-save

  Dan Balasescu · 2020-10-09 17:58:31 +09:00
  a1226ccaa2
• Account for the width of points so they don't suddenly appear at timeline edges
  Dean Herbert · 2020-10-09 16:49:51 +09:00
  5d888f687a
• Only run regeneration when passing a new min/max tick boundary
  Dean Herbert · 2020-10-09 16:47:29 +09:00
  ceb1494c33
• Only recalculate when display actually changes
  Dean Herbert · 2020-10-09 15:57:31 +09:00
  017a8ce496
• Add local pooling to TimelineTickDisplay
  Dean Herbert · 2020-10-09 15:48:24 +09:00
  9baf704942
• Set beatmap to sane default on exiting editor
  Dean Herbert · 2020-10-09 13:12:48 +09:00
  68039cff40
• Add reverse handler button to selection box
  Dean Herbert · 2020-10-09 06:32:23 +09:00
  825e10ec8c
• Fix SliderPath not handling Clear correctly
  Dean Herbert · 2020-10-09 06:31:59 +09:00
  eacc7dca9a
• Fix incorrect comments
  Dean Herbert · 2020-10-09 05:14:44 +09:00
  85b33fffd0
• Fix ternary button states not updating correctly after a paste operation
  Dean Herbert · 2020-10-09 04:31:45 +09:00
  5966205037
• Reset new combo button state after successful placement
  Dean Herbert · 2020-10-09 03:31:01 +09:00
  e7eda19b07
• Further simplify non-transactional change logic
  Dean Herbert · 2020-10-08 18:42:53 +09:00
  4ccd751604
• Add missing non-transactional SaveState calls
  Dean Herbert · 2020-10-08 18:41:03 +09:00
  3114174e09
• Tidy up EditorBeatmap slightly
  Dean Herbert · 2020-10-08 18:06:49 +09:00
  afed832b19
• Copy list content before firing events to avoid pollution
  Dean Herbert · 2020-10-08 18:04:07 +09:00
  1027b608ff
• Update usages of ChangeHandler to EditorBeatmap where relevant
  Dean Herbert · 2020-10-08 18:04:07 +09:00
  38babf3de5
• Hook ChangeHandler to transactional events rather than individual ones
  Dean Herbert · 2020-10-08 18:04:07 +09:00
  b2d93f799f