Dean Herbert
9e7a28002d
Merge branch 'master' into beatmap-track-rework
2020-08-13 17:56:50 +09:00
Dean Herbert
ab56980f8c
Merge branch 'master' into fix-spun-out-mod-rate-dependency
2020-08-13 17:24:11 +09:00
Dean Herbert
2067e1ce44
Merge pull request #9798 from EVAST9919/dashboard-news
2020-08-13 17:23:54 +09:00
Dean Herbert
99bea6b8e9
Add missing null check (player construction is potentially delayed now)
2020-08-13 12:52:35 +09:00
Dean Herbert
27cd9e119a
Delay beatmap load until after transition has finished
...
Previously the beatmap would begin loading at the same time the
`PlayerLoader` class was. This can cause a horribly visible series of
stutters, especially when a storyboard is involved.
Obviously we should be aiming to reduce the stutters via changes to the
beatmap load process (such as incremental storyboard loading,
`DrawableHitObject` pooling, etc.) but this improves user experience
tenfold in the mean time.
2020-08-13 12:04:32 +09:00
smoogipoo
91e28b849d
Fix incorrect BeatmapManager construction
2020-08-13 00:29:23 +09:00
Dean Herbert
429ad783cf
Merge branch 'update-framework' into beatmap-track-rework
2020-08-12 23:35:46 +09:00
Dean Herbert
00f8bb7c3e
Update resources
2020-08-12 23:28:45 +09:00
Dean Herbert
b10cddf625
Update framework
2020-08-12 23:28:08 +09:00
Dean Herbert
05b06e7451
Merge branch 'master' into fix-skinnable-sound-mute
2020-08-12 22:01:04 +09:00
Andrei Zavatski
f3202fb123
Naming adjustments
2020-08-12 11:24:26 +03:00
Andrei Zavatski
9b112baa88
Merge remote-tracking branch 'refs/remotes/ppy/master' into dashboard-news
2020-08-12 11:15:58 +03:00
Bartłomiej Dach
8fe5775ecb
Allow testing mod combinations in ModTestScenes
2020-08-11 21:55:20 +02:00
Andrei Zavatski
84655b0798
Change hover colour for news title
2020-08-11 20:17:29 +03:00
Andrei Zavatski
fdfda453c7
Merge remote-tracking branch 'refs/remotes/ppy/master' into dashboard-news
2020-08-11 20:14:52 +03:00
smoogipoo
c0031955c9
Update with further framework changes
2020-08-12 01:50:18 +09:00
smoogipoo
e47a1eb313
Use adjustable ITrack
2020-08-12 01:41:21 +09:00
smoogipoo
688e447950
Fix potential hierarchy mutation from async context
2020-08-12 01:33:06 +09:00
smoogipoo
eec94e1f53
Make track not-null in GameplayClockContainer/FailAnimation
2020-08-12 00:51:43 +09:00
smoogipoo
b66f303e71
Add annotation
2020-08-12 00:48:45 +09:00
smoogipoo
070d71ec27
More cleanups
2020-08-12 00:48:38 +09:00
Dean Herbert
8bfe6ba27c
Fix informational overlays not hiding each other correctly
2020-08-11 23:15:08 +09:00
smoogipoo
031d29ac34
Inspect current track directly
2020-08-11 13:53:23 +09:00
smoogipoo
faff0a70c4
Privatise BMWB
2020-08-11 13:48:57 +09:00
smoogipoo
338c01fa43
Remove track store reference counting, use single instance stores
2020-08-11 13:16:06 +09:00
smoogipoo
7d35893ecd
Make MusicController non-nullable
2020-08-11 12:40:58 +09:00
smoogipoo
c66a14e9c5
Remove beatmap from FailAnimation
2020-08-11 12:37:48 +09:00
smoogipoo
b64142dff9
Fix incorrect load state being used
2020-08-11 12:37:00 +09:00
Dan Balasescu
c86798f8b2
Merge pull request #9829 from peppy/fix-multiple-assembly-loaded-crash
...
Fix crash when same ruleset loaded more than once
2020-08-11 12:09:44 +09:00
Dan Balasescu
8b7e715c2b
Merge pull request #9818 from peppy/improve-token-fail-error-messaging
...
Improve messaging when timeshift token retrieval fails
2020-08-11 11:31:52 +09:00
Dean Herbert
471ed968e3
Fix crash when same ruleset loaded more than once
...
If the same ruleset assembly was present more than once in the current
AppDomain, the game would crash. We recently saw this in Rider EAP9.
While this behaviour may change going forward, this is a good safety
measure regardless.
2020-08-11 11:09:02 +09:00
Dean Herbert
dd2f677aa4
Merge pull request #9633 from Joehuu/fix-keybind-clearing
2020-08-11 11:01:03 +09:00
Dean Herbert
02084d7636
Merge branch 'master' into improve-token-fail-error-messaging
2020-08-11 10:59:33 +09:00
Dean Herbert
d1b106a3b5
Include mention of old releases in error message
2020-08-11 10:59:28 +09:00
Dan Balasescu
088f7f5cc7
Merge pull request #9819 from peppy/fix-overlay-depths
...
Always show newly presented overlay at front
2020-08-11 10:24:37 +09:00
Dean Herbert
ecb4826e19
Update framework
2020-08-11 06:54:26 +09:00
Dean Herbert
365aae799e
Merge branch 'master' into fix-skinnable-sound-mute
2020-08-10 23:55:51 +09:00
Dean Herbert
730d13fda6
Always show newly presented overlay at front
...
This feels much better. Does not change order if the overlay to be shown
is not yet completely hidden.
- Closes #9815 .
2020-08-10 20:48:04 +09:00
Dean Herbert
1f84e54151
Improve messaging when timeshift token retrieval fails
...
Obviously not a final solution, but should better help self-compiling
(or unofficial package) users better understand why this is happening.
2020-08-10 20:16:16 +09:00
Andrei Zavatski
d8f8930691
Remove HomeNewsPanelFooter
2020-08-09 05:28:43 +03:00
Andrei Zavatski
a72a48624d
Remove NewsPostDrawableDate
2020-08-09 05:16:08 +03:00
Bartłomiej Dach
a636c7052c
Merge branch 'master' into adujustable-skinnablesound
2020-08-08 21:51:47 +02:00
Dean Herbert
ffb2e56a8d
Reverse direction of bool to make mental parsing easier
2020-08-08 23:25:52 +09:00
Dean Herbert
0d1f273603
Merge branch 'master' into fix-skinnable-sound-mute
2020-08-08 23:24:03 +09:00
Dean Herbert
1090137da3
Adjust comment to read better
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2020-08-08 23:23:02 +09:00
smoogipoo
87ce1e3558
Remove impossible null case (DummyWorkingBeatmap)
2020-08-08 00:58:04 +09:00
smoogipoo
b8373e89b7
Move beatmap bind to BDL load()
2020-08-07 23:08:09 +09:00
smoogipoo
e87f50f74f
Rename method
2020-08-07 22:31:41 +09:00
smoogipoo
b6fb7a0d39
Fix possibly setting null track
2020-08-07 22:05:58 +09:00
smoogipoo
08820c62ec
Add back removed nullcheck
2020-08-07 21:36:02 +09:00
smoogipoo
b08ebe6f81
More inspections (rider is broken)
2020-08-07 21:14:45 +09:00
smoogipoo
961c6dab54
Fix more inspections
2020-08-07 21:08:03 +09:00
smoogipoo
5002d69f69
Update inspections
2020-08-07 20:51:56 +09:00
smoogipoo
61b632516e
Ensure CurrentTrack is never null
2020-08-07 19:43:16 +09:00
Andrei Zavatski
cddd4f0a97
Implement HomeShowMoreNewsPanel
2020-08-07 13:18:31 +03:00
Andrei Zavatski
76d35a7667
Implement HomeNewsGroupPanel
2020-08-07 12:59:45 +03:00
smoogipoo
bf21fdd6da
Merge branch 'master' into beatmap-track-rework
2020-08-07 18:41:34 +09:00
Andrei Zavatski
2e0f567d5d
Implement HomeNewsPanel component
2020-08-07 11:33:02 +03:00
Dean Herbert
c84452cfbf
Update usages
2020-08-06 21:53:20 +09:00
Dean Herbert
f994bf2888
Update framework
2020-08-06 21:34:48 +09:00
Dean Herbert
e3105fd4c8
Add more resilient logic for whether to avoid playing SkinnableSound on no volume
2020-08-06 19:16:26 +09:00
smoogipoo
d1af1429b3
Fix inspection
2020-08-06 19:08:45 +09:00
smoogipoo
4cfca71d08
Fix a few test scenes
2020-08-06 19:05:15 +09:00
smoogipoo
adf4f56dce
Move MusicController to OsuGameBase
2020-08-06 19:01:23 +09:00
smoogipoo
f8279dab32
Refactor MainMenu
2020-08-06 18:54:14 +09:00
smoogipoo
ef689d943a
Fix intros playing incorrectly
2020-08-06 18:54:08 +09:00
smoogipoo
2e3ecf71c7
Pass track from Player to components
2020-08-06 18:31:08 +09:00
smoogipoo
7c3ae4ed42
Remove generics from IApplicableToTrack
2020-08-06 18:25:34 +09:00
Dean Herbert
9685df0eca
Only update key binding on next usage to avoid large blocking calls
2020-08-06 18:24:20 +09:00
smoogipoo
c8ebbc8594
Remove MusicController from EditorClock
2020-08-06 18:19:55 +09:00
smoogipoo
f53672193e
Fix track stores being kept alive
2020-08-06 17:48:07 +09:00
Joehu
f9c369b23c
Fix toolbar music button tooltip overflowing off-screen
2020-08-06 01:20:03 -07:00
Joehu
d574cac702
Add keybinding to toolbar button's tooltip
2020-08-06 01:18:45 -07:00
Joehu
7bcb68ffac
Handle overlay toggling with toolbar buttons instead
2020-08-06 01:17:24 -07:00
smoogipoo
c72ab9047e
Cleanup test scene disposal
2020-08-06 17:15:33 +09:00
Joehu
ad959ce523
Make toolbar button abstract
2020-08-06 01:06:51 -07:00
smoogipoo
e8ab3cff3c
Add class constraint
2020-08-06 17:02:47 +09:00
smoogipoo
fe8c462498
Remove intermediate container
2020-08-06 17:00:17 +09:00
smoogipoo
0f7fde5d2c
Revert unnecessary change
2020-08-06 16:24:14 +09:00
smoogipoo
86ae61c6b7
Re-implement store transferral in BeatmapManager
2020-08-06 16:24:14 +09:00
smoogipoo
0edd509397
Only change track when audio doesn't equal
2020-08-06 16:24:14 +09:00
smoogipoo
f058f5e977
Fix incorrect value being set
2020-08-06 16:24:14 +09:00
smoogipoo
11a6c9bdcc
Revert unnecessary change
2020-08-06 16:24:14 +09:00
smoogipoo
e9fc783b1d
Add back loop-on-completion
2020-08-06 16:24:14 +09:00
smoogipoo
58660c70a3
Cache before idle tracker
2020-08-06 16:24:14 +09:00
smoogipoo
5c05fe3988
Expose track from MusicController
2020-08-06 16:24:14 +09:00
smoogipoo
6e42b8219c
Move track to MusicController, compiles
2020-08-06 16:24:14 +09:00
smoogipoo
641279ec3e
Make SkinnableSound an IAdjustableAudioComponent
2020-08-06 14:43:48 +09:00
smoogipoo
9a00ad48c6
Update components to use extension methods
2020-08-06 14:43:39 +09:00
Dan Balasescu
bba23dc928
Merge pull request #9780 from peppy/add-toolbar-tooltips
...
Add missing toolbar tooltips for right-hand icons
2020-08-06 13:45:01 +09:00
Dean Herbert
e3f314349a
Don't use title case
...
Co-authored-by: Joseph Madamba <madamba.joehu@outlook.com>
2020-08-06 12:27:30 +09:00
Dean Herbert
bf1bb32674
Add missing toolbar tooltips for right-hand icons
2020-08-05 19:09:55 +09:00
Dean Herbert
3916d98e52
Add comment for clarity
2020-08-05 18:50:37 +09:00
Dean Herbert
8644d04a84
Merge branch 'master' into news-fix
2020-08-05 18:50:35 +09:00
Dean Herbert
22b52d63c7
Update framework
2020-08-04 20:51:59 +09:00
Salman Ahmed
9d10658e3c
Allow providing custom sprite text for RollingCounter<T>
2020-08-03 20:14:17 +03:00
Dean Herbert
4d6f60edaf
Fix multiplayer match select forcing playback even when user paused
2020-08-03 22:43:50 +09:00
Dan Balasescu
8a9036938f
Merge pull request #9761 from peppy/fix-android-version-hash
...
Add fallback hash generation to fix android startup crash
2020-08-03 19:20:28 +09:00
Dan Balasescu
6d266b5a93
Merge pull request #9712 from frenzibyte/merge-global-to-legacy
...
Merge GlobalSkinConfiguration settings into the LegacySetting enum
2020-08-03 19:16:35 +09:00
Dean Herbert
f812767c95
Add fallback hash generation to fix android startup crash
2020-08-03 18:49:06 +09:00
