Merge pull request #9829 from peppy/fix-multiple-assembly-loaded-crash

Fix crash when same ruleset loaded more than once
2026-05-23 05:39:53 +08:00 · 2020-08-11 12:09:44 +09:00
parent 8b7e715c2b 471ed968e3
commit c86798f8b2
1 changed files with 5 additions and 0 deletions
@@ -191,6 +191,11 @@ namespace osu.Game.Rulesets
            if (loadedAssemblies.ContainsKey(assembly))
                return;

+            // the same assembly may be loaded twice in the same AppDomain (currently a thing in certain Rider versions https://youtrack.jetbrains.com/issue/RIDER-48799).
+            // as a failsafe, also compare by FullName.
+            if (loadedAssemblies.Any(a => a.Key.FullName == assembly.FullName))
+                return;
+
            try
            {
                loadedAssemblies[assembly] = assembly.GetTypes().First(t => t.IsPublic && t.IsSubclassOf(typeof(Ruleset)));