1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-16 04:27:52 +08:00
Commit Graph

62409 Commits

Author SHA1 Message Date
Bartłomiej Dach
76954f6e91
Merge branch 'master' into skin-editor-selection-negative-scaling 2023-09-01 21:30:24 +02:00
Wleter
fc4069f794 let SelectionBox perform flip with scale handles 2023-09-01 13:01:51 +02:00
Dean Herbert
8d0f6df329
Merge pull request #24280 from tybug/stable-notelock
Correctly implement stable notelock in Classic mod
2023-09-01 18:05:57 +09:00
Dean Herbert
ede9fae381 Remove broken check from TestSceneHitCircleLateFade 2023-09-01 17:28:31 +09:00
Dean Herbert
90121814f9 Merge branch 'master' into stable-notelock 2023-09-01 17:15:48 +09:00
Dean Herbert
c75b14c729 Apply NRT to new LegacyHitPolicy class (and other implementations) 2023-09-01 16:56:34 +09:00
Dean Herbert
38bb0faa58
Merge pull request #24686 from frenzibyte/hitcircles-fade-fix 2023-09-01 11:47:43 +09:00
Bartłomiej Dach
26270c977c
Merge branch 'master' into hitcircles-fade-fix 2023-08-31 23:53:37 +02:00
Bartłomiej Dach
b5d88713fe
Merge pull request #24691 from peppy/file-ipc-race-fix
Fix potential race condition in song bar beatmap lookup flow
2023-08-31 21:54:38 +02:00
Wleter
47160f7744 make getClosestAnchor work with rotated drawable 2023-08-31 20:24:26 +02:00
Dean Herbert
0131296394
Merge pull request #24669 from bdach/switch-to-new-score-download-endpoint
Switch download requests to new API endpoint
2023-09-01 02:50:27 +09:00
Bartłomiej Dach
ab8a032928
Merge pull request #24690 from peppy/tournament-schedule-screen-layout-fix
Fix regression in spacing on tournament schedule screen
2023-08-31 18:14:14 +02:00
Dean Herbert
cf9c8120c5 Fix potential race condition in song bar beatmap lookup flow
Cancelling a web request may not necessarily cancel the callbacks.

This might help with https://github.com/ppy/osu/issues/24598.
2023-08-31 19:04:10 +09:00
Dean Herbert
34b279845b Add more testability for song bar 2023-08-31 19:03:56 +09:00
Dean Herbert
4bdaca3816 Fix regression in spacing on schedule screen 2023-08-31 18:47:41 +09:00
Dean Herbert
540c58c359 Fix tournament screen tests not matching OsuGameBase resolution
This would cause things to look completely out of whack.

The numbers here match `DrawSizePreservingFillContainer` defaults as
used by `OsuGameBase.CreateScalingContainer()`.
2023-08-31 18:47:41 +09:00
Dean Herbert
4b68493084 Add ability to test recent / upcoming matches on schedule screen 2023-08-31 18:43:06 +09:00
Dean Herbert
7aa1505062 Improve legibility of LINQ queries for recent/upcoming matches 2023-08-31 18:39:51 +09:00
Dean Herbert
5fa31b7b35 Fix schedule screen not responding to new matches being added 2023-08-31 18:39:51 +09:00
Dean Herbert
2d88135198 Add automated test coverage for new test 2023-08-31 16:18:53 +09:00
Salman Ahmed
b8df714f56 Remove unused using directives 2023-08-30 21:50:52 +03:00
Salman Ahmed
993cebe785 Fix mod "Classic" interfering with DrawableHitCircle animation while in hit state 2023-08-30 21:42:47 +03:00
Salman Ahmed
c91031604c Add test cases for hitting hit circles with "early fade" behaviour 2023-08-30 21:41:57 +03:00
Dean Herbert
038e618af0 Merge branch 'master' into switch-to-new-score-download-endpoint 2023-08-31 00:15:57 +09:00
Bartłomiej Dach
91c3ae4fef
Merge pull request #24680 from peppy/tournament-remove-minimum-window-size
Remove tournament client minimum window size
2023-08-30 09:35:59 +02:00
Wleter
f277909470 maintain rotated selection's centre position 2023-08-30 09:16:16 +02:00
Bartłomiej Dach
8398e07be9
Merge branch 'master' into tournament-remove-minimum-window-size 2023-08-30 08:21:08 +02:00
Bartłomiej Dach
0f123fd8e0
Remove unused using directive 2023-08-30 08:20:57 +02:00
Bartłomiej Dach
fb8e3df582
Merge pull request #24679 from peppy/tournament-save-via-keyboard
Allow saving changes in tournament system using `Ctrl`+`S`
2023-08-30 08:18:01 +02:00
Bartłomiej Dach
9b013beb1a
Merge pull request #24614 from peppy/carousel-difficulty-split
Split out individual difficulties when using difficulty sort at song select
2023-08-30 08:06:44 +02:00
Dean Herbert
96a5443813
Merge branch 'master' into carousel-difficulty-split 2023-08-30 14:24:30 +09:00
Dean Herbert
cbd4b91feb
Merge pull request #24678 from Nabile-Rahmani/bot-scores
Fix and use score user's IsBot property in results screen animation
2023-08-30 14:00:35 +09:00
Dean Herbert
24d6cbefe1 Remove tournament client minimum window size
This seemed like a good idea but people were using it with smaller
resolutions, do let's just not do it.

Addresses https://github.com/ppy/osu/discussions/24670.
2023-08-30 13:45:00 +09:00
Dean Herbert
a85f0d5791 Allow saving changes in tournament system using Ctrl+S 2023-08-30 13:29:08 +09:00
Dean Herbert
d3e40f89e2
Merge pull request #24675 from bdach/hide-score-v2-mod
Mark "Score V2" mod as not user-playable
2023-08-30 13:18:27 +09:00
Nabile Rahmani
270e2a6600
Update osu.Game/Rulesets/Mods/ModExtensions.cs
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2023-08-29 23:59:08 +02:00
Nabile Rahmani
b658b0e346 Fix and use score user's IsBot property in results screen animation
While a mod-created replay did flag itself as performed by a bot, the extension method converting it into a Score did not copy all the generated properties.

As noted, it might be preferable for ModCreatedUser to inherit APIUser and forward it as-is to the Score instance.

Related to PR #24675
2023-08-29 23:28:50 +02:00
Wleter
ce1bc71567 formatting 2023-08-29 18:41:56 +02:00
Wleter
586ce6e8d3 fix multiple selected 2023-08-29 17:47:42 +02:00
Wleter
14ee0ee395
Merge branch 'ppy:master' into skin-editor-selection-negative-scaling 2023-08-29 17:30:55 +02:00
Wleter
d56ab0fe9a change names 2023-08-29 17:25:52 +02:00
Wleter
3c575516ab add correct scaling for 90 degrees rotation 2023-08-29 17:06:23 +02:00
Bartłomiej Dach
d07530b241
Mark "Score V2" mod as not user-playable
The mod generally will only be present on scores imported from stable.
As such, it's probably ok to mark it as such.

The primary reason for this change is to address #24436 (Score V2 being
visible on beatmap overlay leaderboard mod selector).

There is one possibly-unintended consequence of this change, namely that
the results screen uses `UserPlayable` to determine as to whether
animations should be played back, with the intention of turning off the
animation playback for autoplay scores specifically. Therefore, turning
off this flag will mean that the results screen animations will not play
out for Score V2 scores - but I tend to consider this as either largely
unimportant, or something that should be fixed in some other way
(possibly by checking against the autoplay mod directly).

Other usages of `UserPlayable` are either innocuous, or straight-up good
safeties going forward in the context of Score V2 (guards against
selection in mod select overlays, against score submission with
the mod).
2023-08-29 11:52:11 +02:00
Givikap120
f8adc911cd
Merge branch 'ppy:master' into map_info_on_mod_settings 2023-08-28 23:17:04 +03:00
Givikap120
50235cc245 somewhat working prototype 2023-08-28 23:16:33 +03:00
Dan Balasescu
390b6f649d Add test 2023-08-29 03:46:11 +09:00
Wleter
07e126241d working negative scaling 2023-08-28 16:41:55 +02:00
Bartłomiej Dach
118c86df34
Fix TestSceneUpdateBeatmapSetButton using random difficulty count 2023-08-28 14:57:00 +02:00
Dean Herbert
d701a25969
Merge pull request #24668 from bdach/disable-redundant-verbatim-string-prefix-inspections
Disable redundant verbatim string prefix inspections
2023-08-28 21:21:52 +09:00
Bartłomiej Dach
99d5ff9efb
Switch download requests to new API endpoint
This API endpoint is intended for usage with the entire `solo_scores`
machinery and ID schema, rather than the legacy `*_scores_high` ID
schema. It also supports automagically falling back to downloading
legacy replays if a stable-imported score is requested for download
(internally this happens via `legacy_score_id` in the `data` json).

This change will allow replays to be downloaded, but it will still not
yield 100% correct behaviour, as there is further work to be done in
that respect. The download tracker is expecting score hashes to arrive
from web to verify the integrity of the incoming download, but the API
does not expose such a facility right now; we will have to decide as to
whether we want to add one web-side, or whether we want to disable the
checking client-side.
2023-08-28 13:50:52 +02:00