Henry Lin
0196141335
Remove unused constants
2021-07-29 14:52:40 +08:00
Henry Lin
18e760ee91
Extract metronome from OsuModTarget
2021-07-29 14:52:18 +08:00
Henry Lin
22d83c75e3
Revert imports re-ordering
...
Out of the scope of this PR
2021-07-28 18:32:38 +08:00
Henry Lin
58bbe9db7e
Added muted mod
2021-07-28 18:21:08 +08:00
Dean Herbert
4a4d9b0dc6
Update description to match mania mirror implementation
2021-07-28 19:20:40 +09:00
Gabe Livengood
712bc578dc
update setting name and description
2021-07-27 17:45:52 -04:00
Salman Ahmed
5cb02002d7
Fix flipped xmldoc
2021-07-27 18:24:17 +03:00
Salman Ahmed
ed903c60ea
Fix code style issues and remove unused using directives
2021-07-27 18:24:17 +03:00
Gabe Livengood
c741366c72
review modifications: change xmldocs, change reflection method name, remove reflection method returns, simplify incompat. mod list
2021-07-27 09:01:01 -04:00
Gabe Livengood
c7c261ba03
review modifications: change xmldoc wording, configure with enum instead of bool, declare incompatibility with hr
2021-07-26 17:48:03 -04:00
Gabe Livengood
49160e4482
review modifications: maniamodmirror inheritance, reflection utilities, vertical flip option
2021-07-26 10:46:41 -04:00
Gabe Livengood
eb585a6120
Add "Mirror" mod
2021-07-25 20:40:50 -04:00
Dean Herbert
50a2abbe7f
Merge pull request #12683 from frenzibyte/legacy-beatmap-combo-offset
...
Apply combo offsets "colour hax" only on beatmap skins
2021-07-23 14:30:18 +09:00
aitani9
715f3e3f7c
Make blinds move correctly whenever the playfield is rotated
2021-07-22 14:07:41 -07:00
aitani9
80cb7c77b9
Calculate the diagonal length using Vector2.LengthFast instead of manually
2021-07-22 14:04:01 -07:00
aitani9
e6b28e1386
Rename origin to center for clarity
2021-07-22 14:01:31 -07:00
02Naitsirk
b31fef7e00
Implement total SR formula that better correlates with pp
2021-07-22 13:49:47 -04:00
Dean Herbert
3392086d1c
Merge pull request #13984 from ekrctb/catch-editor-reverse
...
Implement "reverse pattern" in catch editor
2021-07-23 01:12:13 +09:00
Salman Ahmed
523c154f15
Add ComboIndexWithOffsetsBindable and bind similar to ComboIndexBindable
2021-07-22 16:40:33 +03:00
Dean Herbert
cde8ae6f18
Merge pull request #13483 from emu1337/diffspike-balance
...
Spike difficulty / AR&FL adjustments
2021-07-22 19:28:22 +09:00
ekrctb
cc01b9e639
Extract SliderPath reverse logic to be used in other rulesets
2021-07-22 16:14:43 +09:00
aitani9
283d953c4f
Fix blinds moving when barrel roll mod is active
2021-07-21 14:07:00 -07:00
Dean Herbert
adda96ac86
Merge pull request #13962 from ekrctb/platform-action
...
Adapt to framework `PlatformAction` type change
2021-07-21 18:17:38 +09:00
Dean Herbert
399c3b0be8
Rename property, reword xmldoc and improve readability of update code
2021-07-21 17:32:56 +09:00
ekrctb
1bac471b49
Adapt to PlatformAction type change
2021-07-21 16:12:53 +09:00
ekrctb
1bff4373b3
Allow specifying flipping support of selection box different from scaling
2021-07-21 15:59:45 +09:00
emu1337
84fd59777c
Merge branch 'master' into diffspike-balance
2021-07-20 19:39:41 +02:00
Salman Ahmed
9d92b795fa
Revert making ComboOffsets legacy and define BeatmapSkinComboIndex instead
2021-07-20 14:15:43 +03:00
Salman Ahmed
554652b033
Merge branch 'refactor-combo-colour-retrieval' into legacy-beatmap-combo-offset
2021-07-20 10:11:52 +03:00
Henry Lin
1c6a13fca7
Disallow mistimed event firing
2021-07-20 10:31:19 +08:00
Henry Lin
a387d8df74
Use BeatSyncClock
2021-07-20 10:30:40 +08:00
Bartłomiej Dach
fb5d25405e
Replace calls to obsoleted GetOrDefault() extension
2021-07-18 21:52:16 +02:00
Bartłomiej Dach
6e065362be
Merge branch 'master' into osu-target-mod
2021-07-18 18:22:36 +02:00
Henry Lin
fdebe4b94a
Code formatting fixes
2021-07-18 22:01:26 +08:00
Dean Herbert
49f0c707f6
Move approach circle hiding within BeginAbsoluteSequence
2021-07-18 22:34:28 +09:00
Dan Balasescu
da7e880e46
Merge pull request #13893 from peppy/mouse-settings-localisation
...
Add localisation coverage of `MouseSettings`
2021-07-16 23:25:12 +09:00
Dean Herbert
8cdc3536f4
Merge pull request #13826 from stanriders/buff-ar
...
Change approach rate bonuses to be less punishing on mid-length maps
2021-07-16 22:47:10 +09:00
Dean Herbert
304eac26d3
Merge branch 'master' into osu-target-mod
2021-07-15 16:51:02 +09:00
Dean Herbert
ea87869753
Fix metronome playing during intro time
2021-07-15 16:50:55 +09:00
Dean Herbert
c38590f1ff
Use a slightly more appropriate metronome sound
2021-07-15 16:43:24 +09:00
Dean Herbert
5b91111eda
Update SettingsSubsection.Header to accept a LocalisableString
2021-07-15 13:09:51 +09:00
Dean Herbert
e7b78b1ea5
Adjust transform logic to hopefully be a bit easier to parse
2021-07-13 20:26:05 +09:00
Dean Herbert
4314946e10
Reorganise functions to order more logically (hitcircle before slider methods)
2021-07-13 19:37:17 +09:00
Dean Herbert
6b663037e4
Use switch for pattern matching
2021-07-13 19:37:02 +09:00
Dean Herbert
db8ffc6316
Merge branch 'master' into osu-random-mod-improvements
2021-07-13 19:31:37 +09:00
Naxess
3a5912e35e
Add new checks to verifiers
2021-07-13 10:53:25 +02:00
Naxess
53c0298b5e
Add too short spinners check and tests
2021-07-13 10:51:40 +02:00
Naxess
fec9448301
Add too short sliders check and tests
2021-07-13 10:50:41 +02:00
Bartłomiej Dach
63dedb36de
Rename variable
2021-07-11 16:49:23 +02:00
Bartłomiej Dach
7aecafeecb
Rename constant to reflect its purpose
2021-07-11 16:46:30 +02:00
Henry Lin
c181a724c6
Refactor hit object clamping
2021-07-11 22:01:28 +08:00
Bartłomiej Dach
e10b7867c1
Rewrite method again to hopefully help readability
2021-07-10 12:13:36 +02:00
Dean Herbert
90326f8864
Standardise variables
2021-07-09 13:24:26 +09:00
StanR
02298c2cf4
Fix incorrect curve, move total hits factor into a separate variable for clarity
2021-07-09 00:06:05 +03:00
StanR
592d3fdf00
Cleanup
2021-07-08 11:54:58 +03:00
StanR
c67f756c75
Change approach rate bonuses to be less punishing on mid-length maps
2021-07-08 11:52:43 +03:00
Dean Herbert
88b00123f6
Use existing reflection methods to avoid manual binding of ExtendedLimits
2021-07-08 17:49:00 +09:00
Dean Herbert
bd7c334588
Avoid the need for per-settings control classes
2021-07-08 17:49:00 +09:00
Dean Herbert
a6e94dd491
Add back extended limits support
2021-07-08 17:49:00 +09:00
Dean Herbert
c4313d6e96
Initial implementation of new flow (only working for approach rate)
2021-07-08 17:48:08 +09:00
Dean Herbert
0e4f4a6fde
Initial storage changes
2021-07-08 14:28:13 +09:00
Dean Herbert
d07c469a89
Merge pull request #13783 from smoogipoo/smooth-auto-gen
...
Make osu! auto generator interpolate during key-up frames
2021-07-06 15:04:40 +09:00
Henry Lin
50e316fca4
Merge branch 'master' into osu-target-mod
2021-07-06 12:02:51 +08:00
Bartłomiej Dach
8e102280b7
Revert & disable case with two contradicting inspections
...
Leaving the `false` default value without the suppression triggers
`RedundantArgumentDefaultValue`, while removing it triggers
`BaseMethodCallWithDefaultParameter`.
Disable the former, because a single redundant parameter is less bad
than silent breakage if the default value of `propagateChildren` in the
base method ever changes.
2021-07-05 20:21:44 +02:00
PercyDan54
e1c646b9b2
Remove redundant arguments
2021-07-05 23:52:39 +08:00
smoogipoo
8b7ccdc8b5
Adjust comment
2021-07-05 18:51:23 +09:00
smoogipoo
7d6ab08bb3
Remove unnecessary conditional
2021-07-05 18:49:09 +09:00
smoogipoo
695af31c58
Start alternating at 225BPM as previously
2021-07-05 18:43:27 +09:00
smoogipoo
2b8efe21ca
Don't ease with 0 time difference
2021-07-05 17:52:10 +09:00
smoogipoo
12ca845e55
Use marker class (cleanup)
2021-07-05 17:24:23 +09:00
smoogipoo
6a2c0f772e
Always apply easing, adjust heuristic a bit
2021-07-05 17:22:48 +09:00
smoogipoo
96c0ab8ded
Adjust last frame position when not waiting
2021-07-05 17:11:59 +09:00
Henry Lin
eecf4af029
Rename getSliderBoundingBox and add comments
2021-07-05 09:16:01 +08:00
Dean Herbert
ec71deec51
Remove some mentions of "lazer"
...
I am aware there are more throughout the codebase but intentionally left
the remaining mentioned for one reason or another. The intention here is
to mainly change user-facing versioning to change the positioning of the
"lazer" term (to be where we would expect "cuttingedge" or "beta" to
be).
2021-07-04 12:41:27 +09:00
Henry Lin
d1862d8cff
Rename map to mapRange
2021-07-04 10:01:56 +08:00
Henry Lin
1470bb1563
Use IHidesApproachCircles
2021-07-03 13:02:39 +08:00
Henry Lin
f18c17d1a8
Merge branch 'master' into osu-target-mod
2021-07-03 13:00:52 +08:00
Henry Lin
b0a619bb4c
Prevent multiple enumeration in checkForOverlap
2021-07-01 12:49:34 +08:00
Henry Lin
34be437d7a
Added definitelyBigger
2021-07-01 12:21:41 +08:00
Henry Lin
58f80abe32
Several requested changes
...
- Rename `origHitObjects` to `originalHitObjects`
- Use `Value` instead of `GetValueOrDefault()`
- Remove `endObj`
- Added comments
- Rename `closestIdx` to `precedingIndex`
- Changed an `almostEquals` call
2021-07-01 11:57:57 +08:00
Henry Lin
c69455cfd0
Fixed slider bounding box calculation
2021-07-01 11:20:55 +08:00
Henry Lin
7585f1f790
Move special case handling back to moveSliderIntoPlayfield
2021-07-01 11:03:22 +08:00
Henry Lin
6e1839fcf2
Rename shift_object_count to objects_to_shift_before_slider
2021-07-01 11:03:22 +08:00
Henry Lin
328dcb4d6b
Use Math.Clamp instead of MathHelper.Clamp
2021-07-01 11:03:22 +08:00
Henry Lin
3c1f0452a2
Refactor and rename getMinSliderMargin to getSliderBoundingBox.
2021-07-01 11:03:22 +08:00
Bartłomiej Dach
913f7602e4
Change seed control type in line with changes
2021-06-30 20:41:08 +02:00
Bartłomiej Dach
c0613a3e4f
Merge branch 'master' into osu-target-mod
2021-06-30 20:27:55 +02:00
Salman Ahmed
4b56d94a98
Revert accidentally pushed part of change
2021-06-30 10:26:34 +03:00
Salman Ahmed
e3344c33ea
Better convey reason of "Spin In" incompatibility with "Hidden"
2021-06-30 09:57:15 +03:00
Henry Lin
3f185a0622
Fixed an exception when clamping large sliders
2021-06-30 10:35:06 +08:00
Salman Ahmed
dbe3150f88
Mention about marker interfaces even more explicitly
2021-06-29 11:37:08 +03:00
Salman Ahmed
7997d57030
Mention interfaces being "markers" for the time being
2021-06-29 11:25:35 +03:00
Henry Lin
8d1eae7c70
Use IndexInCurrentCombo
2021-06-29 14:25:45 +08:00
Henry Lin
2722565204
Take circle radius into account when clamping to playfield
2021-06-29 13:36:30 +08:00
Henry Lin
0c5777c2c8
Added comments
2021-06-29 12:56:05 +08:00
Henry Lin
d4ff4b26f5
Split part of addHitSamples to a subroutine
2021-06-29 12:49:25 +08:00
Henry Lin
96e09605d8
Osu random mod improvements
...
- Reduce "jump streams" by increasing maximum jump angle and variance in jump angle
- Reduce weird jumps to sliders by shifting hit circles in front of sliders
2021-06-29 12:33:40 +08:00
Salman Ahmed
69dac018c7
Make OsuModSpinIn as incompatible with other IHidesApproachCircles mods
...
Respecting the TODO comment above it, mark `OsuModSpinIn` as
incompatible with other `IHidesApproachCircles` mods as well.
2021-06-28 21:20:07 +03:00
Salman Ahmed
baf736026b
Mark IHidesApproachCircles mods as incompatible with IRequiresApproachCircles
2021-06-28 21:20:07 +03:00
Salman Ahmed
6a67a6736a
Mark IRequireApproachCircles mods as incompatible with IHidesApproachCircles
2021-06-28 21:20:07 +03:00
