206 Commits

• Merge branch 'master' into edit-nodesample
  Bartłomiej Dach · 2024-06-06 13:42:25 +02:00
  86b13074a0
• Only optimise Catmull segments in osu ruleset
  Dan Balasescu · 2024-04-01 17:22:50 +09:00
  4806ea54f1
• Fix failing tests related to slider ticks
  Andrei Zavatski · 2024-02-17 23:28:35 +03:00
  572f693eec
• Remove list allocations in UpdateNestedSamples
  Dean Herbert · 2024-02-18 03:23:34 +08:00
  0df6e8f595
• Revert sample lookup logic that was not allocating anything
  Dean Herbert · 2024-02-18 03:18:50 +08:00
  0714a4fc1e
• Reduce allocations during beatmap selection
  Andrei Zavatski · 2024-02-17 15:46:38 +03:00
  22f5a66c02
• Revert incorrect end position optimisation

  Closes https://github.com/ppy/osu/issues/26867.
  
  Reverts 882f490390
  and ce643aa68f.
  
  The applied optimisation may have been valid as long as it was
  constrained to `Slider`. But it is not, as `SliderTailCircle` stores a
  local copy of the object position. And as the commit message of
  ce643aa68f states, this could be bypassed
  by some pretty hacky delegation from `SliderTailCircle.Position` to the
  slider, but it'd also be pretty hacky because it would make flows like
  `PositionBindable` break down.
  
  Long-term solution is to probably remove bindables from hitobjects.

  Bartłomiej Dach · 2024-01-31 12:45:42 +01:00
  dfea2ade6d
• Merge remote-tracking branch 'upstream/master' into edit-nodesample
  OliBomby · 2024-01-25 11:33:29 +01:00
  c2d57dc77c
• revert overwriting Position getter in SliderTailCircle

  It would have very weird implications when combined with the position bindable which would be all wrong and stuff

  OliBomby · 2024-01-13 13:54:04 +01:00
  ce643aa68f
• lazy load slider tail position
  OliBomby · 2024-01-13 01:32:37 +01:00
  882f490390
• Adjust comment on Slider's judgement
  Dan Balasescu · 2023-11-10 14:00:34 +09:00
  44c0442f4f
• Correctly propagate classic behaviour flag to tail
  Dean Herbert · 2023-11-09 22:03:22 +09:00
  edef31f426
• Update xmldoc to match flipped flag semantics
  Bartłomiej Dach · 2023-11-02 18:58:14 +01:00
  a0757ce13f
• Simplify classic behaviour flag to only need to be specified on the slider itself
  Dean Herbert · 2023-11-02 18:31:29 +09:00
  bf9f20705f
• Remove redundant passing of Scale to nested objects
  Dean Herbert · 2023-11-02 17:52:10 +09:00
  9af2a5930c
• Rename and invert flags for slider classic behaviours
  Dean Herbert · 2023-11-02 17:43:21 +09:00
  9c1f4b552e
• Fix some new nullable inspections
  Dean Herbert · 2023-10-30 15:10:10 +09:00
  a91b704d21
• Remove usage of LastTick in osu! ruleset
  Dean Herbert · 2023-09-29 16:58:17 +09:00
  dd6d09189e
• Update comments to better explain what LastTick is doing
  Dean Herbert · 2023-09-29 14:40:44 +09:00
  d7119674e8
• Move LegacyLastTickOffset specification to generation code and stop passing everywhere
  Dean Herbert · 2023-09-29 14:32:29 +09:00
  81485c548c
• Adjust slider calculations to new method API

  Code originally read
  
  	Velocity = scoringDistance / beatLength
  		 = BASE_SCORING_DISTANCE * SliderMultiplier * GetPrecisionAdjustedSliderVelocityMultiplier() / beatLength
  
  Given (mathematically, floats are not generally as forgiving):
  
  	GetPrecisionAdjustedBeatLength() = beatLength / GetPrecisionAdjustedSliderVelocityMultiplier()
  
  it follows that (inverting both sides):
  
  	1 / GetPrecisionAdjustedBeatLength() = GetPrecisionAdjustedSliderVelocityMultiplier() / beatLength
  
  and therefore
  
  	Velocity = BASE_SCORING_DISTANCE * SliderMultiplier * GetPrecisionAdjustedSliderVelocityMultiplier() / beatLength
  		 = BASE_SCORING_DISTANCE * SliderMultiplier / GetPrecisionAdjustedBeatLength()
  
  and to recover `scoringDistance`
  
  	scoringDistance = Velocity * beatLength

  Bartłomiej Dach · 2023-09-15 12:30:25 +02:00
  5c6cd879dd
• Fix sliders not always being the correct length

  This is another similar case where stable floating point precision comes
  into play due to use of `hitObjectManager.Beatmap.BpmMultiplierAt` (see
  https://github.com/peppy/osu-stable-reference/blob/1531237b63392e82c003c712faa028406073aa8f/osu!/GameplayElements/HitObjects/Osu/SliderOsu.cs#L680)
  
  Closes #24708.

  Dean Herbert · 2023-09-07 18:20:08 +09:00
  22ee64cfda
• Remove precision limitations of SliderVelocity
  Dean Herbert · 2023-09-07 17:41:58 +09:00
  dcbdc114ce
• Rename SliderVelocity to SliderVelocityMultiplier to distinguish from Velocity
  Dean Herbert · 2023-09-06 19:01:08 +09:00
  1a37543d28
• Add better xmldoc for Slider.Velocity
  Dean Herbert · 2023-09-06 18:58:58 +09:00
  d06490220d
• Ensure populated node samples so new objects have unique node sample lists
  OliBomby · 2023-08-16 20:48:52 +02:00
  cc4e11a5ac
• add min and max value to SliderVelocity
  OliBomby · 2023-04-30 19:32:24 +02:00
  41d4894aa3
• fix ticks not being generated by default
  OliBomby · 2023-04-30 16:03:58 +02:00
  1eb2e35dff
• Remove IContext & add IHasGenerateTicks
  OliBomby · 2023-04-26 13:10:57 +02:00
  6c70948681
• clean up code stuff
  OliBomby · 2023-04-25 19:06:29 +02:00
  e4b64bdc3e
• fix implementations of IHasSliderVelocity
  OliBomby · 2023-04-25 18:22:22 +02:00
  66eda40cdf
• Fixed DifficultyPointPiece
  OliBomby · 2023-04-25 18:12:53 +02:00
  065464d90c
• remove unused directives
  OliBomby · 2023-04-25 13:06:37 +02:00
  97910d6be6
• remove ApplyLegacyInfo method
  OliBomby · 2023-04-25 12:52:21 +02:00
  891b87a5ff
• Add LegacyContext
  OliBomby · 2023-04-25 12:12:46 +02:00
  ea1e6e9798
• made the SampleControlPoint and DifficultyControlPoint obsolete
  OliBomby · 2023-04-25 11:34:09 +02:00
  a4c6850ab2
• Implement hold "sliding" samples in osu!mania
  Dean Herbert · 2022-10-11 16:31:37 +09:00
  f060e6a780
• Remove unused import in Slider
  Khang · 2022-08-24 02:54:40 -04:00
  9c6968e96d
• Remove unnecessary workaround
  Khang · 2022-08-23 14:18:40 -04:00
  ec9daec93b
• Move GenerateTicks to LegacyDifficultyControlPoint and remove support for NaN slider velocity support for other rulesets (at least for now)
  Khang · 2022-08-23 14:07:18 -04:00
  c1ced85b5e
• Use an infinite tick distance instead of directly disabling tick generation for SliderEventGenerator
  Khang · 2022-08-22 23:31:24 -04:00
  a81672f3dc
• Treat NaN slider velocity timing points as 1.0x but without slider ticks
  Khang · 2022-08-22 21:58:38 -04:00
  9f08c474ca
• Update parameter discards
  Dean Herbert · 2022-06-24 21:26:19 +09:00
  31a447fda0
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Merge pull request #17356 from apollo-dw/strict-tracking

  Implement "Strict Tracking" mod in osu!

  Dan Balasescu · 2022-03-22 07:32:36 +09:00
  36772ec652
• Use new mod-related object types for Strict Tracking
  apollo-dw · 2022-03-19 18:29:44 +00:00
  149cfd338d
• Add TailSamples to auxiliary samples list
  Dean Herbert · 2022-03-14 17:19:48 +09:00
  1b8c632b87
• Move slider slide samples to auxiliary specification
  Dean Herbert · 2022-03-14 17:19:48 +09:00
  90e34d7686
• merge in ppy/master
  Xexxar · 2021-10-28 14:47:28 +00:00
  9f5a7526ed
• Merge pull request #15255 from goodtrailer/node-samples-ilist

  Change IHasRepeats.NodeSamples to IList from List

  Dean Herbert · 2021-10-28 14:24:26 +09:00
  5c7623e68e