1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-11 09:27:29 +08:00

revert overwriting Position getter in SliderTailCircle

It would have very weird implications when combined with the position bindable which would be all wrong and stuff
This commit is contained in:
OliBomby 2024-01-13 13:54:04 +01:00
parent fca9b1f536
commit ce643aa68f
2 changed files with 4 additions and 8 deletions

View File

@ -218,6 +218,7 @@ namespace osu.Game.Rulesets.Osu.Objects
{
RepeatIndex = e.SpanIndex,
StartTime = e.Time,
Position = EndPosition,
StackHeight = StackHeight,
ClassicSliderBehaviour = ClassicSliderBehaviour,
});
@ -244,6 +245,9 @@ namespace osu.Game.Rulesets.Osu.Objects
if (HeadCircle != null)
HeadCircle.Position = Position;
if (TailCircle != null)
TailCircle.Position = EndPosition;
}
protected void UpdateNestedSamples()

View File

@ -1,11 +1,9 @@
// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
// See the LICENCE file in the repository root for full licence text.
using System;
using osu.Game.Rulesets.Judgements;
using osu.Game.Rulesets.Osu.Judgements;
using osu.Game.Rulesets.Scoring;
using osuTK;
namespace osu.Game.Rulesets.Osu.Objects
{
@ -17,12 +15,6 @@ namespace osu.Game.Rulesets.Osu.Objects
/// </summary>
public bool ClassicSliderBehaviour;
public override Vector2 Position
{
get => Slider.EndPosition;
set => throw new NotImplementedException();
}
public SliderTailCircle(Slider slider)
: base(slider)
{