221 Commits

• Remove setup screen controls that do nothing useful

  Before I go with a hammer to redesign these, I want to remove stuff that
  does nothing first.
  
  Hard-breaks API to allow rulesets to specify an enumerable of custom
  sections rather than two specific weird ones.
  
  For specific rulesets:
  
  - osu!:
    - Stack leniency slider merged into difficulty section.
  - osu!taiko:
    - Approach rate and circle size sliders removed.
    - Colours section removed.
  - osu!catch:
    - No functional changes.
  - osu!mania:
    - Special style toggle merged into difficulty section.
    - Colours section removed.

  Bartłomiej Dach · 2024-07-10 14:53:16 +02:00
  c8a64c5950
• Update HasFlag usages
  Dean Herbert · 2024-07-03 00:19:04 +09:00
  5350945340
• Initial implemention of the No Release mod

  This commit adds a new osu!mania mod No Release that relaxes tail
  judgements. The current implementation automatically awards Perfect
  (or Meh if the hold note is broken midway) for a hold note tail at
  the end of its Perfect window, as long as it is held by then.
  
  Tests are pending for the next commit.

  Nathan Du · 2024-06-28 22:21:08 +08:00
  960d552dc1
• Split mania difficulty section implementation off completely from base

  - "Circle size" / key count needs completely different handling.
  - Approach rate does not exist in mania.

  Bartłomiej Dach · 2024-06-11 11:30:20 +02:00
  10af642342
• Fully qualify LegacyBeatmapConversionDifficultyInfo
  Dan Balasescu · 2024-04-01 17:02:32 +09:00
  8e0ca11d1c
• Add ability to query key count with mods
  Dan Balasescu · 2024-03-28 22:51:12 +09:00
  10edb54614
• Add mania keycount check
  Arthur Araujo · 2024-03-20 15:52:16 -03:00
  c605e463a4
• Merge pull request #27068 from smoogipoo/mania-hd-fi-progression

  Add progressive coverage for mania's Hidden and FadeIn mods

  Dean Herbert · 2024-02-16 01:00:53 +08:00
  c1d9f53ab4
• Use new LINQ Order() instead of OrderBy() when possible
  Berkan Diler · 2024-02-08 18:01:00 +01:00
  6adf0ac01e
• Add ManiaModCover to take over old roles of the mods
  Dan Balasescu · 2024-02-07 00:15:14 +09:00
  69db1b2778
• Add keycount to song select details panel and carousel panels
  Dan Balasescu · 2023-12-09 22:31:51 +09:00
  b36db3518c
• Change osu!mania conversion mod ordering to be more appeasing
  Dean Herbert · 2023-11-02 15:49:10 +09:00
  c83589cb74
• Add note about why SmallBonus is not listed in GetValidHitResults
  Dean Herbert · 2023-10-13 17:36:30 +09:00
  850950ba61
• Remove remaining usages of LargeTickHit in mania
  Bartłomiej Dach · 2023-10-12 11:16:51 +02:00
  a42e75452e
• Split legacy scoring attributes into a separate object
  Dan Balasescu · 2023-09-07 21:10:38 +09:00
  2334be1987
• Fix "key count" setting showing as "circle size" in osu!mania editor

  Closes https://github.com/ppy/osu/issues/12904.

  Dean Herbert · 2023-07-21 18:52:29 +09:00
  fd2bdc10c7
• Merge branch 'master' into results-screen-component-metrics
  Bartłomiej Dach · 2023-07-13 19:53:52 +02:00
  d5912165e9
• Add missing heading for statistics section in results screen
  Dean Herbert · 2023-07-13 18:50:52 +09:00
  9ad63bae37
• Adjust metrics of SimpleStatisticTable
  Dean Herbert · 2023-07-13 18:45:32 +09:00
  947b40149f
• Implement back-and-forth conversion of ModScoreV2 and LegacyMods
  Bartłomiej Dach · 2023-07-09 16:15:21 +02:00
  7be5e0e978
• ILegacyScoreProcessor -> ILegacyScoreSimulator
  Dean Herbert · 2023-07-04 17:32:54 +09:00
  1629024111
• Move Ruleset method to ILegacyRuleset interface
  Dan Balasescu · 2023-06-29 17:24:37 +09:00
  c6ad184d94
• Return StatisticItems rather than StatisticRows from ruleset

  There were no usages of more than one column being provided per row, so
  it seemed like unnecessarily complexity. I'm currently trying to reduce
  complexity so we can improve the layout of the results screen, which
  currently has up to three levels of nested `GridContainer`s.
  
  Of note, I can't add backwards compatibility because the method
  signature has not changed in `Ruleset` (only the return type). If we do
  want to keep compatibility with other rulesets, we could designate a new
  name for the updated method.

  Dean Herbert · 2023-06-01 14:35:15 +09:00
  985604fab5
• Merge branch 'master' into mod-accuracy-challenge
  Dean Herbert · 2023-01-17 16:46:54 +09:00
  70cb23bbc9
• Remove HP drain from mania
  Dan Balasescu · 2023-01-11 13:01:18 +09:00
  f03677f394
• Add method to get stage from column index
  Dean Herbert · 2022-10-07 15:24:37 +09:00
  dee01abab1
• Fix classic skin colours sourcing from triangles defaults
  Dean Herbert · 2022-10-07 15:24:36 +09:00
  4a127f5d81
• Fix regression in legacy dual stage handling logic
  Dean Herbert · 2022-10-07 15:24:36 +09:00
  3947011baf
• Add back triangles column colours via a transformer
  Dean Herbert · 2022-10-07 15:24:36 +09:00
  5fe9b953a5
• Remove unnecessary Beatmap parameter in ManiaLegacySkinTransformer
  Dean Herbert · 2022-10-07 15:24:36 +09:00
  1a0b953846
• Add base transformer for osu!mania argon skin
  Dean Herbert · 2022-10-04 14:56:46 +09:00
  97207c11f5
• Rename CreateLegacySkinProvider to CreateSkinTransformer and apply to all skins
  Dean Herbert · 2022-09-15 20:18:10 +09:00
  c7f8f948b9
• Move the CreateConvertibleReplayFrame() into the base ruleset class for avoid api breaking change in the customized ruleset.
  andy840119 · 2022-09-10 11:07:23 +08:00
  3d7367a842
• Merge branch 'master' of https://github.com/ppy/osu into remove-the-nullable-disable-in-the-ruleset

  # Conflicts:
  #	osu.Game.Rulesets.Catch/CatchRuleset.cs
  #	osu.Game.Rulesets.Osu/OsuRuleset.cs
  #	osu.Game.Rulesets.Taiko/TaikoRuleset.cs
  #	osu.Game/Rulesets/Ruleset.cs

  andy840119 · 2022-09-10 10:40:12 +08:00
  e62999fb16
• Remove "internal" identifier as unnecessary
  Dean Herbert · 2022-08-29 14:01:15 +09:00
  90b9c02ac6
• Add ruleset API versioning
  Dean Herbert · 2022-08-22 16:35:08 +09:00
  f5710d8000
• Update GetVariantName to also support localisation
  Dean Herbert · 2022-08-22 14:51:00 +09:00
  d199b3b100
• Check if StatisticItem.Name is null or empty
  naoei · 2022-08-20 21:48:53 -04:00
  29ef1c8db8
• Localise hit result name
  naoei · 2022-08-14 14:57:02 -04:00
  45e9eda9e7
• Allow StatisticItem's name param to be nullable
  naoei · 2022-08-14 14:51:35 -04:00
  18ce784ae0
• Remove the nullable disable annotation for all rulesets.
  為什麼 · 2022-07-10 10:15:27 +08:00
  1725a76fa0
• Move CreateConvertibleReplayFrame() into legacy ruleset interface because technically only legacy ruleset use it to convert the legacy frame.

  But seems some of the customized ruleset use it for save the replay frame.

  為什麼 · 2022-07-10 10:15:27 +08:00
  857377e145
• Update parameter discards
  Dean Herbert · 2022-06-24 21:26:19 +09:00
  31a447fda0
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• revert more testing leftovers...
  Gabe Livengood · 2022-05-24 10:56:31 -04:00
  252bacc8d4
• add accuracy challenge mod
  Gabe Livengood · 2022-05-24 10:23:44 -04:00
  dde0756bed
• Remove unnecessary ctor argument
  Dan Balasescu · 2022-03-15 12:37:39 +09:00
  523f668c8c
• Restructure PerformanceCalculator to not require ScoreInfo argument
  Dan Balasescu · 2022-03-14 14:25:28 +09:00
  4a3e3aba65
• Add adaptive speed mod
  Henry Lin · 2022-03-02 09:57:52 +08:00
  c9b205afeb
• Show hit error on results screen

  Leading up to implementation of "local offset", this feels like a good
  thing to have visible first and foremost.

  Dean Herbert · 2022-02-28 19:11:06 +09:00
  a41e1c80f1