61517 Commits

This Branch

This Branch

All Branches

• Fix PopupDialog potentially accumulating schedules during load
  Bartłomiej Dach · 2023-07-16 19:43:37 +02:00
  cd02a8a9ca
• Merge pull request #24246 from bdach/fix-exit-dialog-crash

  Fix potential crash in confirm exit dialog while attempting to exit game

  Dean Herbert · 2023-07-17 01:11:07 +09:00
  acb51dfca3
• Update framework
  Dean Herbert · 2023-07-17 00:55:25 +09:00
  e25cd03e4b
• Remove unused local variable
  Bartłomiej Dach · 2023-07-16 17:10:26 +02:00
  a42992d3fd
• Fix PerformAction<T>() potentially crashing when no matching button is found
  Bartłomiej Dach · 2023-07-16 16:55:20 +02:00
  d25a03984b
• Add failing test covering exit dialog crash
  Bartłomiej Dach · 2023-07-16 16:55:20 +02:00
  72bf43e297
• Merge pull request #24233 from chayleaf/fix-taiko-maps-not-finishing

  Fix taiko maps sporadically not completing with Hidden mod active

  Dean Herbert · 2023-07-16 13:32:38 +09:00
  2023.716.0 50e6f0aee9
• Fix covariant array spec in new test
  Dean Herbert · 2023-07-16 12:48:58 +09:00
  416ee0d99c
• Merge pull request #24235 from AkiSakurai/toplocalrank

  Compute the top local rank directly without an expensive detach call

  Dean Herbert · 2023-07-16 12:14:56 +09:00
  2d51aa21b7
• Merge pull request #24219 from peppy/fix-mania-everything

  Fix osu!mania scores failing to convert to new standardised score due to cast failure

  Dean Herbert · 2023-07-16 11:54:42 +09:00
  cf70f5e04d
• simplify code
  Aki · 2023-07-16 10:21:32 +08:00
  cb354685ca
• Fix nested hits not being hittable if cut off by parent object ending
  Bartłomiej Dach · 2023-07-15 18:44:47 +02:00
  041e818892
• Add failing test case for hitting nested hit past parent end time
  Bartłomiej Dach · 2023-07-15 18:43:31 +02:00
  955aa70e46
• Add inline commentary about OnKilled() override
  Bartłomiej Dach · 2023-07-15 18:22:04 +02:00
  9e960894c2
• Add test coverage for failing hit judgement with HD active
  Bartłomiej Dach · 2023-07-15 18:17:45 +02:00
  24d63a4d96
• Bring back test coverage for fail case from #16475

  It was inadvertently dropped during refactoring in
  b185194d07.

  Bartłomiej Dach · 2023-07-15 18:15:42 +02:00
  542916f857
• move StrongNestedHit OnKilled to DrawableStrongNestedHit
  chayleaf · 2023-07-15 22:33:16 +07:00
  3e91d30825
• Compute the top local rank directly without an expensive detach call
  Aki · 2023-07-15 23:00:13 +08:00
  309c852222
• Fix some taiko maps not finishing in some conditions

  I don't know how to reproduce this issue in a test, so no tests for now.
  Nonetheless, this fixes the issue for me at least on one map:
  https://osu.ppy.sh/beatmapsets/1899665#taiko/3915653
  
  This workaround is similar to #16475 (the test from that commit got
  eventually removed for some reason).

  chayleaf · 2023-07-15 20:24:40 +07:00
  7f957d3fbe
• Flag decoded scores more correctly
  Dean Herbert · 2023-07-15 12:19:18 +09:00
  eb81eac635
• Fix incorrect comparer implementation
  Dean Herbert · 2023-07-15 11:19:34 +09:00
  e58488d04a
• Update framework
  Dean Herbert · 2023-07-15 01:12:10 +09:00
  1868826d69
• Ensure migration is never run on scores with new-enough TotalScoreVersions
  Dean Herbert · 2023-07-14 20:02:25 +09:00
  480259b8d2
• Fix osu!mania scores failing to convert to new standardised score due to cast failure

  Regressed in https://github.com/ppy/osu/pull/23917.
  Closes #24217.

  Dean Herbert · 2023-07-14 19:38:10 +09:00
  d4fb0bef95
• Merge pull request #24199 from peppy/revert-to-default-design-change

  Update design of "revert to default" button

  Bartłomiej Dach · 2023-07-13 23:44:24 +02:00
  cdbb6f90be
• Merge pull request #24197 from peppy/allow-autoplay-failure

  Allow autoplay to fail

  Bartłomiej Dach · 2023-07-13 23:44:07 +02:00
  ff56e35093
• Fix broken test
  Bartłomiej Dach · 2023-07-13 22:28:26 +02:00
  e7dbe3c938
• Merge pull request #24190 from novialriptide/emoji-fix

  Replace emoji unicode with `[emoji]`

  Bartłomiej Dach · 2023-07-13 22:05:12 +02:00
  cef0dd1d61
• Merge pull request #24204 from peppy/results-screen-component-metrics

  Touch up various results screen component's metrics

  Bartłomiej Dach · 2023-07-13 22:03:49 +02:00
  96e4b8d792
• Merge pull request #24183 from Susko3/framework-clipboard

  Resolve `Clipboard` via DI

  Dean Herbert · 2023-07-14 05:01:50 +09:00
  34e3276d23
• Fix mixed [cC]urrent usage
  Bartłomiej Dach · 2023-07-13 22:00:21 +02:00
  9cc2150b5a
• Remove outdated comment
  Bartłomiej Dach · 2023-07-13 21:58:55 +02:00
  3ca767b7a2
• Rewrite test scene to show non-themed and themed variants
  Bartłomiej Dach · 2023-07-13 21:54:30 +02:00
  6b9dabbd3c
• Do not rely on OverlayColourProvider presence
  Bartłomiej Dach · 2023-07-13 21:45:06 +02:00
  eeb50e2700
• Remove unused property
  Bartłomiej Dach · 2023-07-13 21:25:43 +02:00
  674eb1a36b
• Make autoplay compatible with ModFailCondition
  Bartłomiej Dach · 2023-07-13 21:23:57 +02:00
  a1e83b20e6
• Adjust failing test after permitting autoplay and no fail combo
  Bartłomiej Dach · 2023-07-13 21:22:48 +02:00
  ae7ed697ec
• Add some extra text coverage against potential emoji-to-link misparses
  Bartłomiej Dach · 2023-07-13 20:51:52 +02:00
  4859b8c994
• Merge branch 'master' into framework-clipboard
  Dean Herbert · 2023-07-14 03:32:37 +09:00
  ded7ec3aa6
• Update framework
  Dean Herbert · 2023-07-14 03:31:36 +09:00
  4114fab8ea
• Fix taiko statistics table not using 2-column layout
  Bartłomiej Dach · 2023-07-13 20:06:53 +02:00
  632077319f
• Fix differing anchor specs on statistics panel flow items
  Bartłomiej Dach · 2023-07-13 20:00:29 +02:00
  20bde40ce2
• Merge branch 'master' into results-screen-component-metrics
  Bartłomiej Dach · 2023-07-13 19:53:52 +02:00
  d5912165e9
• Merge pull request #24202 from peppy/save-preset-on-select

  Allow saving changes to mod presets using enter key

  Bartłomiej Dach · 2023-07-13 19:50:16 +02:00
  9b771ee798
• Merge pull request #24206 from peppy/results-screen-misc

  Fix some minor issues with results screen

  Bartłomiej Dach · 2023-07-13 19:49:49 +02:00
  16540d69d5
• Merge pull request #24203 from peppy/results-screen-testability

  Make results / statistics visual testing easier with better data population

  Bartłomiej Dach · 2023-07-13 19:43:01 +02:00
  601e3fe24f
• Merge branch 'master' into results-screen-testability
  Bartłomiej Dach · 2023-07-13 19:06:04 +02:00
  56409fa5a5
• Crudely fix crashes when switching between TestResultsWithPlayer cases

  In the visual test browser, if two `TestResultsWithPlayer` test cases
  are ran consecutively, the second would die on `SoloStatisticsWatcher`
  seeing duplicated online score IDs. This surfaced after
  6ef39b87fe, which changed
  `TestResultsScreen` to inherit `SoloResultsScreen` rather than
  `ResultsScreen`.
  
  This is probably _not_ a very good fix, but I'm trying to be pragmatic
  for now. `SoloStatisticsWatcher` should probably not live in
  `OsuGameBase`.

  Bartłomiej Dach · 2023-07-13 19:06:02 +02:00
  4b06b6f34e
• Merge pull request #24191 from peppy/fix-hit-distro-code-quality

  Fix timing distribution graph sometimes not displaying correctly

  Bartłomiej Dach · 2023-07-13 18:35:28 +02:00
  1ed15dc42f
• Merge pull request #24196 from peppy/fix-swell-input-eating

  Fix osu!taiko swells eating input after already being judged

  Bartłomiej Dach · 2023-07-13 17:44:20 +02:00
  aee0f7d967