osu-lazer

Merge branch 'master' into heatmap-misses

Bartłomiej Dach · 2024-03-18 14:43:24 +01:00

c9bbeeb49a

Fix cross-talk between pooled DrawableSliderRepeat usage causing incorrect rotation

Dean Herbert · 2024-03-08 11:37:13 +08:00

fcc35a6acc

Merge pull request #27429 from bdach/rewind-slider-tracking

Fix slider tracking state not restoring correctly in all cases on rewind

Dean Herbert · 2024-03-07 22:41:12 +08:00

646edb239a

Update usage of MathUtils

Dean Herbert · 2024-03-06 12:13:12 +08:00

b53b752e54

Store tracking history to slider judgement result instead

Bartłomiej Dach · 2024-02-29 12:11:50 +01:00

876b806423

Reset slider input manager state completely on new object application

Kind of scary this wasn't happening already.

Mirrors `SpinnerRotationTracker`.

Bartłomiej Dach · 2024-02-29 11:59:19 +01:00

1d1db951f0

Fix slider tracking state not restoring correctly in all cases on rewind

Bartłomiej Dach · 2024-02-29 11:59:15 +01:00

d05b31933f

Fix subscribing to ApplyCustomUpdateState too much

Bartłomiej Dach · 2024-02-28 13:20:41 +01:00

b5ce2642aa

Fix slider tails sometimes not dimming correctly

Originally noticed during review of another change:
https://github.com/ppy/osu/pull/27369#issuecomment-1966140198.

`DrawableOsuHitObject` tries to solve the initial dimming of objects
by applying transform to a list of dimmable parts. For plain drawables
this is safe, but if one of the parts is a DHO, it is not safe,
because drawable transforms can be cleared at will.

In particular, on first use of a drawable slider,
`UpdateInitialTransforms()` would fire via `LoadComplete()` on the
`DrawableSlider`, but *then*, also via `LoadComplete()`,
the `DrawableSliderTail` would update its own state and by doing so
inadvertently clear the dim transform just added by the slider.

To fix, ensure dim transforms are applied to DHOs
via `ApplyCustomUpdateState`.

Bartłomiej Dach · 2024-02-27 11:45:03 +01:00

bbdd85020c

Merge pull request #27369 from Detze/incorrect-slider-head-dim

Fix slider head being incorrectly dimmed twice

Bartłomiej Dach · 2024-02-27 11:17:34 +01:00

087a2a741a

Don't dim slider head in DrawableSlider

Detze · 2024-02-24 21:56:44 +01:00

91d7bd1026

Reduce allocations in DrawableSpinner

Andrei Zavatski · 2024-02-24 20:18:30 +03:00

1fb19e7129

Always process position as long as it's hittable

For example... If a hitobject is pressed but the result is a shake, this
will stop processing hits.

Dan Balasescu · 2024-02-07 03:52:56 +09:00

1f13124b38

Add xmldocs

Dan Balasescu · 2024-02-07 03:52:14 +09:00

e2867986c5

Fix inverted condition

Dan Balasescu · 2024-02-07 03:50:56 +09:00

38f7913b31

Enable NRT for DrawableHitCircle to clean up

Dan Balasescu · 2024-02-07 03:38:07 +09:00

9b8f206486

Show near-misses on the results-screen heatmap

Dan Balasescu · 2024-02-06 22:30:22 +09:00

5850d6a578

Apply further changes to remove remaining weirdness

Bartłomiej Dach · 2024-02-05 13:37:38 +01:00

fb80d76b4a

Merge branch 'master' into hit-object-result-allocations

Bartłomiej Dach · 2024-02-05 13:24:10 +01:00

39fe078984

Refactor result application around again to remove requirement for fields

Co-authored-by: Dean Herbert <pe@ppy.sh>

Bartłomiej Dach · 2024-02-05 13:21:01 +01:00

efe6bb25b1

Merge pull request #26703 from peppy/smaller-slider-misses

Adjust slider tick / end defaults again

Bartłomiej Dach · 2024-01-29 13:51:07 +01:00

2667cb8b36

Merge pull request #26698 from EVAST9919/slider-sample-alloc

Reduce sliding sample allocations in `DrawableSlider`

Dean Herbert · 2024-01-29 20:37:32 +09:00

a3199333bb

Also fix spinner case

Dean Herbert · 2024-01-29 20:36:59 +09:00

034f8c0388

Reduce allocation overheads in SliderInputManager

Dean Herbert · 2024-01-26 17:49:20 +09:00

b6fa50c312

update DrawableHitCircle.ApplyResult to pass this to its callback

Chandler Stowell · 2024-01-25 11:25:41 -05:00

93bd3ce5ae

Remove weird red fade that didn't work

Dean Herbert · 2024-01-25 19:31:57 +09:00

fd9527d523

Update triangles skin judgment display

Dean Herbert · 2024-01-25 19:31:57 +09:00

107b37494e

Fix slider sliding samples allocation

Andrei Zavatski · 2024-01-25 04:06:15 +03:00

21b11092d6

use stack to pass action state when applying hit results

this removes closure allocations

Chandler Stowell · 2024-01-24 13:13:45 -05:00

d2775680e6

Fix slider sometimes not updating relative anchor position

Salman Ahmed · 2024-01-22 02:07:32 +03:00

57b2d018a9

change wording

OliBomby · 2024-01-15 12:51:08 +01:00

96ffe8e737

Clarify comment

OliBomby · 2024-01-15 12:49:40 +01:00

86382f4408

Fix so it reacts to PathVersion with Scheduler

OliBomby · 2024-01-13 12:50:39 +01:00

fca9b1f536

Use invalidation based logic for child anchor position updpates in DrawableSlider

Dean Herbert · 2024-01-09 14:17:33 +09:00

5970a68e2d

Reset child anchor position cache on hitobject position change

Dean Herbert · 2024-01-07 20:55:28 +09:00

962c8ba4ac

Avoid iteration over NestedHitObjects in silder's Update unless necessary

Dean Herbert · 2024-01-07 14:31:22 +09:00

5cc4a586ac

Remove unnecessary second iteration over NestedHitObjects

Dean Herbert · 2024-01-07 14:31:22 +09:00

35eff639cb

Fix spinner max bonus not respecting ISamplePlaybackDisabler

The spinner max bonus was loaded through SkinnableSound instead of PausableSkinnableSound, leading to it not respecting the case where sample playback is globally disabled through ISamplePlaybackDisabler, and can be easily heard in situations like during the catchup period after seeking using the ArgonSongProgressBar with song volume at 0

rushiiMachine · 2023-12-27 12:55:49 -08:00

cf39bb7a18

Fix relax mod not considering full follow area radius when automatically holding sliders

Closes https://github.com/ppy/osu/issues/25947.

Regressed in https://github.com/ppy/osu/pull/25776 with the changes to
`DrawableSliderBall`.

I would have liked to include tests, but relax mod is a bit untestable,
because it disengages completely in the presence of a replay:

	https://github.com/ppy/osu/blob/7e09164d7084265536570ac7036d7244934b651c/osu.Game.Rulesets.Osu/Mods/OsuModRelax.cs#L49-L58

Additionally, `RulesetInputManager` disengages completely from parent
inputs when there is a replay active:

	https://github.com/ppy/osu/blob/7e09164d7084265536570ac7036d7244934b651c/osu.Game/Rulesets/UI/RulesetInputManager.cs#L116

which means there is really no easy way to control positional input
while still having relax logic work. So I'm hoping the fix could be
considered obvious enough to not require test coverage.

Bartłomiej Dach · 2023-12-22 12:50:42 +01:00

7e557152fb

Expose only as one method

Dan Balasescu · 2023-12-21 14:58:23 +09:00

6b4b2a57fc

Relocate HitResult numeric score to ScoreProcessor

Dan Balasescu · 2023-12-21 14:52:31 +09:00

4e3b994142

Add support for showing tick misses

Dean Herbert · 2023-12-20 20:23:19 +09:00

9b383e3276

Fix sliding sample playing before Slider's start time