h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2026-05-20 01:59:54 +08:00
Code Issues Releases Wiki Activity

Merge pull request #26698 from EVAST9919/slider-sample-alloc

Browse Source 
Reduce sliding sample allocations in `DrawableSlider`
This commit is contained in:
Dean Herbert
2024-01-29 20:37:32 +09:00
committed by GitHub
Unverified
parent f1c1d9cb14 034f8c0388
commit a3199333bb
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
osu.Game.Rulesets.Osu/Objects/Drawables/DrawableSlider.cs
+2 -2
View File
@@ -239,11 +239,11 @@ namespace osu.Game.Rulesets.Osu.Objects.Drawables
if (Tracking.Value && Time.Current >= HitObject.StartTime)
{
// keep the sliding sample playing at the current tracking position
if (!slidingSample.IsPlaying)
if (!slidingSample.RequestedPlaying)
slidingSample.Play();
slidingSample.Balance.Value = CalculateSamplePlaybackBalance(CalculateDrawableRelativePosition(Ball));
}
else if (slidingSample.IsPlaying)
else if (slidingSample.IsPlaying || slidingSample.RequestedPlaying)
slidingSample.Stop();
}
}
osu.Game.Rulesets.Osu/Objects/Drawables/DrawableSpinner.cs
+1 -1
View File
@@ -153,7 +153,7 @@ namespace osu.Game.Rulesets.Osu.Objects.Drawables
{
if (tracking.NewValue)
{
if (!spinningSample.IsPlaying)
if (!spinningSample.RequestedPlaying)
spinningSample.Play();
spinningSample.VolumeTo(1, 300);