71086 Commits

This Branch

This Branch

All Branches

• Fix rate adjustments changing the spacing between replay frames
  Dean Herbert · 2025-01-09 13:30:04 +09:00
  c8f72fdbe9
• Add test showing that rate adjustments cause discrepancies in replay frame precision
  Dean Herbert · 2025-01-09 13:30:04 +09:00
  2a7a3d932e
• Merge pull request #31452 from bdach/delete-juice-stream-if-path-degenerates

  Delete entire juice stream when only one vertex remains after deleting another vertex

  Dan Balasescu · 2025-01-09 09:18:29 +09:00
  c72cb016dd
• Merge pull request #31454 from bdach/select-closest-timing-point-on-every-enter

  Select closest timing point every time the timing screen is changed to

  Dan Balasescu · 2025-01-09 09:04:18 +09:00
  520a5e4bfb
• Merge pull request #31450 from peppy/association-manager-cleanup
  Dean Herbert · 2025-01-08 23:38:52 +09:00
  2e10f83b5c
• Select closest timing point every time the timing screen is changed to

  No issue thread for this, was pointed out internally:
  https://discord.com/channels/90072389919997952/1259818301517725707/1316604605777444905
  
  Due to the custom setup that editor has with its nested
  "screens-that-aren't-screens", the logic that selects the closest
  timing point to the current time would only fire on the first open of
  the screen. Seems like a good idea to have it fire every time instead.

  Bartłomiej Dach · 2025-01-08 14:24:46 +01:00
  5a2024777d
• Add explicit ToString() to avoid sending LocalisableString to registry function
  Dean Herbert · 2025-01-08 20:19:38 +09:00
  e131a6c39f
• Enable NRT in test scene
  Bartłomiej Dach · 2025-01-08 11:47:28 +01:00
  87866d1b96
• Delete entire juice stream when only one vertex remains after deleting another vertex

  Closes https://github.com/ppy/osu/issues/31425.

  Bartłomiej Dach · 2025-01-08 11:47:25 +01:00
  9058fd9739
• Add failing test
  Bartłomiej Dach · 2025-01-08 11:39:48 +01:00
  ac19124632
• Merge pull request #31448 from bdach/automatic-new-combo-after-break

  Force new combo on objects succeeding a break

  Bartłomiej Dach · 2025-01-08 11:22:30 +01:00
  e7070bd812
• Only update combo information when any changes happened
  Bartłomiej Dach · 2025-01-08 10:28:06 +01:00
  7c70dc4dc3
• Extend test coverage with combo index correctness checks
  Bartłomiej Dach · 2025-01-08 10:28:04 +01:00
  fbfda2e044
• Merge pull request #31445 from bdach/reset-speed-on-test-play

  Reset playback speed to 100% on entering test play

  Dean Herbert · 2025-01-08 16:16:28 +09:00
  f216c22806
• Change association localisation flow to make logical sense
  Dean Herbert · 2025-01-08 15:57:39 +09:00
  b628880214
• Don't use records they are ugly

  Refactor `WindowsAssociationManager` to be usable

  Dean Herbert · 2025-01-08 15:54:48 +09:00
  d04947d400
• Merge pull request #27920 from peppy/upgrade-packages

  Upgrade packages

  Dan Balasescu · 2025-01-08 14:48:35 +09:00
  22b4f40eb5
• Appease message pack new inspections
  Dean Herbert · 2025-01-08 03:13:29 +09:00
  d5f2bdf6cd
• Upgrade more packages again

  This also downgrades nunit to be aligned across all projects. Getting it
  up-to-date is a bit high effort.

  Dean Herbert · 2025-01-08 03:13:11 +09:00
  6f42b59e31
• Update realm xmldoc references
  Dean Herbert · 2025-01-08 01:35:56 +09:00
  125d652dd8
• Merge branch 'master' into upgrade-packages
  Dean Herbert · 2025-01-08 01:23:28 +09:00
  18ff25bc6d
• Merge pull request #31442 from peppy/supporter-button-always-warns

  Always show dialog when clicking supporter icon before opening browser

  Bartłomiej Dach · 2025-01-07 15:14:53 +01:00
  d0a39a7733
• Merge pull request #31435 from peppy/star-range-display-quality

  Fix star range display looking a bit bad when changing opacity

  Bartłomiej Dach · 2025-01-07 14:58:00 +01:00
  5431a08b35
• Merge pull request #31390 from peppy/slider-end-suppress-fix

  Fix slider end circles not remaining for long enough when hit animations disabled

  Bartłomiej Dach · 2025-01-07 14:49:25 +01:00
  d2918894a0
• Merge pull request #31388 from peppy/fix-reverse-arrow-animation

  Remove use of `Loop` (and transforms) for slider repeat arrow animations

  Bartłomiej Dach · 2025-01-07 14:43:09 +01:00
  bda1c3f6e8
• Force new combo on objects succeeding a break

  No issue thread for this again. Reported internally on discord:
  https://discord.com/channels/90072389919997952/1259818301517725707/1320420768814727229
  
  Placing this logic in the beatmap processor, as a post-processing step,
  means that the new combo force won't be visible until a placement has
  been committed. That can be seen as subpar, but I tried putting this
  logic in the placement and it sucked anyway:
  
  - While the combo number was correct, the colour looked off, because it
    would use the same combo colour as the already-placed objects after
    said break, which would only cycle to the next, correct one on
    placement
  
  - Not all scenarios can be handled in the placement. Refer to one of the
    test cases added in the preceding commit, wherein two objects are
    placed far apart from each other, and an automated break is inserted
    between them - the placement has no practical way of knowing whether
    it's going to have a break inserted automatically before it or not.

  Bartłomiej Dach · 2025-01-07 14:06:23 +01:00
  c93b87583a
• Add test coverage for expected behaviour
  Bartłomiej Dach · 2025-01-07 13:59:26 +01:00
  973f606a9e
• Do not expose track directly in EditorClock

  Intends to stop people from mutating it directly, and going through
  `EditorClock` members like `AudioAdjustments` instead.

  Bartłomiej Dach · 2025-01-07 11:40:18 +01:00
  98bb723438
• Remove unused protected field
  Bartłomiej Dach · 2025-01-07 11:26:08 +01:00
  275e8ce7b7
• Re-route editor tempo adjustment via EditorClock and remove it on gameplay test
  Bartłomiej Dach · 2025-01-07 11:25:00 +01:00
  a5036cd092
• Add failing test
  Bartłomiej Dach · 2025-01-07 11:23:47 +01:00
  3c03406b45
• Mark recommendation test as flaky

  Will revisit during song select refactoring no doubt.

  Dean Herbert · 2025-01-07 17:58:12 +09:00
  b8a10d9b0e
• Fix multiple animation inconsistencies pointed out in review
  Dean Herbert · 2025-01-07 16:54:11 +09:00
  8d913e8971
• Fix star range display looking a bit bad when changing opacity
  Dean Herbert · 2025-01-07 16:42:06 +09:00
  383fda7431
• Refactor StarRatingRangeDisplay test to be more usable
  Dean Herbert · 2025-01-07 16:42:06 +09:00
  a0496c60a4
• Ensure slider is not selectable when body is not visible
  Dean Herbert · 2025-01-07 16:38:22 +09:00
  1648f2efa3
• Merge pull request #31418 from peppy/intro-file-integrity

  Ensure intro files exist in storage during startup

  Bartłomiej Dach · 2025-01-07 08:14:40 +01:00
  01e9c0f15e
• Merge pull request #31306 from bdach/aspire-slider-breakage

  Fix slider event generator incorrectly not generating repeats when tick distance is zero

  Dan Balasescu · 2025-01-07 11:50:18 +09:00
  77d9c955ea
• Merge pull request #31436 from EVAST9919/editor-alloc

  Reduce allocations in the editor caused by `TimelineBlueprintContainer`

  Dan Balasescu · 2025-01-07 11:31:39 +09:00
  638128ba88
• Use cleaner array creation expression
  Andrei Zavatski · 2025-01-07 01:23:19 +03:00
  d35b308745
• Fix allocations in updateSamplePointContractedState
  Andrei Zavatski · 2025-01-07 00:48:58 +03:00
  791ca915e4
• Reduce HitSampleInfo constants allocations
  Andrei Zavatski · 2025-01-07 00:36:58 +03:00
  e8dc09f5bc
• Merge pull request #31433 from bdach/romanised-metadata-ascii-only

  Constrain range of usable characters in romanised metadata to ASCII only

  Dean Herbert · 2025-01-07 03:29:44 +09:00
  1ca28d74a3
• Constrain range of usable characters in romanised metadata to ASCII only

  Closes https://github.com/ppy/osu/issues/31398.
  
  Rationale given in issue.
  
  Compare stable logic:
  
  - https://github.com/peppy/osu-stable-reference/blob/2280c4c436f80d04f9c79d3c905db00ac2902273/osu!/GameModes/Edit/Forms/SongSetup.cs#L118-L122
  - https://github.com/peppy/osu-stable-reference/blob/2280c4c436f80d04f9c79d3c905db00ac2902273/osu!common/Helpers/GeneralHelper.cs#L410-L423
  
  The control character check is a bit gratuitous (text boxes will already
  not allow insertion of those, see
  https://github.com/ppy/osu-framework/blob/e05cb86ff64abd343de49a143ada9734fd160a0a/osu.Framework/Graphics/UserInterface/TextBox.cs#L92),
  but as it's a general helper I figured might as well.

  Bartłomiej Dach · 2025-01-06 14:04:47 +01:00
  3a4497af32
• Don't require track to be playing to fix test failures on some platforms
  Dean Herbert · 2025-01-06 18:27:00 +09:00
  ca9e16387a
• Always show dialog when clicking supporter icon before opening browser

  I managed to do this by accident three times today while testing using
  the dashboard display, so it's time to action on it.
  
  Touched on in
  https://github.com/ppy/osu/discussions/30740#discussioncomment-11345996.
  Was also mentioned recently in discord or another discussion explicitly
  but I can't find that.

  Dean Herbert · 2025-01-06 17:51:04 +09:00
  4f1a6b4688
• Merge pull request #31386 from peppy/fix-applying-offset

  Fix not being able to apply last play offset after returning to song select

  Dan Balasescu · 2025-01-06 11:40:12 +09:00
  448790a76f
• Merge pull request #31414 from frenzibyte/fix-display

  Fix mobile release dialog obstructed by the software keyboard

  Dean Herbert · 2025-01-05 00:37:29 +09:00
  d6e73d75d2
• Reduce nesting slightly
  Dean Herbert · 2025-01-05 00:32:06 +09:00
  37da72d764
• Ensure intro files exist in storage

  Guards against user interdiction.
  
  See
  [https://discord.com/channels/188630481301012481/1097318920991559880/1324765503012601927](recent)
  but not only case of this occurring.

  Dean Herbert · 2025-01-04 15:27:49 +09:00
  72dfdac2e2