Dean Herbert
57e5f5575a
Fix derived API request types firing success when they shouldn't
...
The usual case of `virtual`/`override` being dangerous when logic is
added to the base implementation. As such, I've removed this completely.
2021-07-22 14:23:27 +09:00
Henry Lin
aab7678a69
Truncate beatmap text
2021-07-22 12:18:37 +08:00
Jamie Taylor
507b53dc73
Use 'Soft' hover/select samples for EditorTable row selection
2021-07-21 22:02:40 +09:00
Jamie Taylor
e3d1868af5
Add hover/select sounds to directory/file selector components
2021-07-21 22:02:17 +09:00
Jamie Taylor
cd54653977
Add 'Soft' HoverSampleSet variant
2021-07-21 22:00:13 +09:00
Lucas A
ea4f9b2ac7
Localise beatmap online status pill.
2021-07-21 13:15:07 +02:00
Lucas A
032ced5d16
Localise beatmap explicit content pill.
2021-07-21 13:05:01 +02:00
Dean Herbert
fe9e72d767
Merge pull request #13959 from smoogipoo/fix-beatmaplisting-null-cursor
...
Fix beatmap listing continually paginating when no more beatmaps are available
2021-07-21 19:55:40 +09:00
Derrick Timmermans
9d43ca122f
Allow context menus to be triggered as well
2021-07-21 12:04:09 +02:00
Dan Balasescu
4c63e8e036
Merge pull request #13964 from peppy/fix-mod-overflow
...
Fix mod display overflowing on contracted results panels
2021-07-21 18:52:00 +09:00
Derrick Timmermans
f85ff40a6b
Add back LeftMouse button check
2021-07-21 11:47:21 +02:00
Dean Herbert
adda96ac86
Merge pull request #13962 from ekrctb/platform-action
...
Adapt to framework `PlatformAction` type change
2021-07-21 18:17:38 +09:00
Dean Herbert
a261f1ef8f
Merge pull request #13960 from ekrctb/selection-box-can-flip
...
Allow specifying different value of scaling and flipping support for a selection box
2021-07-21 18:05:18 +09:00
Dean Herbert
399c3b0be8
Rename property, reword xmldoc and improve readability of update code
2021-07-21 17:32:56 +09:00
Dan Balasescu
b390018e64
Merge branch 'master' into fix-mod-overflow
2021-07-21 17:26:47 +09:00
Dan Balasescu
b556d6d382
Merge pull request #13963 from peppy/tidy-mod-display
...
Tidy up `ModDisplay`
2021-07-21 17:26:39 +09:00
Dean Herbert
173334383f
Update framework
2021-07-21 16:56:09 +09:00
Dean Herbert
b910c21230
Add ModFlowDisplay and consume in ContractedPanelMiddleContent
2021-07-21 16:53:04 +09:00
Dean Herbert
b65e607941
Add test covering mod displays with too many mods
2021-07-21 16:43:41 +09:00
Dean Herbert
5bee06fd5f
Remove forgotten AutoSize specification
2021-07-21 16:43:29 +09:00
Dean Herbert
396ad79d50
Remove unnecessary UnbindAll call
2021-07-21 16:43:08 +09:00
Dean Herbert
a63065dbe9
Tidy up ModDisplay
2021-07-21 16:38:25 +09:00
ekrctb
1bac471b49
Adapt to PlatformAction type change
2021-07-21 16:12:53 +09:00
smoogipoo
bcd1a3c232
Use existing bool
2021-07-21 16:04:07 +09:00
ekrctb
1bff4373b3
Allow specifying flipping support of selection box different from scaling
2021-07-21 15:59:45 +09:00
smoogipoo
0118c3638c
Fix beatmap listing continually paginating for null cursors
2021-07-21 15:59:02 +09:00
Dan Balasescu
3121836741
Merge pull request #13942 from peppy/fix-autoplay-results-timestamp
...
Avoid showing time of play on results screen when autoplay
2021-07-21 15:37:31 +09:00
Dan Balasescu
747c475b95
Merge pull request #13932 from peppy/fix-multiple-request-completion-states
...
Fix API request potentially firing failed events after completion
2021-07-21 15:11:03 +09:00
Anton Kovalyov
bfad044b00
Remove unused imports.
2021-07-20 21:57:55 -07:00
Anton Kovalyov
2b0d530075
Eliminate Overlay.KeyBinding namespace and move everything to Settings.Section.Input
2021-07-20 21:18:24 -07:00
Dean Herbert
59dd3452fe
Merge pull request #13954 from bdach/user-profile-beatmap-api-adjustments
...
Adjust user beatmap section naming on profile overlay to match web
2021-07-21 08:21:10 +09:00
Bartłomiej Dach
db9cf443c7
Allow confirming room password by pressing Enter
2021-07-21 00:04:51 +02:00
Derrick Timmermans
a8cf6a6854
Fix slight Y position offset in HandleDrag
2021-07-20 23:00:58 +02:00
Derrick Timmermans
bfec87b082
Let TimelineBlueprintContainer only accept positional input within timeline quad
2021-07-20 22:30:50 +02:00
Bartłomiej Dach
1e634d9db0
Adjust user beatmap sections on profile overlay to match web
2021-07-20 21:55:17 +02:00
emu1337
84fd59777c
Merge branch 'master' into diffspike-balance
2021-07-20 19:39:41 +02:00
Derrick Timmermans
8b09ddbcd6
Merge branch 'ppy:master' into timeline-object-interactions
2021-07-20 16:36:39 +02:00
Salman Ahmed
9d92b795fa
Revert making ComboOffsets legacy and define BeatmapSkinComboIndex instead
2021-07-20 14:15:43 +03:00
Dan Balasescu
738d321788
Merge pull request #13946 from peppy/fix-online-play-sub-screens-not-async-loaded
...
Fix `OnlinePlayScreen` sub-screens not loaded asynchronously
2021-07-20 19:51:13 +09:00
Dean Herbert
3a974d5027
Merge branch 'master' into legacy-beatmap-combo-offset
2021-07-20 19:49:35 +09:00
Dean Herbert
d066ebcd70
Merge pull request #12682 from frenzibyte/refactor-combo-colour-retrieval
...
Refactor combo colours retrieval to use skin config lookups instead
2021-07-20 19:47:57 +09:00
Dean Herbert
16a2e63bd4
Use existing localisation
2021-07-20 19:44:02 +09:00
Dean Herbert
59457743e5
Move further to the right to avoid overlap with toolbox listing
2021-07-20 19:43:52 +09:00
Dean Herbert
9c4fbf45e9
Add the ability to enter and exit the skin editor via on-screen buttons
2021-07-20 19:36:12 +09:00
Dean Herbert
8e1f8c28bd
Use default value to denote no play date, rather than null
2021-07-20 19:05:08 +09:00
Dean Herbert
1a8ab77f21
Revert nullability change
2021-07-20 19:03:29 +09:00
Dan Balasescu
15127f972e
Merge branch 'master' into fix-online-play-sub-screens-not-async-loaded
2021-07-20 18:47:41 +09:00
Dean Herbert
d87ea741ed
Fix OnlinePlayScreen sub-screens not loaded asynchronously
2021-07-20 16:38:39 +09:00
Salman Ahmed
554652b033
Merge branch 'refactor-combo-colour-retrieval' into legacy-beatmap-combo-offset
2021-07-20 10:11:52 +03:00
Salman Ahmed
1af230c48c
Merge branch 'master' into refactor-combo-colour-retrieval
2021-07-20 10:08:25 +03:00
Dean Herbert
fe414b942f
Ensure online play subscreen is loaded before forwarding OnExiting
...
Closes https://github.com/ppy/osu-framework/issues/4619 (actually not a
framework issue; the framework correctly guards against this scenario,
see
4e29504384/osu.Framework/Screens/ScreenStack.cs (L277)
2021-07-20 15:51:34 +09:00
Dean Herbert
662822a40c
Avoid showing time of play on results screen when autoplay
...
Closes https://github.com/ppy/osu/issues/13940 .
2021-07-20 15:19:44 +09:00
Dean Herbert
6cc81c24b4
Merge pull request #13785 from ekrctb/dependency-providing-container
...
Add a convenient way to provide ad-hoc dependency to children in visual test
2021-07-20 14:18:17 +09:00
Dean Herbert
9ea1f5900a
Don't consider version suffixes when checking for updates
...
This is just to make life easier for me with deploys for now.
2021-07-20 01:05:37 +09:00
Dean Herbert
e77597c2b6
Merge pull request #13921 from Game4all/localise-profile-overlay
...
Localise user profile overlay
2021-07-20 00:37:01 +09:00
Dean Herbert
844152e1b1
Merge pull request #13861 from peppy/add-password-support
...
Add multiplayer room password support
2021-07-19 23:32:28 +09:00
Dan Balasescu
6e104fe084
Merge pull request #13894 from peppy/fix-beat-synced-container-alt
...
Fix multiple issues with `BeatSyncedContainer`
2021-07-19 23:19:20 +09:00
smoogipoo
6a55cb9df0
Revert unintended change
...
It's a deeper issue with ScreenStack (see:
https://github.com/ppy/osu-framework/issues/4619 ).
2021-07-19 22:52:07 +09:00
smoogipoo
57a99886d5
Fix password icon not disappearing when no password
2021-07-19 22:31:01 +09:00
smoogipoo
892d858d5f
Fix compile error
2021-07-19 22:23:31 +09:00
smoogipoo
b7c2d6b1ab
Merge branch 'master' into add-password-support
2021-07-19 22:23:09 +09:00
Dan Balasescu
5ef1fe6948
Merge branch 'master' into fix-replay-date
2021-07-19 21:58:37 +09:00
Dan Balasescu
f3bcaf7f11
Merge pull request #13929 from peppy/i-deep-cloneable
...
Create a deep clone of score for score submission purposes
2021-07-19 21:58:27 +09:00
smoogipoo
0a43e54dfc
Fix request failing due to parameters
2021-07-19 21:24:22 +09:00
smoogipoo
a001e4aa16
Fix web request failing if password is null
2021-07-19 20:57:16 +09:00
smoogipoo
3168a927dc
Fix possible exception
2021-07-19 20:50:30 +09:00
Dean Herbert
80c2b1449b
Fix API request potentially firing failed events after completion
...
Specifically, `Cancel()` calls were not thread safe. Due to a series of
events, `ListPollingComponent` could call `Cancel` from a non-update
thread, leading to a race condition where both a `Success` and `Fail`
event can be fired.
This is intended to be the simplest fix possible, locking and guarding
specifically on the callbacks. Further work could be done in the future
to improve the flow surrounding `pendingFailure`, potentially reducing
redundant work and cleaning up the code, but that's not happening here.
Closes https://github.com/ppy/osu/issues/13632 .
2021-07-19 20:27:01 +09:00
smoogipoo
2eec524f27
Fix password not copied from multiplayer client
2021-07-19 20:20:08 +09:00
smoogipoo
d6aa15e5d7
Remove local APIRoom from test multiplayer client
2021-07-19 20:19:23 +09:00
smoogipoo
a5a0f12e19
Also copy password in test room manager
2021-07-19 20:07:56 +09:00
smoogipoo
26d0eea485
Set HasPassword correctly in the response room
2021-07-19 20:03:32 +09:00
smoogipoo
2515785f93
Use room password to fill settings textbox
2021-07-19 20:03:32 +09:00
smoogipoo
8c0daa89a0
Make test multiplayer client validate password
2021-07-19 20:03:27 +09:00
smoogipoo
063f14da98
Update test room manager to not return passwords
2021-07-19 20:03:27 +09:00
Dean Herbert
b3f60c8253
Fix date being updated on replays unexpectedly
2021-07-19 19:28:35 +09:00
Dean Herbert
f16b4957aa
Move clone to earlier in the process
2021-07-19 19:18:34 +09:00
Dean Herbert
23ef666f34
Merge pull request #13887 from ekrctb/legacy-converted-y
...
Preserve Y position of hit objects in osu!catch
2021-07-19 18:48:23 +09:00
Dan Balasescu
f1f6af88a1
Merge pull request #13926 from peppy/set-rank-on-failed-submission
...
Set score's rank on a failed submission
2021-07-19 18:45:21 +09:00
Dan Balasescu
473011070f
Merge pull request #13908 from peppy/editor-disallow-placement-when-untimed
...
Fix editor composer allowing object placement without timing present
2021-07-19 18:37:19 +09:00
Dean Herbert
13cb658d29
Mark identifiers as verbatim strings
2021-07-19 18:15:09 +09:00
Dean Herbert
80539fefe1
Merge branch 'master' into localise-profile-overlay
2021-07-19 18:14:59 +09:00
Dean Herbert
b29209d13f
Ensure tool is always set back to select tool when beatmap becomes untimed
2021-07-19 17:08:40 +09:00
Dean Herbert
bde35d9f21
Rename radio button classes to be local to editor
2021-07-19 16:57:12 +09:00
ekrctb
87c39909c6
Simplify DependencyProvidingContainer
...
Using an array of tuple for dependencies instead of using children.
2021-07-19 14:37:19 +09:00
Dean Herbert
caba78cb5d
Copy score during submission process to ensure it isn't modified
2021-07-19 14:14:28 +09:00
Dean Herbert
e507faef29
Add deep cloning support to Score/ScoreInfo/Replay
2021-07-19 14:14:28 +09:00
Dean Herbert
3c028ce05c
Add IDeepCloneable interface and update existing CreateCopy methods to use it
2021-07-19 12:54:17 +09:00
Dean Herbert
d7f997a7f3
Set score's rank on a failed submission
...
As we don't have a `RankInfo.F`, this is the next best choice. I am also
adding a check osu-web side for this - this is just to make sure we
aren't sending scores with SS when they are not actually completed.
I'm working on a separate PR to ensure this does not get mutated during
the player exit process.
2021-07-19 12:36:15 +09:00
Bartłomiej Dach
fb5d25405e
Replace calls to obsoleted GetOrDefault() extension
2021-07-18 21:52:16 +02:00
Lucas A
80885301a3
Fix codefactor issues.
2021-07-18 19:36:34 +02:00
Lucas A
9257cd7fad
Revert the use of an enum in ProfileHeader.
2021-07-18 19:18:06 +02:00
Lucas A
77807f9e32
Merge branch 'master' into localise-profile-overlay
2021-07-18 19:14:05 +02:00
Derrick Timmermans
2e2a2bdd99
Allow moving timeline selection when mousedown event is outside of blueprint container
2021-07-18 18:06:59 +02:00
Derrick Timmermans
ee220feecf
Avoid using guesses to determine whether inputs blocked
2021-07-18 16:04:23 +02:00
Lucas A
2c26248042
Localise missing text of PaginatedKudosuHistoryContainer.
2021-07-17 17:36:49 +02:00
Lucas A
28845364a3
Localise score weighting.
2021-07-17 16:52:35 +02:00
Lucas A
77d8f240f8
Use ctor default values.
2021-07-17 16:41:42 +02:00
Lucas A
a7c280508f
Throw instead of silently returning.
2021-07-17 16:40:37 +02:00
Lucas A
2545275f71
Partly localise Kudosu section.
2021-07-17 16:29:09 +02:00
Lucas A
148eb890ff
Localise Historical section.
2021-07-17 16:24:11 +02:00
Lucas A
2f3ed4a4ab
Fix PaginatedProfileSubsection ctor arguments
2021-07-17 16:13:33 +02:00
Lucas A
fbbf8ce5a3
Localise Ranks section.
2021-07-17 15:53:24 +02:00
Lucas A
d17f658985
Localise Recent section.
2021-07-17 15:50:56 +02:00
Lucas A
5bb45c7f84
Localise beatmap section.
2021-07-17 15:45:17 +02:00
kj415j45
f4eeb9139e
Correct code style
2021-07-17 21:37:58 +08:00
Lucas A
d36842aa15
Localise TopHeaderContainer
2021-07-17 15:32:28 +02:00
Dean Herbert
c6bc95767d
Simplify popover hide logic and add test coverage
2021-07-17 22:31:47 +09:00
Lucas A
213e3c0716
Localise DetailHeaderContainer
2021-07-17 15:29:34 +02:00
Lucas A
c6a27e4baa
Localise CentreHeaderContainer.
2021-07-17 15:27:40 +02:00
Lucas A
2cfec1dc32
Localise osu!supporter badge.
2021-07-17 15:26:18 +02:00
Lucas A
a0c6945f8f
Localise user graph.
2021-07-17 15:25:45 +02:00
Lucas A
306a34a802
Localise level badge tooltip.
2021-07-17 15:21:30 +02:00
kj415j45
0183564810
Merge branch 'localisation-base' of https://github.com/kj415j45/osu into localisation-base
2021-07-17 21:19:14 +08:00
Lucas A
4d276b114b
Localise profile header.
2021-07-17 15:18:45 +02:00
kj415j45
ca1080dfb5
use switch statement
...
Co-authored-by: bdach <dach.bartlomiej@gmail.com>
2021-07-17 21:16:57 +08:00
Lucas A
d9c7ea2026
Localise profile section titles.
2021-07-17 14:57:05 +02:00
Lucas A
e6b8307b8e
Localise ProfileHeader
2021-07-17 14:46:14 +02:00
bdach
7859d02c5b
Allow null for breadcrumb control
2021-07-17 20:33:26 +08:00
LiangXiang Shen
6bebb1fdb9
Merge branch 'master' into localisation-base
2021-07-17 19:50:52 +08:00
huoyaoyuan
e3c10e3994
Add missing LocalisableString
2021-07-17 19:40:32 +08:00
kj415j45
22ff40fdd5
Fix broken WikiHeader
2021-07-17 19:40:25 +08:00
huoyaoyuan
5b694ad28b
Replace string with LocalisableString
2021-07-17 19:37:32 +08:00
Dean Herbert
64cf9b702e
Fix incorrec nesting of manual input manager test containers
2021-07-17 17:26:11 +09:00
Dean Herbert
c966cb0530
Fix dependency lookup failing due to location of PopoverContainer
2021-07-17 15:04:18 +09:00
Dean Herbert
d609839ff6
Fix test not working due to popover container being too global
2021-07-17 15:04:00 +09:00
Dean Herbert
87d3bd4b93
Fix time until next beat potentially being exactly zero at point of trigger
2021-07-17 14:35:43 +09:00
Dean Herbert
50eed26bd1
Rename radio button item to label
2021-07-17 02:32:23 +09:00
Dean Herbert
eac9b1ec7e
Disable toolbox composition buttons when beatmap is not timed
2021-07-17 02:30:13 +09:00
Dean Herbert
3ae5f6707a
Expose whether an EditorBeatmap has timing present or not via bindable
2021-07-17 02:30:00 +09:00
Dean Herbert
7a671754f2
Change RadioButton's object to a string
2021-07-17 02:29:31 +09:00
Derrick Timmermans
e35cff99c7
Pass on mouseDown input to timeline if no selection modification is made with that input
2021-07-16 17:21:43 +02:00
Dan Balasescu
6eed857d63
Merge branch 'master' into input-settings-localisation
2021-07-16 23:25:25 +09:00
Dan Balasescu
da7e880e46
Merge pull request #13893 from peppy/mouse-settings-localisation
...
Add localisation coverage of `MouseSettings`
2021-07-16 23:25:12 +09:00
Derrick Timmermans
3e8a13bfbf
Allow interacting with timeline objects outside of drawable bounds
2021-07-16 16:16:34 +02:00
Dean Herbert
7df7137c88
Add localisation support for remaining input settings sections
2021-07-16 23:03:55 +09:00
Dean Herbert
b3d89254a9
Bump LocalisationAnalyser for new key generation
2021-07-16 23:03:55 +09:00
Gagah Pangeran Rosfatiputra
8541e73fc1
use text flow in markdown image caption
2021-07-16 16:26:15 +07:00
Dean Herbert
b6996d647e
Add ability to disable mistimed event firings
2021-07-15 16:22:48 +09:00
Dean Herbert
d0fc258886
Remove unused OsuLogo.BeatMatching
2021-07-15 15:11:42 +09:00
Dean Herbert
98a1f40a98
Ensure EarlyActivationMilliseconds is applied even in idle state
2021-07-15 15:10:14 +09:00
Dean Herbert
c47ff1919c
Fix regression in idle behaviour and refactor further
2021-07-15 14:56:49 +09:00
Dean Herbert
5ecf6511e6
Fix default timing points being used if "track" is not running
2021-07-15 14:41:50 +09:00
Dean Herbert
a3129ad00e
Refactor BeatSyncedContainer to support GameplayClock
2021-07-15 14:37:13 +09:00
Dean Herbert
3f3adfe297
Add localisation support for MouseSettings
2021-07-15 13:09:51 +09:00
Dean Herbert
d58534dce6
Update CommonStrings to latest localiser tools output
2021-07-15 13:09:51 +09:00
Dean Herbert
5b91111eda
Update SettingsSubsection.Header to accept a LocalisableString
2021-07-15 13:09:51 +09:00
Dean Herbert
687c9aa33d
Add tooltip and keywords for "high precision" setting
2021-07-15 12:37:52 +09:00
Dean Herbert
9d693c75cf
Add Schedule to restore password text box focus behaviour
2021-07-14 23:56:52 +09:00
Dean Herbert
cc09a8b5ba
Update to use OsuPopover implementation
2021-07-14 23:55:46 +09:00
Dean Herbert
b5dd9403b1
Merge branch 'master' into add-password-support
2021-07-14 23:53:03 +09:00
