325 Commits

• Remove unused method
  Dan Balasescu · 2022-07-26 14:15:59 +09:00
  1b2158ff04
• Mark SetupZoom and parameterless ZoomableScrollContainer ctor as protected
  Salman Ahmed · 2022-07-25 12:07:50 +03:00
  48bcf57066
• Fix Timeline attempting to setup zoom with unloaded track
  Salman Ahmed · 2022-07-25 12:07:50 +03:00
  07c6b44864
• Refactor ZoomableScrollContainer to allow setting up zoom range and initial zoom after load
  Salman Ahmed · 2022-07-25 12:07:50 +03:00
  123930306b
• Fix timeline zoom focus point when using buttons
  Dan Balasescu · 2022-07-22 17:03:05 +09:00
  e1df50c8ff
• Merge pull request #19294 from peppy/fix-timeline-feedback-loop

  Fix timeline `alt`+`scroll` zoom not correctly zooming to current mouse position

  Dean Herbert · 2022-07-22 16:05:38 +09:00
  72916d708c
• Fix timeline zoom receiving feedback from bindable changes

  This causes the focal point zooming to not work (as the focal point is
  lost). There's no need to handle ongoing changes to
  `BeatmapInfo.TimelineZoom` because it is not a property which is changed
  at runtime.

  Dean Herbert · 2022-07-22 15:25:57 +09:00
  6eb42d08ce
• Combine both calls to use same pathway
  Dean Herbert · 2022-07-22 14:59:20 +09:00
  4cec9a085a
• Fix zoom delta math
  Adam Baker · 2022-07-21 17:29:13 -05:00
  997fe00cdc
• Extract zoom delta method
  Adam Baker · 2022-07-21 17:28:43 -05:00
  d69dc457ba
• Make zoom sensitivity relative to containers max zoom
  Adam Baker · 2022-07-21 08:26:48 -05:00
  a4f071fe53
• Update parameter discards
  Dean Herbert · 2022-06-24 21:26:19 +09:00
  31a447fda0
• Remove unnecessary null casts
  Dean Herbert · 2022-06-24 14:50:11 +09:00
  f71f6302fd
• Convert == usages to ReferenceEquals
  Dan Balasescu · 2022-06-20 16:56:19 +09:00
  e0c82d11ab
• Fix BlueprintContainer eating input from skin editor buttons
  Salman Ahmed · 2022-06-18 18:28:36 +03:00
  a5e5172b91
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Merge pull request #18649 from frenzibyte/selection-context-outside-bounds

  Fix context menus not appearing when clicking outside of editor playfield's bounds

  Dean Herbert · 2022-06-15 17:08:09 +09:00
  87bf53485a
• Split zoom updating to named method with value as optional
  Salman Ahmed · 2022-06-15 07:57:16 +03:00
  d3feb07bc1
• Fix ZoomableScrollContainer attempting to update zoom with overlapping range
  Salman Ahmed · 2022-06-15 05:43:41 +03:00
  268a7e1334
• Remove no longer necessary ReceivePositionalInputAt overrides in timeline components
  Salman Ahmed · 2022-06-14 00:19:47 +03:00
  fa4930c586
• Merge pull request #18462 from frenzibyte/fix-timeline-zooming

  Fix timeline objects disappearing prematurely on wide-screens

  Dan Balasescu · 2022-06-05 11:49:44 +09:00
  b897e1464f
• Remove unnecessary nesting of IconButton and update design a touch
  Dean Herbert · 2022-06-03 17:00:00 +09:00
  cd3edc869c
• Share button repeating logic with TimelineButton for better UX
  Salman Ahmed · 2022-06-03 05:23:49 +03:00
  b51e0a5047
• Fix ZoomableScrollContainer not updating on parent size changes
  Salman Ahmed · 2022-06-03 02:34:10 +03:00
  21385655fe
• Revert "Fix timeline objects disappearing prematurely on wide-screens"

  This reverts commit 02baf9a97a.

  Salman Ahmed · 2022-06-03 02:03:04 +03:00
  60fb5d5e6c
• Merge branch 'master' into fix-timeline-zooming
  Salman Ahmed · 2022-06-03 02:00:09 +03:00
  8471b24659
• Merge pull request #18477 from frenzibyte/fix-timeline-context-menu

  Fix context menu no longer opening for hitobjects in timeline

  Dan Balasescu · 2022-05-30 11:49:06 +09:00
  be998cdb0a
• Fix wrong sizing of editor timeline ticks
  Bartłomiej Dach · 2022-05-29 20:15:17 +02:00
  c892ec83ef
• Fix context menu no longer open on hitobjects in timeline
  Salman Ahmed · 2022-05-29 15:23:32 +03:00
  9cc5df9b13
• Fix timeline objects disappearing prematurely on wide-screens
  Salman Ahmed · 2022-05-28 17:45:38 +03:00
  02baf9a97a
• Merge branch 'master' into editor-tidy-up
  Dan Balasescu · 2022-05-25 11:58:34 +09:00
  f468d1eb16
• Merge branch 'master' into editor-beat-divisor-size-static
  Bartłomiej Dach · 2022-05-24 23:17:02 +02:00
  5f6baaca13
• Update timeline colours and paddings to match new designs
  Dean Herbert · 2022-05-24 18:43:22 +09:00
  a905731053
• Move beat divisor tick size retrieval to static methods
  Dean Herbert · 2022-05-24 18:15:20 +09:00
  4a88affd03
• Fix Timeline potentially not updating visuals to correct state on first display
  Dean Herbert · 2022-05-24 18:11:05 +09:00
  1137545d4a
• Merge pull request #18236 from peppy/snap-unification

  Add `enum` to snap method as alternative to multiple nested invocations

  Dan Balasescu · 2022-05-20 11:35:05 +09:00
  64a371638e
• Allow localisation of PlaceholderText
  Dean Herbert · 2022-05-17 17:42:46 +09:00
  83e781d5a1
• Add enum to snap method as alternative to mutliple nested invocations
  Dean Herbert · 2022-05-12 16:19:07 +09:00
  c0abce918f
• Merge pull request #18220 from frenzibyte/control-popover-focus

  Focus textbox upon opening control point popovers

  Dean Herbert · 2022-05-11 19:41:25 +09:00
  5800d7e99d
• Focus textbox on control point popovers
  Salman Ahmed · 2022-05-11 09:55:34 +03:00
  96db530de6
• Fix timeline not handling mouse down events
  Salman Ahmed · 2022-05-11 09:39:27 +03:00
  0b597e712e
• Merge branch 'master' into cache-at-interface
  Dean Herbert · 2022-05-05 18:54:24 +09:00
  e83604a1fc
• Move snap provider caching to interfaces
  Dean Herbert · 2022-05-05 16:44:37 +09:00
  1c6a233cc0
• Add xmldoc and rename methods in IPositionSnapProvider for legibility
  Dean Herbert · 2022-05-05 15:58:21 +09:00
  f6fc926f1a
• Move distancing methods from IPositionSnapProvider to IDistanceSnapProvider
  Salman Ahmed · 2022-04-28 05:48:45 +03:00
  59cf3ff50f
• Merge branch 'master' into osu-distance-spacing
  Salman Ahmed · 2022-04-24 05:23:30 +03:00
  4f8f27a58b
• Allow tabbing between textboxes in sample point popover
  Bartłomiej Dach · 2022-03-06 01:43:56 +01:00
  e1eeb9c6bb
• Add flow for changing set of valid divisors between presets
  Bartłomiej Dach · 2022-02-27 15:37:51 +01:00
  d0c01afc2e
• Change "distance spacing" multipler type to double

  Avoids losing precision on initial load, causing an unnecessary
  hash change in `EditorChangeHandler`.
  
  Resolves test failures in `TestSceneEditorChangeStates`
  (https://github.com/ppy/osu/runs/5192493482?check_suite_focus=true).

  Salman Ahmed · 2022-02-16 03:28:12 +03:00
  0992bec2c8
• Expose distance spacing in IPositionSnapProvider for updating distance grid

  Alternate method is to expose a `SnapDistancesChanged` event in
  `IPositionSnapProvider` instead, but I chose this way as an analogue to
  `IBeatSnapProvider.BeatDivisor`, which might even make sense to be
  exposed as `BindableBeatDivisor` instead of caching that separately.

  Salman Ahmed · 2022-02-15 02:21:53 +03:00
  528dc03b8c