1091 Commits

• Mark IHasRecordingHandler.Recorder nullable
  Bartłomiej Dach · 2023-06-26 18:52:05 +02:00
  cc45ec4fff
• Split out interfaces from RulesetInputManager and improve xmldoc
  Dean Herbert · 2023-06-26 16:34:57 +09:00
  084354a8dc
• Remove unused interface
  Dean Herbert · 2023-06-26 16:32:19 +09:00
  c8e081c2b6
• Merge branch 'master' into hud/kc-skinnable
  tsrk · 2023-06-25 15:42:08 +02:00
  350d722c8d
• revert: bring back old attachment flow

  As discussed, this would bring more problems that anything.
  
  Refs: 4c39708, f83a4f4

  tsrk · 2023-06-25 15:21:55 +02:00
  a7088ffe22
• Merge pull request #23976 from peppy/gameplay-sample-trigger-source-correctness

  Adjust `GameplaySampleTriggerSource` to only switch samples when close enough to the next hit object

  Bartłomiej Dach · 2023-06-25 08:23:55 +02:00
  25842105ce
• Merge branch 'master' into mass-nrt
  Dean Herbert · 2023-06-24 09:59:15 +09:00
  2bda63c2c8
• Manual fixes to reduce warnings to zero
  Dean Herbert · 2023-06-24 01:52:53 +09:00
  df5b389629
• Automated pass
  Dean Herbert · 2023-06-24 01:00:03 +09:00
  0ab0c52ad5
• Change "floating fruits" mod to only apply adjustments to the playfield

  Avoids things like touch screen inputs also being flipped.
  
  Note that these adjustments can't be applied directly to the playfield
  due to how playfields are used in various rulesets (basically relying on
  the `PlayfieldAdjustContainer` to get things in the right place).
  
  Closes #24000.

  Dean Herbert · 2023-06-23 14:18:43 +09:00
  08b3c0cce0
• Fix nested logic not being completely correct (favouring already-passed rather than near-future)
  Dean Herbert · 2023-06-23 13:48:13 +09:00
  64b726d5ec
• Remove redundant parentheses
  Bartłomiej Dach · 2023-06-22 20:02:10 +02:00
  79606317ab
• Make IGameplayClock optional in GameplaySampleTriggerSource to ease testing
  Dean Herbert · 2023-06-21 17:33:42 +09:00
  4ff5275208
• Apply NRT to GameplaySampleTriggerSource
  Dean Herbert · 2023-06-20 21:03:55 +09:00
  cb07f2399f
• Use IGameplayClock to ensure our clock source is correct
  Dean Herbert · 2023-06-20 20:47:56 +09:00
  04dad6c6e8
• Fix nested lookups
  Dean Herbert · 2023-06-20 20:45:02 +09:00
  0e86102681
• Add back optimisation and increase time allowance slightly
  Dean Herbert · 2023-06-20 20:30:07 +09:00
  786d5a394b
• Adjust GameplaySampleTriggerSource to only switch samples when close enough to the next hit object

  Closes #23963.
  
  To simplify things, I've removed the optimisation of using
  `AliveObject`s because it would break the way this whole lookup works.

  Dean Herbert · 2023-06-20 20:06:07 +09:00
  555ce7684b
• refactor: tidy up attachement flow

  TODO: find better naming and improve XMLDocs

  tsrk · 2023-06-18 22:57:21 +02:00
  f83a4f4952
• style(KeyCounterController): remove reliance on Receptor
  tsrk · 2023-06-18 21:26:16 +02:00
  141f9efad5
• refactor: remove detachment logic

  No real use case, cleaning up the diff

  tsrk · 2023-06-15 12:24:37 +02:00
  b4cbcb210e
• Merge branch 'master' into hud/kc-skinnable
  tsrk · 2023-06-14 22:19:45 +02:00
  42b740a175
• refactor: decouple Trigger logic from KeyCounterDisplay

  This allows to keep a coeherent state regardless of the progress of the play

  tsrk · 2023-06-14 21:13:35 +02:00
  c637fddf73
• Remove redundant nullable suppression directives
  Salman Ahmed · 2023-06-07 08:20:41 +03:00
  62cb6a98ca
• Fix gameplay playfield border being affected by beatmap track time

  Closes https://github.com/ppy/osu/issues/23470.

  Dean Herbert · 2023-06-06 16:08:24 +09:00
  c0016fa5d2
• feat: integrate attachment flow in SkinComponentsContainer
  tsrk · 2023-06-06 00:27:43 +02:00
  6fc6729677
• refactor: improve attachement flow

  This removes the hard reliance on individual classes and makes its usage easiser to ingreate anywhere
  else.

  tsrk · 2023-06-06 00:12:53 +02:00
  4c397085c5
• Fix OverlappingScrollAlgorithm returning incorrect results for TimeAt before first control point
  Dean Herbert · 2023-05-26 19:59:19 +09:00
  cb468fa4ec
• Add failing test cases for drum roll/swell sample playback
  Bartłomiej Dach · 2023-05-21 18:57:01 +02:00
  5229cf7343
• Fix hold-for-right-click showing during gameplay
  Dean Herbert · 2023-05-13 21:32:30 +09:00
  8c542c6c51
• Apply nullability in related classes and remove unused variable
  Dean Herbert · 2023-05-08 17:09:08 +09:00
  1b7dd32eb1
• remove other usages of hitobject SampleControlPoint
  OliBomby · 2023-04-25 16:01:43 +02:00
  ebe1d852f5
• Apply changes to custom ShaderManager
  Dan Balasescu · 2023-04-18 11:31:56 +09:00
  c0a25144cf
• Fix SampleStore isn't being disposed
  Andrei Zavatski · 2023-04-06 11:40:04 +03:00
  ed565b1e59
• Fix incorrect indent
  Bartłomiej Dach · 2023-04-05 19:47:25 +02:00
  e5d57a65c9
• Merge branch 'master' into gameplay/key-counter-abstraction
  Bartłomiej Dach · 2023-04-05 19:45:14 +02:00
  432f698697
• Fix abysmal debug performance due to try-catch logic in DrawableRulesetDependencies
  Dean Herbert · 2023-04-03 18:04:33 +09:00
  7011928d86
• Merge branch 'master' into gameplay/key-counter-abstraction
  Dean Herbert · 2023-04-03 15:33:35 +09:00
  b0c09df259
• Fix ruleset-local shader manager not correctly falling back to existing cached shaders
  Dean Herbert · 2023-03-28 15:00:49 +09:00
  0d77ec013a
• Update DrawableRulesetDependencies xmldoc to read more correctly
  Dean Herbert · 2023-03-28 14:15:19 +09:00
  c742b3f0a8
• Rename Add/AddRange methods as they are no longer conflicting with Container
  Dean Herbert · 2023-03-15 18:02:41 +09:00
  5f9b13a775
• Merge pull request #22527 from Terochi/replay-length-extension

  Replay recording extension until results screen transition

  Dan Balasescu · 2023-03-11 15:41:32 +09:00
  e327993d11
• refactor: make KCD a CompositeDrawable
  tsrk · 2023-03-08 00:47:16 +00:00
  44297a7d0a
• Move KeyCounter components to HUD namespace
  Dean Herbert · 2023-03-07 16:41:39 +09:00
  28520414aa
• Merge branch 'master' into gameplay/key-counter-abstraction
  Dean Herbert · 2023-03-07 16:09:45 +09:00
  8f6df5ea0f
• Merge pull request #22659 from peppy/fix-taiko-drum-nested-sample-detection

  Fix `GameplaySampleTriggerSource` not considering nested objects when determining the best sample to play

  Bartłomiej Dach · 2023-02-22 18:56:59 +01:00
  d679703fa2
• refactor(KeyCounterDisplay): apply suggestions

  I also took the freedom to add type checking, as we can't limit the
  usage of `Add()` since it's a Container. The exception thrown also
  advises of using the suggested `AddTrigger()` instead.

  tsrk · 2023-02-22 14:58:27 +00:00
  1beec71037
• Merge pull request #22635 from peppy/use-overlays-container-more

  Use `Overlays` container rather than `KeyBindingInputManager` for flashlight

  Dean Herbert · 2023-02-22 18:30:21 +09:00
  a8c692a215
• Remove contradictory remark from xmldoc
  Bartłomiej Dach · 2023-02-21 21:05:46 +01:00
  ab97b02235
• Move DrawableRuleset.Audio to a less generic level
  Dean Herbert · 2023-02-21 19:03:52 +09:00
  1acc536248