Dan Balasescu
844c023fb7
Fix tests
2023-05-23 18:18:27 +09:00
Cootz
c3f06ad2db
Merge branch 'master' into add-mod-search-option
2023-05-23 08:55:57 +03:00
Cootz
a226caff56
Fix testing
2023-05-06 11:09:44 +03:00
Cootz
f0d35eb12b
Update testing
2023-05-03 13:12:11 +03:00
Dean Herbert
384693a431
Fix test failure in MultiplayerMatchSongSelect due to multiple overlays present
...
https://github.com/ppy/osu/actions/runs/4868337922/jobs/8681736995?pr=23308 .
2023-05-03 14:30:58 +09:00
Salman Ahmed
20f4061e30
Move ongoing operation wait step to proper place
2023-01-29 00:24:15 +03:00
Dean Herbert
e8770b84cd
Remove no longer necessary interface type
2023-01-18 15:23:55 +09:00
Dean Herbert
65bd2e74fd
Merge branch 'master' into skin/argon-song-progress-cleaner
2023-01-17 18:00:42 +09:00
Salman Ahmed
f63de55a20
Mark ready-button-pressing multiplayer tests with FlakyTest attribute
2023-01-16 22:34:32 +03:00
Salman Ahmed
1a776eb546
Mark item-mutating queue mode tests with FlakyTest attribute
2023-01-16 22:34:04 +03:00
tsrk
0f1fe1d683
refactor(hud/gameplay/SongProgress): Add interface to designate SongProgressBars
2023-01-09 21:48:53 +01:00
Joseph Madamba
49b0984079
Add failing playlist no selection after deleted test
2023-01-03 11:10:01 -08:00
Dan Balasescu
e9998f1690
Store maximum statistics to spectator state
2022-12-09 20:15:07 +09:00
Dan Balasescu
7bc8908ca9
Partial everything
2022-11-27 00:00:27 +09:00
Dan Balasescu
28277dd880
Fix tests
2022-10-17 19:34:05 +09:00
Dean Herbert
d2b80645ab
Change Leaderboard to use IUser instead of APIUser
2022-09-13 18:00:21 +09:00
Dean Herbert
6945c43e0d
Merge pull request #20178 from smoogipoo/fix-match-creation-beatmap-select
...
Fix several weird scenarios with online play song selection
2022-09-08 23:07:09 +09:00
Dan Balasescu
9aab502adc
Merge pull request #20157 from peppy/true-gameplay-rate
...
Refactor `TrueGameplayRate` to account for only gameplay adjustments, no matter what
2022-09-08 19:54:32 +09:00
Dan Balasescu
a90ca94a18
Remove outdated tests
2022-09-08 19:51:28 +09:00
Dan Balasescu
208bd0f391
Give OnlinePlaySongSelect a reference PlaylistItem
2022-09-07 21:34:29 +09:00
Dean Herbert
770c1ade2f
Add test coverage of track rate adjusting during multi spectator
2022-09-07 20:00:24 +09:00
Dan Balasescu
2923c10cd8
Rewrite rooms to store multiple active countdowns
...
Update test to the new structure
2022-09-05 19:03:26 +09:00
Dean Herbert
9050f54681
Split out test assertion methods to read better
2022-08-26 16:56:03 +09:00
Dean Herbert
a8c699610a
Fix lead in tests not waiting for player to start running
...
The tests are only meant to ensure that gameplay eventually starts.
The case where failures can occur is where the master clock is behind
the player clock (due to being in lead-in time). Because the test is
running in real-time, it can take arbitrary amounts of time to catch up.
If it took too long, the test would fail.
2022-08-25 18:00:14 +09:00
Dean Herbert
ddb434f47a
Rename asserts to method names to make it easier to track in logs
2022-08-25 17:30:13 +09:00
Dean Herbert
a5c61d9a52
Improve understandability of TestMostInSyncUserIsAudioSource
2022-08-25 16:47:33 +09:00
Dean Herbert
ddccf4defe
Remove dollar sign
2022-08-24 17:17:59 +09:00
Dean Herbert
27b57947e4
Rename PlayerArea.GameplayClock to SpectatorPlayerClock for clarity
2022-08-24 17:13:14 +09:00
Dean Herbert
5f01f461b3
Ensure elapsed time is always non-zero when advancing SpectatorPlayerClock
2022-08-24 17:13:14 +09:00
Dean Herbert
995e6664b6
Rename spectator clock sync classes
2022-08-24 15:13:08 +09:00
Dean Herbert
6d78218142
Update usages of GameplayClockContainer.GameplayClock to access properties directly
2022-08-15 18:08:49 +09:00
Salman Ahmed
789e8b4d8d
Fix multi-spectator test updating state after removing user
...
Removing user triggers `playingUsers.Remove`, but doing so before
updating the state leads to `EndGameplay` being called with `State ==
Playing` rather than `Quit`.
2022-08-06 05:41:26 +03:00
Salman Ahmed
8ca8484f0e
Fix failing tests
2022-07-30 11:49:33 +03:00
Dan Balasescu
aaa6f963bd
Fix potential test failures due to Setup/SetUpSteps ordering
2022-07-29 15:27:39 +09:00
Dean Herbert
2b9d46d803
Remove unused RulesetStore from BeatmapManager constructor
2022-07-28 16:19:05 +09:00
Dan Balasescu
6b69ff19c8
Remove unused using
2022-07-22 17:24:46 +09:00
Salman Ahmed
e5ab6652fd
Fix one more case of referencing old mod select overlay in tests
2022-07-22 11:12:24 +03:00
Adam Baker
59018ab5ba
Fix multiplayer queue edit button opening to the wrong beatmap
2022-07-18 23:21:16 -05:00
Salman Ahmed
0bafafd63b
Remove unnecessary test coverage
...
RIP hours.
2022-07-15 03:20:52 +03:00
Salman Ahmed
be69514002
Fix CollectionManager opening file multiple times across test scene
2022-07-14 06:21:23 +03:00
Salman Ahmed
cb2f0b8c67
Add test coverage for collection items
2022-07-14 03:42:03 +03:00
Salman Ahmed
9ec4fbb86d
Add test coverage for details item
2022-07-14 03:41:47 +03:00
Salman Ahmed
099a7e90d6
Centralise creation of playlist in test scene
2022-07-14 02:19:30 +03:00
Salman Ahmed
102d0415f1
Merge branch 'master' into drawable-playlist-item-collection
2022-07-14 00:10:49 +03:00
Salman Ahmed
67fa15f231
Remove no longer required context menu container in ParticipantsList
2022-07-08 01:42:55 +03:00
Dean Herbert
dd5b127fb5
Update various tests to enable NRT to avoid new inspection failures
2022-07-07 17:51:49 +09:00
Dan Balasescu
385bd5a1b2
Merge pull request #18965 from peppy/mark-flaky-tests
...
Mark, document and silence remaining flaky tests on standard CI runs
2022-07-03 21:41:14 +09:00
Dean Herbert
2cc9c579d4
Merge pull request #18969 from smoogipoo/fix-multiplayer-cross-pollution
...
Fix cross-pollution of server- and client-side multiplayer objects in tests
2022-07-02 13:18:35 +09:00
Dan Balasescu
93c68e4329
More test hardening around ClientAPIRoom usages
2022-07-01 19:49:27 +09:00
Dean Herbert
6baccad058
Merge pull request #18821 from ggliv/locked-room-filter
...
Add room access type filter to multiplayer lounge screen
2022-07-01 19:37:43 +09:00
Dan Balasescu
b64c0d011c
Isolate client's Room from TestMultiplayerClient
2022-07-01 19:23:25 +09:00
Dan Balasescu
0be858b5bf
Rename APIRoom -> ClientAPIRoom, remove unused asserts
2022-07-01 19:21:59 +09:00
Dean Herbert
e213c1a4ef
Rename enum to explicitly mention it is a filter
2022-07-01 17:27:03 +09:00
Dean Herbert
9911c6cbf0
Merge branch 'master' into locked-room-filter
2022-07-01 17:17:01 +09:00
Dean Herbert
8f8c2a8c9a
Remove one flaky test description (fixed via #18966 )
2022-07-01 16:55:47 +09:00
Dan Balasescu
58c9bb031f
Apply PR reviews/fixes
2022-07-01 16:51:15 +09:00
Dan Balasescu
c22e77e481
Fix test sometimes referencing old ModSelect object
2022-07-01 16:46:27 +09:00
Dean Herbert
b597843579
Mark and document remaining flaky tests
2022-07-01 16:17:40 +09:00
Dean Herbert
84ecd524c8
Move wait steps upwards
2022-06-30 17:58:43 +09:00
Dean Herbert
7ab8335935
Fix various multiplayer test failures due to not waiting for ongoing operation
...
As seen at
https://teamcity.ppy.sh/buildConfiguration/Osu_Build/1138?hideProblemsFromDependencies=false&hideTestsFromDependencies=false&expandBuildChangesSection=true&expandBuildTestsSection=true .
2022-06-30 17:42:45 +09:00
Dean Herbert
31a447fda0
Update parameter discards
2022-06-24 21:26:19 +09:00
Bartłomiej Dach
489ed5d34d
Rename test method
2022-06-23 18:04:38 +02:00
Gabe Livengood
454eff43c5
publicity -> accesstype
2022-06-23 11:40:25 -04:00
Gabe Livengood
9a15adbfff
add an all option to publicity filter
2022-06-23 11:24:28 -04:00
Gabe Livengood
2def6d809b
refactor to use enum dropdown
2022-06-23 11:02:27 -04:00
Dean Herbert
7ef8b7df5f
Add timeout for all ManualResetEventSlim.Wait invocations
...
Timeout values were taken as best-guesses of upper values we'd expect
from sane execution.
2022-06-23 14:46:00 +09:00
Gabe Livengood
a03cfbc2d4
add test coverage
2022-06-22 17:01:42 -04:00
Dan Balasescu
f8830c6850
Automated #nullable processing
2022-06-17 16:37:17 +09:00
Bartłomiej Dach
6f1437e73d
Fix compilation failure due not applying rename fully
2022-06-02 21:18:09 +02:00
Dan Balasescu
793dfe2bc8
Mark players as playing
2022-06-02 14:22:45 +09:00
Dan Balasescu
600da89f72
Fix disposing previous leaderboard too late
2022-06-02 14:22:15 +09:00
Dan Balasescu
13d85b8cc7
Merge branch 'scoreprocessor-cleanup' into multiplayer-leaderboard-user-mods-2
2022-05-31 19:53:37 +09:00
Dan Balasescu
22d998dc2a
Use new score processor in MultiplayerGameplayLeaderboard
2022-05-30 19:26:26 +09:00
Dean Herbert
2f57849bcb
Fix unexpected assertion failure
2022-05-27 20:59:00 +09:00
Dean Herbert
ef47b380c6
Add featured artist playlist category
2022-05-27 20:18:46 +09:00
Bartłomiej Dach
af1d4d3aee
Use more proper button subtypes in tests
2022-05-25 23:06:12 +02:00
Bartłomiej Dach
4f8b6b52ba
Add failing test coverage for select/deselect all enable behaviour
2022-05-25 21:49:31 +02:00
Dan Balasescu
7d0470794b
Merge pull request #18353 from frenzibyte/spectator-catch-up-work-alt
...
Disallow multi-spectator player clocks from being started/stopped externally
2022-05-23 13:59:54 +09:00
Bartłomiej Dach
0bef2ca752
Adjust test slightly
...
* Import `osuTK.Input` instead of using full qualified name
* Use some more straightforward assertions
2022-05-22 19:27:20 +02:00
maromalo
fc25d248ad
Test coverage + no virtual
2022-05-21 18:16:29 -03:00
Salman Ahmed
d73afcaf48
Fix existing test coverage false-passing
...
Also improves general test coverage to test more realisticly, in order
to produce accurate results.
2022-05-21 17:12:04 +03:00
Dean Herbert
b6575c216b
Allow selecting all mods at free mod select using ctrl+a
2022-05-15 03:25:14 +09:00
Bartłomiej Dach
62f6caf76d
Rename ModSelect{Screen -> Overlay} test scenes
2022-05-11 18:04:39 +02:00
Bartłomiej Dach
76c63f1d0a
Rename ModSelect{Screen -> Overlay} in place of removed old design
2022-05-10 22:56:50 +02:00
Bartłomiej Dach
4a3447f59f
Remove old free mod select overlay
2022-05-10 21:45:57 +02:00
Dan Balasescu
a16f2349aa
Fix next queued item not selecting after gameplay
2022-05-09 17:55:42 +09:00
Salman Ahmed
077c77d524
Add method for scaling results screen in tests
2022-05-08 16:00:07 +03:00
Bartłomiej Dach
5d6d7bb324
Fix incorrect assert in multiplayer song select test scene
2022-05-07 13:15:16 +02:00
Bartłomiej Dach
e7e7486a8e
Merge branch 'mod-overlay/back-button' into mod-overlay/integration
2022-05-07 10:59:30 +02:00
Bartłomiej Dach
9d3e67b10d
Update free mod select/deselect all test after back button addition
2022-05-07 10:25:23 +02:00
Bartłomiej Dach
e1953c484c
Add test coverage for selecting/deselecting all mods on free mod select
2022-05-07 09:50:08 +02:00
Bartłomiej Dach
380cd1e036
Add test coverage for lack of customisation on free mod select
2022-05-06 21:35:22 +02:00
Dean Herbert
060461a431
Add test coverage of multiplayer gameplay exit flow
2022-05-06 15:22:22 +09:00
Bartłomiej Dach
d296f78dfe
Replace references to old mod select classes in multiplayer match screen test
2022-05-05 22:16:57 +02:00
Bartłomiej Dach
ecc2805099
Replace references to old mod select classes in match song select test
...
Also note the change from `songSelect.ChildrenOfType<>()...` to
`this.ChildrenOfType<>()...` - because the new design is registered at
game-level, the mod select is not a child of the song select screen
anymore.
2022-05-05 22:16:57 +02:00
Bartłomiej Dach
199bdb8e7d
Replace reference to old mod select in multiplayer test
2022-05-05 22:16:56 +02:00
Salman Ahmed
a26793cd65
Add missing Test prefix
2022-05-05 06:12:24 +03:00
Salman Ahmed
f28978b856
Handle against playlists which disallow selection
...
`SelectedItem.Disabled` is also not checked against in the select-via-click flow inside `DrawableRoomPlaylistItem` (only `AllowSelection` is checked).
2022-05-05 05:48:35 +03:00
Bartłomiej Dach
ec27fa8e85
Add test coverage for keyboard selection
2022-05-04 13:15:10 +02:00
Dan Balasescu
b293d3923c
Merge branch 'master' into multiplayer-force-start-2
2022-04-23 01:03:55 +09:00
