Dean Herbert
29a37e3585
Merge pull request #27491 from bdach/f-rank-appearance
...
Update F rank badge colours to match latest designs
2024-03-06 18:55:20 +08:00
Bartłomiej Dach
08609e19d6
Fix osu! standardised score estimation algorithm violating basic invariants
...
As it turns out, the "lower" and "upper" estimates of the combo portion
of the score being converted were misnomers. In selected cases
(scores with high accuracy but combo being lower than max by more than
a few objects) the janky score-based math could overestimate the count
of remaining objects in a map. For instance, in one case the numbers
worked out something like this:
- Accuracy: practically 100%
- Max combo on beatmap: 571x
- Max combo for score: 551x
The score-based estimation attempts to extract a "remaining object
count" from score, by doing something along of sqrt(571^2 - 551^2). That
comes out to _almost 150_. Which leads to the estimation overshooting
the total max combo count on the beatmap by some hundred objects.
To curtail this nonsense, enforce some basic invariants:
- Neither estimate is allowed to exceed maximum achievable
- Ensure that lower estimate is really lower and upper is really upper
by just looking at the values and making sure that is so rather than
just saying that it is.
2024-03-06 11:40:10 +01:00
Dan Balasescu
d8003ab8e8
Merge pull request #27489 from bdach/fix-catch-pp-mismatch
...
Fix catch pp calculator not matching live with respect to miss handling
2024-03-06 19:39:20 +09:00
Bartłomiej Dach
b740481eaf
Merge pull request #27504 from peppy/replay-state-sanity-1
...
Never set `waitingOnFrames` if a replay is not attached
2024-03-06 09:51:09 +01:00
Bartłomiej Dach
0d4515d26e
Merge pull request #27506 from peppy/update-framework
...
Update framework
2024-03-06 08:43:24 +01:00
Bartłomiej Dach
53fffc6a75
Remove unused using directives
2024-03-06 07:57:59 +01:00
jvyden
98ca021e66
Catch and warn about osu!stable lobbies
2024-03-06 01:17:37 -05:00
Dean Herbert
06c7483347
Merge branch 'master' into update-framework
2024-03-06 12:36:05 +08:00
Dean Herbert
85364d25dc
Merge pull request #27276 from bdach/medals
...
Add flow for displaying achieved medals
2024-03-06 12:31:55 +08:00
Dean Herbert
3a224211aa
Update various packages which shouldn't cause issues
2024-03-06 12:17:00 +08:00
Dean Herbert
4c7678225e
Update framework
2024-03-06 12:13:41 +08:00
Dean Herbert
0696e7de52
Update ImageSharp usages
2024-03-06 12:13:12 +08:00
Dean Herbert
b53b752e54
Update usage of MathUtils
2024-03-06 12:13:12 +08:00
Dean Herbert
6455c0583b
Update usage of CircularProgress.Current
2024-03-06 12:13:10 +08:00
Jayden
9871300317
Improve language of user-facing errors
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2024-03-05 18:22:39 -05:00
jvyden
b53777c2a4
Refactor room secret handling to use JSON
...
Also log room secrets for debugging purposes
2024-03-05 18:21:26 -05:00
Dean Herbert
65ce4ca390
Never set waitingOnFrames if a replay is not attached
2024-03-06 04:37:11 +08:00
Dean Herbert
57daaa7fed
Add logging for GameplayClockContainer starting or stopping
2024-03-06 04:37:11 +08:00
Bartłomiej Dach
09c6c5d79b
Merge pull request #27497 from frenzibyte/mod-select-overlay-fix-ux
...
Fix mod select overlay settings order not always matching mod panels
2024-03-05 19:40:13 +01:00
Bartłomiej Dach
429fa8dfae
Merge pull request #27242 from Susko3/log-global-statistics
...
Log `GlobalStatistics` when exporting logs from settings
2024-03-05 19:32:54 +01:00
Bartłomiej Dach
e6f1a722cb
Remove unused field and commented-out code
2024-03-05 18:49:19 +01:00
Berkan Diler
d0f7ab3316
Revert some changes
2024-03-05 17:18:59 +01:00
Bartłomiej Dach
f91423a775
Merge pull request #27456 from frenzibyte/catch-hr-issues
...
Fix catch fruit position getting randomised when last fruit has zero position
2024-03-05 14:23:27 +01:00
Dean Herbert
b4bc34d8a1
Merge pull request #27502 from turbedi/ToDictionary_overload
...
Use new ToDictionary() overload without delegates
2024-03-05 20:25:31 +08:00
Berkan Diler
6fabbe2616
Use new ToDictionary() overload without delegates
2024-03-05 10:27:12 +01:00
Berkan Diler
5965db4fd7
Use ArgumentException.ThrowIfNullOrEmpty throw helper
2024-03-05 10:20:57 +01:00
Berkan Diler
a891303484
Use ArgumentOutOfRangeException throw helper methods
2024-03-05 10:20:30 +01:00
Berkan Diler
9bac60a98f
Use ArgumentNullException.ThrowIfNull in more places
2024-03-05 10:19:47 +01:00
Berkan Diler
43841e210d
Use ObjectDisposedException.ThrowIf throw helper
2024-03-05 09:58:46 +01:00
Jayden
cceb616a18
Update failure messages
...
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
2024-03-04 22:25:36 -05:00
Salman Ahmed
49b3e81e8a
Migrate DefaultPerformancePointsCounter and rename it
2024-03-05 04:35:39 +03:00
Salman Ahmed
b1477c30f2
Add deserialisation test coverage
2024-03-05 04:30:57 +03:00
Salman Ahmed
0cbcfcecdc
Integrate "Argon" performance points counter with HUD layout
2024-03-05 03:58:43 +03:00
Salman Ahmed
d7f1e50d66
Add "Argon" performance points counter
2024-03-05 03:34:29 +03:00
Salman Ahmed
3ee57cdfba
Refactor performance points test scene to support skinning
2024-03-05 03:34:25 +03:00
Salman Ahmed
92f455f199
Abstractify performance points calculation to a base class
2024-03-05 03:33:48 +03:00
Salman Ahmed
9543908c7a
Fix mod select overlay settings order not always matching panels order
2024-03-04 23:36:45 +03:00
Bartłomiej Dach
6080c14dd5
Update F rank badge colours to match latest designs
2024-03-04 14:47:49 +01:00
Bartłomiej Dach
405958f73c
Add test scene for drawable ranks
2024-03-04 14:43:53 +01:00
Bartłomiej Dach
b896d97a4f
Fix catch pp calculator not matching live with respect to miss handling
2024-03-04 11:53:59 +01:00
Bartłomiej Dach
dcd6b02809
Fix incorrect implementation of GetCountMiss() for catch
2024-03-04 11:49:12 +01:00
Bartłomiej Dach
af2b80e030
Add failing encode test
2024-03-04 11:48:49 +01:00
Dan Balasescu
6635d9be04
Add countdown display
2024-03-04 16:50:24 +09:00
Dan Balasescu
bce3bd55e5
Fix catch by moving cursor-specific handling local
2024-03-04 16:08:17 +09:00
Dan Balasescu
e935c49a98
Merge pull request #27154 from bdach/catch-fail-on-banana
...
Fix draining processor failing gameplay on bonus misses, tiny droplet misses, and ignore hits
2024-03-04 13:53:02 +09:00
Dan Balasescu
5bd037fe8f
Merge branch 'master' into catch-fail-on-banana
2024-03-04 13:13:26 +09:00
Dean Herbert
e1744df2b7
Merge pull request #27472 from frenzibyte/fix-translation
2024-03-03 03:49:42 +08:00
Salman Ahmed
85f131d2f8
Fix "unranked explaination" tooltip text using incorrect translation key
2024-03-02 22:45:15 +03:00
Salman Ahmed
285adcb00e
Fix catch hit object position getting randomised when last object has pos=0
2024-03-02 03:18:59 +03:00
Salman Ahmed
82373ff752
Add failing catch beatmap
2024-03-02 03:18:59 +03:00
