1049 Commits

• Merge branch 'master' into correct-reverse-arrow-depth
  Bartłomiej Dach · 2021-09-20 22:32:28 +02:00
  c911332540
• Fix slider parts not reproxying after first hitobject freed
  Bartłomiej Dach · 2021-09-18 16:27:30 +02:00
  79438c19a4
• Merge branch 'master' into update-framework
  Dean Herbert · 2021-09-16 22:49:02 +09:00
  fde7c88999
• Fix legacy approach circles accepting alpha
  smoogipoo · 2021-09-16 19:35:15 +09:00
  d8f27633a4
• Update with keybinding changes
  smoogipoo · 2021-09-16 18:26:12 +09:00
  f9d5abff8a
• Fix osu! judgements getting scaled twice over different durations
  Dean Herbert · 2021-09-02 16:31:43 +09:00
  b907c2f4f6
• Fix repeat arrows being hidden beneath head circles in legacy skins

  Aims to make minimal changes to `DrawableSlider` itself. I'm not super
  happy about the slider ball being moved above the head circle, but it
  *is* what people are used to so no one except for me is going to
  complain.
  
  Supersedes and closes https://github.com/ppy/osu/pull/14561.

  Dean Herbert · 2021-09-01 19:41:49 +09:00
  738ce0f689
• Merge branch 'master' into avoid-default-skin-judgement-transform-overhead
  Dan Balasescu · 2021-08-27 10:02:40 +09:00
  f0296e5d12
• Merge branch 'master' into path-control-point-bindable-removal
  Dan Balasescu · 2021-08-27 09:37:37 +09:00
  a28bc9f6b2
• Remove redundant default value
  Salman Ahmed · 2021-08-26 08:18:58 +03:00
  b9ea984c36
• Avoid expensive text spacing transforms for now
  Dean Herbert · 2021-08-26 13:15:27 +09:00
  8cfb3d456b
• Avoid unnecessary unbind operations when constructing FollowPointLifetimeEntry
  Dean Herbert · 2021-08-26 12:35:31 +09:00
  69064c1938
• Remove bindable usage in PathControlPoint

  This is quite a breaking change, but I think it is beneficial due to the large amount of usage of this class.
  
  I originally intended just to remove the allocations of the two delegates handling the `Changed` flow internally, but as nothing was really using the bindables for anything more than a general "point has changed" case, this felt like a better direction.

  Dean Herbert · 2021-08-26 12:33:53 +09:00
  6dcd9427ac
• Add ComboIndexWithOffsetsBindable and bind similar to ComboIndexBindable
  Salman Ahmed · 2021-07-22 16:40:33 +03:00
  523c154f15
• Rename property, reword xmldoc and improve readability of update code
  Dean Herbert · 2021-07-21 17:32:56 +09:00
  399c3b0be8
• Revert making ComboOffsets legacy and define BeatmapSkinComboIndex instead
  Salman Ahmed · 2021-07-20 14:15:43 +03:00
  9d92b795fa
• Merge branch 'refactor-combo-colour-retrieval' into legacy-beatmap-combo-offset
  Salman Ahmed · 2021-07-20 10:11:52 +03:00
  554652b033
• Implement IHasApproachCircle in DrawableHitCircle as well
  Salman Ahmed · 2021-06-21 07:35:07 +03:00
  68e28f4903
• Replace spinner approach circle proxying logic with hooking up to OnSkinChange in mod
  Salman Ahmed · 2021-06-19 20:06:28 +03:00
  c04b09520d
• Move spinner approach circle to its own SkinnableDrawable
  Salman Ahmed · 2021-06-18 20:33:50 +03:00
  843c8bd7a4
• Merge branch 'master' into legacy-spinner-approach-circle
  Salman Ahmed · 2021-06-18 19:50:52 +03:00
  f7b5341663
• Hide spinner approach circle in "Hidden" mod
  Salman Ahmed · 2021-06-18 06:23:54 +03:00
  c9458fd9ce
• Fix approach circle fade not running early on an early user hit

  Regressed in https://github.com/ppy/osu/pull/12153.
  Closes https://github.com/ppy/osu/issues/13531.

  Dean Herbert · 2021-06-17 15:09:05 +09:00
  a46f730a69
• Merge branch 'master' into fix-skin-sample-lookup
  Dean Herbert · 2021-06-08 17:37:36 +09:00
  6017ef3825
• Fix slider repeat arrow not updating rotation immediately while paused in editor

  A bit of a local solution, but not sure there's a better way to handle
  this.
  
  Closes #13342.

  Dean Herbert · 2021-06-07 15:58:43 +09:00
  277eb9fa6e
• Merge branch 'legacy-skin-default-fallback' into fix-skin-sample-lookup
  Dean Herbert · 2021-06-07 12:01:19 +09:00
  d26c9a66c2
• Bring back scheduling of follow point update
  ekrctb · 2021-06-04 18:41:02 +09:00
  d7da66d876
• Remove one TODO

  It can be removed because pooled drawables are always ready, and `FollowPointConnection` is also ready when applied.

  ekrctb · 2021-06-04 17:09:59 +09:00
  0098ac2760
• Resolve nullable inspection, enable nullable for FollowPointLifetimeEntry
  ekrctb · 2021-06-04 17:09:59 +09:00
  bc892086fe
• Use general lifetime container for follow point container
  ekrctb · 2021-06-04 16:31:50 +09:00
  b373b120ff
• Remove defunct Animate calls
  ekrctb · 2021-06-02 11:46:28 +09:00
  c06ff3c623
• Fix hit circle animation reset when skin is changed

  The transforms applied in `Animate` call was not applied because the piece is recreated.

  ekrctb · 2021-06-02 11:32:24 +09:00
  b82190e157
• Merge branch 'master' into fix-skin-sample-lookup
  Dean Herbert · 2021-05-28 14:47:35 +09:00
  6268bbea85
• Remove allowFallback parameters completely
  Dean Herbert · 2021-05-27 14:50:42 +09:00
  70a844ac10
• Make DrawableSliderTail not require ITrackSnaking
  Endrik Tombak · 2021-05-26 23:21:05 +03:00
  9ac4ef273e
• Fix sliders jumping around the screen on movement
  smoogipoo · 2021-05-24 17:15:57 +09:00
  3db995c778
• Add regression test for spinner sample actually transforming its frequency
  Dean Herbert · 2021-05-24 15:10:33 +09:00
  8336428574
• Fix follow points displaying at incorrect locations when dragging a slider out-of-bounds
  Dean Herbert · 2021-05-05 18:30:57 +09:00
  1410b8f36d
• Consider "combo offsets" as legacy logic and separate from combo information
  Salman Ahmed · 2021-05-05 07:43:08 +03:00
  cd6d070b4a
• Extract scale constant
  Dean Herbert · 2021-04-26 15:30:22 +09:00
  d10aac851d
• Expose DrawableSliderRepeat's arrow and move transforms to children
  Dean Herbert · 2021-04-26 15:22:42 +09:00
  4da964c3f3
• Expose presence of MainCirclePiece via an interface
  Dean Herbert · 2021-04-26 15:22:17 +09:00
  aa7ade8186
• Animate back slider repeat and tail circle pieces
  Salman Ahmed · 2021-04-26 02:39:49 +03:00
  0b9172a1dc
• Split out animation triggering of MainCirclePiece to be interface driven
  Dean Herbert · 2021-04-21 19:15:10 +09:00
  47a4a07024
• Keep hitcircles aligned with view in "Barrel Roll" mod
  Dean Herbert · 2021-04-20 18:36:11 +09:00
  ac0ed72d04
• Merge branch 'master' into legacy-spm-counter
  Dean Herbert · 2021-04-12 12:52:52 +09:00
  e2470d757e
• Rework slider hackery to not overwrite Samples
  smoogipoo · 2021-04-09 15:28:08 +09:00
  f2e811928b
• Actually use whistle sample for sliderwhistle
  smoogipoo · 2021-04-08 23:13:16 +09:00
  8efa381d3a
• Don't serialise OriginalSamples
  smoogipoo · 2021-04-08 20:57:50 +09:00
  7d291ed7d7
• Add support for sliderwhistle
  smoogipoo · 2021-04-08 20:20:09 +09:00
  7713c8a45f