3279 Commits

• Merge branch 'master' into fix-scrolling-lifetime
  smoogipoo · 2021-06-02 11:08:28 +09:00
  8ee2b3a2d2
• Merge pull request #13256 from ekrctb/update-lifetime-2

  Update DHO lifetime on entry lifetime change

  Dan Balasescu · 2021-06-02 11:07:54 +09:00
  ac83450791
• Simplify lifetime setter

  Setting entry lifetime will cause `LifetimeChanged` event and `base.LifetimeStart`/`End` will be modified in the callback.

  ekrctb · 2021-06-01 14:46:43 +09:00
  40949f6c1b
• Fix wrong code
  ekrctb · 2021-06-01 14:38:02 +09:00
  0f381f7758
• Revert invalid code transformation
  ekrctb · 2021-06-01 14:28:23 +09:00
  86020adf64
• Apply code styling suggestions

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  ekrctb · 2021-06-01 13:17:30 +09:00
  d5714e63b9
• Remove unused IScrollingHitObject interface
  ekrctb · 2021-05-31 23:17:26 +09:00
  86d1ba7ef2
• Change timing of HitObjectContainer.OnAdd/OnRemove

  Now, `OnAdd` is always invoked after the DHO is added to the container.
  This change is required by `ScrollingHitObjectContainer` to compute origin adjusted lifetime when origin position is relative to the parent drawable size.

  ekrctb · 2021-05-31 20:56:25 +09:00
  ff04942295
• Merge branch 'simplify-shoc' into fix-scrolling-lifetime

  # Conflicts:
  #	osu.Game/Rulesets/UI/Scrolling/ScrollingHitObjectContainer.cs

  ekrctb · 2021-05-31 16:50:47 +09:00
  948a14a627
• Reset lifetime to initial lifetime when layout is invalidated
  ekrctb · 2021-05-31 16:47:10 +09:00
  86d1225aad
• Remove scrollLength caching field

  It was not clear when the field is updated.

  ekrctb · 2021-05-31 16:28:02 +09:00
  6d96846776
• Remove delay of lifetime update

  The scheduling is no longer necessary because `OnAdd` is changed to not invoked immediately for non-pooled DHOs.

  ekrctb · 2021-05-31 16:24:13 +09:00
  742c5b442b
• Don't add nested hit objects to the sets

  Only top-level hit objects are checked for layout computation caching.
  Also, lifetime of nested hit objects are not managed by the HitObjectContainer.

  ekrctb · 2021-05-31 16:20:35 +09:00
  3cedc0824d
• Make SetInitialLifetime public
  ekrctb · 2021-05-31 15:33:28 +09:00
  56a0a24cba
• Update drawable lifetime on entry lifetime change
  ekrctb · 2021-05-31 14:45:29 +09:00
  e25cca6fbe
• Merge pull request #13235 from ekrctb/update-lifetime-1

  Update hit object lifetime on `HitObject.DefaultsApplied`

  Dan Balasescu · 2021-05-31 14:44:40 +09:00
  8c6277f0d8
• Apply comment rewording suggestion

  Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>

  ekrctb · 2021-05-31 13:41:49 +09:00
  0c101d2859
• Fix comment grammar
  ekrctb · 2021-05-30 13:06:28 +09:00
  abb77b95b4
• Add test case of DHO setting LifetimeStart in OnApply
  ekrctb · 2021-05-28 21:51:48 +09:00
  265dfe5416
• Reset lifetime on HitObject.DefaultsApplied
  ekrctb · 2021-05-28 21:35:26 +09:00
  43bf734816
• Fix wrong/misleading comment of InitialLifetimeOffset
  ekrctb · 2021-05-28 17:19:36 +09:00
  1d5e8f4a91
• Add a mention that OnApply/OnFree is performed after ApplyDefaults
  Dean Herbert · 2021-05-27 15:20:35 +09:00
  122bb05aa8
• Merge pull request #12933 from peppy/fix-scroll-wheel-gameplay-bindings

  Disallow using scroll wheel for gameplay bindings

  Dan Balasescu · 2021-05-25 16:04:18 +09:00
  774611f142
• Ignore certain banned InputKeys for gameplay purposes
  Dean Herbert · 2021-05-24 18:40:40 +09:00
  57640810b5
• Merge pull request #12915 from peppy/regenerate-replay-less

  Ensure `RegenerateAutoplay` is only run once per frame

  Dan Balasescu · 2021-05-24 17:25:42 +09:00
  7a343c1576
• Fix DHOs not receiving initial skin changed events
  smoogipoo · 2021-05-24 14:07:40 +09:00
  7494ddeef4
• Ensure RegenerateAutoplay is only run once per frame
  Dean Herbert · 2021-05-23 21:20:08 +09:00
  bbfd7ea23f
• Merge branch 'master' into fix-dho-lmc
  Dan Balasescu · 2021-05-21 19:11:57 +09:00
  5ad41ded94
• Rename SpectatorStreamingClient -> SpectatorClient
  smoogipoo · 2021-05-20 15:55:07 +09:00
  6beeb7f7c4
• Don't couple PoolableDrawableWithLifetime lifetime with its entry

  It turns out the incompatibility with `LifetimeManagementContainer` causes more issues than anticipated.

  ekrctb · 2021-05-20 14:56:15 +09:00
  0489ae719d
• Fix PlacementBlueprint using the wrong beatmap when applying defaults

  Closes #12855.

  Dean Herbert · 2021-05-19 18:34:07 +09:00
  6c4709e7b4
• Merge branch 'master' into always-use-lifetime-entry
  Dan Balasescu · 2021-05-18 20:10:12 +09:00
  ef81bdf63f
• Revert "Use entry to calculate lifetime in ScrollingHOC"

  This reverts commit 632bb70e

  ekrctb · 2021-05-18 19:55:31 +09:00
  84a1a86c63
• Revert "Fix uninitialized scrollLength value is used"

  This reverts commit 73dfb04d

  ekrctb · 2021-05-18 19:55:25 +09:00
  2c65b8fa93
• Merge pull request #12782 from smoogipoo/rework-hitobject-blueprints

  Rename hitobject blueprints and tie them to HitObjects

  Dean Herbert · 2021-05-18 16:30:58 +09:00
  a96603f025
• Remove now unnecessary Apply() method
  smoogipoo · 2021-05-18 14:26:26 +09:00
  882d54a8f8
• Add Apply() method for applying new DHOs
  smoogipoo · 2021-05-18 14:14:10 +09:00
  e621cfc4ea
• Fix unresolved xmldocs
  smoogipoo · 2021-05-18 13:11:58 +09:00
  f1f3606fd0
• Fix up xmldocs

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dan Balasescu · 2021-05-18 13:02:23 +09:00
  9d423245d8
• Merge pull request #12811 from PercyDan54/hidden-code-cleanup

  Remove obsolete methods in `ModHidden` and apply few touches

  Dean Herbert · 2021-05-16 22:07:45 +09:00
  a32f1ef35a
• Merge pull request #12759 from Naxesss/beatmap-verifier-context

  Encapsulate check arguments in context object

  Dean Herbert · 2021-05-15 15:39:12 +09:00
  bdcb1a624e
• Duplicate implementions
  PercyDan54 · 2021-05-15 11:55:50 +08:00
  166974506e
• Revert "Remove empty override"

  This reverts commit a86a4bab91.

  PercyDan54 · 2021-05-15 11:45:14 +08:00
  6e5c4ed7c6
• Ignore possible nulls in Type.GetType() calls

  They're mostly used in extensibility scenarios, so everything happens in
  runtime. There is no better resolution than to crash with a null
  reference exception.

  Bartłomiej Dach · 2021-05-15 00:09:34 +02:00
  628e7a71ed
• Remove empty override
  PercyDan54 · 2021-05-14 21:55:32 +08:00
  a86a4bab91
• Cleanup code in ModHidden
  PercyDan54 · 2021-05-14 21:29:13 +08:00
  67dfeeb1b7
• Add local variable for regular access to HitObjects
  Dean Herbert · 2021-05-14 16:23:45 +09:00
  fcb226bd20
• Fix formatting of #nullable enable
  Naxess · 2021-05-14 03:38:35 +02:00
  a447f20095
• Add #nullable enable

  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Naxess · 2021-05-14 03:34:50 +02:00
  90e0b3374e
• Rework hitobject blueprints to take in hitobject models
  smoogipoo · 2021-05-13 19:53:32 +09:00
  ffb6135a1b