3183 Commits

Author	SHA1	Message	Date
Dean Herbert	c1e9b6d4ca	Fix beatmap backgrounds loading default briefly before final display ... Due to the way `ModelBackedDrawable` works, the default starts to get loaded even though a final `Beatmap` has been set. This avoids loading the default fallback unless a beatmap has been set (and has no background itself).	2024-05-03 13:42:56 +08:00
Dean Herbert	058bd5ced6	Stop using visually noisy bg4 for default backgrounds ... This has always really annoyed me.	2024-05-03 13:38:27 +08:00
Bartłomiej Dach	802666e621	Update local metadata lookup cache more often ... As proposed in https://github.com/ppy/osu/issues/27332#issuecomment-1962308306.	2024-05-02 16:18:29 +02:00
Salman Ahmed	895c09d4d1	Merge branch 'master' into storyboard-loops-v2	2024-05-01 23:46:38 +03:00
Bartłomiej Dach	f0eef32913	Fix code quality inspection	2024-05-01 15:21:39 +02:00
Dean Herbert	44091b1f35	Fix some lines still getting forgotten about	2024-05-01 17:33:03 +08:00
Dean Herbert	ba9f4e4baf	Don't skip lines in beatmap decoding ... Was added in cc76c58f5f without any specific reasoning. Likely not required (and will fix some storyboard elements inside `.osu` files from not being correctly saved).	2024-04-30 16:42:15 +08:00
Dean Herbert	fd3f4a9e7b	Preserve storyboard events when saving a beatmap in the editor ... Until we have full encoding support for storyboards, this stop-gap measure ensures that storyboards don't just disappear from existence.	2024-04-30 00:01:56 +08:00
Dean Herbert	4ae9f81c73	Apply transforms to storyboard videos ... This requires that they are a `StoryboardSprite` for simplicity. Luckily this works just fine.	2024-04-22 18:43:15 +08:00
Bartłomiej Dach	2d3b273974	Remove redundant string interpolation	2024-03-29 10:37:49 +01:00
Dean Herbert	233b9eb172	Avoid reporting an import as successful when all beatmaps failed to import	2024-03-29 17:11:55 +08:00
Bartłomiej Dach	3e764ae4f0	Merge pull request #27639 from 64ArthurAraujo/verify-unused-audio-at-end ... Add verify checks to unused audio at the end	2024-03-21 12:19:53 +01:00
Bartłomiej Dach	1f343b7545	Add extended logging when discarding online metadata lookup results ... Related to: https://github.com/ppy/osu/issues/27674 Relevant log output for that particular case: [network] 2024-03-20 07:25:30 [verbose]: Performing request osu.Game.Online.API.Requests.GetBeatmapRequest [network] 2024-03-20 07:25:30 [verbose]: Request to https://dev.ppy.sh/api/v2/beatmaps/lookup successfully completed! [network] 2024-03-20 07:25:30 [verbose]: GetBeatmapRequest finished with response size of 3,170 bytes [database] 2024-03-20 07:25:30 [verbose]: [4fe02] [APIBeatmapMetadataSource] Online retrieval mapped Tsukiyama Sae - Hana Saku Iro wa Koi no Gotoshi (Log Off Now) [Destiny] to 744883 / 1613507. [database] 2024-03-20 07:25:30 [verbose]: Discarding metadata lookup result due to mismatching online ID (expected: 1570982 actual: 1613507) [network] 2024-03-20 07:25:30 [verbose]: Performing request osu.Game.Online.API.Requests.GetBeatmapRequest [network] 2024-03-20 07:25:30 [verbose]: Request to https://dev.ppy.sh/api/v2/beatmaps/lookup successfully completed! [network] 2024-03-20 07:25:30 [verbose]: GetBeatmapRequest finished with response size of 2,924 bytes [database] 2024-03-20 07:25:30 [verbose]: [4fe02] [APIBeatmapMetadataSource] Online retrieval mapped Tsukiyama Sae - Hana Saku Iro wa Koi no Gotoshi (Log Off Now) [Easy] to 744883 / 1570982. [database] 2024-03-20 07:25:30 [verbose]: Discarding metadata lookup result due to mismatching online ID (expected: 1613507 actual: 1570982) Note that the online IDs are swapped.	2024-03-20 08:28:11 +01:00
Bartłomiej Dach	e4418547fe	Document GetLastObjectTime() exception on empty beatmap	2024-03-19 19:19:07 +01:00
Joseph Madamba	f8a841e907	Add comment explaining why width is limited to the button area ... Same comment as a47ccb8edd/osu.Game/Screens/Select/BeatmapInfoWedgeV2.cs (L91-L92).	2024-03-14 00:17:22 -07:00
Joseph Madamba	b309aad895	Fix noticeable masking artifact of beatmap cards when already downloaded ... Had a similar fix before seeing https://github.com/ppy/osu/pull/20743#discussion_r994955470, but using that diff instead so co-authoring. Co-Authored-By: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2024-03-13 22:36:52 -07:00
Salman Ahmed	c1649b76d6	Reorder command properties to match general format ... I had them shuffled around in the middle of the refactor.	2024-03-08 21:33:53 +03:00
Salman Ahmed	8d3e502262	Merge branch 'master' into storyboard-loops-v2	2024-03-08 20:22:19 +03:00
Salman Ahmed	fa9b2f0cd5	Add generics to ApplyInitialValue/ApplyTransforms for ability to return custom transform sequences ... *sigh*	2024-03-08 03:07:39 +03:00
Salman Ahmed	585ab59768	Apply major refactor to the storyboard commands flow structrure	2024-03-08 01:10:09 +03:00
Bartłomiej Dach	3d8fdc52a4	Merge pull request #27501 from turbedi/throw_helper ... Use ThrowHelper methods in more places	2024-03-07 11:36:21 +01:00
Dean Herbert	0696e7de52	Update ImageSharp usages	2024-03-06 12:13:12 +08:00
Dean Herbert	b53b752e54	Update usage of MathUtils	2024-03-06 12:13:12 +08:00
Dean Herbert	6455c0583b	Update usage of CircularProgress.Current	2024-03-06 12:13:10 +08:00
Andrei Zavatski	8b03acd27b	Implement StoryboardElementWithDuration	2024-03-06 00:16:06 +03:00
Berkan Diler	a891303484	Use ArgumentOutOfRangeException throw helper methods	2024-03-05 10:20:30 +01:00
Andrei Zavatski	c05007804f	Use more direct way to apply transforms	2024-03-03 20:50:28 +03:00
Dean Herbert	cc8b838bd4	Add comprehensive log output to help figure out problematic clocks	2024-02-29 23:05:28 +08:00
Brandon	01d0ad506d	Merge branch 'master' into delete_none_message	2024-02-22 17:37:26 -08:00
Bartłomiej Dach	7861125e7a	Swap AR and OD on tooltips ... Matches everything else.	2024-02-22 12:11:49 +01:00
Bartłomiej Dach	46c8560ca5	Merge branch 'master' into multiplayer-difficulty-tooltip	2024-02-22 12:08:29 +01:00
Bartłomiej Dach	d06c67ad8f	Substitute two jank interdependent bool flags for single tri-state enums	2024-02-22 12:05:50 +01:00
Mike Will	012d6b7fe1	Change userBeatmapOffsetClock to a FramedOffsetClock ... Assuming that the global audio offset is set perfectly, such that any audio latency is fully accounted for, if a specific beatmap still sounds out of sync, that would no longer be a latency issue. Instead, it would indicate a misalignment between the beatmap's track and time codes, the correction for which should be a virtual-time offset, not a real-time offset.	2024-02-19 09:14:49 -05:00
Dean Herbert	7f82f10317	Fix beatmap potentially loading in a bad state ... Over-caching could mean that a beatmap could load and cause a late crash. Let's catch it early to avoid such a crash occurring.	2024-02-19 17:18:07 +08:00
Brandon	413b7aab60	Switch to const string	2024-02-18 22:12:03 -08:00
Brandon	c6ca812ea0	Add feedback to delete button even when no-op	2024-02-18 21:52:23 -08:00
Andrei Zavatski	dd32c0a226	Merge branch 'master' into judgements-rework	2024-02-16 20:08:57 +03:00
Bartłomiej Dach	138fea8c38	Only apply set-level metadata after all difficulties have been processed	2024-02-12 12:08:51 +01:00
Bartłomiej Dach	87702b3312	Only check online matching when determining whether to save online metadata ... After https://github.com/ppy/osu/pull/23362 I'm not sure the `LocallyModified` check is doing anything useful. It was confusing me really hard when trying to parse this logic, and it can misbehave (as `None` will also pass the check).	2024-02-12 12:07:20 +01:00
Bartłomiej Dach	4f0ae4197a	Refuse to apply online metadata in the most dodgy scenarios	2024-02-12 11:43:41 +01:00
Andrei Zavatski	5e692345de	Don't convert pixel data to array	2024-02-11 17:44:54 +03:00
Dean Herbert	7dba21fdac	Move init method to bottom of file	2024-02-11 20:05:58 +08:00
Dean Herbert	01501f3b82	Merge branch 'master' into refactor-metadata-lookup-sources	2024-02-10 14:43:51 +08:00
Andrei Zavatski	c500264306	Cache created judgement in HitObject	2024-02-09 23:20:31 +03:00
Berkan Diler	6adf0ac01e	Use new LINQ Order() instead of OrderBy() when possible	2024-02-08 18:01:00 +01:00
Dan Balasescu	b44f77cee1	Update R# + fix inspections	2024-02-02 21:00:28 +09:00
Dean Herbert	cf97cb1e0c	Merge branch 'master' into dont-round-sv	2024-01-26 19:16:58 +09:00
Dean Herbert	d66a2c452f	Merge branch 'master' into multiplayer-difficulty-tooltip	2024-01-25 21:18:16 +09:00
Dean Herbert	50300adef8	Tidy things up	2024-01-25 21:17:56 +09:00
Dean Herbert	aeac0a2a9d	Nullability	2024-01-25 21:16:12 +09:00
Dean Herbert	3c18efed05	Remove transparency	2024-01-25 21:13:47 +09:00
Dean Herbert	64ba95bbd6	Remove pointless comments	2024-01-25 21:13:47 +09:00
smallketchup82	2305a53a02	Remove max combo reading & remove unnecessary commas	2024-01-22 08:59:37 -05:00
Bartłomiej Dach	493d495992	Merge pull request #26605 from peppy/simplify-gameplay-pause ... Simplify gameplay pause sequence	2024-01-22 08:49:08 +01:00
Dean Herbert	c9945b41c1	Remove rounding of slider velocity (when applied as scroll speed) ... This affects both osu!taiko and osu!mania. Closes https://github.com/ppy/osu/issues/25862.	2024-01-18 18:37:44 +09:00
smallketchup82	5c70c786b4	Fix extended tooltip content still being shown despite ShowExtendedTooltip being false	2024-01-18 03:18:44 -05:00
Dean Herbert	8ab8c90e33	Remove "pause rate adjust" flow	2024-01-18 14:21:02 +09:00
Andrei Zavatski	42e4c933d3	Fix ConstrainedIconContainer always using masking	2024-01-18 04:06:02 +03:00
smallketchup82	060ea1d4fd	Switch from using a constructor argument to using a public field for ShowExtendedTooltip	2024-01-17 14:04:13 -05:00
smallketchup82	9a6541356e	Refactor the extended tooltip variables to be more descriptive	2024-01-17 13:31:23 -05:00
smallketchup82	b6422bc8bd	Apply suggested changes ... - Change difficultyicon mods parameter docstring to be more professional - Add a parameter for controlling whether the difficulty statistics show or not. Defaults to false - Round the BPM in the tooltip to make sure it displays correctly	2024-01-17 09:07:17 -05:00
smallketchup82	d2efa2e56a	peppy said he prefers the version without pipes so ill remove the pipes	2024-01-14 15:47:50 -05:00
smallketchup82	f7c1e66165	Make the difficulty stats change based on the currently applied mods	2023-12-22 17:28:02 -05:00
smallketchup82	3b58f6a7e7	Implement difficulty statistics	2023-12-21 21:07:12 -05:00
Dean Herbert	f09c6b8c1b	Change default values of new object counts to -1 to identify non-processed values	2023-12-19 18:20:02 +09:00
Dean Herbert	bfa90e9dcb	Also populate ObjectCounts when running a full beatmap process ... Saves running things twice on an old install	2023-12-18 18:41:41 +09:00
Dean Herbert	dc5c9837ed	Fix StarRatingDisplay's display width to avoid text making slight autosize changes	2023-12-15 16:00:03 +09:00
Bartłomiej Dach	c0e68df20f	Fix InverseDifficultyRange() not working correctly in both directions	2023-12-14 20:41:12 +01:00
Bartłomiej Dach	24e31f7d91	Implement inverse of IBeatmapDifficultyInfo.DifficultyRange()	2023-12-14 20:41:12 +01:00
Dan Balasescu	0171078052	Move object counts to BeatmapInfo	2023-12-13 17:33:24 +09:00
Dan Balasescu	767d5c8018	Add object counts to IBeatmapDifficultyInfo	2023-12-09 22:31:51 +09:00
Dean Herbert	1b50d1011a	Move constant local to taiko	2023-12-06 15:59:34 +09:00
Dean Herbert	b5bae566c2	Fix incorrect slider velocity being written on export for osu!taiko beatmaps	2023-12-06 15:59:34 +09:00
Dean Herbert	0af16732b8	Change default slider velocity to 1.4 ... This is the default in osu!stable and plays better than 1.0.	2023-12-06 13:38:46 +09:00
Dean Herbert	8704dc3505	Fix change in filter behaviour	2023-12-05 18:20:27 +09:00
Dean Herbert	42010574b5	Avoid list construction when doing filtering	2023-12-05 15:26:14 +09:00
Bartłomiej Dach	02c794cc1f	Merge pull request #25552 from peppy/fix-r#-inpsections ... Fix a couple of new r# inspections	2023-11-24 11:04:08 +09:00
Dean Herbert	268b965ee8	Enable NRT on Beatmap	2023-11-23 17:28:16 +09:00
Dean Herbert	a80a5be4ec	Fix a couple of new r# inspections	2023-11-23 17:11:40 +09:00
Dan Balasescu	7bc2d6e6cd	Merge branch 'master' into fix-combo-handling	2023-11-23 16:22:01 +09:00
Dan Balasescu	7998204cfe	Fix combo/combo colouring issues around spinners	2023-11-23 13:54:05 +09:00
Dan Balasescu	cb4568c4a1	Fix first object after break not starting a new combo	2023-11-22 17:22:48 +09:00
Bartłomiej Dach	b6e3e42445	Merge branch 'master' into bspline-sliders	2023-11-20 12:03:29 +09:00
cs	fa976a5aa0	Fix code style/quality issues	2023-11-13 08:25:27 +01:00
cs	54b8244a18	CI Fixup	2023-11-11 15:02:06 +01:00
Thomas Müller-Höhne	926636cc03	Generalize Bezier curves to BSplines of Nth degree	2023-11-11 13:32:53 +01:00
Dean Herbert	615d8384ab	Refactor everythign back to sanity	2023-11-09 22:31:28 +09:00
Bartłomiej Dach	c58a47760e	Merge pull request #25167 from peppy/fix-circle-radius ... Fix circle scale not matching stable due to missing multiplier	2023-10-20 20:59:53 +02:00
Dean Herbert	3fb74cb5f9	Move helper method to LegacyRulesetExtensions and stop applying rounding allowance to catch ... As discussed, it isn't used in stable like this. Was a mistake.	2023-10-20 18:57:14 +09:00
Bartłomiej Dach	c89081589c	Fix insufficient leniency when querying sample points	2023-10-20 10:26:16 +02:00
Dean Herbert	040d0970f2	Use DifficultyRange helper method in one more place	2023-10-18 23:54:18 +09:00
Dean Herbert	3a5490892c	Centralise and repair circle size calculations game-wide	2023-10-18 19:50:42 +09:00
Dean Herbert	e081fa48a2	Fix various other inspections	2023-10-17 17:48:51 +09:00
Dean Herbert	2781846147	Fix beatmaps with no preview point set getting incorrect default ... Note that this will require a re-import to fix existing beatmaps becuse.. it's stored to realm. Probably not worth worrying about for now.	2023-10-10 19:13:16 +09:00
Dean Herbert	f8455af0d0	Fix double interpolation being applied when applyOffsets=false	2023-10-05 13:20:52 +09:00
Dean Herbert	5a17a86d1d	Merge branch 'master' into clock-fix-attempt-2	2023-10-04 16:57:49 +09:00
Dean Herbert	2481c0b64b	Don't show replay import "missing beatmap" notifications during stable import ... Closes https://github.com/ppy/osu/issues/24926.	2023-09-27 17:04:43 +09:00
Dean Herbert	d019cb5167	Update in line with framed clock changes	2023-09-22 22:02:18 +09:00
Dean Herbert	6629a47ed3	Fix FramedBeatmapClock's source not being processed	2023-09-22 16:22:35 +09:00
Dean Herbert	bf08fbe196	Set source directly in FramedBeatmapClock ctor ... This isn't required, but avoids creating a temporary `StopwatchClock` and generally just makes debug easier with less state changes.	2023-09-22 16:22:35 +09:00