1
0
mirror of https://github.com/ppy/osu.git synced 2024-09-30 11:17:25 +08:00
Commit Graph

44033 Commits

Author SHA1 Message Date
Salman Ahmed
6dc11543ad Handle (null?) PP in PerformanceTable 2021-08-29 17:20:33 +03:00
Salman Ahmed
6aaef7b0be Handle null PP during score set in TopScoreStatisticsSection
Supersedes #14562
Closes #14541
2021-08-29 17:19:17 +03:00
Salman Ahmed
8f3416d853 Assert PP not null when showPerformancePoints is true 2021-08-29 16:03:39 +03:00
Salman Ahmed
e374ef163d Update localisable formattable extensions usages inline with framework change 2021-08-29 15:00:28 +03:00
Joseph Madamba
9a5445bded Fix overlays closing when clicking any empty area of the toolbar instead 2021-08-28 22:25:13 -07:00
Joseph Madamba
38912bfc16 Fix floating overlays not closing when clicking some empty area of the toolbar 2021-08-28 20:38:35 -07:00
Bartłomiej Dach
2efe82a18d
Remove popover container from manual input manager test scene 2021-08-28 20:20:42 +02:00
Bartłomiej Dach
d9db1ecee9
Remove game-global popover container 2021-08-28 20:05:59 +02:00
Bartłomiej Dach
fcc3e57d5d
Move overlay colour provider up to editor screen 2021-08-28 20:05:58 +02:00
Bartłomiej Dach
e94d96f250
Add local popover container to editor screens 2021-08-28 20:05:58 +02:00
Bartłomiej Dach
7457480b50
Add local popover container to lounge subscreen 2021-08-28 20:05:58 +02:00
Bartłomiej Dach
7122f48568
Merge pull request #14552 from frenzibyte/fix-test-visibility-regression
Fix editor screen test scenes not updated to show their screens
2021-08-28 19:55:44 +02:00
Salman Ahmed
eb90cedc9b Fix editor screen test scenes not updated to show their screens 2021-08-28 20:09:35 +03:00
Dean Herbert
6f03f7a6a6
Merge pull request #14534 from peppy/fix-tournament-startup-crash
Fix tournament client crashing at startup when osu!(stalble) is at ranking screen
2021-08-28 17:44:01 +09:00
Bartłomiej Dach
d37df6afec
Fix test failing after BDL -> [Test] change 2021-08-28 09:45:00 +02:00
Dean Herbert
b008a86d8c Remove unused using statement 2021-08-28 16:35:54 +09:00
Dean Herbert
6ef096001e Fix several cases of incorrect handling of CurrentMatch nullability 2021-08-28 16:24:36 +09:00
Dean Herbert
303c70791d Add more failing test coverage for null CurrentMatch 2021-08-28 16:24:36 +09:00
Dean Herbert
e9b97f7937 Fix tournament crashing when osu!(stable) is at ranking screen at startup 2021-08-28 14:28:33 +09:00
Dean Herbert
7fbeb9ecc7 Add failing test coverage for tournament startup states 2021-08-28 14:28:30 +09:00
Salman Ahmed
589f2863ca Move incompatibility tooltip logic to local player mod select overlays
This one turned out to be a bit more involved, due to tooltips being
shared and having the potential of being used somewhere where it
shouldn't be, due to the same content type matching.

That's the reason I've defined a protected `TargetContentType`, to be
able to separate "local player mod tooltips" and regular mod tooltips
apart.

Definitely unsure about the solution, but that's as far as I can think
of right now.
2021-08-28 02:38:46 +03:00
Salman Ahmed
e527bfd4bf Move incompatibility icon logic to local player mod select overlays 2021-08-28 02:37:46 +03:00
Salman Ahmed
69f5705ca0
Merge pull request #14526 from peppy/update-framework
Update framework
2021-08-28 01:42:50 +03:00
Dean Herbert
681a87d4ec Update framework 2021-08-28 07:08:06 +09:00
Dean Herbert
804ca88d63 Update framework 2021-08-27 19:52:45 +09:00
Salman Ahmed
378734a7f8 Separate solo spectator player and "exit on restart" logic to own class 2021-08-27 13:24:37 +03:00
Salman Ahmed
1650fbb8be Add failing test steps 2021-08-27 13:24:37 +03:00
Dean Herbert
2bfb9d5478
Merge pull request #14512 from nekodex/lobby-sounds
Add sounds for some lobby events
2021-08-27 19:21:11 +09:00
Salman Ahmed
b7a0316194 Shorten test player count to 4 for less steps 2021-08-27 13:14:56 +03:00
Dean Herbert
97f27897b1 Add test coverage of mass multiplayer event firing 2021-08-27 18:57:35 +09:00
Dean Herbert
2b06dacd0e Change debounce back to using scheduler
Should better allow for adjusting in the future, as well.
2021-08-27 18:57:19 +09:00
Dean Herbert
33aa48bcf6 Merge branch 'master' into lobby-sounds 2021-08-27 18:46:12 +09:00
Dean Herbert
23414b0c63 Combine test scene to avoid huge copy paste 2021-08-27 18:44:44 +09:00
Dean Herbert
34d185d846 Convert final step to until step to avoid unnecessary delays 2021-08-27 18:39:36 +09:00
Dean Herbert
7d9bae4507 Update resources 2021-08-27 18:29:49 +09:00
Dan Balasescu
8e57547ec3
Merge pull request #14510 from peppy/avoid-default-skin-judgement-transform-overhead
Change default skin's judgement result transform to reduce allocation overhead
2021-08-27 10:34:44 +09:00
Dan Balasescu
f0296e5d12
Merge branch 'master' into avoid-default-skin-judgement-transform-overhead 2021-08-27 10:02:40 +09:00
Dan Balasescu
4f22acb632
Merge pull request #14507 from peppy/path-control-point-bindable-removal
Remove bindable usage in `PathControlPoint`
2021-08-27 10:02:29 +09:00
Dan Balasescu
a28bc9f6b2
Merge branch 'master' into path-control-point-bindable-removal 2021-08-27 09:37:37 +09:00
Bartłomiej Dach
aacca006e4
Merge pull request #14487 from frenzibyte/alternative-difficulty-bindable
Fix unbind exception in `DifficultyBindable` due to different bindable type bindings
2021-08-26 23:29:54 +02:00
Bartłomiej Dach
2ef2af17eb
Merge branch 'master' into alternative-difficulty-bindable 2021-08-26 23:07:52 +02:00
Bartłomiej Dach
b2ab670ae4
Merge pull request #14506 from peppy/skip-overlay-optimisations
Remove delegate overhead in `SkipOverlay`
2021-08-26 23:00:04 +02:00
Bartłomiej Dach
d71dff4340
Merge branch 'master' into skip-overlay-optimisations 2021-08-26 22:38:17 +02:00
Salman Ahmed
cea632463e Remove empty newline 2021-08-26 22:30:20 +03:00
Bartłomiej Dach
23df13d6d2
Merge pull request #14495 from frenzibyte/fix-mania-editor
Fix osu!mania editor crashing on compose screen load
2021-08-26 21:28:26 +02:00
Bartłomiej Dach
875ef3e68f
Merge branch 'master' into fix-mania-editor 2021-08-26 21:00:20 +02:00
Dean Herbert
90e81a595d Move DrumSampleTriggerSource into its own class to avoid nested references 2021-08-26 17:19:46 +09:00
Dean Herbert
f078a9d2bf Fix incorrect step type 2021-08-26 17:17:39 +09:00
Dean Herbert
15aa0458bc Use PausableSkinnableSound instead 2021-08-26 17:15:36 +09:00
Dean Herbert
ec85d7f356 Remove unused helper method 2021-08-26 17:15:23 +09:00