1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-15 13:47:24 +08:00
Commit Graph

11805 Commits

Author SHA1 Message Date
Fabep
6adaf6a41f Changed ModCustomisationPanelState names 2024-08-28 10:09:47 +02:00
Bartłomiej Dach
a3b0ff4808
Merge branch 'master' into break-overlay-animation 2024-08-27 11:17:56 +02:00
Bartłomiej Dach
321e509f11
Merge pull request #29615 from peppy/break-overlay-improvements
Add shadow around break overlay middle content to make sure it remains visible
2024-08-27 11:16:08 +02:00
Bartłomiej Dach
7c0550d251
Merge pull request #29500 from frenzibyte/fix-pausing-for-the-millionth-time
Fix oversight in osu! pause input handling
2024-08-27 10:04:47 +02:00
Bartłomiej Dach
e59689f31a
Fix test and NRT failure 2024-08-27 09:49:49 +02:00
Dean Herbert
6f1664f0a6
Add beat-synced animation to break overlay
I've been meaning to make the progress bar synchronise with the beat
rather than a continuous countdown, just to give the overlay a bit more
of a rhythmic feel.

Not completely happy with how this feels but I think it's a start?

I had to refactor how the break overlay works in the process. It no
longer creates transforms for all breaks ahead-of-time, which could be
argued as a better way of doing things. It's more dynamically able to
handle breaks now (maybe useful for the future, who knows).
2024-08-27 16:34:37 +09:00
Dean Herbert
c2c83fe73d
Fix TestSceneBreakTracker not removing old drawables
Also adds a bright background for testing overlay display.
2024-08-27 14:33:36 +09:00
Salman Ahmed
b54487031a Add DailyChallengeButton for intro played flag reset logic 2024-08-24 22:19:17 +09:00
Jonas Brandstötter
89a4025c01
Fix Daily Challenge play count using a different colour than osu-web 2024-08-24 11:21:28 +02:00
Salman Ahmed
f5e195a7ee Remove existing test asserts 2024-08-24 06:40:30 +09:00
Dean Herbert
3943fe96f4
Add failing test showing deserialise failing with some skins 2024-08-23 20:44:35 +09:00
Dean Herbert
60271fb0f7
Merge pull request #29564 from peppy/skinnable-components-what-2
Remove requirement of `base` calls to ensure user skin container layouts are retrieved
2024-08-23 17:52:46 +09:00
Dean Herbert
48cfd77ee8
Component -> Lookup 2024-08-23 14:48:50 +09:00
Bartłomiej Dach
a32a817305
Merge pull request #29512 from peppy/toolbar-pp-change-weird
Fix toolbar PP change showing `+0` instead of `0`
2024-08-22 12:08:12 +02:00
Dean Herbert
b57b8168a6
Rename Target lookup to Component 2024-08-22 19:00:28 +09:00
Dean Herbert
9a21174582
Move GlobalSkinnableContainers to global scope 2024-08-22 18:46:07 +09:00
Dean Herbert
f37cab0c6e
Rename SkinComponentsContainerLookup to GlobalSkinnableContainerLookup 2024-08-22 18:39:36 +09:00
Dean Herbert
41756520b1
Rename SkinComponentsContainer to SkinnableContainer 2024-08-22 17:42:50 +09:00
Dean Herbert
67f0ea5d7d
Fix flooring causing delta to not work as expected 2024-08-22 16:22:00 +09:00
Dean Herbert
7e483bbee3
Merge pull request #29541 from frenzibyte/fix-mod-customisation-dragging-outside
Keep mod customisation panel open when dragging outside
2024-08-22 15:28:32 +09:00
Bartłomiej Dach
d33f4837fa
Merge pull request #29532 from bdach/redesign-timing-table-tracking
Redesign timing table tracking
2024-08-22 08:21:39 +02:00
Dean Herbert
9b9986b6f2
Add isolated test for daily challenge intro flag 2024-08-22 15:14:52 +09:00
Dean Herbert
236a273e09
Simplify DailyChallengeIntro test scene
Seems like some bad copy-paste in the past. Most of this is already
being done in `TestSceneDailyChallenge`.
2024-08-22 15:14:42 +09:00
Dean Herbert
dfb4a76e29
Fix test being repeat step 2024-08-22 14:45:40 +09:00
Dean Herbert
54e5f1c9f0
Merge pull request #29556 from frenzibyte/kiai-star-bursts
Add star fountains/bursts when entering kiai mode in gameplay
2024-08-22 14:14:25 +09:00
Salman Ahmed
a669c53df7 Add failing test cases 2024-08-22 06:00:07 +09:00
Dean Herbert
a943000579
Merge pull request #29435 from OliBomby/improve-snaps
Fix timeline snapping ignoring nearby timing points
2024-08-22 01:36:30 +09:00
Dean Herbert
2876cb73bd
Merge pull request #28991 from Layendan/master
Add collection and favourite buttons to results screen
2024-08-21 23:59:26 +09:00
Salman Ahmed
c92af71029 Add in-gameplay version of kiai star fountains/burst 2024-08-21 17:34:38 +09:00
OliBomby
8d72ec8bd6 move timing point binary search back inline 2024-08-21 01:50:52 +02:00
OliBomby
ff3bffc7d9 add test 2024-08-21 00:30:57 +02:00
OliBomby
ae6d855f8d Merge remote-tracking branch 'upstream/master' into doubleclick 2024-08-20 23:19:27 +02:00
Salman Ahmed
ae4fefeba1 Add failing test case 2024-08-21 03:22:03 +09:00
Dan Balasescu
2011d5525f
Add flaky test attribute to some tests
See occurences like https://github.com/ppy/osu/actions/runs/10471058714.
2024-08-20 22:21:10 +09:00
Dan Balasescu
44213a34ae
Merge pull request #29508 from peppy/hold-for-menu-sometimes
Change "hold for menu" button to only show for touch by default
2024-08-20 21:45:50 +09:00
Bartłomiej Dach
3202c77279
Add failing test 2024-08-20 12:36:05 +02:00
Dean Herbert
a633fcdb49
Merge branch 'master' into redesign-timing-table-tracking 2024-08-20 19:16:03 +09:00
Bartłomiej Dach
333e5b8cac
Remove outdated tests 2024-08-20 11:23:39 +02:00
Dean Herbert
73f2f5cb12
Fix more tests 2024-08-20 17:59:55 +09:00
Dean Herbert
c85b04bca5
Add more test coverage to better show overlapping break / kiai sections 2024-08-20 17:45:44 +09:00
Salman Ahmed
2ecf5ec939 Add further test coverage 2024-08-20 16:47:20 +09:00
Dean Herbert
5ba1b4fe3d
Update test coverage 2024-08-20 01:13:00 +09:00
Bartłomiej Dach
7693d4c039
Merge branch 'master' into master 2024-08-19 14:30:20 +02:00
Dean Herbert
610ebc5481
Fix toolbar PP change showing +0 instead of 0 2024-08-19 20:50:11 +09:00
Salman Ahmed
9e962ce314 Add failing test case 2024-08-19 14:14:12 +09:00
OliBomby
3d4bc8a2cc fix tests 2024-08-16 15:04:38 +02:00
Dan Balasescu
7a47597234
Add one more case 2024-08-16 18:21:06 +09:00
Dan Balasescu
e0da476346
Add tests for util function 2024-08-16 18:12:46 +09:00
Dean Herbert
68bad9a277
Attempt file operations more than once in another test instance
See
https://github.com/ppy/osu/pull/29433/checks?check_run_id=28833985792.
2024-08-16 17:39:45 +09:00
Dean Herbert
5710f0f302
Merge pull request #26254 from frenzibyte/mania-combo-counter
Add argon/classic osu!mania combo counter
2024-08-15 17:56:28 +09:00
Dean Herbert
e603888130
Update remaining tests to use new base class (and tidy up V2 suffixes) 2024-08-14 21:09:28 +09:00
Dean Herbert
1665d9a93e
Fix failing test setup 2024-08-14 21:01:35 +09:00
Joseph Madamba
6f2bc7e6f1 Use Content override instead 2024-08-14 00:44:03 -07:00
Dean Herbert
2174510544
Move other V2 tests to new test namespace 2024-08-14 15:51:07 +09:00
Joseph Madamba
c24f1444f9 Directly resolve IBindable<WorkingBeatmap> by making a local variant of DifficultyNameContent 2024-08-13 23:26:18 -07:00
Joseph Madamba
f8796e3192 Move resizing width and background logic to SongSelectComponentsTestScene 2024-08-13 23:26:17 -07:00
Joseph Madamba
2b41f71fd0 Workaround single-frame layout issues with {Link|Text|Fill}FlowContainers 2024-08-13 23:26:17 -07:00
Joseph Madamba
625c6fc7eb Implement song select v2 difficulty name content component 2024-08-13 23:26:17 -07:00
Joseph Madamba
46d41cb590 Add base song select components test scene 2024-08-13 23:26:17 -07:00
Dean Herbert
e465049050
Merge branch 'master' into mania-combo-counter 2024-08-14 15:12:00 +09:00
Dean Herbert
dd9705b660
Fix file access test failure by forcing retries
See https://github.com/ppy/osu/actions/runs/10369630825/job/28708248682.
2024-08-14 12:26:21 +09:00
Salman Ahmed
7acc1772cb Add test coverage 2024-08-13 13:07:21 +03:00
Dean Herbert
14a00621f8
Fix occasional test failures in TestSceneBetmapRecommendations
The game was being constructed befor the API was setup, which could mean
depending on test execution ordering and speed, the recommendations
array would not be filled.

Easy to reproduce by `[Solo]`ing `TestCorrectStarRatingIsUsed`.

See https://github.com/ppy/osu/runs/28689915929#r0s0.
2024-08-13 17:28:16 +09:00
Dan Balasescu
58354e3e68
Fix another test
The last two PRs didn't interact well together.
2024-08-13 17:18:11 +09:00
Dan Balasescu
4b4f0ecf7d
Merge pull request #29342 from cl8n/remove-mania-action-special
Remove "Special" `ManiaAction`s for center columns
2024-08-13 15:36:36 +09:00
Dan Balasescu
cd76f474d8
Merge pull request #29388 from cl8n/fix-mania-replay
Fix error on parsing osu!mania replays with 18 or more keys
2024-08-13 15:29:53 +09:00
Bartłomiej Dach
06c2952fe8
Merge branch 'master' into grids-3 2024-08-12 13:55:35 +02:00
Bartłomiej Dach
92bd123ebc
Merge pull request #29363 from peppy/fix-daily-challenge-notification-spam
Fix daily challenge notification spam
2024-08-12 12:18:38 +02:00
Bartłomiej Dach
041c70e4eb
Fix tests 2024-08-12 11:19:02 +02:00
clayton
2233602184
Update mania replay decode test to include 18K keypress 2024-08-11 09:45:42 -07:00
Dan Balasescu
104942ccf6
Merge pull request #29362 from peppy/dont-truncate-floating-point-positioning
Fix hit object coordinates being truncated to `int` values
2024-08-09 19:10:24 +09:00
Dean Herbert
c8a7727199
Make ID retrieval global to all tests and fix multiple other usages 2024-08-09 17:46:51 +09:00
Dean Herbert
18c80870d8
Update one more RNG usage in same tests 2024-08-09 17:40:48 +09:00
Dean Herbert
0a8e342830
Fix occasionally ChatOverlay test failures due to RNG usage
See https://github.com/ppy/osu/actions/runs/10302758137/job/28517150950.

Same ID gets chosen twice for PM channel.
2024-08-09 17:38:17 +09:00
Dean Herbert
2114f092c7
Add failing test coverage showing coordinate truncation 2024-08-09 16:34:39 +09:00
Dean Herbert
80c814008f
Update in line with new changes 2024-08-09 14:55:01 +09:00
Dean Herbert
e645651ef4
Merge branch 'master' into mania-combo-counter 2024-08-09 00:19:17 +09:00
Dean Herbert
dcafee7cb7
Merge pull request #26249 from frenzibyte/ruleset-specific-combo-counter
Move combo counter to ruleset-specific HUD components container
2024-08-08 17:41:58 +09:00
Dean Herbert
278d887ee5
Fix test failures due to missing room name 2024-08-08 15:10:14 +09:00
Dean Herbert
1ee5522a25
Merge branch 'master' into daily-challenge-intro-screen-part-2 2024-08-08 14:08:14 +09:00
clayton
48d9bc982f
Fix tests 2024-08-07 14:36:04 -07:00
Dean Herbert
3c572abaa7
Merge branch 'master' into ruleset-specific-combo-counter 2024-08-08 03:21:52 +09:00
Bartłomiej Dach
e6d5389608
Merge branch 'master' into hover-open-mod-customise 2024-08-07 14:05:19 +02:00
Bartłomiej Dach
518c1aa5a0
Remove weird Expanded / ExpandedState duality 2024-08-07 14:01:30 +02:00
Bartłomiej Dach
437812eebe
Merge pull request #29279 from normalid-awa/bugfix/editor/delete-operation-wont-close-the-menu
Close context menus when deselecting items in editor
2024-08-07 13:25:13 +02:00
Salman Ahmed
a0615a8f18
Frenzi's WIP animation 2024-08-07 19:07:45 +09:00
Dean Herbert
6870311c1e
Remove requirement of specifying animateOnnter in BackgroundScreen ctor 2024-08-07 19:07:44 +09:00
Dean Herbert
b081b47714
Add test of daily challenge flow from main menu 2024-08-07 19:07:44 +09:00
Dean Herbert
b1488fd5b7
Merge pull request #29027 from normalid-awa/feature/skin/legacy-input-overlay
Add legacy key counter support
2024-08-07 17:48:30 +09:00
Dean Herbert
1aea8e911c
Add test coverage of chat mentions 2024-08-07 01:33:56 +09:00
Dean Herbert
f7b45a26de
Improve test coverage and segregation 2024-08-06 19:32:00 +09:00
Dean Herbert
9ccd8c906d
Merge branch 'master' into hover-open-mod-customise 2024-08-06 18:35:35 +09:00
Dean Herbert
8619bbb943
Fix legacy key counter's background being visible when intended to be hidden 2024-08-06 16:12:00 +09:00
Dan Balasescu
c574551ee0
Simplify caching 2024-08-06 16:02:36 +09:00
Dean Herbert
60fc02bb9b
Merge branch 'master' into feature/skin/legacy-input-overlay 2024-08-06 14:05:33 +09:00
Dan Balasescu
d637bbf752
Merge pull request #29286 from peppy/middle-click-delete
Allow object deletion with middle mouse
2024-08-06 13:38:56 +09:00
jkh675
59ff549b4d Remove unused using 2024-08-05 16:46:56 +08:00
jkh675
3c8d0ce59f Revert the unit test changes 2024-08-05 16:40:31 +08:00
Dean Herbert
17eb134797
Merge branch 'master' into bugfix/visual/long-commet-tooltip-overflow 2024-08-05 17:01:20 +09:00
Dean Herbert
24a0ead62e
Make tests actually show what value they are testing 2024-08-05 17:01:00 +09:00
Dean Herbert
9c5e29b2c9
Fix test being disabled for cases which should pass 2024-08-05 16:58:00 +09:00
Dean Herbert
c0814c2749
Add test of existing slider placement behaviour for safety 2024-08-05 14:25:10 +09:00
Dean Herbert
9673985e2c
Add test coverage of right/middle click behaviours with placement blueprints 2024-08-05 14:25:09 +09:00
Dan Balasescu
136cdcfb29
Merge pull request #29059 from frenzibyte/fix-results-fetching-twice
Fix results screen fetching scores twice when scrolled to edge
2024-08-05 14:23:47 +09:00
Dean Herbert
419d5a76ce
Merge branch 'master' into fix-pause-in-osu-again 2024-08-05 12:00:21 +09:00
jkh675
2098fb8a9d Fix code quality 2024-08-05 00:08:02 +08:00
jkh675
1b25633e47 Fix headless test 2024-08-04 23:45:42 +08:00
jkh675
2720bcf285 Fix ruleset unit test 2024-08-04 22:37:54 +08:00
jkh675
7cebf4c3d2 Fix code quality 2024-08-04 21:18:03 +08:00
jkh675
38dacfeaa2 Fix unit test 2024-08-04 21:12:09 +08:00
jkh675
273bd73a99 Fix unit test error 2024-08-04 19:50:57 +08:00
jkh675
6f9866d542 Add unit test for OsuTooltip 2024-08-04 18:56:19 +08:00
Dean Herbert
7765d0ff70
Merge pull request #29157 from frenzibyte/user-profile-daily-challenge-streak-display
Add daily challenge stats display to user profile overlay
2024-08-03 23:57:19 +09:00
Dean Herbert
531cf64ddb
Add failing test showing date added changing when importing as update with no change 2024-08-02 20:46:02 +09:00
Caiyi Shyu
c85dc40f91
Merge branch 'master' into hover-open-mod-customise 2024-08-02 19:07:27 +08:00
Salman Ahmed
dc9f6a07cb Fix inspections 2024-08-02 11:16:32 +03:00
Salman Ahmed
c3b2d81066 Add failing test case 2024-08-02 10:19:44 +03:00
Dean Herbert
310def64f4
Merge branch 'master' into user-profile-daily-challenge-streak-display 2024-08-02 15:40:46 +09:00
Dean Herbert
816dee181a
Rename classes to remove "streak" terminology
Since the primary display isn't showing a streak.
2024-08-02 15:33:30 +09:00
Caiyi Shyu
051d52c23f Update ModCustomisationPanel to use ExpandedState enum 2024-08-01 19:25:45 +08:00
Dean Herbert
e9ed9ff58b
Merge pull request #29188 from bdach/daily-challenge/better-messaging
Add notification on daily challenge conclusion & start of new one
2024-07-31 13:35:25 +09:00
Dean Herbert
5ebb5ad670
Fix test failure due to TestMetadataClient providing null statistics array 2024-07-31 02:53:10 +09:00
Dean Herbert
d75c170ba1
Merge branch 'master' into daily-challenge/better-messaging 2024-07-30 19:04:48 +09:00
Dean Herbert
71649005bf
Elongate usernames in DrawableChannel test 2024-07-30 17:52:55 +09:00
Dean Herbert
71acb7e9fc
Merge pull request #29137 from normalid-awa/feature/visual/chatline-background-altering
Alternate background colour of chat lines to better visually distinguish wrapped lines
2024-07-30 17:51:41 +09:00
Bartłomiej Dach
1b57a2a136
Show new daily challenge notification globally 2024-07-30 10:36:26 +02:00
Bartłomiej Dach
a05f810724
Attempt to fix tests more 2024-07-30 10:07:38 +02:00
Bartłomiej Dach
ae38e66036
Add failing test coverage 2024-07-30 08:39:01 +02:00
Salman Ahmed
91dfe4515b Fix daily challenge display showing incorrect statistic 2024-07-30 08:12:03 +03:00
Salman Ahmed
7c3d592a84 Fix user profile overlay test scene being broke 2024-07-30 07:06:59 +03:00
Bartłomiej Dach
5032a149e7
Merge pull request #29187 from peppy/daily-challenge-pieces-not-always-present
Favour updating daily challenge statistics when they come on screen
2024-07-29 15:48:26 +02:00
Bartłomiej Dach
b77a10b6db
Fix tests maybe 2024-07-29 15:28:52 +02:00
Dean Herbert
1daeb7ebd0
Rename typo in test naming 2024-07-29 22:19:38 +09:00
Bartłomiej Dach
b46f3c97da
Add notification on daily challenge conclusion & start of new one
Because I wish to stop seeing "DAILY CHALLENGE WHERE" every day
on #general.

The notifications are constrained to the daily challenge screen only to
not spam users who may not care.
2024-07-29 14:30:10 +02:00
Dean Herbert
7afcd72872
Fix potentially too many scores displaying in breakdown while in gameplay 2024-07-29 20:58:42 +09:00
Dean Herbert
76cd2df699
Add ability to test daily challenge carousel items when hidden 2024-07-29 20:43:47 +09:00
Dean Herbert
997b3eb498
Fix typos and visuals 2024-07-29 20:24:51 +09:00
Shreyas Kadambi
ae61df0abe Add back accidentally removed test 2024-07-28 11:47:00 -04:00
Shreyas Kadambi
1c9c3c92fd Add tests for expected timestamp format 2024-07-28 11:30:42 -04:00
normalid
e58bdbb8a9 Improve unit test 2024-07-28 15:08:36 +08:00
Salman Ahmed
82fbd5b045 Rename file 2024-07-28 06:40:16 +03:00
Salman Ahmed
e82c54a31c Integrate daily challenge streak display with user profile overlay 2024-07-28 05:58:30 +03:00
Salman Ahmed
17f5d58be2 Add daily challenge streak display and tooltip 2024-07-28 05:58:27 +03:00
Joseph Madamba
bc25e5d706 Remove unnecessary depth and padding set 2024-07-27 19:13:11 -07:00
Joseph Madamba
850bcaef7a Merge remote-tracking branch 'upstream/master' into pr/28991 2024-07-27 19:09:02 -07:00
Joseph Madamba
b4ca07300a Use same size button for everything 2024-07-27 18:43:54 -07:00
normalid
4e44a6e7f8 Clean up code 2024-07-27 18:55:17 +08:00
normalid
73a98b45e9 FIx code quality 2024-07-27 18:48:45 +08:00
normalid
7f4bfb25a9 Implement unit test 2024-07-27 18:24:32 +08:00
Caiyi Shyu
bd017aea38
fix TestPreexistingSelection failing 2024-07-26 23:58:52 +08:00