38 Commits

• Fix replay/spectator scroll text not toggling with Ctrl+H (#37027)

  Intended to add toggle but forgot.
  
  This also fixes https://github.com/ppy/osu/issues/37012 via a convoluted
  refactor of a lot of stuff. The basic overview is:
  
  - Moved all replay overlay concerns out of `HUDOverlay`. We can display
  this above everything confidently (i think).
  - Split out `ReplayOverlay` and `ReplaySettingsOverlay` so the base
  class can handle the visibility, hotkeys and everything that should be
  shared with *all* replay overlay components going forward. `Ctrl+H` is
  supposed to hide any of these kinds of details, and I'm sure we'll add
  more in the future.
  - Reorganised some things in `Player` so the new structure would work.
  Mainly the overlays which add a black layer during fade out.

  Dean Herbert · 2026-04-01 11:29:25 +02:00
  279effe23c
• Move v2 files to final location

  This contains only renames and namespace updates.

  Dean Herbert · 2026-03-03 16:45:15 +09:00
  c28c64940a
• Fix failing test case due to mod overlay being moved to game level
  Dean Herbert · 2026-01-10 01:44:07 +09:00
  dda1c7f75b
• Attempt to fix flaky TestGameplaySettingsDoesNotExpandWhenSkinOverlayPresent

  See https://github.com/ppy/osu/pull/35118/checks?check_run_id=51202910556.

  Dean Herbert · 2025-09-25 15:56:48 +09:00
  12e29f0bcc
• Fix skin editor tests not passing on macOS
  Dan Balasescu · 2025-08-03 03:50:06 +09:00
  0270ca6cf1
• Update existing tests to work with Song Select v2
  Dean Herbert · 2025-07-01 17:25:38 +09:00
  397b9b3994
• Adjust test to pass

  What I think was happening here is that the dump of the accuracy
  counter's state was happening too early. The component is loaded
  synchronously into the `ISerialisableDrawableContainer` before its
  default position is set via the "apply defaults" `ArgonSkin` flow
  - so the test needs to wait for that to take place first.

  Bartłomiej Dach · 2025-01-13 13:14:34 +01:00
  39a69d6454
• Merge branch 'master' into fix-skin-editor-undo
  Bartłomiej Dach · 2025-01-13 12:39:51 +01:00
  8968ab19d9
• Add failing test showing player settings appearing in skin editor
  Dean Herbert · 2024-12-13 17:18:34 +09:00
  b470e30cc0
• Add failing test coverage of skin editor still not undoing correctly to initial state
  Bartłomiej Dach · 2024-10-16 14:21:07 +02:00
  f84f6b78d9
• Rename SkinComponentsContainer to SkinnableContainer
  Dean Herbert · 2024-08-22 17:42:50 +09:00
  41756520b1
• Add failing test for skins not saving on change
  Bartłomiej Dach · 2024-04-29 14:38:49 +02:00
  fa3aeca09d
• Add failing test coverage
  Bartłomiej Dach · 2024-02-19 09:59:25 +01:00
  444ac5ed4d
• Extend test coverage of skin editor open to fail better
  Bartłomiej Dach · 2023-12-06 10:11:41 +01:00
  faf60cec91
• Do not attempt to load gameplay scene if current beatmap is dummy
  Bartłomiej Dach · 2023-12-04 14:42:51 +01:00
  063694f544
• Add test coverage for crashing on wrong ruleset
  Bartłomiej Dach · 2023-12-04 14:42:51 +01:00
  43312619e3
• Add test coverage for crashing on dummy beatmap
  Bartłomiej Dach · 2023-12-04 14:42:42 +01:00
  7c041df0f1
• Add test coverage for crashing on empty beatmap
  Bartłomiej Dach · 2023-12-04 14:42:40 +01:00
  d3e94cd5bf
• Extract beatmap import steps from gameplay scene switch helper
  Bartłomiej Dach · 2023-12-04 13:34:36 +01:00
  7deff70b4a
• Add failing test case for skin editor freeze
  Bartłomiej Dach · 2023-10-27 14:23:41 +02:00
  b5cb538004
• Rename test to distinguish it from test-to-come
  Bartłomiej Dach · 2023-10-27 14:15:30 +02:00
  6789a522d6
• Adjust failing test after permitting autoplay and no fail combo
  Bartłomiej Dach · 2023-07-13 21:22:48 +02:00
  ae7ed697ec
• Add failing test coverage for clearing sidebar contents
  Bartłomiej Dach · 2023-03-04 14:08:50 +01:00
  9d4bb2ecf7
• Move NonSkinnableScreenPlaceholder to outer scope
  Bartłomiej Dach · 2023-03-04 13:22:43 +01:00
  2f25fb4083
• Add failing test case
  Bartłomiej Dach · 2023-03-04 13:17:54 +01:00
  3dd3b5e77a
• Move skin editor to overlays namespace
  Dean Herbert · 2023-02-02 14:00:31 +09:00
  8dc2e6872e
• Use ToString() for test instead of linq skip
  Dean Herbert · 2023-01-17 11:51:17 +09:00
  4cf448ec11
• Select button using its index in test
  ansel · 2023-01-16 22:47:14 +03:00
  0ec608ec5d
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Merge branch 'master' into skin-editor-transform-fix
  Dean Herbert · 2022-06-20 14:10:01 +09:00
  7daab2d45b
• Move beatmap import step to only be required when entering gameplay
  Dean Herbert · 2022-06-20 14:08:05 +09:00
  e4d0c7a0fb
• Add test coverage of original fail case and improve test reliability and code quality
  Dean Herbert · 2022-06-20 14:08:05 +09:00
  329f1a0822
• Move common step of toggling skin editor to own method
  Dean Herbert · 2022-06-20 13:32:44 +09:00
  243806e810
• add test coverage
  Gabe Livengood · 2022-06-19 14:35:05 -04:00
  2b0e82be40
• Actually click the gameplay scene button than TriggerClick
  Salman Ahmed · 2022-06-18 18:32:02 +03:00
  47ce087694
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Add failing test for mod overlay not closing on entering skin editor
  Bartłomiej Dach · 2022-05-07 22:47:19 +02:00
  bdea6d8654
• Rename skin editor scene library test scene to be more general
  Bartłomiej Dach · 2022-05-07 22:43:53 +02:00
  a3e61fddcb