375 Commits

• Fix mania hold notes dimming unexpectedly (#37008)

  Fixes https://github.com/ppy/osu/issues/29223
  
  This fixes several issues around hold note dimming.
  
  Notice in the following video:
  - The tail piece of the first note not getting dimmed.
  - The body of the second note not responding to dimming at all.
  
  
  https://github.com/user-attachments/assets/8e51053d-8d88-4e48-909b-79218d65917b
  
  Then, notice in the following video:
  - The body piece of the second note is dimmed from the very beginning.
  
  
  https://github.com/user-attachments/assets/a514c630-5c72-4ba5-96d5-472bae1058b3
  
  This requires a specific setup whereby the hold note and its components
  must be reused from the pool. In particular:
  1. The hold note must be long. So long that by the time the tail becomes
  on screen, the body will already have dimmed.
  2. The hold note must be re-used from the pool. We can induce this by
  setting the pool sizes to 1 in
  [`Column.cs`](https://github.com/ppy/osu/blob/780ce2666099c22d1e0673cafab544418b5d14b0/osu.Game.Rulesets.Mania/UI/Column.cs#L121-L123).
  3. The second hold note should be placed far enough in the timeline that
  the first hold note dies by the time it becomes visible.
    4. Scroll speed should be adjusted to fit the above constraints.
  
  I haven't done a full deep dive into exactly _why_ this is happening, so
  the fix here is hand-wavy. That said, just by looking at the old code in
  `LegacyBodyPiece` you'll get a feeling that something's bound to go
  wrong;
  - It never resets the `missingFadeTime` state.
  - It never resets the colours back to `Color4.White`.
  - It applies transforms onto external components.
  - It jumps through hoops to figure out how to set `missingFadeTime`.
  
  My hope is that these changes first bring some sanity in the process,
  and if it breaks again I'll consider doing a more proper root cause
  (I've had this issue in the back of my mind for about 1 year).
  
  With this PR, they now behave as expected:
  
  
  https://github.com/user-attachments/assets/140b37c5-cf84-44ba-b797-86ac6d8130c8
  
  
  https://github.com/user-attachments/assets/6f2342a4-6a9a-4941-a55a-24a357f27c25

  Dan Balasescu · 2026-03-23 08:33:23 +01:00
  d4a4acd3f4
• Only play hold note sliding samples when beatmap is converted
  Salman Alshamrani · 2025-08-04 12:27:55 +03:00
  4171c3a241
• Fix drawable hold notes continuing to show hit lighting with No Release mod and classic skin

  Closes https://github.com/ppy/osu/issues/33751.

  Bartłomiej Dach · 2025-06-18 17:59:54 +02:00
  176a85763c
• Fix incorrect translation of note freezing logic
  Bartłomiej Dach · 2025-05-20 08:58:11 +02:00
  bd703b60f9
• Fix hold notes being missed after rewinding gameplay

  Closes https://github.com/ppy/osu/issues/27589.
  
  Follows osu! spinner precedent in storing the holding state to the
  judgement result rather than attempting to keep it in the DHO (which is
  prone to getting dropped on pool re-use).

  Bartłomiej Dach · 2025-05-19 12:23:47 +02:00
  59490054db
• Add support for legacy osu!mania barline height and colour spec
  Dean Herbert · 2025-02-28 15:13:13 +09:00
  cb29459a1e
• Add basic setup for mania legacy barline implementation
  Dean Herbert · 2025-02-28 14:43:00 +09:00
  3e8dafa3c5
• Add setters to hitobject coordinate interfaces
  Bartłomiej Dach · 2024-12-27 11:01:47 +01:00
  0d16ed028b
• Fix osu!mania hold notes playing a sound at their tail in the editor

  Closes #29584.

  Dean Herbert · 2024-08-27 14:06:02 +09:00
  9840a07eaf
• Fix hold note light lingering with No Release

  Turns out endHold() is not called in the Tail.IsHit branch of the
  hold notes' CheckForResult method.

  Nathan Du · 2024-07-18 16:08:30 +08:00
  00ed7a7a2f
• Rewrite no release mod

  Per the request of spaceman_atlas, the No Release mod is rewritten to
  avoid modifications to DrawableHoldNoteTail. The approach is based
  on that of the Strict Tracking mod for the osu!(standard) ruleset,
  injecting the mod behavior by replacing the normal hold note with
  the mod's variant. The variant inherits most bevaior from the normal
  hold note, but when creating nested hitobjects, it creates its own
  hold note tail variant instead, which in turn is used to instantiate
  the mod's variant of DrawableHoldNoteTail with a new behavior.
  
  The time a judgement is awarded is changed from the end of its
  Perfect window to the time of the tail itself.

  Nathan Du · 2024-07-01 20:29:30 +08:00
  1eb10e029c
• Initial implemention of the No Release mod

  This commit adds a new osu!mania mod No Release that relaxes tail
  judgements. The current implementation automatically awards Perfect
  (or Meh if the hold note is broken midway) for a hold note tail at
  the end of its Perfect window, as long as it is held by then.
  
  Tests are pending for the next commit.

  Nathan Du · 2024-06-28 22:21:08 +08:00
  960d552dc1
• Apply further changes to remove remaining weirdness
  Bartłomiej Dach · 2024-02-05 13:37:38 +01:00
  fb80d76b4a
• Refactor result application around again to remove requirement for fields

  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Bartłomiej Dach · 2024-02-05 13:21:01 +01:00
  efe6bb25b1
• update DrawableHitCircle.ApplyResult to pass this to its callback
  Chandler Stowell · 2024-01-25 11:25:41 -05:00
  93bd3ce5ae
• use stack to pass action state when applying hit results

  this removes closure allocations

  Chandler Stowell · 2024-01-24 13:13:45 -05:00
  d2775680e6
• Remove remaining usage of NotePerfectBonus
  Dean Herbert · 2023-12-20 19:47:36 +09:00
  e0c27510f2
• Change mania scoring to match ScoreV2
  Dan Balasescu · 2023-12-20 18:35:45 +09:00
  104fbbde94
• Enforce minimum gameplay sample volume of 5%
  Bartłomiej Dach · 2023-10-20 15:50:13 +02:00
  b321d556b6
• Rename PerfectBonusNote to NotePerfectBonus
  Dean Herbert · 2023-10-16 15:14:28 +09:00
  4f1546c474
• Add empty hit windows on PefectBonusNote
  Dean Herbert · 2023-10-16 14:58:49 +09:00
  1a957364ae
• Add DisplayResult flag and remove unnecessary AlwaysPresent
  Dean Herbert · 2023-10-16 14:57:58 +09:00
  43f619f92a
• Fix MissForcefully not considering the bonus object
  Dean Herbert · 2023-10-16 14:53:36 +09:00
  14fedffcc1
• Adjust method flow to hopefully be more legible
  Dean Herbert · 2023-10-16 13:31:14 +09:00
  e85c039722
• Remove nullability of bonusNote
  Dean Herbert · 2023-10-16 13:14:58 +09:00
  ddbda69751
• Fix hodl tail notes not correctly handling nested bonus judgement
  Dean Herbert · 2023-10-13 17:36:19 +09:00
  125f28219d
• Add nested bonus judgement to DrawableNote for perfect bonus score
  Dean Herbert · 2023-10-13 17:01:48 +09:00
  94b64044e0
• Assign empty hit windows to HoldNoteBody

  It's not a timed object, so following precedent, it should have empty
  hitwindows.
  
  This is not actually just aesthetics; several components check whether a
  hitobject has empty hitwindows to determine whether to include it on
  various HUD displays and results screen components where timed objects
  are explicitly involved.

  Bartłomiej Dach · 2023-10-11 19:40:55 +02:00
  3f29f27cd4
• Apply some xmldoc and structural changes
  Dean Herbert · 2023-10-10 16:59:25 +09:00
  8dc9453d8d
• Actually use the judgement
  Dan Balasescu · 2023-10-09 11:49:54 +09:00
  f0da7f016d
• Add mania hold note body + combo break judgement
  Dan Balasescu · 2023-10-09 09:47:00 +09:00
  9415fe4446
• Remove mania hold note ticks
  Dan Balasescu · 2023-08-31 17:30:27 +09:00
  c60f13dd92
• Add barline pooling for mania
  Dan Balasescu · 2023-08-15 13:33:49 +09:00
  6a7b0786c9
• Use IsRewinding in a few more places
  Bartłomiej Dach · 2023-07-08 13:32:24 +02:00
  9dae806734
• Replace various local implementations of rewinding checks with new property
  Dean Herbert · 2023-07-07 15:21:24 +09:00
  e0fc97bb93
• Automated pass
  Dean Herbert · 2023-06-24 01:00:03 +09:00
  0ab0c52ad5
• Fix fix logic causing further regression on release
  Dean Herbert · 2023-06-17 01:37:09 +09:00
  3b1f92d8b8
• Fix osu!mania hold notes sometimes looking incorrect after rewind
  Dean Herbert · 2023-06-16 14:54:19 +09:00
  b5de109cb3
• Merge branch 'master' into mania-barlines-behind-notes
  Bartłomiej Dach · 2023-06-07 21:43:39 +02:00
  f069f982d4
• Fix osu!mania barlines showing in front of notes

  Closes #23412.

  Dean Herbert · 2023-06-07 14:23:23 +09:00
  d57c2ab7e4
• Remove redundant nullable suppression directives
  Salman Ahmed · 2023-06-07 08:20:41 +03:00
  62cb6a98ca
• Fix osu!mania hold notes snapping to judgement area too early on early hits

  Closes https://github.com/ppy/osu/issues/23515.

  Dean Herbert · 2023-06-01 16:06:35 +09:00
  98f35f7481
• Remove no-longer-correct remark
  Bartłomiej Dach · 2023-05-08 22:35:41 +02:00
  1ff1730948
• Merge branch 'master' into fix-mania-head-note-animation
  Bartłomiej Dach · 2023-05-08 22:23:01 +02:00
  3f45948664
• Remove clamping of sizingContainer in DrawableHoldNote to fix head note alignment
  Dean Herbert · 2023-05-08 18:14:07 +09:00
  27c10cbdb7
• Add back early return in OnReleased for safety
  Dean Herbert · 2023-05-08 15:43:11 +09:00
  814f0b3fed
• Move logic to Update instead
  Dean Herbert · 2023-05-03 15:18:37 +09:00
  6a59ded1ba
• Merge branch 'master' into mania-fix-hold-note-rewind
  Dean Herbert · 2023-05-03 15:04:59 +09:00
  4013cdcfa8
• remove all non-test usage of SampleControlPoint
  OliBomby · 2023-04-26 13:55:39 +02:00
  d97daee96b
• Fix osu!mania hold note animations not correctly re-applying after rewind

  There's early exit logic in `OnPressed`/`OnReleased` for the sake of
  keeping order correct, but this doesn't account for the fact that
  `DrawableHitObject` resets all animations when the hit state changes.
  
  A bit of an ugly workaround, but seems to work as expected.

  Dean Herbert · 2023-03-14 18:15:19 +09:00
  5aebbac6c5