h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2026-05-21 01:39:54 +08:00
Code Issues Releases Wiki Activity

Fix hold note light lingering with No Release

Browse Source 
Turns out endHold() is not called in the Tail.IsHit branch of the
hold notes' CheckForResult method.
This commit is contained in:
Nathan Du
2024-07-18 16:08:30 +08:00
Unverified
parent 3a1c05337d
commit 00ed7a7a2f
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
osu.Game.Rulesets.Mania/Objects/Drawables/DrawableHoldNote.cs
+7 -4
View File
@@ -268,11 +268,14 @@ namespace osu.Game.Rulesets.Mania.Objects.Drawables
ApplyMaxResult();
else
MissForcefully();
}
// Make sure that the hold note is fully judged by giving the body a judgement.
if (Tail.AllJudged && !Body.AllJudged)
Body.TriggerResult(Tail.IsHit);
// Make sure that the hold note is fully judged by giving the body a judgement.
if (!Body.AllJudged)
Body.TriggerResult(Tail.IsHit);
// Important that this is always called when a result is applied.
endHold();
}
}
public override void MissForcefully()