1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-15 05:17:25 +08:00
Commit Graph

3090 Commits

Author SHA1 Message Date
Andrei Zavatski
d09d6f31d7 Implement Masking property for TrianglesBackground 2023-01-25 12:20:51 +03:00
Andrei Zavatski
04c96355cb Use TriangleBorder shader to draw triangles 2023-01-24 07:38:42 +03:00
Dean Herbert
432e0a6a37
Merge branch 'master' into level-badge-colour 2023-01-23 15:46:15 +09:00
Dean Herbert
9c2494383f Rename fetch method to be non-plural to match all others 2023-01-23 15:43:52 +09:00
Bartłomiej Dach
88d58e8476
Merge pull request #22337 from Joehuu/fix-comment-editor-sounds
Fix comment editor text boxes not having sound feedback
2023-01-22 09:10:20 +01:00
Joseph Madamba
da03abc812 Fix comment editor text boxes not having sound feedback 2023-01-21 17:32:42 -08:00
Bartłomiej Dach
718cbf9382
Fix SegmentedGraph draw node calculating segment colours in unsafe manner
The `SegmentedGraph`'s draw node would call `getSegmentColour()`
on the drawable, which would query the `DrawColourInfo` and
`tierColours` properties of the drawable. This is a cross-thread access
and as such completely unsafe, as due to being cross-thread it can die
on invalidations or out-of-bounds accesses.

Fix by transferring everything to the draw node first before attempting
to draw. `SegmentedGraph.TierColours` setter already correctly
invalidates the draw node via `graphNeedsUpdate`, so no further
intervention was required there.

Closes #22326.
2023-01-21 23:19:34 +01:00
Dean Herbert
db8084570d
Merge pull request #22285 from bdach/segmented-graph-tint
Apply draw colour to segmented graph
2023-01-19 13:36:19 +09:00
Bartłomiej Dach
a0fe71c706
Use alternative segment colour computation method 2023-01-19 00:08:32 +01:00
Bartłomiej Dach
903c37bf32
Apply draw colour to segmented graph segments 2023-01-18 23:17:57 +01:00
StanR
24ed84aad0 Add tiered level badge colouring 2023-01-18 16:25:11 +03:00
Dean Herbert
5a272b4bd6
Merge branch 'master' into skin/argon-song-progress-cleaner 2023-01-18 15:25:02 +09:00
Dean Herbert
b62b5714e8 Fix TierColours assignment 2023-01-17 18:07:11 +09:00
Dean Herbert
53e7873f6c
Merge branch 'master' into fix-pause-gameplay-action-not-closing 2023-01-17 17:41:16 +09:00
ansel
76eefc7573 Add support for localisation where it was missing 2023-01-15 01:46:11 +03:00
Dean Herbert
123c477e00
Merge branch 'master' into ui/segmented-graph 2023-01-12 19:02:49 +09:00
tsrk
bb2ece5c71
refactor(SegmentedGraph): adjust tierCount based on passed Colours 2023-01-12 10:57:12 +01:00
tsrk
7cbc03dce6
refactor(SegmentedGraph): use (get/set)ters to expose TierColour 2023-01-12 10:13:16 +01:00
tsrk
5694487a7b
fix(SegmentedGraph): update graphNeedsUpdate variable during Update() loop 2023-01-12 02:36:35 +01:00
tsrk
624e90b213
style: nitpicks 2023-01-11 21:32:12 +01:00
tsrk
6249322a32
fix(SegmentedGraph): solve issue for negatives values 2023-01-11 14:03:36 +01:00
tsrk
e128b9ee5c
fix(SegmentedGraph): make ctor public 2023-01-11 14:03:19 +01:00
tsrk
42ff8c75fa
refactor: make class not abstract 2023-01-11 11:22:18 +01:00
tsrk
578d16f2bc
perf: Do not draw sectoins that are less than 1px 2023-01-11 11:11:31 +01:00
Joseph Madamba
776b60f3b3 Fix manual input manager test scenes not matching game input hierarchy
Fix popover using on key down

Fix popover not expiring when using global action
2023-01-10 15:35:26 -08:00
tsrk
21073f3601
reafactor: use DrawNode to draw SegmenteddGraph 2023-01-10 22:49:35 +01:00
Salman Ahmed
11648db910 Fix game overlays not blocking scroll properly 2023-01-10 21:01:06 +03:00
tsrk
91eab7985b
feat(ui): Implement a segmented graph 2023-01-09 21:35:27 +01:00
Dean Herbert
e35f63c001 Ensure screenshot filenames are unique by locking over file creation 2023-01-10 01:37:16 +09:00
Dean Herbert
ac85433178 Fix default volume control keys not working when chat textbox is focused
Closes #22004.
2023-01-03 09:44:35 +08:00
Joseph Madamba
777ffcf805 Highlight "open" option on external link button context menu 2022-12-26 20:47:24 -08:00
Berkan Diler
c7ca4bbba5 Use generic Enum methods 2022-12-26 20:36:39 +01:00
Bartłomiej Dach
e416bdd06b
Merge branch 'master' into remove_obsolete_star_colours 2022-12-26 16:35:47 +01:00
mk56-spn
fbff5d8d69 Remove obsoleted "ForDifficultyRating" method 2022-12-26 16:16:52 +01:00
Bartłomiej Dach
67aea34e7e
Merge branch 'master' into fix-breadcrumb-tab-item-click-area 2022-12-23 16:36:58 +01:00
Berkan Diler
08d2fbeb8e Use new ArgumentNullException.ThrowIfNull throw-helper API 2022-12-22 21:27:59 +01:00
Bartłomiej Dach
64a45aa0e0
Merge branch 'master' into wiki-heading-id-attributes 2022-12-20 06:34:47 +01:00
Dean Herbert
4a9b58adda
Merge branch 'master' into markdown-footnote-support 2022-12-20 13:48:35 +09:00
Bartłomiej Dach
7c282d9def
Enable generic attribute support for wiki markdown containers 2022-12-19 21:32:38 +01:00
Bartłomiej Dach
db1380a346
Refactor markdown extension management 2022-12-19 20:19:51 +01:00
Bartłomiej Dach
a88812861e
Implement bidirectional footnote link navigation 2022-12-19 19:34:47 +01:00
Bartłomiej Dach
73a4310935
Add styling for footnote groups 2022-12-19 19:34:40 +01:00
Bartłomiej Dach
112613c2f0
Add styling for footnote links 2022-12-19 19:28:01 +01:00
Bartłomiej Dach
0dce899634
Throw on OsuClickableContainer.ClearInternal() invocations
As they may cause critical failure due to getting rid of the `Content`.
2022-12-19 18:25:45 +01:00
Joseph Madamba
813c351607 Fix breadcrumb tab item click area not extending to background height 2022-12-16 21:44:10 -08:00
Dean Herbert
ba54551313 Merge branch 'master' into guard-url-protocols 2022-12-16 18:23:16 +09:00
Dean Herbert
27c497145f Fix the MOTHERLOAD of undetected issues that are now visible thanks to net6.0 2022-12-16 18:16:26 +09:00
Jamie Taylor
d5b2c7dfe9
Clamp SFX panning on results screen 2022-12-16 17:19:07 +09:00
Susko3
0f34d908c7 Use LocalisableStrings for date and time formats 2022-12-16 00:05:47 +01:00
Dean Herbert
efe057176e Make OsuButton abstract 2022-12-13 22:13:48 +09:00
Dean Herbert
edc78205d5 Add comments about why both positional input checks are required in OsuClickableContainer 2022-12-13 22:12:52 +09:00
Andrei Zavatski
890dd9cd06 Fix input doesn't take original drawable modifications into account 2022-12-12 15:10:03 +03:00
Andrei Zavatski
b0d475cd8b CI fix 2022-12-12 14:57:07 +03:00
Andrei Zavatski
d2b3533356 Fix OsuClickableContainer input receiving 2022-12-12 14:42:54 +03:00
Andrei Zavatski
7e39f171fb Fix OsuButton input receiving 2022-12-12 14:42:54 +03:00
Dean Herbert
0497e433b1 Change SectionsContainer to use flowing children for section update logic 2022-12-07 16:30:15 +09:00
Salman Ahmed
af000c6e92 Fix RangeSlider potentially throwing exception on mobile platforms 2022-12-04 21:58:00 +03:00
ansel
7d7b824f56 Add description for torus alt 2022-12-03 23:42:16 +03:00
Andrei Zavatski
2eaefcad30 Remove unused renderer 2022-11-30 04:56:07 +03:00
Andrei Zavatski
3b13ca1167 Remove texture from TrianglesV2 2022-11-30 04:09:46 +03:00
Dean Herbert
08a403cb33
Merge pull request #21428 from mk56-spn/RangeSlider_implementation
Refactor star "DifficultyRangeFilterControl" into generic range slider
2022-11-29 16:08:13 +09:00
Dean Herbert
56a694fb04 Add automated test coverage of simple scenarios for RangeSlider 2022-11-29 15:10:21 +09:00
Andrei Zavatski
3e277a92e9 Fix incorrect texel size calculation 2022-11-29 03:21:59 +03:00
Andrei Zavatski
ba1717c2ca Don't draw 0 thickness triangles 2022-11-29 02:36:27 +03:00
mk56-spn
db7f429e39 Fix partial class issues and adjust test slightly 2022-11-27 10:44:05 +01:00
mk56-spn
0aba119056 Merge remote-tracking branch 'origin/RangeSlider_implementation' into RangeSlider_implementation
# Conflicts:
#	osu.Game.Tests/Visual/SongSelect/TestSceneDifficultyRangeFilterControl.cs
#	osu.Game/Screens/Select/DifficultyRangeFilterControl.cs
2022-11-27 10:40:29 +01:00
Bartłomiej Dach
fd16e5992b
Merge branch 'master' into triangles-fix 2022-11-26 19:28:55 +01:00
Andrei Zavatski
7ab5136e12 Compute texel size in the DrawNode 2022-11-26 20:05:34 +03:00
Bartłomiej Dach
212d78865a
Add a few more missing partial specs 2022-11-26 16:30:52 +01:00
Bartłomiej Dach
894ef15e79
Merge branch 'master' into update-framework 2022-11-26 16:19:36 +01:00
Dan Balasescu
7bc8908ca9 Partial everything 2022-11-27 00:00:27 +09:00
mk56-spn
92ed2ed4ef Refactor star "DifficultyRangeFilterControl" into generic range slider class 2022-11-26 12:19:08 +01:00
Dean Herbert
5ada9efa60 Update outdated comment regarding colour choices 2022-11-25 22:10:20 +09:00
Dean Herbert
76e9382e0b Fix triangles showing on ExpandableButtons when in contracted state 2022-11-25 20:18:35 +09:00
Dean Herbert
b0f14d4963 Clamp AimCount to ensure at least one triangle is spawned 2022-11-25 20:14:21 +09:00
Dean Herbert
4cb068ceb9 Change AimCount to not consider height 2022-11-25 20:10:04 +09:00
Dean Herbert
6ad432b311 Use RoundedButton in more places 2022-11-24 16:33:01 +09:00
Dean Herbert
53b03df93d Combine TriangleButton and RoundedButton classes 2022-11-24 16:26:57 +09:00
Dean Herbert
bea2acc60e Remove local specifications of triangle colouring 2022-11-24 16:18:15 +09:00
Dean Herbert
4fbca4037c Update existing triangle buttons to use RoundedButton 2022-11-24 16:18:15 +09:00
Dean Herbert
40f706155f Update RoundedButton to have new triangles design 2022-11-24 16:18:15 +09:00
Dean Herbert
44a71741e4
Merge pull request #21225 from EVAST9919/triangles-v2
Implement TrianglesV2 component
2022-11-24 16:15:25 +09:00
Dean Herbert
172e798847
Merge pull request #21228 from Terochi/recent-messages-implementation
Add ability to view chat send history in input box
2022-11-23 14:58:42 +09:00
Terochi
d81ef541bc Variant 5: cannot change history, edit resets index 2022-11-21 10:17:28 +01:00
Terochi
7dc7729ac2 Variant 4: cannot change history, empty text/everything selected resets index (current with bug fix) 2022-11-21 10:11:26 +01:00
Terochi
58288275a6 Variant 3: cannot change history, cannot reset index (the "default") 2022-11-21 09:43:36 +01:00
Terochi
672e1cd45b Variant 2: edit changes history, cannot reset index (similar to stable) 2022-11-21 09:41:29 +01:00
Terochi
8f942f130b Variant 1: edit changes history, empty text resets index 2022-11-21 09:36:31 +01:00
Andrei Zavatski
ec8532951c Make Thickness property auto 2022-11-21 10:32:19 +03:00
Andrei Zavatski
14a4de36f4 Expose thickness property 2022-11-21 10:20:35 +03:00
Dean Herbert
9a330c3cdb Apply nullability and clean up conditionals 2022-11-21 15:02:45 +09:00
Dean Herbert
a07b033d22
Merge branch 'master' into triangles-v2 2022-11-21 14:55:01 +09:00
Andrei Zavatski
18c79dfda3 Move all the logic into BarsInfo class 2022-11-20 23:00:13 +03:00
Bartłomiej Dach
33b2fe46d9
Add xmldoc to HistoryTextBox 2022-11-20 12:29:47 +01:00
Andrei Zavatski
36141cb2a4 Make BarsInfo a class 2022-11-20 05:14:07 +03:00
Andrei Zavatski
fcb52ee237 Make BarsInfo a readonly struct 2022-11-20 02:28:07 +03:00
Andrei Zavatski
fbfcf49ea6 Remove readonly modifier from struct fields 2022-11-20 02:13:54 +03:00
Andrei Zavatski
2cb966b47c Rework BarsInfo struct 2022-11-20 01:48:54 +03:00
Andrei Zavatski
6c62cfb830 Store barBreadth as a separate float 2022-11-19 23:40:02 +03:00
Andrei Zavatski
67ee9f3915 Naming adjustments 2022-11-19 23:34:55 +03:00