1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-16 15:37:44 +08:00
Commit Graph

83 Commits

Author SHA1 Message Date
Naxess
a4a1919842 Add too short audio files check and tests 2021-07-13 03:46:45 +02:00
Naxess
0a8fd01b99 Add zero byte check and tests 2021-07-13 03:45:21 +02:00
Naxess
b58644106c Add nested hitobject tests for few hitsounds check 2021-06-27 15:58:00 +02:00
Naxess
1dbac76da5 Use local variables for common sample lists 2021-06-27 15:57:41 +02:00
Naxess
1d5bff1660 Add concurrent hitobjects test for few hitsounds check
See https://github.com/ppy/osu/pull/13669#discussion_r659314980
2021-06-27 15:26:52 +02:00
Naxess
c2ceb83bbb Move MockNestedHitObject to own class 2021-06-27 15:16:40 +02:00
Naxess
5642d321b7 Fix comments in few hitsounds check tests 2021-06-26 23:43:08 +02:00
Naxess
82b64f5589 Add hitsounded with break test 2021-06-26 19:57:12 +02:00
Naxess
a5abc664f3 Add few hitsounds check tests 2021-06-26 19:21:15 +02:00
Naxess
7b9569a117 Add muted object check tests 2021-06-26 19:21:01 +02:00
Dean Herbert
9069db0743 Fix case of hitObjects variables 2021-05-14 16:22:19 +09:00
Naxess
9860e482af Use TestWorkingBeatmap instead of null in tests
Fixes the warning that #12801 will give.
2021-05-14 05:32:52 +02:00
Naxess
94538b3842 Remove accidental whitespace 2021-05-13 12:56:36 +02:00
Naxess
19800f5f7f Move IBeatmap arg into context 2021-05-13 11:24:22 +02:00
Naxess
c13b93e6f1 Replace IWorkingBeatmap arg with BeatmapVerifierContext in checks
This simplifies passing of contextual information by enabling addition without needing to refactor lots of classes.

See next commit for example.
2021-05-12 02:29:18 +02:00
Naxess
200352b750 Rename unsnap check templates 2021-04-27 13:56:05 +02:00
Naxess
0f0870c8b8 Sort objects by time in concurrent check test 2021-04-27 00:36:26 +02:00
Naxess
ce258febf6 Rename CheckUnsnaps -> CheckUnsnappedObjects
Will potentially have `CheckUnsnappedKiai` or similar later, so this is worth specifying.

Also consistent with `CheckConcurrentObjects`, which will likely have a `CheckConcurrentLines` later.
2021-04-26 20:32:44 +02:00
Naxess
b8cdcf56c0 Add concurrent object check tests 2021-04-26 20:22:24 +02:00
Naxess
71f880aa94 Fix duplicate code in unsnap test 2021-04-26 17:44:46 +02:00
Naxess
9178aa1d7d Add unsnap check tests 2021-04-26 04:48:56 +02:00
Naxess
c0318a4d3e Fix usage of _ in Moq lambdas 2021-04-20 13:29:14 +02:00
Naxess
6a1e4ff99f Add file hash to file presence test
Necessary because we now find the storage path of the file rather than just the file itself.
2021-04-20 13:28:32 +02:00
Naxess
2bb079ea14 Add audio quality check tests 2021-04-20 01:36:15 +02:00
Naxess
be6a02a17e Simplify background quality test names 2021-04-20 01:32:22 +02:00
Naxess
8656176ab8 Add the playable beatmap as check argument
This is different from the working beatmap's `.Beatmap` property in that it is mutated by the ruleset/editor.

So hit objects, for example, are actually of type `Slider` and such instead of the legacy `ConvertSlider`.

This should be preferred over `workingBeatmap.Beatmap`.
2021-04-20 01:31:51 +02:00
Naxess
010720de74 Factor out general file presence checking
This allows us to use the same method of checking for other files that should exist, for example the audio file.

By using the same method, they all share test cases too.
2021-04-18 02:07:33 +02:00
Naxess
0502fbb429 Add background quality check tests 2021-04-18 01:21:51 +02:00
Naxess
448574e7e6 Use WorkingBeatmap instead of IBeatmap
This lets us access things like the background, track, etc. which are necessary for quality and filesize checks.

Also improves the structure of the `CheckBackgroundTest` class in the process.
2021-04-17 17:33:53 +02:00
Dean Herbert
b45d7de4ec Update asserts to use better nunit specifications 2021-04-13 15:04:01 +09:00
Naxess
6d3f9fa9ce Use is class instead of Equals with template index
Ensures ordering of `PossibleTemplates` does not affect tests.
2021-04-13 02:29:25 +02:00
Naxess
0bcc39bd36 Remove redundant space 2021-04-13 02:17:35 +02:00
Naxess
47cf4bcf25 Add CheckBackground tests 2021-04-13 01:22:24 +02:00