63525 Commits

This Branch

This Branch

All Branches

• Bypass Parent nullability checks for now
  Dean Herbert · 2023-10-17 17:48:45 +09:00
  5341a335a6
• Remove unused using directive
  Bartłomiej Dach · 2023-10-17 10:30:01 +02:00
  2192c9f2c2
• Remove unused field
  Bartłomiej Dach · 2023-10-17 10:27:16 +02:00
  22c1a963e7
• Remove redundant explicit array type specification
  Bartłomiej Dach · 2023-10-17 10:26:02 +02:00
  7abd7fe658
• Merge pull request #25153 from peppy/store-speed-change-config

  Persist the state of "show speed changes" between editor sessions

  Bartłomiej Dach · 2023-10-17 10:23:00 +02:00
  5833c20be5
• Merge branch 'master' into key-binding-deduplication
  Dean Herbert · 2023-10-17 17:17:44 +09:00
  4885c55ef0
• Combine selection and input handling logic for beat snap grids across all rulesets
  Dean Herbert · 2023-10-17 17:09:42 +09:00
  4381169a3f
• Add beat snap grid to osu!taiko editor

  Addresses https://github.com/ppy/osu/discussions/25150.

  Dean Herbert · 2023-10-17 16:59:56 +09:00
  2a89a25790
• Add backwards migration of catch dash binding
  Bartłomiej Dach · 2023-10-17 09:43:40 +02:00
  4cfc95c673
• Abstract out common implementation of BeatSnapGrid
  Dean Herbert · 2023-10-17 16:42:52 +09:00
  1b9acdf55c
• Cache IScrollingInfo at a HitObjectComposer level automatically
  Dean Herbert · 2023-10-17 16:42:22 +09:00
  d26d4b8b79
• Use left mouse as alternative default binding for catch dash

  This mirrors stable. Although the way stable does this is pretty dodgy,
  see:
  	https://github.com/peppy/osu-stable-reference/blob/master/osu!/GameModes/Play/Rulesets/Fruits/RulesetFruits.cs#L274-L275

  Bartłomiej Dach · 2023-10-17 09:31:29 +02:00
  79a4b985fe
• Persist the state of "show speed changes" between editor sessions

  Addresses https://github.com/ppy/osu/discussions/25149.

  Dean Herbert · 2023-10-17 16:01:02 +09:00
  165cd07428
• Merge pull request #25111 from peppy/mania-bonus-refactor

  Change osu!mania "perfect" judgements to only award bonus score

  Dan Balasescu · 2023-10-17 14:27:54 +09:00
  6f4a2b9889
• Merge branch 'master' into mania-bonus-refactor
  Dan Balasescu · 2023-10-17 13:28:04 +09:00
  d2a3f14d5b
• Merge pull request #25143 from peppy/split-spinner-fix

  Apply various fixes and cleanup to spinner logic

  Bartłomiej Dach · 2023-10-16 22:30:24 +02:00
  240d317928
• Fix bindings being cleared if multiple bindings for same action have the same combination

  This actually seems to be the case in catch (dash is bound to shift
  twice). This is annoying but harmless, so let's work around it for now
  to avoid ruining users' configs.

  Bartłomiej Dach · 2023-10-16 22:20:26 +02:00
  828cedea33
• Add failing case for two bindings of single action bound to same key
  Bartłomiej Dach · 2023-10-16 22:20:26 +02:00
  3aae07d1ca
• Add migration to remove duplicate bindings
  Bartłomiej Dach · 2023-10-16 22:20:26 +02:00
  9c6166ec3d
• Prevent ruleset input managers from reading duplicate bindings
  Bartłomiej Dach · 2023-10-16 21:02:24 +02:00
  639c96e60c
• Implement method to deduplicate keybindings
  Bartłomiej Dach · 2023-10-16 20:51:57 +02:00
  90c44cee54
• Add stub of method to deduplicate bindings (and failing test)
  Bartłomiej Dach · 2023-10-16 20:48:52 +02:00
  79273b88f6
• Merge branch 'master' into split-spinner-fix
  Bartłomiej Dach · 2023-10-16 18:59:08 +02:00
  f14928cdfb
• Fix potential frame misordering in generator
  Dan Balasescu · 2023-10-16 22:49:41 +09:00
  3065c9f23d
• Add inline commentary about workarounds in beatmap conversion test
  Bartłomiej Dach · 2023-10-16 13:40:45 +02:00
  b3d60c6d4f
• Fix conversion test failures
  Bartłomiej Dach · 2023-10-16 13:37:11 +02:00
  937694cd14
• Merge pull request #25142 from bdach/clean-up-scoring-difficulty-attributes

  Remove no longer used scoring difficulty attributes

  Dean Herbert · 2023-10-16 20:16:20 +09:00
  75011db3a7
• Remove no longer used scoring difficulty attributes
  Bartłomiej Dach · 2023-10-16 12:36:58 +02:00
  f2436a5ecb
• Fix incorrect initial rotation transfer value

  Should have been removed as part of https://github.com/ppy/osu/pull/24360.

  Dean Herbert · 2023-10-16 19:34:55 +09:00
  0bb95cfa88
• Tidy up lastAngle usage and add assertion of maximum delta
  Dean Herbert · 2023-10-16 19:34:22 +09:00
  10bab61441
• Use ID rather than SoloScoreID

  The latter is apparently not going to be a thing anymore.

  Bartłomiej Dach · 2023-10-16 12:02:55 +02:00
  e2192806e4
• Change SpinFramesGenerator to take degrees as input
  Dean Herbert · 2023-10-16 18:34:56 +09:00
  04af46b8c7
• Add prospective test coverage of spinner input handling
  Dean Herbert · 2023-10-16 18:31:01 +09:00
  28ee99f132
• Add SpinFramesGenerator class to simplify creating spinner tests
  Dean Herbert · 2023-10-16 18:25:40 +09:00
  cfa4adb24d
• Rename RateAdjustedRotation to TotalRotation
  Dean Herbert · 2023-10-16 18:25:03 +09:00
  159b24acf7
• Allow watching replay from multi/playlist results screens
  Bartłomiej Dach · 2023-10-16 11:20:02 +02:00
  fb2293821a
• Preserve OnlineID when importing scores

  Previously, for lazer scores, the ID returned from `osu-web` was
  discarded and replaced with -1, due to the fact that the appropriate
  structures for unification with stable, as well as unification across
  solo and multiplayer, were not in place yet.
  
  Now we're at the point where scores from all the aforementioned sources
  receive a `solo_scores` DB row, and as such, we can start treating
  `solo_scores`-scheme IDs as canonical "online IDs" for a score.

  Bartłomiej Dach · 2023-10-16 11:20:02 +02:00
  c4af8591a5
• Use solo score ID as OnlineID when converting from MultiplayerScore
  Bartłomiej Dach · 2023-10-16 11:20:02 +02:00
  d5a733d244
• Add LegacyOnlineID handling to places that definitely need it

  Mostly places that can interact with imported replays.
  
  There are other places that use the online ID as a sort tiebreaker, or
  to check presence of a score on results screens, but they should
  probably still continue to only use `OnlineID`, since all scores with a
  legacy online ID should have an online ID, but the converse is not
  generally true.

  Bartłomiej Dach · 2023-10-16 11:20:02 +02:00
  b144cfd55c
• Encode/decode new OnlineID into/from LegacyReplaySoloScoreInfo
  Bartłomiej Dach · 2023-10-16 11:20:02 +02:00
  c53f4c144c
• Move legacy online ID encode/decode to legacy property
  Bartłomiej Dach · 2023-10-16 11:20:02 +02:00
  fa519984df
• Add failing test for legacy online ID decoding
  Bartłomiej Dach · 2023-10-16 11:20:02 +02:00
  bfcb4f4f2d
• Add LegacyOnlineID with backwards migration
  Bartłomiej Dach · 2023-10-16 11:20:02 +02:00
  c1a817fec6
• Fix large instantaneous delta on first frame

  Happens when the first update frame comes in before any mouse input.

  Dan Balasescu · 2023-10-16 18:17:11 +09:00
  84be714d6b
• Merge pull request #25139 from peppy/collection-ordering-fix

  Fix collections not being sorted alphabetically in context menus

  Bartłomiej Dach · 2023-10-16 10:53:43 +02:00
  9cd33d9bb2
• Merge pull request #25140 from peppy/manage-collections-drag-handles-bye-bye

  Remove drag handles from manage collections dialog for now

  Bartłomiej Dach · 2023-10-16 10:47:38 +02:00
  ee3ddacf46
• Merge pull request #25136 from peppy/fix-taiko-hp-bar-animation

  Fix health bar animating when it shouldn't be

  Bartłomiej Dach · 2023-10-16 10:30:17 +02:00
  38d92187af
• Reformat long lines
  Bartłomiej Dach · 2023-10-16 09:06:34 +02:00
  c48142816c
• Rename test step
  Bartłomiej Dach · 2023-10-16 09:04:53 +02:00
  624c05e0ff
• Fix collections not being sorted correctly in context menus
  Dean Herbert · 2023-10-16 16:03:12 +09:00
  7139592e43