63525 Commits

This Branch

This Branch

All Branches

• Merge pull request #25154 from peppy/taiko-beat-snap-grid

  Add beat snap grid to osu!taiko editor

  Bartłomiej Dach · 2023-10-19 21:34:24 +02:00
  cd3ff2b74c
• Remove unused using directive
  Bartłomiej Dach · 2023-10-19 20:45:47 +02:00
  2c6bf9e346
• Fix Floating Fruits not flipping playfield properly

  Regressed by https://github.com/ppy/osu/pull/25070.

  Bartłomiej Dach · 2023-10-19 19:47:49 +02:00
  cc1f1d2270
• Tidy up CatchHitObjectComposer
  Dean Herbert · 2023-10-19 23:57:36 +09:00
  74b86349d5
• Move beat snap grid implementation details to ScrollingHitObjectComposer
  Dean Herbert · 2023-10-19 23:54:34 +09:00
  013b5fa916
• Merge branch 'master' into taiko-beat-snap-grid
  Dean Herbert · 2023-10-19 23:53:01 +09:00
  52c2eb93de
• Merge pull request #25171 from bdach/distance-snapping-composition

  Replace `DistancedHitObjectComposer` with composition-based approach

  Dean Herbert · 2023-10-19 23:46:10 +09:00
  e8d0962197
• Inherit ScrollingHitObjectComposer in catch
  Bartłomiej Dach · 2023-10-19 11:58:25 +02:00
  0c4e74c82d
• Remove DistancedHitObjectComposer
  Bartłomiej Dach · 2023-10-19 11:46:30 +02:00
  144ef5a87c
• Remove DistancedHitObjectComposer inheritance from catch composer
  Bartłomiej Dach · 2023-10-19 11:46:30 +02:00
  31849192c3
• Remove DistancedHitObjectComposer inheritance from osu! composer
  Bartłomiej Dach · 2023-10-19 11:46:30 +02:00
  dcfd6a0a8a
• Split IPositionSnapProvider from IDistanceSnapProvider

  In preparation to remove `DistancedHitObjectComposer`, split off
  `IPositionSnapProvider` from `IDistanceSnapProvider`.
  
  `DistancedHitObjectComposer` was not touching `IPositionSnapProvider`'s
  only interface member at all, it was just forwarding it for subclasses
  to override to their own leisure.

  Bartłomiej Dach · 2023-10-19 11:45:24 +02:00
  3ab083b696
• Merge pull request #25169 from smoogipoo/fix-diffcalc-pr-command

  Fix invalid PR URL in diffcalc GitHub action

  Bartłomiej Dach · 2023-10-19 08:29:28 +02:00
  0b8b87d6bd
• Fix incorrect PR url in diffcalc workflow
  Dan Balasescu · 2023-10-19 15:19:51 +09:00
  832ba861bb
• Merge pull request #25159 from smoogipoo/improve-diffcalc-command

  Fix + improve diffcalc command for comment-based execution

  Dean Herbert · 2023-10-19 12:11:16 +09:00
  66421a55ab
• Pin third-party actions
  Dan Balasescu · 2023-10-19 02:39:34 +09:00
  14cadd1eeb
• Fix Catcher code change not accounting for double sizing requirement
  Dean Herbert · 2023-10-18 23:56:17 +09:00
  42087037ae
• Use DifficultyRange helper method in one more place
  Dean Herbert · 2023-10-18 23:54:18 +09:00
  040d0970f2
• Ignore instead of retry tests
  Dean Herbert · 2023-10-18 20:12:14 +09:00
  78d3c3723d
• Merge pull request #24640 from Givikap120/pitch_change

  Add an "Adjust pitch" switch to DT/HT

  Bartłomiej Dach · 2023-10-18 13:07:22 +02:00
  12f343f0e2
• Centralise and repair circle size calculations game-wide
  Dean Herbert · 2023-10-18 19:50:42 +09:00
  3a5490892c
• Merge branch 'master' into pitch_change
  Bartłomiej Dach · 2023-10-18 12:27:27 +02:00
  f1a16c50b8
• Add inline commentary in Mod{Day,Night}core about different speed adjustments
  Bartłomiej Dach · 2023-10-18 12:27:16 +02:00
  cff69d63a6
• Fix circle scale not matching stable due to missing multiplier

  This multiplier has to exist.
  
  I'm not guaranteeing that the rest is correct here. Should we be doing
  proper cross-testing on this? Maybe, but it's going to be hard to get
  right. We could likely check as far as "game pixels", but there's still
  a chance that the osu-framework could be doing something weird in the
  rest of the hierarchy where playfield scale is involved.
  
  Closes https://github.com/ppy/osu/issues/25162. Tested to fix the linked
  replay.

  Dean Herbert · 2023-10-18 18:35:14 +09:00
  6ae82c5e73
• Merge pull request #25160 from bdach/repeat-arrow-hidden-fade

  Adjust slider repeat transforms to closer match stable

  Dean Herbert · 2023-10-18 18:03:48 +09:00
  54da6f1048
• Attempt to fix flaky tests with egregious retry rule
  Dean Herbert · 2023-10-18 17:46:14 +09:00
  be321e34e9
• Remove incorrect plural from variable
  Dean Herbert · 2023-10-18 17:44:01 +09:00
  92524d4299
• Take in IBindables and tidy up multiplier handling
  Dean Herbert · 2023-10-18 17:39:13 +09:00
  9907adc337
• Move audio adjustment hookup to own method for clarity
  Dean Herbert · 2023-10-18 17:38:11 +09:00
  161890292f
• Also share ScoreMultiplier implementation
  Dean Herbert · 2023-10-18 17:23:50 +09:00
  e56ff33271
• Split common functionality from rate adjust mods into helper class
  Dean Herbert · 2023-10-18 17:23:50 +09:00
  43238b0cee
• Merge branch 'master' into pitch_change
  Dean Herbert · 2023-10-18 16:33:03 +09:00
  eabfcfbf2a
• Comment flaky tests for now

  Same issue as other commented test (clock precision not high enough).
  
  Will probably want a solution to this at some point.

  Dean Herbert · 2023-10-18 16:26:34 +09:00
  7479830a8e
• Merge pull request #25163 from Joehuu/double-click-slider-nub-default

  Add ability to revert slider settings to default when double-clicking nub

  Dean Herbert · 2023-10-18 16:23:05 +09:00
  bf4aa3c118
• Merge branch 'master' into legacy-tick-test-coverage
  Dan Balasescu · 2023-10-18 15:21:31 +09:00
  939b55020c
• Add ability to revert slider settings to default when double-clicking nub
  Joseph Madamba · 2023-10-17 21:41:03 -07:00
  18e8ca6245
• Add slider nub double click revert to default test
  Joseph Madamba · 2023-10-17 21:41:03 -07:00
  1a3a81c33b
• Merge pull request #25155 from peppy/fix-new-inspections

  Fix various new rider EAP inspections

  Bartłomiej Dach · 2023-10-17 17:04:39 +02:00
  e927267c4d
• Fix legacy slider repeats becoming much too large on hit

  They had scale transforms applied to them in two places: the actual
  legacy pieces themselves (esp. `LegacyHitCirclePiece`), and on the
  `DrawableSliderRepeat` level.
  
  This change moves all of the scale transforms to the skinnable pieces.
  Argon and triangles have received a copy of the previous logic each,
  so behaviour on those skins should not change.

  Bartłomiej Dach · 2023-10-17 14:47:44 +02:00
  f3cda58474
• Instantly fade out slider repeats when hidden is active
  Bartłomiej Dach · 2023-10-17 14:15:21 +02:00
  30e5f47007
• Add test step for covering slider appearance with hidden active
  Bartłomiej Dach · 2023-10-17 14:15:21 +02:00
  f116854c9f
• Run timeout job on self-hosted runner
  Dan Balasescu · 2023-10-17 21:01:23 +09:00
  4946b437c9
• Delete comment on cancellation

  - Add always() pre-condition to force evaluation.
  
  - Message is set as it's required by the action for a non-error status code.

  Dan Balasescu · 2023-10-17 20:51:28 +09:00
  566b09ff20
• Use action for GHA diffcalc workflow permissions check
  Dan Balasescu · 2023-10-17 20:28:04 +09:00
  08845ec1c6
• Clean up code and add xmldoc and inline doc
  Dean Herbert · 2023-10-17 20:24:23 +09:00
  4f0d55e1a9
• Fix final test

  This looks to have been a WIP test, so I've brought it up to the point
  of passing. I haven't given it much more attention than that, though.

  Dean Herbert · 2023-10-17 20:24:23 +09:00
  80ac0c46d9
• Adjust tests in line with new expectations
  Dean Herbert · 2023-10-17 20:24:23 +09:00
  9011170c3e
• Add SpinnerSpinHistory and tests
  Dean Herbert · 2023-10-17 20:10:22 +09:00
  af7180a5b5
• Merge pull request #25152 from bdach/key-binding-deduplication

  Clear pre-existing bindings of same key combination to single action

  Dean Herbert · 2023-10-17 17:49:51 +09:00
  d9fc532a9f
• Fix various other inspections
  Dean Herbert · 2023-10-17 17:48:51 +09:00
  e081fa48a2