47458 Commits

This Branch

This Branch

All Branches

• Reorder methods to hopefully make more sense
  Dean Herbert · 2021-12-22 18:17:00 +09:00
  3c95497ed7
• Enable NRT on IWorkingBeatmap
  Dean Herbert · 2021-12-22 18:17:00 +09:00
  e38e4c0adc
• Remove BeatmapSetInfo and Metadata from interface

  There were very few accesses to this, and after realm they should all be
  done via the `BeatmapInfo`, so let's remove this.

  Dean Herbert · 2021-12-22 18:17:00 +09:00
  967419c9ac
• Simplify WorkingBeatmap in multiple ways

  Just a clean-up pass.

  Dean Herbert · 2021-12-22 18:17:00 +09:00
  1b0af78831
• Convert BeatmapMetadata access to be via a computed property
  Dean Herbert · 2021-12-22 18:17:00 +09:00
  b38b300159
• Merge pull request #16206 from peppy/fix-collection-import-test-cleanup

  Fix `ImportCollectionsTest.TestSaveAndReload` not cleaning up before run

  Dean Herbert · 2021-12-22 18:16:48 +09:00
  ea7d2c06fc
• Add comment regarding host name choice
  Dean Herbert · 2021-12-22 15:44:47 +09:00
  a866572ca8
• Merge pull request #16205 from smoogipoo/fix-multiplayer-tests

  Fix multiplayer test failures when checking for parted room

  Dean Herbert · 2021-12-22 13:42:05 +09:00
  cfdfe81afb
• Fix ImportCollectionsTest.TestSaveAndReload not cleaning up before/after run
  Dean Herbert · 2021-12-22 13:38:20 +09:00
  f81e32149b
• Merge pull request #16198 from smoogipoo/fix-current-item-before-population

  Fix delete button showing on current item before beatmap retrieval

  Dean Herbert · 2021-12-22 13:15:07 +09:00
  a88800c99a
• Fix multiplayer test failures when checking for parted room
  Dan Balasescu · 2021-12-22 12:55:37 +09:00
  24c6f8fafa
• Merge pull request #16201 from bdach/timeline-blueprint-contrast-improvement

  Improve contrast of timeline blueprint foreground content for pastel combo colours

  Dan Balasescu · 2021-12-22 11:33:29 +09:00
  7bc5079485
• Fix delete button test failures

  Can be tested by adding a Thread.Sleep() in
  DrawableRoomPlaylistItem.load().

  Dan Balasescu · 2021-12-22 09:55:19 +09:00
  ee64ab6383
• Merge pull request #16200 from bdach/lookup-cache-racing

  Fix online lookup caches potentially getting stuck

  Dan Balasescu · 2021-12-22 09:48:58 +09:00
  c71942a350
• Merge pull request #16199 from peppy/fix-custom-directory-tests

  Ensure `CustomDataDirectoryTest` methods use a fresh directory to avoid IO errors

  Bartłomiej Dach · 2021-12-21 13:56:07 +01:00
  dca081979f
• Merge branch 'master' into fix-custom-directory-tests
  Bartłomiej Dach · 2021-12-21 13:08:27 +01:00
  e35a8cab65
• Improve contrast of timeline blueprint foreground content for pastel combo colours
  Bartłomiej Dach · 2021-12-21 12:54:17 +01:00
  7ab1c0c99d
• Fix online lookup cache not clearing completed task on early return

  The task not being cleared in the early return path would cause
  `pendingRequestTask` to become stuck as a completed task, and
  `queryValue()` would not recreate it due to the null check there,
  therefore stalling all lookups forevermore until a game restart.

  Bartłomiej Dach · 2021-12-21 11:13:41 +01:00
  ca7303a50a
• Extract abstract implementation of online lookup cache
  Bartłomiej Dach · 2021-12-21 11:12:51 +01:00
  ee89d8643e
• Merge pull request #16181 from dekrain/statics-reset-no-sb

  Split session statics reset method to prevent unloading seasonal backgrounds

  Dean Herbert · 2021-12-21 18:52:04 +09:00
  df975fb29e
• Merge pull request #16197 from bdach/beatmap-card/renames

  Rename beatmap card-related classes

  Dean Herbert · 2021-12-21 18:51:34 +09:00
  0bda7892f7
• Ensure CustomDataDirectoryTest methods use a fresh directory to avoid IO errors

  Resolves test failures like https://github.com/ppy/osu/runs/4592088736?check_suite_focus=true.

  Dean Herbert · 2021-12-21 18:42:39 +09:00
  4a3a5054fd
• Directly bind to room updates

  Currently doesn't really cause any difference, however it may in the
  future if we decide the queueing algorithm shouldn't update PlaylistOrder
  when an item has been played.

  Dan Balasescu · 2021-12-21 18:40:29 +09:00
  4ce61d4260
• Fix test
  Dan Balasescu · 2021-12-21 18:38:31 +09:00
  e2f8c71081
• Disallow expired items from showing delete button

  This isn't possible in practice since expired items are removed from the
  queue list, but this helps out in tests.

  Dan Balasescu · 2021-12-21 18:37:42 +09:00
  a34d24fb20
• Merge pull request #16196 from peppy/update-framework

  Update framework

  Dan Balasescu · 2021-12-21 18:23:02 +09:00
  d7136d6b48
• Merge pull request #16178 from bdach/lounge-background-screen-correct

  Fix lounge screen showing information sourced from wrong playlist item

  Dan Balasescu · 2021-12-21 17:36:23 +09:00
  4ba5a939db
• Merge pull request #15867 from MBmasher/fl-cumulative-strain

  Fix cumulative strain time calculation in Flashlight skill

  Dan Balasescu · 2021-12-21 17:19:09 +09:00
  05b79f864e
• Fix delete button being able to show on current item
  Dan Balasescu · 2021-12-21 16:57:58 +09:00
  51b7e920c0
• Merge pull request #16194 from peppy/fix-results-screen-wait-test

  Fix intermittent test failures on `TestSceneResultsScreen` due to long delay step

  Dan Balasescu · 2021-12-21 16:56:49 +09:00
  a53c67b2ea
• Cover seasonal backgrounds not resetting on inactivity in test
  Bartłomiej Dach · 2021-12-21 08:50:25 +01:00
  b6a458a07e
• Do not reset last hover sound playback time on inactivity
  Bartłomiej Dach · 2021-12-21 08:47:41 +01:00
  979624160f
• Remove unused private method
  Bartłomiej Dach · 2021-12-21 08:47:26 +01:00
  cd10af633c
• Update framework
  Dean Herbert · 2021-12-21 16:38:03 +09:00
  0198d49a3a
• Merge pull request #16192 from peppy/add-room-lost-logging

  Add logging of `MultiplayerMatchSubScreen` exiting from room loss

  Dan Balasescu · 2021-12-21 16:37:08 +09:00
  32fbaf47c0
• Rename BeatmapCard{Base => }
  Bartłomiej Dach · 2021-12-21 08:26:25 +01:00
  c7b9b176c6
• Rename BeatmapCard{ => Normal}
  Bartłomiej Dach · 2021-12-21 08:26:21 +01:00
  88d4e95ad8
• Add and use separate extensions for historical and upcoming playlist items
  Bartłomiej Dach · 2021-12-21 08:01:04 +01:00
  bd1fb33ad6
• Merge pull request #16012 from bdach/beatmap-card/extra

  Implement "extra" beatmap card size

  Dean Herbert · 2021-12-21 15:40:33 +09:00
  2707b2fbda
• Fix SessionStaticsTest never working

  In headless operation, the test would complete before ever reaching an
  idle state. And this test only ran headless..

  Dean Herbert · 2021-12-21 15:39:08 +09:00
  16fe0e4f89
• Rename method and simplify SetDefault calling code
  Dean Herbert · 2021-12-21 15:34:32 +09:00
  981158ed88
• Fix intermittent test failures on TestSceneResultsScreen due to long delay step

  Using real time delays of 3 seconds doesn't play well with headless runs.

  Dean Herbert · 2021-12-21 15:15:05 +09:00
  c0a8758839
• Merge pull request #16189 from peppy/fix-beatmap-listing-overlay-test-failure

  Fix intermittent failures on `TestSceneBeatmapListingOverlay`

  Dan Balasescu · 2021-12-21 15:11:25 +09:00
  a8cd96278d
• Merge pull request #16188 from peppy/multiplayer-button-enabled

  Centralise all multiplayer button clicking test logic

  Dan Balasescu · 2021-12-21 15:10:26 +09:00
  5cea8da80f
• Also add logging to OnlinePlayScreen
  Dean Herbert · 2021-12-21 15:07:06 +09:00
  d08b66a5ff
• Merge pull request #16187 from peppy/fix-threading-colour-error-meter

  Fix potential wrong thread mutation in `ColourHitErrorMeter`

  Dan Balasescu · 2021-12-21 15:05:57 +09:00
  3b700b6967
• Add logging of MultiplayerMatchSubScreen exiting from room loss
  Dean Herbert · 2021-12-21 14:53:24 +09:00
  ddadf3c4b5
• Fix intermittent failures on TestSceneBeatmapListingOverlay

  In the specific method, there was no wait step after the initial fetch
  (unlike all of the rest), meaning the fetch may not have finished in
  time for the follow-up steps.
  
  As seen at
  https://github.com/ppy/osu/runs/4588058438?check_suite_focus=true.

  Dean Herbert · 2021-12-21 14:12:06 +09:00
  0f8a6a3f64
• Merge pull request #16168 from peppy/windows-key-when-inactive

  Avoid blocking windows key usage when the osu! window is not active

  Dan Balasescu · 2021-12-21 13:51:10 +09:00
  2ea31c26a5
• Add note about local button clicking usage
  Dean Herbert · 2021-12-21 13:49:51 +09:00
  bb3f375958