1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-06 19:17:25 +08:00
Commit Graph

59 Commits

Author SHA1 Message Date
andy840119
e862ba5e04 Fix the wrong AsNonNull() usage. 2022-11-05 20:13:50 +08:00
andy840119
6062641bf4 Mark mock track as nun-nullable because technically it should not accept the null track. 2022-11-05 16:17:20 +08:00
andy840119
5931e965c5 Mark background prams in the getMockWorkingBeatmap() as nun-nullable because technically it should not accept the null background. 2022-11-05 16:16:26 +08:00
andy840119
c8c76f2351 Use AsNonNull() because the type does not accept the null case. 2022-10-30 17:03:54 +08:00
andy840119
500bf90a34 Mark as accept the nullable stream. 2022-10-30 17:03:54 +08:00
andy840119
6ce3841686 Remove nullable disable annotation in the test case. 2022-10-30 17:03:54 +08:00
Dean Herbert
a70fc10d06 Fix mock track construction failure 2022-09-02 16:30:04 +09:00
Dan Balasescu
b4e55f7309 Apply IRenderer changes 2022-08-02 19:50:57 +09:00
Dan Balasescu
f8830c6850 Automated #nullable processing 2022-06-17 16:37:17 +09:00
Bartłomiej Dach
b978010b48
Remove unused allowMissing parameter in audio file check test
No longer used since 7f95400f46.
2022-02-01 21:53:21 +01:00
Dean Herbert
4f66e8f881 Fix issues with editor check tests 2022-01-12 16:39:36 +09:00
Joseph Madamba
7de43e3aba Fix most open compound words in identifiers being closed 2021-12-27 20:26:28 -08:00
Dean Herbert
c7bc03e6f7 Add helper method for editor check tests 2021-11-24 14:22:41 +09:00
Dean Herbert
c2f8d9f677 Update tests which set Files lists directly 2021-11-24 14:00:14 +09:00
Naxesss
72ee2b1556 Refactor to avoid duplicate code 2021-11-10 06:18:40 +01:00
Naxesss
5dc6a9ed21 Add background stream closed test 2021-11-10 05:04:30 +01:00
Dean Herbert
d1e6d1cb98 Update some other missed incorrect null/empty usages 2021-11-04 14:50:43 +09:00
Dean Herbert
67d9590a79 Fix new inspections 2021-11-04 14:02:09 +09:00
Bartłomiej Dach
c7db286b94
Merge branch 'master' into file-sanity-checks 2021-10-14 00:17:29 +02:00
Dean Herbert
7f95400f46 Add proper stream disposal to tests 2021-10-12 11:04:41 +09:00
Naxesss
bb9cbd3e66 Undo disposal of Stream for use in mocking
Because the Stream object is accessed when the mocked object calls `GetStream`, we cannot close it here.

The resource should be released upon teardown anyway.
2021-10-12 00:35:58 +02:00
Naxesss
47b4d03145 Dispose of Streams when used 2021-10-12 00:13:38 +02:00
Naxesss
01d77fb741 Remove redundant Bass.Init call in test setup 2021-10-11 23:58:06 +02:00
Dean Herbert
9fae2c350d Fix test regressions 2021-08-30 17:25:36 +09:00
Naxess
6da2a3d51f Add zero-length objects check and tests 2021-07-13 10:50:11 +02:00
Naxess
c8f58cbf6c Add audio in video check and tests 2021-07-13 04:17:41 +02:00
Naxess
a4a1919842 Add too short audio files check and tests 2021-07-13 03:46:45 +02:00
Naxess
0a8fd01b99 Add zero byte check and tests 2021-07-13 03:45:21 +02:00
Naxess
b58644106c Add nested hitobject tests for few hitsounds check 2021-06-27 15:58:00 +02:00
Naxess
1dbac76da5 Use local variables for common sample lists 2021-06-27 15:57:41 +02:00
Naxess
1d5bff1660 Add concurrent hitobjects test for few hitsounds check
See https://github.com/ppy/osu/pull/13669#discussion_r659314980
2021-06-27 15:26:52 +02:00
Naxess
c2ceb83bbb Move MockNestedHitObject to own class 2021-06-27 15:16:40 +02:00
Naxess
5642d321b7 Fix comments in few hitsounds check tests 2021-06-26 23:43:08 +02:00
Naxess
82b64f5589 Add hitsounded with break test 2021-06-26 19:57:12 +02:00
Naxess
a5abc664f3 Add few hitsounds check tests 2021-06-26 19:21:15 +02:00
Naxess
7b9569a117 Add muted object check tests 2021-06-26 19:21:01 +02:00
Dean Herbert
9069db0743 Fix case of hitObjects variables 2021-05-14 16:22:19 +09:00
Naxess
9860e482af Use TestWorkingBeatmap instead of null in tests
Fixes the warning that #12801 will give.
2021-05-14 05:32:52 +02:00
Naxess
94538b3842 Remove accidental whitespace 2021-05-13 12:56:36 +02:00
Naxess
19800f5f7f Move IBeatmap arg into context 2021-05-13 11:24:22 +02:00
Naxess
c13b93e6f1 Replace IWorkingBeatmap arg with BeatmapVerifierContext in checks
This simplifies passing of contextual information by enabling addition without needing to refactor lots of classes.

See next commit for example.
2021-05-12 02:29:18 +02:00
Naxess
200352b750 Rename unsnap check templates 2021-04-27 13:56:05 +02:00
Naxess
0f0870c8b8 Sort objects by time in concurrent check test 2021-04-27 00:36:26 +02:00
Naxess
ce258febf6 Rename CheckUnsnaps -> CheckUnsnappedObjects
Will potentially have `CheckUnsnappedKiai` or similar later, so this is worth specifying.

Also consistent with `CheckConcurrentObjects`, which will likely have a `CheckConcurrentLines` later.
2021-04-26 20:32:44 +02:00
Naxess
b8cdcf56c0 Add concurrent object check tests 2021-04-26 20:22:24 +02:00
Naxess
71f880aa94 Fix duplicate code in unsnap test 2021-04-26 17:44:46 +02:00
Naxess
9178aa1d7d Add unsnap check tests 2021-04-26 04:48:56 +02:00
Naxess
c0318a4d3e Fix usage of _ in Moq lambdas 2021-04-20 13:29:14 +02:00
Naxess
6a1e4ff99f Add file hash to file presence test
Necessary because we now find the storage path of the file rather than just the file itself.
2021-04-20 13:28:32 +02:00
Naxess
2bb079ea14 Add audio quality check tests 2021-04-20 01:36:15 +02:00