61 Commits

• Moved X clamping from X to EffectiveX
  Drison64 · 2022-09-19 17:26:04 +02:00
  4958421303
• Made X position value of CatchHitObject clamp to CatchPlayfield's width
  Drison64 · 2022-09-18 17:29:08 +02:00
  6d7d80a4fb
• Fix osu! and catch hitobjects no longer scaled to 1 by default
  Salman Ahmed · 2022-07-19 07:00:13 +03:00
  8f80a22ef9
• Change bindable properties in all HitObjects to be lazily initialised
  Salman Ahmed · 2022-07-19 05:39:10 +03:00
  1051009827
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Convert usages of BeatmapDifficulty to IBeatmapDifficultyInfo
  Dean Herbert · 2021-10-01 16:55:50 +09:00
  a92d499d7a
• Add ComboIndexWithOffsetsBindable and bind similar to ComboIndexBindable
  Salman Ahmed · 2021-07-22 16:40:33 +03:00
  523c154f15
• Rename property, reword xmldoc and improve readability of update code
  Dean Herbert · 2021-07-21 17:32:56 +09:00
  399c3b0be8
• Revert making ComboOffsets legacy and define BeatmapSkinComboIndex instead
  Salman Ahmed · 2021-07-20 14:15:43 +03:00
  9d92b795fa
• Merge branch 'refactor-combo-colour-retrieval' into legacy-beatmap-combo-offset
  Salman Ahmed · 2021-07-20 10:11:52 +03:00
  554652b033
• Preserve Y position of hit objects in osu!catch
  ekrctb · 2021-07-14 14:38:38 +09:00
  7f432665e5
• Use getters of OriginalX and XOffset
  ekrctb · 2021-07-06 15:32:32 +09:00
  175d666906
• Allow serialization of catch hit objects
  ekrctb · 2021-07-06 15:32:32 +09:00
  ae1b1cbec9
• Consider "combo offsets" as legacy logic and separate from combo information
  Salman Ahmed · 2021-05-05 07:43:08 +03:00
  cd6d070b4a
• Remove EffectiveXBindable (setting Value was not handled)

  And use orthogonal `OriginalXBindable` and `XOffsetBindable`.

  ekrctb · 2020-12-14 13:39:07 +09:00
  5b5e883904
• Fix comment
  ekrctb · 2020-12-14 13:18:32 +09:00
  0ad256a762
• Revert "Remove X setter from CatchHitObject"

  This reverts commit 7cbbd74d

  ekrctb · 2020-12-14 13:18:14 +09:00
  d96399ea42
• Remove X setter from CatchHitObject
  ekrctb · 2020-12-14 11:38:07 +09:00
  7cbbd74df2
• Add some more doc comment
  ekrctb · 2020-12-14 11:32:34 +09:00
  f621d977fc
• Use OriginalX for CatchHitObject.X instead of EffectiveX

  And explicitly implement IHasXPosition interface to prevent use of the X property.
  It should be preferred for beatmap conversion purpose.

  ekrctb · 2020-12-14 11:26:05 +09:00
  36529bdd1b
• Add doc comments to catch hit object X properties
  ekrctb · 2020-12-14 11:15:49 +09:00
  089f3bebf5
• Obsolete X getter
  ekrctb · 2020-12-14 11:03:10 +09:00
  c1f3f1c231
• Separate asymmetric CatchHitObject.X to EffectiveX and OriginalX
  ekrctb · 2020-12-14 11:03:03 +09:00
  8da502da44
• Make RandomSeed a property, not a bindable
  ekrctb · 2020-12-02 20:53:47 +09:00
  fdcfa81e46
• Set banana combo colour using random seed
  ekrctb · 2020-12-02 17:12:30 +09:00
  08848e49de
• Move fruit visual logic from CHO to DrawableFruit
  ekrctb · 2020-11-27 11:08:32 +09:00
  5e36fb322a
• Add bindables to catch hit objects
  ekrctb · 2020-11-27 11:02:23 +09:00
  c272fda416
• Move members to PalpableCatchHitObject
  ekrctb · 2020-11-24 19:57:37 +09:00
  ab7251d742
• Move Palpable* to separate files
  ekrctb · 2020-11-24 19:48:13 +09:00
  4f7aa7e541
• Reintroduce PalpableCatchHitObject at data level
  Bartłomiej Dach · 2020-08-20 19:06:26 +02:00
  28534c1599
• Standardize osu!catch coordinate system

  There were two coordinate systems used:
  - 0..512 (used in osu!stable)
  - 0..1 (relative coordinate)
  
  This commit replaces the usage of
  the relative coordinate system to
  the coordinate system of 0..512.

  ekrctb · 2020-07-02 00:21:45 +09:00
  3278a1d7d8
• Fix fruit representation not cycling as often as it should
  Dean Herbert · 2020-02-19 14:41:25 +09:00
  26fe15b038
• Fix ordering of fruits to match stable
  Dean Herbert · 2020-02-19 14:31:43 +09:00
  aeb45c8442
• Fix incorrect scaling factor being applied
  Dean Herbert · 2020-02-19 09:52:29 +09:00
  ab863cdfd9
• Fix metrics not matching between skins and lazer
  Dean Herbert · 2020-02-17 19:16:40 +09:00
  89bff32274
• Use empty hitwindows instead of null
  Dean Herbert · 2019-10-09 19:08:31 +09:00
  51bf600ea7
• Add bindables for IHasComboInformation properties
  smoogipoo · 2019-09-26 16:55:08 +09:00
  bbf0544a8d
• Refactor HitWindows for legibility
  Dean Herbert · 2019-09-06 15:24:14 +09:00
  f925e781a9
• Fix multiple invocations by using a separate variable
  smoogipoo · 2019-08-01 13:33:00 +09:00
  38a2b9d92b
• implement HD for CtB
  Unknown · 2019-06-28 10:34:04 +02:00
  01508e6813
• Update licence header (and remove year)
  Dean Herbert · 2019-01-24 17:43:03 +09:00
  8617aaa2a7
• Merge branch 'master' into fix_combo
  Hanamuke · 2018-09-14 18:48:13 +02:00
  a17200a66a
• Compute combo for nested Objects. Display fruit depending on Combo for

  osu!catch

  Hanamuke · 2018-09-13 21:52:15 +02:00
  1c2cc3837a
• Fixed comment. Created static CatchArea.GetCatcheWidth method
  Hanamuke · 2018-09-13 17:01:33 +02:00
  7d3380db66
• Fixes hyperdash computation (for nested objects)
  Hanamuke · 2018-09-12 19:48:35 +02:00
  a3c3bfb1a8
• Implement combo offsets
  smoogipoo · 2018-08-15 11:47:31 +09:00
  31f324945e
• We need DistanceToHyperDash for star rating calculation
  frankhjwx · 2018-05-21 09:58:46 +08:00
  44fd4b95bd
• Make HitWindows not return null by default
  smoogipoo · 2018-05-11 15:52:51 +09:00
  97a523584d
• Normalize all the line endings
  Dean Herbert · 2018-04-13 18:26:38 +09:00
  32a74f95a5
• IHasComboIndex -> IHasComboInformation
  Dean Herbert · 2018-03-22 12:35:17 +09:00
  78a8f60b39