7008 Commits

Author	SHA1	Message	Date
Dean Herbert	1270ee9624	Update multiple tests to use new assert output for easier to understand failures	2022-08-09 19:19:54 +09:00
Dean Herbert	aa9ced7f04	Add test coverage of ToolbarUserButton	2022-08-09 15:51:10 +09:00
BlauFx	e4879aa450	Add test	2022-08-08 21:12:38 +02:00
Bartłomiej Dach	eba070a0f8	Add weak test coverage of broken audio playback after soft-delete	2022-08-08 20:30:37 +02:00
Dean Herbert	e1189da824	Merge branch 'master' into irenderer-glwrapper	2022-08-08 12:31:53 +09:00
Salman Ahmed	f75dced305	Fix possible null assignment inspection in TestScenePreviewTrackManager	2022-08-08 02:00:24 +03:00
Bartłomiej Dach	839409d7ac	Add preset column to solo mod select overlay	2022-08-07 16:20:31 +02:00
Bartłomiej Dach	de64b83532	Add test coverage for desired user selection behaviour	2022-08-07 16:20:16 +02:00
Bartłomiej Dach	25daaa56e2	Add test coverage for desired external selection behaviour	2022-08-07 15:30:20 +02:00
Dean Herbert	4a95638756	Merge branch 'master' into mod-overlay/delete-preset	2022-08-07 12:34:25 +09:00
Dean Herbert	5946124278	Merge pull request #19612 from bdach/mod-overlay/common-delete-dialog ... Unify implementations of deletion dialogs	2022-08-07 12:18:03 +09:00
Bartłomiej Dach	6f6beddab5	Add test coverage for mod preset deletion flow	2022-08-06 21:58:55 +02:00
Bartłomiej Dach	9b3183b2b4	Implement mod preset deletion flow	2022-08-06 21:58:55 +02:00
Bartłomiej Dach	26b9adbe0c	Adjust collection deletion test to match new expectations	2022-08-06 21:07:21 +02:00
Bartłomiej Dach	cc353b872c	Add test coverage for other approval events	2022-08-06 18:21:57 +02:00
Salman Ahmed	789e8b4d8d	Fix multi-spectator test updating state after removing user ... Removing user triggers `playingUsers.Remove`, but doing so before updating the state leads to `EndGameplay` being called with `State == Playing` rather than `Quit`.	2022-08-06 05:41:26 +03:00
Dan Balasescu	cf362a6b4f	Merge pull request #19529 from peppy/locally-modified-pill ... Show "locally modified" pill when local modifications have been made	2022-08-05 21:12:13 +09:00
Dan Balasescu	c4b9b2a14b	Merge branch 'master' into irenderer-glwrapper	2022-08-05 20:35:06 +09:00
Dean Herbert	7c952f8069	Add more test coverage of locally-modified state change	2022-08-05 14:25:10 +09:00
Bartłomiej Dach	ac9321204c	Merge branch 'master' into mod-overlay/create-preset	2022-08-03 21:21:52 +02:00
Dean Herbert	7022d9e5f8	Fix test step names being too long	2022-08-03 21:13:49 +09:00
Dean Herbert	bacbf5b7f0	Update existing test expectations	2022-08-03 20:20:06 +09:00
Dean Herbert	24d84890e4	Change all filter control button state test to until steps ... There's multiple schedules at play which could be adding multi-frame delays. let's play it safe and try and fix flaky tests. Example of `Schedule` which could cause an issue: 392cb352cc/osu.Game/Collections/CollectionDropdown.cs (L77-L78) Example of test failure: https://github.com/ppy/osu/runs/7648118894?check_suite_focus=true	2022-08-03 20:03:07 +09:00
Bartłomiej Dach	add2971eb4	Implement preset creation flow with test coverage	2022-08-02 22:05:54 +02:00
Bartłomiej Dach	1b3074d098	Implement popover for creating mod presets	2022-08-02 22:03:33 +02:00
Dan Balasescu	5a1c05918f	Fix test failures	2022-08-02 20:18:45 +09:00
Dan Balasescu	b4e55f7309	Apply IRenderer changes	2022-08-02 19:50:57 +09:00
Bartłomiej Dach	923d9a4e5f	Add failing assertions to demonstrate autosize failure	2022-08-01 22:04:14 +02:00
Dean Herbert	c0e5f11c90	Merge pull request #19532 from frenzibyte/fix-new-items-sort-stability ... Fix newly imported beatmaps not using correct comparer for sorting	2022-08-02 02:20:51 +09:00
Dean Herbert	01cc9bd7ef	Merge pull request #19479 from frenzibyte/carousel-update-on-resume ... Fix song select not updating selected beatmap card on editor resume	2022-08-02 00:48:18 +09:00
Salman Ahmed	682192dbd7	Add failing test case	2022-08-01 18:43:01 +03:00
Dean Herbert	2519706ad6	Add test coverage of editor crash	2022-08-01 16:53:49 +09:00
Bartłomiej Dach	5a34122a85	Fix test breakage after realm migration	2022-07-31 23:53:46 +02:00
Bartłomiej Dach	9d3cdae4bb	Fix test scene to handle restarts properly	2022-07-31 23:53:46 +02:00
Bartłomiej Dach	9dea8e3d12	Add test coverage of preset soft deletion	2022-07-31 23:53:46 +02:00
Bartłomiej Dach	c837848238	Add extended test coverage of preset realm subscription	2022-07-31 23:53:45 +02:00
Bartłomiej Dach	345f103119	Migrate mod preset column to use realm	2022-07-31 23:53:45 +02:00
Salman Ahmed	b95aff3e5f	Add failing test case	2022-07-30 18:50:41 +03:00
Susko3	38a8b9cf0a	Add battery info for desktop platforms	2022-07-30 14:26:19 +02:00
Dean Herbert	43e612f6d4	Merge pull request #19455 from peppy/confirm-playlist-discard ... Add confirmation dialog when about to discard a playlist	2022-07-30 19:17:49 +09:00
Salman Ahmed	8ca8484f0e	Fix failing tests	2022-07-30 11:49:33 +03:00
Salman Ahmed	ec1a7994cc	Switch method to statement body for better readability ... Almost thought the method was not wrapped in an `AddStep`.	2022-07-30 10:11:01 +03:00
Salman Ahmed	0c125db197	Fix potential nullref on TestSceneAutoplay check steps	2022-07-30 10:11:01 +03:00
Salman Ahmed	3bc1774c87	Merge branch 'master' into pie-chart-progress	2022-07-29 16:54:59 +03:00
Salman Ahmed	3b1a76b190	Remove redundant/overwritten specifications	2022-07-29 16:45:29 +03:00
Salman Ahmed	905bbdc8ee	Remove caching of GameplayClockContainer in favour of GameplayClock ... Also fixes `SongProgress` being displayed in skin editor on non-gameplay screens, due to `GameplayClock` not marked as a required dependency.	2022-07-29 16:45:29 +03:00
Dan Balasescu	6703b8df02	Merge pull request #19454 from peppy/filter-control-tests-realm-refresh ... Ensure realm is in a good state before asserts in `TestSceneFilterControl`	2022-07-29 17:57:38 +09:00
Dean Herbert	07e3765b34	Ensure collection is added to dropdown before trying to click it	2022-07-29 17:25:30 +09:00
Dean Herbert	0a2265b0e8	Add test coverage of playlist exit confirmation	2022-07-29 17:11:37 +09:00
Dean Herbert	eb92c35335	Merge pull request #19442 from smoogipoo/fix-beginplaying-misordering ... Move spectator begin/end playing to SubmittingPlayer	2022-07-29 16:09:50 +09:00
Dean Herbert	e07e761c10	Ensure realm is in a good state before asserts in TestSceneFilterControl	2022-07-29 15:59:53 +09:00
Dan Balasescu	aaa6f963bd	Fix potential test failures due to Setup/SetUpSteps ordering	2022-07-29 15:27:39 +09:00
Dean Herbert	45879f7836	Merge pull request #19443 from smoogipoo/fix-intermittent-hud-tests ... Fix intermittent HUD tests	2022-07-28 23:20:46 +09:00
Dean Herbert	e664690fe2	Remove unnecessary LoadTrack call	2022-07-28 22:19:46 +09:00
Dean Herbert	3005ff1b9f	Merge branch 'master' into pie-chart-progress	2022-07-28 22:19:27 +09:00
Dan Balasescu	aa03df905f	Merge pull request #19441 from peppy/test-working-beatmap-unfuck ... Reduce calls to `LoadTrack` by implicitly running on test/dummy classes	2022-07-28 22:05:25 +09:00
Dan Balasescu	11e0022fad	Merge branch 'master' into realm-collections	2022-07-28 21:00:08 +09:00
Dan Balasescu	ce694123eb	Move spectator begin/end playing to SubmittingPlayer	2022-07-28 20:44:04 +09:00
Dean Herbert	7108553883	Tidy up various things everywhere	2022-07-28 18:25:14 +09:00
Dean Herbert	a21aee4e9c	Reduce calls to LoadTrack by implicitly running on test/dummy classes	2022-07-28 18:11:40 +09:00
Dan Balasescu	1039338d80	Fix intermittent HUD tests	2022-07-28 17:58:07 +09:00
Dan Balasescu	cd01c5d3ac	Fix assertion	2022-07-28 16:34:31 +09:00
Nitrous	0d36907cad	apply code quality fixes	2022-07-28 15:30:45 +08:00
Nitrous	70ed347b06	simplify helper methods	2022-07-28 15:19:35 +08:00
Dean Herbert	2b9d46d803	Remove unused RulesetStore from BeatmapManager constructor	2022-07-28 16:19:05 +09:00
Nitrous	db62d4be3a	apply suggestions ... - refactor `SongProgress` - make`UpdateProgress` more readable - enable NRT on new classes - refactor `TestSceneSongProgress` to use `GameplayClockContainer`	2022-07-28 15:15:41 +08:00
Dan Balasescu	6bf293e130	Fix managed object reused between test runs	2022-07-28 15:45:33 +09:00
Dean Herbert	8ac886a247	Update test to account for sort order	2022-07-28 15:20:25 +09:00
Dean Herbert	ad482b8afc	Tidy up naming of collection dropdowns	2022-07-28 13:57:21 +09:00
Dean Herbert	34a2d1a6e1	Fix ManageCollectionsDialog and remove weird placeholder logic	2022-07-28 13:57:21 +09:00
Dean Herbert	67c7f324ee	Simplify CollectionFilterDropdown filter flow weirdness	2022-07-28 13:57:21 +09:00
Dean Herbert	0913cf013c	Split out tests and fix variable conflict	2022-07-28 13:24:14 +09:00
Dean Herbert	aa65b73f19	Merge branch 'master' into add-notif-externalbutton	2022-07-28 12:17:36 +09:00
Dean Herbert	8da499fb0f	Add proper test coverage	2022-07-28 12:16:21 +09:00
Nitrous	9088caa377	move LegacyComboCounter to osu.Game.Skinning	2022-07-28 08:36:26 +08:00
Dean Herbert	438067a18b	Convert realm data propagation to more correctly use Live<T> ... wip	2022-07-27 19:35:09 +09:00
Dean Herbert	41393616d8	Replace BeatmapCollection with RealmBeatmapCollection	2022-07-27 19:35:09 +09:00
Dean Herbert	9c543fef48	Remove CollectionManager	2022-07-27 18:45:33 +09:00
Nitrous	6af6f03e29	refactor song progress test scene	2022-07-27 15:57:47 +08:00
Nitrous	1e013bd4e9	move song progress graph to its own test scene	2022-07-27 15:57:23 +08:00
Nitrous	37e642b0bd	make SongProgress abstract ... - move unrelated logic to `DefaultSongProgress` - make `LegacySongProgress` inherit `SongProgress`	2022-07-27 15:19:21 +08:00
Dean Herbert	6b73f7c7ec	Split out legacy import path from realm manager	2022-07-27 15:04:09 +09:00
Dan Balasescu	8f7dff5c2c	Merge pull request #19378 from peppy/beatmap-update-test ... Add separate beatmap update flow to handle edge cases better	2022-07-26 18:49:20 +09:00
Dean Herbert	7f75184a01	Merge branch 'master' into beatmap-update-test	2022-07-26 17:27:36 +09:00
Salman Ahmed	91ffa7007f	Improve existing test coverage to cover order changes from other sort modes	2022-07-26 10:24:51 +03:00
Dean Herbert	4efe09e7c2	Merge pull request #19377 from frenzibyte/fix-timeline-tests ... Fix intermittent timeline zoom test failures	2022-07-26 15:18:35 +09:00
Dean Herbert	ef10145d6f	Rename MenuCursorContainer and clean up code	2022-07-26 14:11:52 +09:00
Salman Ahmed	e5355f314d	Use longer hash string	2022-07-25 15:19:32 +03:00
Dean Herbert	6a3e8e31de	Centralise calls to reset online info of a BeatmapInfo	2022-07-25 19:51:19 +09:00
Salman Ahmed	d04df19c7e	Remove APIScore and replace its final usage	2022-07-25 13:13:46 +03:00
Dan Balasescu	1d48cee230	Merge pull request #19373 from peppy/fix-negative-star-rating-display ... Fix star ratings which are still being calculated showing as "-1" at song select	2022-07-25 18:20:30 +09:00
Salman Ahmed	bc2b629ee7	Let tests wait until track load before testing zoom	2022-07-25 12:07:50 +03:00
Salman Ahmed	123930306b	Refactor ZoomableScrollContainer to allow setting up zoom range and initial zoom after load	2022-07-25 12:07:50 +03:00
Salman Ahmed	93175eaf6e	Re-enable timeline zoom test and remove flaky attribute	2022-07-25 11:39:23 +03:00
Dean Herbert	6bf2645b1a	Fix StarRatingDisplay not handling negative numbers as "pending"	2022-07-25 15:44:54 +09:00
Salman Ahmed	6bdd1f43a2	Add visual test coverage	2022-07-25 09:40:20 +03:00
Salman Ahmed	7facd6d822	Merge branch 'master' into beatmap-overlay-null-pp	2022-07-25 07:38:59 +03:00
Salman Ahmed	6c95c49da3	Mark test score with null PP for visual testing	2022-07-25 07:31:52 +03:00
Dan Balasescu	0226b358ee	Disable timeline test for now	2022-07-25 13:20:33 +09:00
Dean Herbert	12e2e63a1c	Merge pull request #19349 from bdach/mod-overlay/presets-column ... Implement basic appearance of mod preset column	2022-07-25 13:10:47 +09:00
Salman Ahmed	fa9daa6899	Fix TestSceneReplayRecorder not using score provided by gameplay state	2022-07-25 05:21:27 +03:00
Salman Ahmed	feef16b09b	Add potentially failing test case	2022-07-25 04:18:30 +03:00
Bartłomiej Dach	6a67d76d7c	Add basic mod preset column implementation	2022-07-24 16:39:04 +02:00
Salman Ahmed	0c16ef3e2e	Add failing test case	2022-07-24 08:34:24 +03:00
Salman Ahmed	2829a7e836	Merge branch 'master' into beatmap-overlay-modded-stats	2022-07-23 10:38:13 +03:00
Salman Ahmed	c937c0548e	Add test coverage	2022-07-23 10:16:11 +03:00
Bartłomiej Dach	d0e15d04cc	Merge branch 'master' into mod-overlay/preset-panel	2022-07-22 19:23:09 +02:00
Dan Balasescu	6b69ff19c8	Remove unused using	2022-07-22 17:24:46 +09:00
Salman Ahmed	e5ab6652fd	Fix one more case of referencing old mod select overlay in tests	2022-07-22 11:12:24 +03:00
Dean Herbert	e20458421a	Update flaky timeline zoom test to output something useful	2022-07-22 16:05:20 +09:00
Bartłomiej Dach	bdff7f1ef4	Implement basic appearance of mod preset panels	2022-07-21 23:29:21 +02:00
Salman Ahmed	559254db31	Merge branch 'master' into fix-update-button-test-failure	2022-07-21 11:15:43 +03:00
Dan Balasescu	defadeef47	Merge pull request #19250 from peppy/fps-counter ... Add game-side FPS counter	2022-07-21 16:26:38 +09:00
Dean Herbert	fc0c9f76bd	Fix UpdateBeatmapSetButton intermittent test failure ... Carousel would only expire items when off-screen. This meant that for a case (like a test) where items are generally always on-screen, `UpdateBeatmapSet` calls would result in panels remaining hidden but not cleaned up.	2022-07-21 16:24:48 +09:00
Salman Ahmed	5513a8b6b4	Fix changelog overlay tests failing due to missing CreatedAt date	2022-07-21 07:21:27 +03:00
Dean Herbert	0c3d43026d	Add initial structure for fps counter	2022-07-20 23:49:19 +09:00
Dean Herbert	62133fa069	Merge pull request #19246 from frenzibyte/fix-wiki-navigation ... Fix wiki overlay not handling path redirection properly	2022-07-20 20:08:11 +09:00
Dan Balasescu	f9c02c34b6	Merge branch 'master' into beatmap-update-online-flow	2022-07-20 15:15:51 +09:00
Salman Ahmed	e7f35701db	Add failing test case	2022-07-20 09:06:11 +03:00
Dean Herbert	af4d7feb9b	Merge pull request #19244 from frenzibyte/highlight-perfect-ticks ... Highlight perfect slider tick/end values in beatmap info leaderboards	2022-07-20 14:44:03 +09:00
Salman Ahmed	ae6aab2555	Merge branch 'master' into edit-map-carousel	2022-07-20 02:43:47 +03:00
Salman Ahmed	4d1f9a1329	Adjust test scene to cover slider ticks	2022-07-20 00:53:10 +03:00
Dean Herbert	6357223341	Fix incorrect DI fetch and apply nullability to ModelDownloader	2022-07-19 20:06:34 +09:00
Dean Herbert	17046b0553	Add basic handling of download failures	2022-07-19 19:01:23 +09:00
Dean Herbert	f6de76e057	Move test to stand-alone class and add full ui testing	2022-07-19 18:50:27 +09:00
Dean Herbert	eaf4f6dbb7	Add beatmap update button	2022-07-19 18:29:36 +09:00
Adam Baker	59018ab5ba	Fix multiplayer queue edit button opening to the wrong beatmap	2022-07-18 23:21:16 -05:00
Bartłomiej Dach	6f37487528	Replace calls to defective Humanizer methods with correct version	2022-07-18 22:34:58 +02:00
Salman Ahmed	b5c7d07ba8	Merge branch 'master' into fix-user-profile-overlay	2022-07-18 10:27:33 +03:00
Dean Herbert	a7f19cc796	Merge pull request #19137 from frenzibyte/country-enum ... Replace `Country` class with enumeration	2022-07-18 16:12:24 +09:00
Salman Ahmed	018da74fe8	Replace default with CountryCode.Unknown	2022-07-18 08:54:35 +03:00
Salman Ahmed	cf99849478	CountryCode.XX -> CountryCode.Unknown	2022-07-18 08:45:54 +03:00
Salman Ahmed	100c53f9ef	Country -> CountryCode	2022-07-18 08:40:34 +03:00
tsunyoku	d1c60b5741	correct assertion logic	2022-07-17 23:53:35 +01:00
tsunyoku	d17acd0f45	add message to Assert.That	2022-07-17 23:16:27 +01:00
tsunyoku	92513dc936	reverse IsInstanceOfType logic	2022-07-17 22:49:09 +01:00
tsunyoku	0c50931d2f	change method of finding incompatibleMod	2022-07-17 22:10:35 +01:00
tsunyoku	dcce14ae8f	rename NoConflictingModAcronyms to ModValidity, add test for two-way mod incompatibility	2022-07-17 21:15:29 +01:00
tsunyoku	14ae183c70	update tests to match SoloScoreInfo	2022-07-17 14:22:46 +01:00
tsunyoku	71a4b8843f	update tests to new profile score format	2022-07-17 14:08:44 +01:00
Dean Herbert	acd5254f51	Add test coverage ensuring unique acronyms	2022-07-16 17:19:55 +09:00
Salman Ahmed	e62049f4a9	Update various usages of Country inline with new enum	2022-07-16 05:04:24 +03:00
Salman Ahmed	68afb65aff	Move default state steps to SetUp rather than duplicating per test case	2022-07-15 22:10:21 +03:00
Salman Ahmed	8f7b3cf11a	Merge branch 'master' into Save-Score-Failed	2022-07-15 22:10:19 +03:00
Dean Herbert	21433d4ecb	Add test coverage of saving a failed score	2022-07-15 20:14:58 +09:00
Dean Herbert	4b253f83c3	Fix intermittent test failures due to randomised score statistics	2022-07-15 17:39:08 +09:00
Dan Balasescu	c1dd1cfead	Merge pull request #19082 from peppy/api-solo-score-model ... Add and consume `SoloScoreInfo`	2022-07-15 15:20:18 +09:00
Salman Ahmed	0bafafd63b	Remove unnecessary test coverage ... RIP hours.	2022-07-15 03:20:52 +03:00
Salman Ahmed	be69514002	Fix CollectionManager opening file multiple times across test scene	2022-07-14 06:21:23 +03:00
Salman Ahmed	cb2f0b8c67	Add test coverage for collection items	2022-07-14 03:42:03 +03:00