Dean Herbert
|
1bbfbb0d8e
|
Fix test that never should have worked
This was only working by luck until now. It was "correctly" matching on
null online ID (see logic at
abc96057b2/osu.Game/Screens/OnlinePlay/Match/RoomSubScreen.cs (L199-L207) ).
Now it works by actually matching on the online ID.
|
2021-06-23 19:30:11 +09:00 |
|
Dean Herbert
|
f6180b7e6a
|
Mark static methods as such
|
2021-06-23 17:37:26 +09:00 |
|
Dean Herbert
|
dcba7bf779
|
Fix import flow potentially hitting foreign key constraint
|
2021-06-23 17:34:56 +09:00 |
|
Dean Herbert
|
ed0552a9e8
|
Add failing test for FK constraint conflict on reimporting modified beatmap with scores present
|
2021-06-23 17:34:56 +09:00 |
|
Dean Herbert
|
28f4c56cd6
|
Fix minor typo in comment
|
2021-06-23 16:30:28 +09:00 |
|
Dean Herbert
|
151dfdfb79
|
Merge pull request #13627 from Joehuu/fix-multiplayer-exit-logic
Fix multiplayer leave dialog not working on all exit operations
|
2021-06-23 14:56:57 +09:00 |
|
Dean Herbert
|
a1da9c5ee3
|
Merge pull request #13626 from Henry-YSLin/IHasSeed-interface
Extract `SeedSettingsControl` to `IHasSeed` interface
|
2021-06-23 14:10:34 +09:00 |
|
Dean Herbert
|
f62b4f2d24
|
Merge pull request #13617 from ekrctb/catch-editor
Add "placeholder" (pre-MVP) implementation of osu!catch editor
|
2021-06-23 14:00:34 +09:00 |
|
Dean Herbert
|
54084f8a9c
|
Move SeedSettingsControl to own file
|
2021-06-23 13:40:05 +09:00 |
|
smoogipoo
|
6fd020d91d
|
Remove unnecessary public accessibility
All interface members are implicitly public.
|
2021-06-23 12:00:57 +09:00 |
|
Joseph Madamba
|
dc428da06c
|
Fix test regression
|
2021-06-22 19:30:52 -07:00 |
|
Joseph Madamba
|
49000b9501
|
Add multiplayer leave navigation tests
|
2021-06-22 19:30:40 -07:00 |
|
ekrctb
|
0b351c9922
|
Fix "possible NRE" inspection
|
2021-06-23 10:57:04 +09:00 |
|
ekrctb
|
125e143401
|
Fix banana shower placement outline initial opacity
|
2021-06-23 10:27:40 +09:00 |
|
ekrctb
|
5a5cb39c9f
|
Add some comments about logic
|
2021-06-23 10:27:40 +09:00 |
|
ekrctb
|
69c8865a04
|
Use more consistent method names
|
2021-06-23 10:19:25 +09:00 |
|
ekrctb
|
a9b8736f70
|
Order field and properties consistently
|
2021-06-23 10:18:44 +09:00 |
|
ekrctb
|
eec4457473
|
Add [CanBeNull] to methods returning null by default
|
2021-06-23 09:40:07 +09:00 |
|
ekrctb
|
e96814bb86
|
Remove comment about using skin for blueprint
As the current game-wise direction is not using skin elements in blueprints.
The design of the blueprint could be improved somehow, though.
|
2021-06-23 09:37:30 +09:00 |
|
ekrctb
|
1a7bfafc69
|
Add icon for composition tools
|
2021-06-23 09:34:11 +09:00 |
|
Dan Balasescu
|
bdc440f11c
|
Merge pull request #13605 from aitani9/overlay-item-sound-edge
Empty the space between `OverlayStreamItem`s
|
2021-06-22 22:13:39 +09:00 |
|
Dean Herbert
|
4cb9c6a842
|
Merge pull request #13423 from frenzibyte/transformers-per-skin
Refactor ruleset skin transforming logic to be per-`ISkin` rather than one `ISkinSource`
|
2021-06-22 21:24:56 +09:00 |
|
Dan Balasescu
|
e39ce6cc67
|
Merge pull request #13610 from gagahpangeran/markdown-heading-font-size
Change osu markdown heading to use actual font size
|
2021-06-22 20:58:48 +09:00 |
|
Dan Balasescu
|
c436f9f0fa
|
Merge pull request #13615 from peppy/mod-utils-check-duplicate-mods
Ensure duplicate mods cannot be defined
|
2021-06-22 20:28:40 +09:00 |
|
Dan Balasescu
|
883b3e56f4
|
Merge branch 'master' into markdown-heading-font-size
|
2021-06-22 20:21:25 +09:00 |
|
Salman Ahmed
|
37f7486fb1
|
Fix potential null reference in LINQ method
|
2021-06-22 12:25:29 +03:00 |
|
Salman Ahmed
|
71e2815e7e
|
Update and improve code documentation
Co-authored-by: Dean Herbert <pe@ppy.sh>
|
2021-06-22 12:05:17 +03:00 |
|
Salman Ahmed
|
ece63b9ba1
|
Remove unused using directive
|
2021-06-22 12:03:55 +03:00 |
|
Salman Ahmed
|
31cbb36a64
|
Implement FindProvider and AllSources properly on all test ISkinSource s
|
2021-06-22 12:03:14 +03:00 |
|
Dean Herbert
|
b8126e3ca8
|
Update framework
|
2021-06-22 17:59:24 +09:00 |
|
Dean Herbert
|
6e0801b852
|
Fix incorrect existing test case
|
2021-06-22 17:41:27 +09:00 |
|
Dean Herbert
|
c4fde635c6
|
Ensure duplicate mods cannot be defined
|
2021-06-22 17:41:20 +09:00 |
|
Dean Herbert
|
2bea44fe94
|
Merge pull request #13349 from ribbanya/skin-editor-closest-anchor
Allow skin elements to find closest anchor
|
2021-06-22 17:31:05 +09:00 |
|
ekrctb
|
21331d3a13
|
Disable caught object stacking in editor
|
2021-06-22 17:20:13 +09:00 |
|
ekrctb
|
e8907b53a8
|
Add basic banana shower placement tool
|
2021-06-22 17:20:13 +09:00 |
|
ekrctb
|
4d7a877795
|
Add basic fruit placement tool
|
2021-06-22 17:20:13 +09:00 |
|
ekrctb
|
0078d7dc18
|
Add outline to selected fruit
|
2021-06-22 17:20:13 +09:00 |
|
ekrctb
|
c28cd5dd75
|
Add basic juice stream selection blueprint
|
2021-06-22 17:20:13 +09:00 |
|
ekrctb
|
b8ccfe6ea7
|
Add basic selection blueprint movement logic
|
2021-06-22 17:20:13 +09:00 |
|
ekrctb
|
fbe44dac34
|
Add empty catch hit object composer
|
2021-06-22 17:20:13 +09:00 |
|
ekrctb
|
a9c7830252
|
Fix NRE when hit object blueprint is not implemented
|
2021-06-22 17:20:13 +09:00 |
|
Salman Ahmed
|
c1284940e1
|
Fix potentially providing the same skin instance twice in AllSources
|
2021-06-22 10:49:37 +03:00 |
|
Salman Ahmed
|
d0cdc07b11
|
Reuse AllSources when looking up on FindProvider
|
2021-06-22 10:49:21 +03:00 |
|
Salman Ahmed
|
b12adc6073
|
Remove all test skinning changes in favour of the ISkinSource.AllSources path
|
2021-06-22 10:48:03 +03:00 |
|
Dean Herbert
|
1fff9a93b9
|
Merge branch 'master' into skin-editor-closest-anchor
|
2021-06-22 16:41:51 +09:00 |
|
Dean Herbert
|
4b3165084d
|
Move scoped functionality into local function
|
2021-06-22 16:40:56 +09:00 |
|
Dean Herbert
|
ffac32a848
|
Reword xmldoc
|
2021-06-22 16:40:48 +09:00 |
|
Dean Herbert
|
6c3d2315d0
|
Merge pull request #13606 from Naxesss/low-diff-checks
Add low difficulty spacing checks
|
2021-06-22 16:29:37 +09:00 |
|
Dean Herbert
|
14bdcef26b
|
Add missing newline
|
2021-06-22 16:20:09 +09:00 |
|
Dean Herbert
|
0ad189e357
|
Expose skin sources via ISkinSource and revert to consuming based on hierarchy
|
2021-06-22 16:19:55 +09:00 |
|