47455 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Dean Herbert	1b0af78831	Simplify WorkingBeatmap in multiple ways ... Just a clean-up pass.	2021-12-22 18:17:00 +09:00
Dean Herbert	b38b300159	Convert BeatmapMetadata access to be via a computed property	2021-12-22 18:17:00 +09:00
Dean Herbert	ea7d2c06fc	Merge pull request #16206 from peppy/fix-collection-import-test-cleanup ... Fix `ImportCollectionsTest.TestSaveAndReload` not cleaning up before run	2021-12-22 18:16:48 +09:00
Dean Herbert	a866572ca8	Add comment regarding host name choice	2021-12-22 15:44:47 +09:00
Dean Herbert	cfdfe81afb	Merge pull request #16205 from smoogipoo/fix-multiplayer-tests ... Fix multiplayer test failures when checking for parted room	2021-12-22 13:42:05 +09:00
Dean Herbert	f81e32149b	Fix ImportCollectionsTest.TestSaveAndReload not cleaning up before/after run	2021-12-22 13:38:20 +09:00
Dean Herbert	a88800c99a	Merge pull request #16198 from smoogipoo/fix-current-item-before-population ... Fix delete button showing on current item before beatmap retrieval	2021-12-22 13:15:07 +09:00
Dan Balasescu	24c6f8fafa	Fix multiplayer test failures when checking for parted room	2021-12-22 12:55:37 +09:00
Dan Balasescu	7bc5079485	Merge pull request #16201 from bdach/timeline-blueprint-contrast-improvement ... Improve contrast of timeline blueprint foreground content for pastel combo colours	2021-12-22 11:33:29 +09:00
Dan Balasescu	ee64ab6383	Fix delete button test failures ... Can be tested by adding a Thread.Sleep() in DrawableRoomPlaylistItem.load().	2021-12-22 09:55:19 +09:00
Dan Balasescu	c71942a350	Merge pull request #16200 from bdach/lookup-cache-racing ... Fix online lookup caches potentially getting stuck	2021-12-22 09:48:58 +09:00
Bartłomiej Dach	dca081979f	Merge pull request #16199 from peppy/fix-custom-directory-tests ... Ensure `CustomDataDirectoryTest` methods use a fresh directory to avoid IO errors	2021-12-21 13:56:07 +01:00
Bartłomiej Dach	e35a8cab65	Merge branch 'master' into fix-custom-directory-tests	2021-12-21 13:08:27 +01:00
Bartłomiej Dach	7ab1c0c99d	Improve contrast of timeline blueprint foreground content for pastel combo colours	2021-12-21 12:54:17 +01:00
Bartłomiej Dach	ca7303a50a	Fix online lookup cache not clearing completed task on early return ... The task not being cleared in the early return path would cause `pendingRequestTask` to become stuck as a completed task, and `queryValue()` would not recreate it due to the null check there, therefore stalling all lookups forevermore until a game restart.	2021-12-21 11:13:41 +01:00
Bartłomiej Dach	ee89d8643e	Extract abstract implementation of online lookup cache	2021-12-21 11:12:51 +01:00
Dean Herbert	df975fb29e	Merge pull request #16181 from dekrain/statics-reset-no-sb ... Split session statics reset method to prevent unloading seasonal backgrounds	2021-12-21 18:52:04 +09:00
Dean Herbert	0bda7892f7	Merge pull request #16197 from bdach/beatmap-card/renames ... Rename beatmap card-related classes	2021-12-21 18:51:34 +09:00
Dean Herbert	4a3a5054fd	Ensure CustomDataDirectoryTest methods use a fresh directory to avoid IO errors ... Resolves test failures like https://github.com/ppy/osu/runs/4592088736?check_suite_focus=true.	2021-12-21 18:42:39 +09:00
Dan Balasescu	4ce61d4260	Directly bind to room updates ... Currently doesn't really cause any difference, however it may in the future if we decide the queueing algorithm shouldn't update PlaylistOrder when an item has been played.	2021-12-21 18:40:29 +09:00
Dan Balasescu	e2f8c71081	Fix test	2021-12-21 18:38:31 +09:00
Dan Balasescu	a34d24fb20	Disallow expired items from showing delete button ... This isn't possible in practice since expired items are removed from the queue list, but this helps out in tests.	2021-12-21 18:37:42 +09:00
Dan Balasescu	d7136d6b48	Merge pull request #16196 from peppy/update-framework ... Update framework	2021-12-21 18:23:02 +09:00
Dan Balasescu	4ba5a939db	Merge pull request #16178 from bdach/lounge-background-screen-correct ... Fix lounge screen showing information sourced from wrong playlist item	2021-12-21 17:36:23 +09:00
Dan Balasescu	05b79f864e	Merge pull request #15867 from MBmasher/fl-cumulative-strain ... Fix cumulative strain time calculation in Flashlight skill	2021-12-21 17:19:09 +09:00
Dan Balasescu	51b7e920c0	Fix delete button being able to show on current item	2021-12-21 16:57:58 +09:00
Dan Balasescu	a53c67b2ea	Merge pull request #16194 from peppy/fix-results-screen-wait-test ... Fix intermittent test failures on `TestSceneResultsScreen` due to long delay step	2021-12-21 16:56:49 +09:00
Bartłomiej Dach	b6a458a07e	Cover seasonal backgrounds not resetting on inactivity in test	2021-12-21 08:50:25 +01:00
Bartłomiej Dach	979624160f	Do not reset last hover sound playback time on inactivity	2021-12-21 08:47:41 +01:00
Bartłomiej Dach	cd10af633c	Remove unused private method	2021-12-21 08:47:26 +01:00
Dean Herbert	0198d49a3a	Update framework	2021-12-21 16:38:03 +09:00
Dan Balasescu	32fbaf47c0	Merge pull request #16192 from peppy/add-room-lost-logging ... Add logging of `MultiplayerMatchSubScreen` exiting from room loss	2021-12-21 16:37:08 +09:00
Bartłomiej Dach	c7b9b176c6	Rename BeatmapCard{Base => }	2021-12-21 08:26:25 +01:00
Bartłomiej Dach	88d4e95ad8	Rename BeatmapCard{ => Normal}	2021-12-21 08:26:21 +01:00
Bartłomiej Dach	bd1fb33ad6	Add and use separate extensions for historical and upcoming playlist items	2021-12-21 08:01:04 +01:00
Dean Herbert	2707b2fbda	Merge pull request #16012 from bdach/beatmap-card/extra ... Implement "extra" beatmap card size	2021-12-21 15:40:33 +09:00
Dean Herbert	16fe0e4f89	Fix SessionStaticsTest never working ... In headless operation, the test would complete before ever reaching an idle state. And this test only ran headless..	2021-12-21 15:39:08 +09:00
Dean Herbert	981158ed88	Rename method and simplify SetDefault calling code	2021-12-21 15:34:32 +09:00
Dean Herbert	c0a8758839	Fix intermittent test failures on TestSceneResultsScreen due to long delay step ... Using real time delays of 3 seconds doesn't play well with headless runs.	2021-12-21 15:15:05 +09:00
Dan Balasescu	a8cd96278d	Merge pull request #16189 from peppy/fix-beatmap-listing-overlay-test-failure ... Fix intermittent failures on `TestSceneBeatmapListingOverlay`	2021-12-21 15:11:25 +09:00
Dan Balasescu	5cea8da80f	Merge pull request #16188 from peppy/multiplayer-button-enabled ... Centralise all multiplayer button clicking test logic	2021-12-21 15:10:26 +09:00
Dean Herbert	d08b66a5ff	Also add logging to OnlinePlayScreen	2021-12-21 15:07:06 +09:00
Dan Balasescu	3b700b6967	Merge pull request #16187 from peppy/fix-threading-colour-error-meter ... Fix potential wrong thread mutation in `ColourHitErrorMeter`	2021-12-21 15:05:57 +09:00
Dean Herbert	ddadf3c4b5	Add logging of MultiplayerMatchSubScreen exiting from room loss	2021-12-21 14:53:24 +09:00
Dean Herbert	0f8a6a3f64	Fix intermittent failures on TestSceneBeatmapListingOverlay ... In the specific method, there was no wait step after the initial fetch (unlike all of the rest), meaning the fetch may not have finished in time for the follow-up steps. As seen at https://github.com/ppy/osu/runs/4588058438?check_suite_focus=true.	2021-12-21 14:12:06 +09:00
Dan Balasescu	2ea31c26a5	Merge pull request #16168 from peppy/windows-key-when-inactive ... Avoid blocking windows key usage when the osu! window is not active	2021-12-21 13:51:10 +09:00
Dean Herbert	bb3f375958	Add note about local button clicking usage	2021-12-21 13:49:51 +09:00
Dean Herbert	aad55ef89e	Remove unused method in TestSceneMultiplayerQueueList	2021-12-21 13:49:51 +09:00
Dean Herbert	9aff646ff4	Centralise all multiplayer button clicking test logic ... This adds the "wait for enabled" check in a way that can be easily reused, as it keeps getting missed in test implementations. This particular commit hopefully fixes https://github.com/ppy/osu/runs/4583845033?check_suite_focus=true.	2021-12-21 13:49:51 +09:00
Dean Herbert	edcbd4de6d	Fix incorrect event unbind logic	2021-12-21 13:05:26 +09:00