113 Commits

• Fix subscribing to ApplyCustomUpdateState too much
  Bartłomiej Dach · 2024-02-28 13:20:41 +01:00
  b5ce2642aa
• Fix slider tails sometimes not dimming correctly

  Originally noticed during review of another change:
  https://github.com/ppy/osu/pull/27369#issuecomment-1966140198.
  
  `DrawableOsuHitObject` tries to solve the initial dimming of objects
  by applying transform to a list of dimmable parts. For plain drawables
  this is safe, but if one of the parts is a DHO, it is not safe,
  because drawable transforms can be cleared at will.
  
  In particular, on first use of a drawable slider,
  `UpdateInitialTransforms()` would fire via `LoadComplete()` on the
  `DrawableSlider`, but *then*, also via `LoadComplete()`,
  the `DrawableSliderTail` would update its own state and by doing so
  inadvertently clear the dim transform just added by the slider.
  
  To fix, ensure dim transforms are applied to DHOs
  via `ApplyCustomUpdateState`.

  Bartłomiej Dach · 2024-02-27 11:45:03 +01:00
  bbdd85020c
• Refactor result application around again to remove requirement for fields

  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Bartłomiej Dach · 2024-02-05 13:21:01 +01:00
  efe6bb25b1
• update DrawableHitCircle.ApplyResult to pass this to its callback
  Chandler Stowell · 2024-01-25 11:25:41 -05:00
  93bd3ce5ae
• use stack to pass action state when applying hit results

  this removes closure allocations

  Chandler Stowell · 2024-01-24 13:13:45 -05:00
  d2775680e6
• Refactor all slider input into SliderInputManager
  Dan Balasescu · 2023-12-15 16:13:32 +09:00
  6bd190c55d
• Bypass Parent nullability checks for now
  Dean Herbert · 2023-10-17 17:48:45 +09:00
  5341a335a6
• Fix object dim being applied to approach circles

  Fixes half of https://github.com/ppy/osu/issues/24956.
  
  The other half is high effort. The number portion is nested deeply and
  with reason - depending on skin setting it changes the visual order.
  
  I'm not sure how to fix that one, but I also think it's weird behaviour
  and if people don't complain, it's probably fine to just dim the number
  for consistency.
  
  That said, the approach circle is an important one to ensure it matches
  1:1, so I've fixed that here.

  Dean Herbert · 2023-09-29 18:23:23 +09:00
  94f4268ae5
• Contain entirety of legacy notelock badness inside the hit policy
  Bartłomiej Dach · 2023-08-24 08:52:49 +02:00
  ed2b1a0754
• correct implementation of stable notelock
  Liam DeVoe · 2023-07-17 23:31:21 -04:00
  768d7b5e1c
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Only apply dim at top level objects
  Dean Herbert · 2022-10-05 17:48:56 +09:00
  52002d91dd
• Fix sliders not dimming correctly due to modified miss window
  Dean Herbert · 2022-10-05 14:25:04 +09:00
  56d424003d
• Add osu! hit object dim

  Stable would dim objects when they can't be hit (ie. the "miss" window
  is not active yet). This was never implemented in lazer, and causes
  quite large visual differences.
  
  No one has mentioned this yet, but it will definitely be one of those
  missing pieces which makes lazer feel different to stable.

  Dean Herbert · 2022-10-04 17:28:17 +09:00
  c2956c6e1e
• Move Shake logic local to hitcircle/slider
  Dean Herbert · 2022-09-22 15:04:20 +09:00
  b844d76311
• Mark DrawableOsuHitObject abstract for clarity
  Dean Herbert · 2022-09-22 14:44:03 +09:00
  2bdc6417e9
• Update usages of RemoveInternal
  Dean Herbert · 2022-08-29 15:57:40 +09:00
  105aa01e7d
• Update Remove/RemoveRange/RemoveAll calls in line with framework changes
  Dean Herbert · 2022-08-29 15:57:40 +09:00
  a215d009fe
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Update slider sliding samples balance calculation to use screen-space as well
  Salman Ahmed · 2022-04-18 09:18:56 +03:00
  3a00931e38
• Calculate sample playback position using screen-space drawable rectangles
  Salman Ahmed · 2022-04-18 07:57:31 +03:00
  fcb48c69cf
• Fix typo in DrawableOsuHitObject
  Dean Herbert · 2022-04-08 15:20:22 +09:00
  879267862c
• Remove unused using statement
  Dean Herbert · 2020-11-27 17:01:07 +09:00
  5bc76cac58
• Merge branch 'master' into improve-dho-time-offsets
  Dean Herbert · 2020-11-27 15:03:56 +09:00
  bcc197f9fe
• Remove hitObject argument from OnApply and OnFree
  ekrctb · 2020-11-27 10:13:05 +09:00
  57454bbb1c
• Add MaximumJudgementOffset to DrawableHitObject, use in more places
  smoogipoo · 2020-11-26 01:12:42 +09:00
  0414e5c550
• Move into OnApply() to resolve one-frame issues
  smoogipoo · 2020-11-17 23:35:36 +09:00
  ce4baf328d
• Tighten osu! ruleset lifetime expiry for past hitobjects
  smoogipoo · 2020-11-17 23:20:19 +09:00
  04805b78c3
• Add nested osu! hitobject pooling
  smoogipoo · 2020-11-12 15:59:48 +09:00
  3f78d81386
• Prevent overrides from messing with application/freeing
  smoogipoo · 2020-11-07 00:40:26 +09:00
  b1e039bcec
• Fix DHOs being freed when not expected
  smoogipoo · 2020-11-07 00:25:26 +09:00
  3a4bd73823
• Make top-level osu! objects use new methods
  smoogipoo · 2020-11-06 23:09:23 +09:00
  33b629a87a
• Merge branch 'master' into drawable-hit-object-hit-state-fix
  Dean Herbert · 2020-11-05 17:07:52 +09:00
  0cadb31947
• Use BDL for top-level osu! DHOs
  smoogipoo · 2020-11-05 13:51:46 +09:00
  9a7fcadabc
• Update existing implementations
  Dean Herbert · 2020-11-04 17:14:23 +09:00
  a3dc1d5730
• Replace assignment references to HitResult.Miss with Judgement.MinResult
  Bartłomiej Dach · 2020-10-02 23:31:24 +02:00
  1f0620ffd4
• Add/improve xmldoc
  smoogipoo · 2020-08-31 13:33:41 +09:00
  acbeb5406f
• Move dampening to base implementation and change range to 0..1
  Dean Herbert · 2020-04-13 13:01:02 +09:00
  65b96079a0
• Merge branch 'master' of https://github.com/ppy/osu into stereo-shifted-playback
  Fire937 · 2020-04-12 01:46:32 +02:00
  22d89dbff7
• Add positional sound support for all rulesets

  The SamplePlaybackBalance is calculated in a way that the balance
  remains between -0.4 and 0.4.
  Positional sound is not supported in osu!taiko.

  Fire937 · 2020-04-12 01:33:25 +02:00
  f274ec297c
• Separate into separate class
  smoogipoo · 2020-04-10 02:02:09 +09:00
  10e849d196
• Cause all earlier hitobjects to get missed
  smoogipoo · 2020-03-19 19:16:24 +09:00
  12a48d2774
• Better english

  Co-Authored-By: Dean Herbert <pe@ppy.sh>

  Dan Balasescu · 2020-03-18 19:13:25 +09:00
  1d680b7a00
• Add notelock implementation
  smoogipoo · 2020-03-10 15:30:24 +09:00
  742698acab
• Use ??=.
  Huo Yaoyuan · 2019-11-12 19:56:51 +08:00
  dcfa98414f
• Set lifetime on initial state update
  smoogipoo · 2019-09-13 18:49:21 +09:00
  5c2c055614
• Move expire to DrawableHitObject
  Dean Herbert · 2019-09-12 19:29:08 +09:00
  f21e47d6d2
• Expose full hitobject rather than hit windows
  smoogipoo · 2019-09-02 17:14:40 +09:00
  0c73c5acf3
• Add HitWindows to JudgementResult to indicate timing errors
  smoogipoo · 2019-09-02 16:28:14 +09:00
  f2bdf94a1d
• Share logic with other rulesets (and make default)
  Dean Herbert · 2019-08-28 18:12:47 +09:00
  9a98f39f06